RE: [PATCH v1 3/4] test/power: removed function pointer validations

["Tummala, Sivaprasad" <Sivaprasad.Tummala@amd.com>]

[-- Attachment #1: Type: text/plain, Size: 1739 bytes --]

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Dave,

Inline..

From: Hunt, David <david.hunt@intel.com>
Sent: Monday, July 22, 2024 4:20 PM
To: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>; anatoly.burakov@intel.com; jerinj@marvell.com; lihuisong@huawei.com; david.marchand@redhat.com; Yigit, Ferruh <Ferruh.Yigit@amd.com>; konstantin.ananyev@huawei.com
Cc: dev@dpdk.org
Subject: Re: [PATCH v1 3/4] test/power: removed function pointer validations

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.



On 20/07/2024 17:50, Sivaprasad Tummala wrote:

After refactoring the power library, power management operations are now

consistently supported regardless of the operating environment, making

function pointer checks unnecessary and thus removed from applications.



Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com><mailto:sivaprasad.tummala@amd.com>

---

 app/test/test_power.c         | 95 -----------------------------------

 app/test/test_power_cpufreq.c | 52 -------------------

 app/test/test_power_kvm_vm.c  | 36 -------------

 3 files changed, 183 deletions(-)





Hi Sivaprasad,

    Nice work on the patch-set.

There's just four function pointer checks remaining that my compiler is complaining about. They are in examples/l3fwd-power/main.c (lines 443, 452, 1350, 1353). It would be nice to have these removed as well, seeing as the functions are now inlines and don't need these checks.

[Siva] ACK. Will fix this in next version.

I'm running the patch set through some tests here, will keep you posted on progress.

Rgds,
Dave.


---snip---

[-- Attachment #2: Type: text/html, Size: 6297 bytes --]