RE: [PATCH v10 0/6] power: refactor power management library

["Tummala, Sivaprasad" <Sivaprasad.Tummala@amd.com>]

[AMD Official Use Only - AMD Internal Distribution Only]

Hi David,

-----Original Message-----
From: David Marchand <david.marchand@redhat.com>
Sent: Tuesday, November 12, 2024 4:08 PM
To: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>; Thomas Monjalon <thomas@monjalon.net>
Cc: david.hunt@intel.com; anatoly.burakov@intel.com; jerinj@marvell.com; radu.nicolau@intel.com; gakhil@marvell.com; cristian.dumitrescu@intel.com; lihuisong@huawei.com; Yigit, Ferruh <Ferruh.Yigit@amd.com>; konstantin.ananyev@huawei.com; dev@dpdk.org
Subject: Re: [PATCH v10 0/6] power: refactor power management library

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


On Tue, Nov 12, 2024 at 9:20 AM David Marchand <david.marchand@redhat.com> wrote:
>
> Hello Siva, Thomas,
>
> On Sun, Nov 10, 2024 at 7:36 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > 28/10/2024 20:55, Sivaprasad Tummala:
> > > This patchset refactors the power management library, addressing
> > > both core and uncore power management. The primary changes involve
> > > the creation of dedicated directories for each driver within
> > > 'drivers/power/core/*' and 'drivers/power/uncore/*'.
> > >
> > > This refactor significantly improves code organization, enhances
> > > clarity, and boosts maintainability. It lays the foundation for
> > > more focused development on individual drivers and facilitates
> > > seamless integration of future enhancements, particularly the AMD uncore driver.
> > >
> > > Furthermore, this effort aims to streamline code maintenance by
> > > consolidating common functions for cpufreq and cppc across various
> > > core drivers, thus reducing code duplication.
> > >
> > > Sivaprasad Tummala (6):
> > >   power: refactor core power management library
> > >   power: refactor uncore power management library
> > >   test/power: removed function pointer validations
> > >   drivers/power: uncore support for AMD EPYC processors
> > >   maintainers: update for drivers/power
> > >   power: rename library sources for cpu frequency management
> >
> > I'm a bit sad there is not more reviews.
> >
> > I've moved the pointers check removal first, renamed intel_pstate
> > files (not the functions), fixed few things like __cplusplus,
> > include guards, sorting and maintainers file.
> >
> > Applied
>
> This series breaks compilation of the vm_power_manager example as the
> "guest channel" API symbols are not provided by the power library
> (itself) anymore.
>
> ninja: Entering directory `/home/dmarchan/builds/main/build-gcc-shared'
> [3355/3373] Linking target examples/dpdk-guest_cli
> FAILED: examples/dpdk-guest_cli
> gcc  -o examples/dpdk-guest_cli
> examples/dpdk-guest_cli.p/vm_power_manager_guest_cli_main.c.o
> examples/dpdk-guest_cli.p/vm_power_manager_guest_cli_parse.c.o
> examples/dpdk-guest_cli.p/vm_power_manager_guest_cli_vm_power_cli_gues
> t.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,--no-as-needed
> -Wl,--undefined-version -pthread -Wl,--start-group -lm -ldl -lnuma
> -lfdt '-Wl,-rpath,$ORIGIN/../lib'
> -Wl,-rpath-link,/home/dmarchan/builds/main/build-gcc-shared/lib
> lib/librte_eal.so.25.0 lib/librte_kvargs.so.25.0
> lib/librte_log.so.25.0 lib/librte_telemetry.so.25.0
> lib/librte_mempool.so.25.0 lib/librte_ring.so.25.0
> lib/librte_net.so.25.0 lib/librte_mbuf.so.25.0
> lib/librte_ethdev.so.25.0 lib/librte_meter.so.25.0
> lib/librte_cmdline.so.25.0 lib/librte_power.so.25.0
> lib/librte_timer.so.25.0 -lpcap -lvirt /usr/lib64/libbsd.so
> /usr/lib64/libarchive.so -Wl,--end-group
> /usr/bin/ld: examples/dpdk-guest_cli.p/vm_power_manager_guest_cli_vm_power_cli_guest.c.o:
> in function `check_response_cmd':
> /home/dmarchan/builds/main/build-gcc-shared/../../../git/pub/dpdk.org/main/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c:382:
> undefined reference to `rte_power_guest_channel_receive_msg'
> /usr/bin/ld: examples/dpdk-guest_cli.p/vm_power_manager_guest_cli_vm_power_cli_guest.c.o:
> in function `query_data':
> /home/dmarchan/builds/main/build-gcc-shared/../../../git/pub/dpdk.org/main/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c:147:
> undefined reference to `rte_power_guest_channel_send_msg'
> /usr/bin/ld: examples/dpdk-guest_cli.p/vm_power_manager_guest_cli_vm_power_cli_guest.c.o:
> in function `receive_capabilities':
> /home/dmarchan/builds/main/build-gcc-shared/../../../git/pub/dpdk.org/main/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c:271:
> undefined reference to `rte_power_guest_channel_receive_msg'
> /usr/bin/ld: examples/dpdk-guest_cli.p/vm_power_manager_guest_cli_vm_power_cli_guest.c.o:
> in function `send_policy':
> /home/dmarchan/builds/main/build-gcc-shared/../../../git/pub/dpdk.org/main/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c:476:
> undefined reference to `rte_power_guest_channel_send_msg'
> /usr/bin/ld: examples/dpdk-guest_cli.p/vm_power_manager_guest_cli_vm_power_cli_guest.c.o:
> in function `query_data':
> /home/dmarchan/builds/main/build-gcc-shared/../../../git/pub/dpdk.org/main/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c:147:
> undefined reference to `rte_power_guest_channel_send_msg'
> /usr/bin/ld: examples/dpdk-guest_cli.p/vm_power_manager_guest_cli_vm_power_cli_guest.c.o:
> in function `receive_freq_list':
> /home/dmarchan/builds/main/build-gcc-shared/../../../git/pub/dpdk.org/main/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c:161:
> undefined reference to `rte_power_guest_channel_receive_msg'
> collect2: error: ld returned 1 exit status [3357/3373] Generating
> drivers/rte_common_cnxk.sym_chk with a custom command (wrapped by
> meson to capture output)
> ninja: build stopped: subcommand failed.
>
> Siva, please have a look quickly.
>
> Here is a quick fix written before first coffee of the day.

LGTM!

--
David Marchand