From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E40B942B8F; Wed, 24 May 2023 19:04:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6EE7C40156; Wed, 24 May 2023 19:04:20 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2049.outbound.protection.outlook.com [40.107.243.49]) by mails.dpdk.org (Postfix) with ESMTP id 77611400EF for ; Wed, 24 May 2023 19:04:18 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TzuBf+K2+IDt+refRab5bEfEAqj4col397WiNA2Bw9TSBjSOCFZd6c+7IJydE+BzHqh0BewraAaOnh9mFc5MpvLfnUmQtQFbXk/Xd5jN1zK0RJuFFKU52R7M8XBFpJU7NU1Q+5eb/GCB+ogu0TGcp30l0X9xZuylvX/7Joyexyq/sYBXbsM4KUHwWtjfustQncBqPQutxLXvXGHIaHFFAHxxDXhDMK/MSjJvhdiax8Ai5GfJxQ54gmjtgEj9uX/jDxU4GBF5l1Ex0fzJT4kYbINJUVx59nmaXQsBwEypIRzKCMQ/WRnUx3MOJ5HYedryoW/yqz6XiCOCdiunUFbXrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ll3sMmy6UbD+GmonpuyZmlmqoCN/ZH4gSDYhedxLtws=; b=HkCLEIRaY4sYDfkM1sJm5Eu29I/ioS7/E6pgwOE/AIBcVqJpvbJhPX9QnNEXAw6s2kf+YV/QVPmZNfwmtSm8H0oLW7rsIsR6TRo5km1/DUSHh0ry9ocAcMvT35ItLjTp7PhvTbvykU51Uu3fC+IuTUxmovo+NwUpNZN5izUrNsE3sbFq8RC8eRk+YtCQfAt6TfRCz1eB1SIO7EJGKHMjZSOH+WsVL4/h4j7gK6AsLtkwJIcFDw7uq5JT0cObzoc4aY++BI8vyPqEuJXt5SqM9adpV0om710pQGreT5WwpZroLUMu2HCBUsM+IG7aYK3x86UgjUSuGZew2mhEeJOGBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ll3sMmy6UbD+GmonpuyZmlmqoCN/ZH4gSDYhedxLtws=; b=jPo74mZ9MMzu+WNC8rq6RJIpc9nOEWyhJjX2t0t9NAAMBur8r1I0o1Lxf0NY8yM5S//9OdKpqe/rNwbNh2ZiBzFeZx+KEnOidIRD/DKkn53yQPWwHxrM0t7bvxiQTU/JrBogX2eUXo5H8ccJyKz9rgL82aD2zOs7z7JYIJcP0Tc= Received: from CH3PR12MB8308.namprd12.prod.outlook.com (2603:10b6:610:131::8) by MW6PR12MB8915.namprd12.prod.outlook.com (2603:10b6:303:23e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Wed, 24 May 2023 17:04:15 +0000 Received: from CH3PR12MB8308.namprd12.prod.outlook.com ([fe80::4e4f:3a93:b7bd:489c]) by CH3PR12MB8308.namprd12.prod.outlook.com ([fe80::4e4f:3a93:b7bd:489c%5]) with mapi id 15.20.6433.015; Wed, 24 May 2023 17:04:15 +0000 From: "Gupta, Nipun" To: Thomas Monjalon CC: "dev@dpdk.org" , "david.marchand@redhat.com" , "Yigit, Ferruh" , "Anand, Harpreet" , "Agarwal, Nikhil" Subject: RE: [PATCH v4 1/4] bus/cdx: introduce cdx bus Thread-Topic: [PATCH v4 1/4] bus/cdx: introduce cdx bus Thread-Index: AQHZgZ7Ytfv0pNrrlE2rdPfL+iQqCK9pXq4AgABhY2A= Date: Wed, 24 May 2023 17:04:14 +0000 Message-ID: References: <20230124140746.594066-1-nipun.gupta@amd.com> <20230508111812.2655-1-nipun.gupta@amd.com> <20230508111812.2655-2-nipun.gupta@amd.com> <14913442.JCcGWNJJiE@thomas> In-Reply-To: <14913442.JCcGWNJJiE@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=51a044e3-9304-48a0-9ca6-e58bbb58a675; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-24T17:03:25Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8308:EE_|MW6PR12MB8915:EE_ x-ms-office365-filtering-correlation-id: 586ddeb8-63d9-4110-7e5a-08db5c78e73f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B61RiHjaJuQdrMAo8+vqja0sdeJYGbmqDzt1DEFMXDvCphCYOZWAtHXW+HK65HFUnwew59b1+gGNcGstpnfZqAHViIEx9yRKIYq2cri15xETSmZpVwEengktOTcsQp5t1/1/QRrW7sBqKvS+wd6cB4jJPPCV4B2PcOaAdj5733f7wSx+Z23zaqbZQhes20aDLcg3AKa7zzIJJnvcYpzAI7/PytkZ0IsRUMKYU6eXDecMV0AyujZpTZyrEG3Q+YHHMYbO7kxYAeQBlCA92wa7rGb4IzJiL538i56HYJZTo3Ht/nOiYVuRkz+W3ylJsbzDKKcp5HBwddV7EtoCFYQMsiXQlOpdMRsGfYBd/9gaPxKKIO8GZmSe6+rEfeXKCqDzyaJyIYD5gaPhPgtKWVP+q0yctFgXp2pOOPlet0WHineR3sipBQ9WMAi2bffyoE0dNJij3sDJ0/BE7C96orEd5N/kD+VKSBD/jppGuvATYhw87CoQgmqWVPxgCV0RZSTqkGvd8n80dJZ6G9CiKg9KMs60HRBQS4xm/hmc5bpnTCL6UiqgdxnHFGOaLGjtH4XJ5UJRxGMHJgrEVMsZdTMy4Y/5h9DwOaWDHsghxqT0lGadJS+PzplL36ZXJR6wNiH7 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8308.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(396003)(376002)(136003)(346002)(366004)(451199021)(71200400001)(41300700001)(66446008)(64756008)(76116006)(66946007)(66476007)(66556008)(2906002)(186003)(52536014)(478600001)(4326008)(7696005)(26005)(316002)(6916009)(5660300002)(54906003)(8936002)(8676002)(9686003)(53546011)(6506007)(55016003)(83380400001)(38070700005)(86362001)(122000001)(38100700002)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zgQ6qFetrvkurNIjh01NX0n5zlfegSbnjOPQMYOf3tqx0FjE8RPqVtk2G5PN?= =?us-ascii?Q?C5XIblvQqFq7sTQsxLipHfJE69JDYe5NOz8/aMC8BxeMTO9GNE7d3tE2YSxT?= =?us-ascii?Q?JdUubDLD/YzJPP6onr974GDyc5dCPE6qs1ziisYnqQq6bof0LMlyhNFEF/a4?= =?us-ascii?Q?qEvGkhTutrtLpcjq+0DGCoWEX92EzwK4FCFXzgf5vohBDLH+5FuGKEw4+ZgB?= =?us-ascii?Q?KNhsdy9Gq/bpGGsBtUSJhcFrZwx2KupGRXABjxb6+3ZOmKJLkF3Gp4HL+hxv?= =?us-ascii?Q?iYrTE6jAqokEmEJuZGjKxh9uZSz8jaegTKfKrsxEziLLfFbmP4I5odGG+8yW?= =?us-ascii?Q?X+R/j9MEPtWoAtWlWkKX8pGOXv+05GPiDZIZPvhCeSmwMhbvP7609jd0egRL?= =?us-ascii?Q?JpdzBbl8vV066wu2J/c+twN1pjnsSJgWyhc7Aq7y4ES4s05LNj56Vdv1IYkX?= =?us-ascii?Q?XY+ywa7A9+54sb27wxceUGXF7oxcRT9qS4FeritqO8RI9a1aQ7EDZzaFSSE8?= =?us-ascii?Q?5l7zSBrOFKF4iXG4yejlEPj5UwZFhmw0LEP1fyap31KPGY2mzhuoDmYFYucD?= =?us-ascii?Q?fas7LRS0JYxZRC9FEfB1Yx1LyO3of3nyVAlCLM2a1sqC/52P52AO/C2DJo03?= =?us-ascii?Q?Q2TF2JaN2K0ZbRuiBBIlvTepLbghnbzDjVBlM9feIg5jJ4/64rtQ3AHGMfRH?= =?us-ascii?Q?vHCkcun12yIa8pW6pYg5SjMdRaWeRhvX3h04ua9hW7LfqXCneSCZik74ygx7?= =?us-ascii?Q?sqQy7GpAJmnG+eMBG+41sTwfzb5z0XWFsW/bDH+y+6S3GFTN6tn99pEttZAn?= =?us-ascii?Q?XdWRWXAdHq9ZMsi1OwZ8epO+V07kNHKTf8RWRJTwr0P5T2Tjo9nJHYCaw6/p?= =?us-ascii?Q?yvSIV/Ua59YqMxCUuQoyBTm8YEXlq3Lw2NlF3u2qP9VHeP63sf2Et44ThDU6?= =?us-ascii?Q?oleuSe/coyMTp0ELfdRSwcxYUlguSqemYTrYBMyRZDZyUHlX0chRYEu6sC0v?= =?us-ascii?Q?YIylRWwi7A99rX7P+eW0DCJIdqGfv674vSbmwFmJVULWL5ee3bczUTv8r3fH?= =?us-ascii?Q?uZGsWzkjZG2yFAmSYPLfpcsbcq1s8Frkqc9UTBwVzhtChILYAGbcxWaSIdKF?= =?us-ascii?Q?KJUwqXwJptm70NLhonQ+zxcRwDt0OxkloizNtYxZwyj/Ag6HFlTyqCLOIzl9?= =?us-ascii?Q?gy+glp0q31fYf2/Fm5zkPTu9vNvvLk+kA9laKvcQ98Dp5xHtIwEU27o0OW7b?= =?us-ascii?Q?bua+4lyGoCydp1dYWPnvCeY57A2VG/t7tyacaui4G1yOqPxK0n7t0Bb8HzE5?= =?us-ascii?Q?A1HrIpHV1kQXABKhkCIgzB/SOUzENyKLyMbfDKMRSUSutZ0GqcKfk8s2EIV4?= =?us-ascii?Q?LMY0vXSI++raY1mQnXGd3UcOjZkNCPpRgyrSnPc7eP0j9cgnwexdsAvmILLo?= =?us-ascii?Q?iHWNTbm4ZdpO8Uz7OT9FK38mAb8eJ4af65UPARbtB0qkYfi81nJDd3jtpNpA?= =?us-ascii?Q?IIb97JQ1V9cg382IvblrlzCtTa+q/0LRiaE5zE1aLPWs+Bze5eDncpo6BsCe?= =?us-ascii?Q?w3PrqGdcf7T4HRjqXrg=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8308.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 586ddeb8-63d9-4110-7e5a-08db5c78e73f X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2023 17:04:14.8032 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: f2n8c2WiKsGuDSsZFJiNulqU0tfdiPgyICag7N/JJg1g2Wzz3k3EUQLb/V8gqU56 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8915 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org [AMD Official Use Only - General] > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, May 24, 2023 4:45 PM > To: Gupta, Nipun > Cc: dev@dpdk.org; david.marchand@redhat.com; Yigit, Ferruh > ; Anand, Harpreet ; > Agarwal, Nikhil > Subject: Re: [PATCH v4 1/4] bus/cdx: introduce cdx bus > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Hello, > > If I understand well, it is very specific to AMD devices. > So I suggest adding "AMD" in title and descriptions. > > 08/05/2023 13:18, Nipun Gupta: > > CDX bus supports multiple type of devices, which can be > > exposed to user-space via vfio-cdx. > > > > vfio-cdx provides the MMIO IO_MEMORY regions as well as the > > DMA interface for the device (IOMMU). > > > > This support aims to enable the DPDK to support the cdx > > devices in user-space using VFIO interface. > > > > Signed-off-by: Nipun Gupta > [...] > > +CDX bus driver > > Can we name it "AMD CDX bus"? Sure will update. > > > +M: Nipun Gupta > > +M: Nikhil Agarwal > > +F: drivers/bus/cdx/ > > [...] > > +* **Added CDX bus support.** > > Here as well and in other places, would be more precise to say "AMD CDX". > > > + > > + CDX bus driver has been added to support AMD CDX bus, which operates > > + on FPGA based CDX devices. The CDX devices are memory mapped on > system > > + bus for embedded CPUs. > [...] > > +#ifndef _BUS_CDX_DRIVER_H_ > > +#define _BUS_CDX_DRIVER_H_ > > In general I prefer not adding underscores, > as it is not required, and not really private. Okay.. I will update for all the header files. > > [...] > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > I would bet some includes are not needed for this header file. Will cut them short. Thanks, Nipun > > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > [...] > >