From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2AB2F42A94; Mon, 8 May 2023 12:48:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B37BC410ED; Mon, 8 May 2023 12:48:39 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2057.outbound.protection.outlook.com [40.107.92.57]) by mails.dpdk.org (Postfix) with ESMTP id A8E1E40685 for ; Mon, 8 May 2023 12:48:37 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KSb+YEeNnjzOVDcDnqbGsmfUIbK1XOxV8f+dngqlWWb/IiBPfO8JBTgxJvAvWr61oTJyr8WLYfe2+FT0k88QoWb/iFPyM1ycai5o/f9OT4sbp3eV9dVnKChW1pP8f3mWVZp7iCRbO50I2oPr1R9WJkpjg6c2d4YuJJnC9YIRGGRubpfg+stCdpPUgwFYerHMy1/U/FZuU5xYf+EUuJX8Ka2am1iSZYY39vULg5kPDzwzIHEv3T72s+F0OuQV0yeDZRgcCDVenjVN9OhDmnqAlYum/XcR0DqqeymjR9kjmZWc/R28jPg0ts1vfcKtiJ1O8swrKCHJvqNIuvqwocE9ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+Yih85G2aKKTwvbmiMDvuugKCmyV1+rqG6b9M48SYBg=; b=SZyl5vdKrKv1wyl5VFZvHPMT/MF+VOMfqXBzA9iZAjKkT/n/x95TTl3nXCBk+U15Al3aFblUTQ/mxLKmBmyPjJevqJmfU/Fm8lWYvjtUoJWFoYIQNsWCrSocBMZ1HrS2QdVsIfJ4EE44l//6WCaSLYgaO2vSArKvvZwFLjYav7o7goYNnz7Z1HSYOMM6sdUiW9BouXAo3laieAVMEx93t7hBJ8OuSw3UiIxos3V2LPqw3baNkWilkCnuLdhxIN2D3OYebRj/mcdvzEFx+gChV3siMh4D9ZGD1/SwQcMohwajXT/amgSbkSc1nOYPlgfgJR96Ffqi3W35GeKsfgD9nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+Yih85G2aKKTwvbmiMDvuugKCmyV1+rqG6b9M48SYBg=; b=AB9DjVMifOP0x46oWhsfvl7kZ9BgURuoLMn/jf1PiRrZ4MYyMNcTr98foWM0qYHxZ6ElNaSdOdIaGq+K7d2aHeOTDB3DaC7sQm3wrtltOu2j1OqU9gMqxRsmvzlqhBllbZsrKTN6zFn796RU9uCXzTpqxagNwYhVxV/ZGQyncGI= Received: from CH3PR12MB8308.namprd12.prod.outlook.com (2603:10b6:610:131::8) by SN7PR12MB6814.namprd12.prod.outlook.com (2603:10b6:806:266::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.31; Mon, 8 May 2023 10:48:34 +0000 Received: from CH3PR12MB8308.namprd12.prod.outlook.com ([fe80::4e4f:3a93:b7bd:489c]) by CH3PR12MB8308.namprd12.prod.outlook.com ([fe80::4e4f:3a93:b7bd:489c%5]) with mapi id 15.20.6363.032; Mon, 8 May 2023 10:48:34 +0000 From: "Gupta, Nipun" To: Thomas Monjalon , "Yigit, Ferruh" CC: "dev@dpdk.org" , "david.marchand@redhat.com" , "Anand, Harpreet" , "Agarwal, Nikhil" Subject: RE: [PATCH v3 5/5] config/arm: add AMD CDX Thread-Topic: [PATCH v3 5/5] config/arm: add AMD CDX Thread-Index: AQHZdGE3+aWz830eH0eT1pZSwl5seK9KUYAAgAXwDdCAAAm0AIAAAOww Date: Mon, 8 May 2023 10:48:33 +0000 Message-ID: References: <20230124140746.594066-1-nipun.gupta@amd.com> <54328b0c-584e-dc58-2559-9d30e089a66a@amd.com> <112237800.nniJfEyVGO@thomas> In-Reply-To: <112237800.nniJfEyVGO@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_ActionId=ede08ed0-553d-4970-9aae-031da3c11029; MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_ContentBits=0; MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_Enabled=true; MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_Method=Privileged; MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_Name=Non-Business-AIP 2.0; MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_SetDate=2023-05-08T10:47:29Z; MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8308:EE_|SN7PR12MB6814:EE_ x-ms-office365-filtering-correlation-id: ee57b958-f93a-40c5-b099-08db4fb1c517 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qcDqIu49rPUcOtkeNlNPR1Y8rToM3z8f+B2Gb3eNH2Ibz1fmymoGpmR1hKBvqM25/psUYr6oHT2rhU/F2JqX8PWmrRghLs1q1bs1iXrVA6n1t9izQIyVBw9sJfqE0TYCnYedVEOBO39NPt2qZkuEpvzD3mkU38AnyDZLQQD9hqVlLOUgXDbCAhppz+YFlL1UYfqumw+L5eTozsP5/usIAxR3n19VavP5iQv0KrWxYsUtuTE6fWdf8BXoF7y2s9sPgi+dYXCLTQRVvvhkHVaN/acEQ5nkojG7wPwwkUki12akq17hJNR/DzCnVf6dHLhIVuvJMwHAm/D9z8ZTBzVNqZ1ePxJEvK9svlGEXFXDvEYwpEKnxCJpc0W+9FvuszkP+criD8r3WhXCU64K+oAkfVX69qkQzwvhyi16wUyMBm5AwLEvRVTW3ZFLPfMVgflECXw5HkMv5GGoZUT8AMoaYp+m8bP6CxMOHtj8+tpya7N35tfjSEv5DbB5fKsX0yCtS3Ja+Vh0+PIzoz8A38g64vnJgm29VvBuEetK7DwS6aMZ30r8UPU7cY9683pELmk5sYGnMe+PvW33kaB/SdGvhffpFL3Pb0jimBa9VuMcyQimkk4LB1NhuIGYqoSDizJj x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8308.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(376002)(366004)(346002)(396003)(39860400002)(451199021)(52536014)(5660300002)(54906003)(110136005)(8676002)(7696005)(71200400001)(8936002)(316002)(41300700001)(53546011)(64756008)(66556008)(478600001)(66476007)(66946007)(76116006)(6636002)(4326008)(66446008)(6506007)(9686003)(2906002)(83380400001)(186003)(122000001)(55016003)(33656002)(86362001)(38070700005)(38100700002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7NxsBJmmDMS1nSyD7YWaoSDJ2CxBCgNuOrfeVUBy3G/yDFnkSee190dfJtrk?= =?us-ascii?Q?KpwxNZhHw/Iyf8aFLifLt3tQ5crsKgTSSKGQsEBHrPt9LXK51g62k+o+Qvic?= =?us-ascii?Q?Td5pwmY2J62ZYwni+u8G0te4VA1yD9+Z7my+lg89mbHP4kcf/Wxl5DdVElYs?= =?us-ascii?Q?qBnwI9tw+FOuPD2S+AvHTqFcDBkgaomdu2u+4FhIOOKqcmGsm9+iWzEZ9ew4?= =?us-ascii?Q?C/KA2TO0hOa9PNchxIi5SHQpo7Qb+fBlM+ELFt7MrBabIgy9yZbifXXEmJeX?= =?us-ascii?Q?0H1UnVi5S3sBq3u1+o5ib7loGlpQTva3sIdNgVC4y5yQp6k5JRuQH2ti3LRm?= =?us-ascii?Q?U+wrxy9JlWeMvhDeAbV7cG3crksmoAB3C22tdfOoKrCYwPp6SLhrBUOgb1EC?= =?us-ascii?Q?YEAUOyPx5MRF7We0UagtlAB6mBeW2bOY71hoTJMt6TMoRwbzB/v8nKeK+TuP?= =?us-ascii?Q?QsjB76OXlYYbD0KjfKmeb0TdV1t3TAo30ztmy1MfkVZyCMZ8hYPycMtoDwFE?= =?us-ascii?Q?A58+tTi0LaR/LBEeIuPwjluaFiQ8r8o2N6EN/lBzww8t7EJZ27MYwusGqfm1?= =?us-ascii?Q?l+JhDxK5jaZqELEhW2Ghn7VgQbm1bQc9+6weGMIAO4RZS0AUqpYaASgfumVX?= =?us-ascii?Q?o+Wg/NVOwIOA6gAb6eZRxfw6goSHkL03/IMLMktJIA+O8xpAi5mLTrA+dTZy?= =?us-ascii?Q?g1oZosenlvAa+i91VhvoubTM1mNej0cgEc5Y/hmacxQMRWZGME+JVdIQQMGq?= =?us-ascii?Q?QuY/LejWlbjCvLnjzi8ZF4rivLsjh1NbDSQLy4cPPEarAJo9QwV/Nxy+LO5c?= =?us-ascii?Q?GX6Wi7iZ0Opk8HZcsqqtrUgtarn1xvfaJ39x3F/WkEE2TOtf/RwKBtioS6TP?= =?us-ascii?Q?J86zzA+wVc19nZTbYgEkhEh/ReKp1UfJMEL4wc0lk7NYbw7VglfqiW9jGiRX?= =?us-ascii?Q?XGYjDRMm5fvD8lqJsoRT4JVEcErC+OL5RXw7IqF15gmHSSV59k2tXJjkRqSF?= =?us-ascii?Q?8Pva6HJfAtLAv4eUJqSBPtM4wQkIbrXF42/XTmfxnmpdsDqC/+Qo1+q7K7j7?= =?us-ascii?Q?KI6XYXHpfO4nOVoDcUswPnNq0NmW5L2Xq3kVFU7bjcnhm1ttynmiQ287Q2Iq?= =?us-ascii?Q?QOqHGfyO3M+zCid/Jfj0x7qhdW4ZjBycAmx3AbMiG56ZmZFC04/9cA509QLA?= =?us-ascii?Q?QUdcZ9K479/1W/B5wW4aoT7iJM8/uM2RqlIZGPgr0EACcw/DSzt6oN4eYZmv?= =?us-ascii?Q?dDcNd6LDCA6Kjrtrj5RdeemAudBwFVEVQS5pkNryg+4F3GfjfRbnfwweDrvh?= =?us-ascii?Q?4vZSYe5rjso4bq4CFUYp5RFzQMIhG4t/R+Wa5g+AQT6hQOeCeZz9oLKP2x0R?= =?us-ascii?Q?bqX8VmhJZopeeFBuzuJUdmvxSjcZoW5AmO46BNcgKyTBr8PE5H2xjSx97iAy?= =?us-ascii?Q?yG8SG2jNPLSyimQ232vljNroCZeQOGz3qnyn4v1DOnUP/clozB+ICHmvANpj?= =?us-ascii?Q?kV+XjKkZv4C4u0ywL3Hx9laT45Au7Uvt3ZumllNBtnzl0OVP60euPX9Lgpz/?= =?us-ascii?Q?bP5dir3oMUpmoY7MpCDLSYPQK+O7DbqRiZT6rARniDH7jHBZXrX0bX6gdgsP?= =?us-ascii?Q?NvH8bVF5pC4ErzF+oOqfa+s=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8308.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee57b958-f93a-40c5-b099-08db4fb1c517 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2023 10:48:33.6955 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3lgM9Eg9bTrapUHztFGhSrzzfaETBOekMIbit8Yr4I9pjdbISfY2BVpew3/JSW1O X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6814 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, May 8, 2023 4:14 PM > To: Yigit, Ferruh ; Gupta, Nipun > > Cc: dev@dpdk.org; david.marchand@redhat.com; Anand, Harpreet > ; Agarwal, Nikhil > Subject: Re: [PATCH v3 5/5] config/arm: add AMD CDX >=20 >=20 > 08/05/2023 12:24, Gupta, Nipun: > > From: Yigit, Ferruh > > > On 4/21/2023 3:54 PM, Nipun Gupta wrote: > > > > Adding support for AMD CDX devices > > > > > > > > Signed-off-by: Nipun Gupta > > > > --- > > > > config/arm/arm64_cdx_linux_gcc | 17 +++++++++++++++++ > > > > config/arm/meson.build | 14 ++++++++++++++ > > > > 2 files changed, 31 insertions(+) > > > > create mode 100644 config/arm/arm64_cdx_linux_gcc > > > > > > > > diff --git a/config/arm/arm64_cdx_linux_gcc > > > b/config/arm/arm64_cdx_linux_gcc > > > > new file mode 100644 > > > > index 0000000000..8e6d619dae > > > > --- /dev/null > > > > +++ b/config/arm/arm64_cdx_linux_gcc > > > > @@ -0,0 +1,17 @@ > > > > +[binaries] > > > > +c =3D ['ccache', 'aarch64-linux-gnu-gcc'] > > > > +cpp =3D ['ccache', 'aarch64-linux-gnu-g++'] > > > > +ar =3D 'aarch64-linux-gnu-ar' > > > > +as =3D 'aarch64-linux-gnu-as' > > > > +strip =3D 'aarch64-linux-gnu-strip' > > > > +pkgconfig =3D 'aarch64-linux-gnu-pkg-config' > > > > +pcap-config =3D '' > > > > + > > > > +[host_machine] > > > > +system =3D 'linux' > > > > +cpu_family =3D 'aarch64' > > > > +cpu =3D 'armv8-a' > > > > +endian =3D 'little' > > > > + > > > > +[properties] > > > > +platform =3D 'cdx' > > > > diff --git a/config/arm/meson.build b/config/arm/meson.build > > > > index 5213434ca4..39b8929534 100644 > > > > --- a/config/arm/meson.build > > > > +++ b/config/arm/meson.build > > > > @@ -305,6 +305,18 @@ soc_bluefield =3D { > > > > 'numa': false > > > > } > > > > > > > > +soc_cdx =3D { > > > > + 'description': 'AMD CDX', > > > > + 'implementer': '0x41', > > > > + 'part_number': '0xd42', > > > > + 'flags': [ > > > > + ['RTE_MACHINE', '"cdx"'], > > > > + ['RTE_MAX_LCORE', 16], > > > > + ['RTE_MAX_NUMA_NODES', 1] > > > > + ], > > > > + 'numa': false > > > > +} > > > > > > Hi Nipun, > > > > > > Why we need a new arm platform/config? Is it because of above flags? > > > If it can work with default values, I think we can drop this patch. > > > > Hi Ferruh, > > > > CDX driver works with generic ARM compilation too > (arm64_armv8_linux_gcc). > > > > The versal platforms supporting CDX have A78 cores, and adding this cdx > config > > Helps to provide gcc option "march=3D armv8.4-a" which is for implement= er > > "0xd42" (ARM cortex A78 cores)., whereas for generic ARM compilation > > "march=3D armv8-a". > > > > Maybe ARM guys can provide more information regarding if there is any > impact > > on using generic architecture flag (i.e. march=3D armv8a) on A78 cores. >=20 > Please let's skip this patch for now. > You should send it separately later, with perf testing and HW description= in the > commit log. Sure, I will skip this and send another spin for CDX bus without this chang= e. Thanks, Nipun >=20 >=20