From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7BD65459CC; Wed, 18 Sep 2024 15:58:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C07342F8D; Wed, 18 Sep 2024 15:58:10 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2053.outbound.protection.outlook.com [40.107.94.53]) by mails.dpdk.org (Postfix) with ESMTP id 933DC402D5 for ; Wed, 18 Sep 2024 15:58:08 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LLUj2HFAwIzxXpZAJWo5zQ4BOqOXs8eTFTLrjbFW0ZEBY8PvfSYabHyqHaFn1YCrbvCHzJDSApqQT5kvzHyP4rJdkjwSJf3LgDsr28wH1qSq6KI2bZqCiXCzbp64mhduuSb7176wSfDRp8JfpCxtibbWH+SD67JRDo9gGfHgwu8ExAHDwR73/cgYlon/FnkscdqEQ06oay0UuteP1bY3sQ5GRlWdUC9N8vMZwGBKDkZ8uDnpwr4dyz6+3l73b44jkXheX0Ft9NE1vwvr3yEgVW/IaOVhHNT3GCcJPQ4KeuwvcIgZqI2NR49BLb73R+fAJv8diGU314M1ehLYgYBNSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ARIrtrqCItKwXyLFKn0+XHP3D8sVmhMWK+R4eDbRI1o=; b=ljrfty9hW1QIFpxkNSceHD0obFPErzvY2TdU79fYGHS23aKjJvKVwq3WMY8nNU5CEhKiX5SdXheTA/A6RPO84zi2kFCqdDZzApx+L+UBFRB8yqEtZh9yzP8lVjjRlyDxXWr+qAaW8zAmItulyoWI5sjeMUx+aWzFxPKMkymif7jcXy/2Ia9fwfiCnH8TeE859RTEcuSyo3ps3In/M6i1o36x5iOrLNnL7fa2wrt8C5M3OW+Yrr+kmOcWdZuJPhf9npfZ6W+242txJjgMSnhfsho1y3X8fJVpBprDNIjKNPn+WUWPa0EQVNMJiBZsK/WXcVuIHIxrq+C14O+o7vSRWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ARIrtrqCItKwXyLFKn0+XHP3D8sVmhMWK+R4eDbRI1o=; b=kxxXeUnkulaX/DNu/ao/BWK55OAqeErEDy7OcNK+gPsO8z4WnPlVR7xhRlbaCJZGls12V8bODJ/yozBwjewzYhBWqFQSfleEb6NBWBIuH8741RjtfUgsZb3TLQuX1LP39/wQtao6Y+2WZj3Hb5hvYFke5vMPMAQU1FSATOj8kI3MiEHyQTt7qdBODMv+roUx8pRC6se8XakbAISvPLmb9SBBlJjxpHUCWdT2UWdrqtVWSPftjgfmjA0gMg8Zw1MdTm0JZ+aVcQ1BczHNa6RtOXtvzMvAaQqYURDCqfh2sPrsuN6VdJzkfgKgw2t5eqiVWRkdhjLHiu6Fh5dfcIgi1A== Received: from CH3PR12MB8460.namprd12.prod.outlook.com (2603:10b6:610:156::15) by SA1PR12MB6919.namprd12.prod.outlook.com (2603:10b6:806:24e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7962.24; Wed, 18 Sep 2024 13:58:04 +0000 Received: from CH3PR12MB8460.namprd12.prod.outlook.com ([fe80::2e9d:7265:3b84:59b5]) by CH3PR12MB8460.namprd12.prod.outlook.com ([fe80::2e9d:7265:3b84:59b5%4]) with mapi id 15.20.7962.022; Wed, 18 Sep 2024 13:58:04 +0000 From: Dariusz Sosnowski To: Slava Ovsiienko , "dev@dpdk.org" CC: Matan Azrad , Raslan Darawsheh , Ori Kam Subject: RE: [PATCH v2 6/9] app/testpmd: remove flex item init command leftover Thread-Topic: [PATCH v2 6/9] app/testpmd: remove flex item init command leftover Thread-Index: AQHbCdFFNS5P1/yYSkKYLmvFUS25j7JdkeVQ Date: Wed, 18 Sep 2024 13:58:04 +0000 Message-ID: References: <20240911160458.524732-1-viacheslavo@nvidia.com> <20240918134623.8441-1-viacheslavo@nvidia.com> <20240918134623.8441-7-viacheslavo@nvidia.com> In-Reply-To: <20240918134623.8441-7-viacheslavo@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8460:EE_|SA1PR12MB6919:EE_ x-ms-office365-filtering-correlation-id: 37cb8031-eaa8-401e-0a85-08dcd7e9eaa1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?bW5f4IfHltTkv7FAc9WkIitjzjCMjZxclO70DcYeslKOb8ETxQaTGNNPEF/e?= =?us-ascii?Q?0OxzBUgSJMOM3G2azu1C/2QGRsylbsAvyGenSbKvHCrQdwtjok9xNGLS/T2G?= =?us-ascii?Q?+y4wFohsI9A5eNEdLP7naWN2hFiYRDs3LSTnAjrdPDQ8nDFqFuR7e85+gMkh?= =?us-ascii?Q?0SKLoPTKO7LgNLimeZj2MLHbMwinlvkLWc+7zp0Bjrs5a3f3oP+r48pLGnHz?= =?us-ascii?Q?AL9Byl8x1B+RRoh+YG9loCjUqfug02VYNFpt33APdBrDE8SXCKDxilwnU/RS?= =?us-ascii?Q?kIe6RtOeWLovoqbgfA561SWxioJCjAKI+NzQ6PLCbL7M8YHCdlC4/BJWRti9?= =?us-ascii?Q?+qncf20H3DiM+XI4xofVCnCDCvGJZlGlyYtrbe3LCWu1/pAXK++c9hyZ4iyx?= =?us-ascii?Q?TejdwJptVjrddib/baDCl6Ug5KnsEe9RTeH0m+Lc7mtDqRnkgvi8zC6ZNrG2?= =?us-ascii?Q?vM4FSHY8erLE+0gtqErl4dApyNO7AM3IF6AkY4uL0pATimvaM5dAYVdOnbg9?= =?us-ascii?Q?Ec/sKRxbcbArPeuuXS+A4UaZts/nzgQCvgJPb+avyEgoVIyjoHKJN1FOrOAe?= =?us-ascii?Q?xugO2kJybfaolmxdrHfM4T5BArO4C0CPHAjUqSPurZt3tkCMZ49QT8iJ13tS?= =?us-ascii?Q?w0bGmyJiHC4HDPIUVoF5beZFUyUk3Apv+NeMygbjy4CocA3KjsbJ9IovEHDu?= =?us-ascii?Q?nfUjOcB7frkpDLXpbDz3Bk7oXA0sYiRU3eTcuC8bf2PMCRhVhnkB0k1qJlmC?= =?us-ascii?Q?HQNfgg6Jk1VPMs1Xqyci1ZK++B/VCQI6ksZcCmpLgud2ACMo/G0Kg/3OK+Ns?= =?us-ascii?Q?86qcHroXCjnq7hABsxuOLEEaw5Lxa9MiW69ozGWv1WoNh9lRadefOx3cPKLy?= =?us-ascii?Q?G6O43GGOtvhICRgQ9pXG2NfH1wjeaMVOSlvA2YnZW2aRGM/7JyBjH4bnaMgH?= =?us-ascii?Q?dPr+ZOVv2iXxD9GRCmY8UFBtC4Q019fduPX3Lu6KrBnjE1ZRkYeszPOmm0tf?= =?us-ascii?Q?HMvAMlEsuLTmMvV1fCLpVkH/yjGrkhBDvonzS2noDg3eBYqAXYneY9zFo9+1?= =?us-ascii?Q?9/55jDzKPhRi1U0bbIRINQnoJqbi5BnctsOvlZXasHiTO5tnmLQa1KaNEg7Z?= =?us-ascii?Q?KwAsokqULbpJ1xYEdNe4/5BYCTda7ZY4i1/5VCMuRwnue7Em3cml8XDRPqfT?= =?us-ascii?Q?z5KHNnhTj7Zr2/BeSxCUofQV7E0HNMoCHT4HCG0UIPMbLELCYfHS8d1tGcNw?= =?us-ascii?Q?CbOtsNxcZYXuine1F0QWrSGjoWuD5SWR1c4yCCSu933tjjFq8qKAOGkBkyPo?= =?us-ascii?Q?R5y1XSlr6AsHvFt8iQgh/3VffnGXckILZx0SoB4g3k3NN3dzzNsrSoIwUofS?= =?us-ascii?Q?BC1xHcELBMPYSv+k0TmYh4FoQ422tuIHRvWtE5SuCxI/0j3bKw=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8460.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gwTwcEoGImNkosSt9+iyHdXjVUtlEIxZHtnpL2oTruwQkAuOCYMbu3pVwGCH?= =?us-ascii?Q?n9U75u4UJIrrBq8fCQhrfbG3llPlwAYeMi3a4MQ95epTpDp1p8pO/nHMugSP?= =?us-ascii?Q?WzKc+mRWRFy0vkuAa5207Q+Jjqv+7C64htUIbfkXSqIDxqzg5J/f8D8CM3NU?= =?us-ascii?Q?G5Yj3veqHRJIqaxXR8k6pfb/gc10HK8c0alcH/rAh1A1mMQrP7f8Km9Yswwz?= =?us-ascii?Q?r5V9nzr4r0B/oj+YL0rGuri3Wjt48w2bli+on1Vf60ga5v7PHv2ZG8QfNsRM?= =?us-ascii?Q?cEcKUcbgb26SuZUQWCX0nEXzcK07xogmFdKMktv6h7PRXzuzUlyR7PpHNrLj?= =?us-ascii?Q?Vd910KHMg7V2X/Htmk+WfjxFQDW2AlNycIVqOsd0WxJrwttSty1zK9ptRTzM?= =?us-ascii?Q?gLyALYncEiawYZXBmy13cbnw4sEKWD3IU0NdKpcWCCViBNBB5cKIxZ3/rYOg?= =?us-ascii?Q?gRiXIYILBKrVedp/399KEYJPGqu2jtF1yy6FKxYfs7BgPKGvCfDAnIWb0hfF?= =?us-ascii?Q?A3aUfjL61nXVOjSMwDZRc909UpdUccB+1Pw/bj0WKJPHLN7KhiaqR/a35nOJ?= =?us-ascii?Q?QCyGCGvC/hmtXKxWvhMj3Ffw5IVa1jUhZYBqKKU7BiCbjKimT+DjH7YoGRDx?= =?us-ascii?Q?n/ozA9QeaFmczeADWCqAdGeDUKozg5Un/yvBfsnubAgJVfB5Q312JCDoycp/?= =?us-ascii?Q?VNxGihMuUXVs2cg2kWbYZltLLMcAwN/nFTThNeWUfjccPJVbzvNkDN6fl0QS?= =?us-ascii?Q?Ctfr5+mW4CaYdVjrkF6gNu1vpP6tILeVid8adlMFvrK/dwmF2xY7cMHo6yoR?= =?us-ascii?Q?ENFoydM7mX6myRX4AInJPfDhF+nw/R1uBiMB+U/hlmcRJTKR+dP+FsTNG/ff?= =?us-ascii?Q?YfaF0+uuaF/Qs3k9PjCY3kSLgKcnFITuKCI9j28U91GdoI9zbwL8HA6iqcII?= =?us-ascii?Q?OljbfV8y9ToP3rbBlISeWKCgk9FdpfjuJibMmiQTdEzXayDI38JFpSmD/yiN?= =?us-ascii?Q?5DADewzqBFHxcn0rx+vy4h2m0fIgZyxgfJi4qXXBu+sMWWbV1mreDKwLmLAC?= =?us-ascii?Q?2cf+FM9dbFbBdJDpMrpXIrNEbwIqxkIAPkQUj+VcZD8JoRBldE1ewus7yLgF?= =?us-ascii?Q?6YwkHs13rGnjrt0nuhRNuKUFln7DsNFKBmHng76ny9dAJZRZRRt2Pa9BKZFT?= =?us-ascii?Q?zchh2m5lWRW7+tgQO3zLuzV0TGdXJnjUv3UKIRnCV7ZRAk4JNPjJin7zWHa4?= =?us-ascii?Q?m70dIrkSZJHxpxAJGuI/s+WvA7YPylMP+aIIFLA9jDYGYY3wqBe6Z2Xf0Pgu?= =?us-ascii?Q?q6b5CKMj4C3ucSBt+kzl8pXa56yc4YKFBRlfyeOMb/m+K5k+hfRA3SceuHPM?= =?us-ascii?Q?CBHfUIAVr9Z7LWlClue6D+80v/QlVcn0ouD/rpERESHho41Sc4uUk4z5i0nn?= =?us-ascii?Q?EdqEtKAAaz7sIIP4N1Kthm8C8H0i5Vw5SSOPNXt/DKwb/RYf0/N1C9vE1j29?= =?us-ascii?Q?f8nuajSFfnVaPkfN3EBvrnXGEGmYecAchr7hkMYcetOFvRKZWrSWK2jWa9qg?= =?us-ascii?Q?B3xu+rlpm9TVaLomI5JYP6Jpw2qLSFYtIiOXapV1?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8460.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37cb8031-eaa8-401e-0a85-08dcd7e9eaa1 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2024 13:58:04.3115 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: So6yOIPrhcJIbstJhixMTDicERmkgHOoHP7ZO6d44mj9mvV+rdoxgusGSt4djSqylpdohHXpMD5iBJBw4ry1JQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6919 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Slava Ovsiienko > Sent: Wednesday, September 18, 2024 15:46 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Dariusz Sosnowski > > Subject: [PATCH v2 6/9] app/testpmd: remove flex item init command leftov= er >=20 > There was a leftover of "flow flex init" command used for debug purposes = and > had no useful functionality in the production code. >=20 > Signed-off-by: Viacheslav Ovsiienko > --- > app/test-pmd/cmdline_flow.c | 12 ------------ > 1 file changed, 12 deletions(-) >=20 > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c in= dex > d04280eb3e..858f4077bd 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -106,7 +106,6 @@ enum index { > HASH, >=20 > /* Flex arguments */ > - FLEX_ITEM_INIT, > FLEX_ITEM_CREATE, > FLEX_ITEM_DESTROY, >=20 > @@ -1317,7 +1316,6 @@ struct parse_action_priv { > }) >=20 > static const enum index next_flex_item[] =3D { > - FLEX_ITEM_INIT, > FLEX_ITEM_CREATE, > FLEX_ITEM_DESTROY, > ZERO, > @@ -4171,15 +4169,6 @@ static const struct token token_list[] =3D { > .next =3D NEXT(next_flex_item), > .call =3D parse_flex, > }, > - [FLEX_ITEM_INIT] =3D { > - .name =3D "init", > - .help =3D "flex item init", > - .args =3D ARGS(ARGS_ENTRY(struct buffer, args.flex.token), > - ARGS_ENTRY(struct buffer, port)), > - .next =3D NEXT(NEXT_ENTRY(COMMON_FLEX_TOKEN), > - NEXT_ENTRY(COMMON_PORT_ID)), > - .call =3D parse_flex > - }, > [FLEX_ITEM_CREATE] =3D { > .name =3D "create", > .help =3D "flex item create", > @@ -11431,7 +11420,6 @@ parse_flex(struct context *ctx, const struct toke= n > *token, > switch (ctx->curr) { > default: > break; > - case FLEX_ITEM_INIT: > case FLEX_ITEM_CREATE: > case FLEX_ITEM_DESTROY: > out->command =3D ctx->curr; > -- > 2.34.1 Acked-by: Dariusz Sosnowski Resending the Ack for each patch separately, because patchwork assigned my = Ack for the series to v1, not v2. Best regards, Dariusz Sosnowski