From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9511A460CE; Tue, 21 Jan 2025 08:16:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E502427DA; Tue, 21 Jan 2025 08:16:44 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2050.outbound.protection.outlook.com [40.107.237.50]) by mails.dpdk.org (Postfix) with ESMTP id 1CDAA42707 for ; Tue, 21 Jan 2025 08:16:43 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wGzPbdM9uhCK58iK0RDMbNJbbNmZNzrkK8QvNvIftqpevngFNaSwa1vFUuGVwUeDI0wH+wB3A8kfDvFADxpxDmAz51ffGpe0Y5+aIVUeSJcN+AUQc+zZuncN8WHpmjTNAjquTQEBVd9/tPAblW7tMEWmi/05+xAWKHq+JplhnbmYnJ2f///0fnFGElz1ox0Cv2z5tU5yfLgmrN9msde20eC9lnYYhqlCqb1w1RAVAfrn8xSSjrfxa+DQka8Z7UPiKZAThaEVMFGJ5KhNDN5XuFV85lOjmEJt4BQ6Bws5Um4DUXbYZX9SB6fAPp8eZiY9QEETfadXj4vQuLGdoBWJPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7Mji8cpugZ5I226Rh79H/AeFayDilfkgNXvzswaDuw8=; b=RvhBh2E4snyzoUWz06T9f4aWtoNbz+DNk1Mp1e+Tb98BCmByGJaC3mGUf4rjPN94fjFxw3E73aeXo9t5Ezqkl3e1zBIRFAKRdG1pBrwb7Q1beGcE9l5bpRi++07tRIZEx1Kwr2SVYUZHfprx4qhvOJVWRe8R/nLFqSvNkzREYK9vy0eDzlAQxypLUmNYGVn0/Zq8x8Nc2I0L2f615pfeowJMBX/NAw7MyLTx+mK2k14M9sbEdh/pTrg08ePP5haTFniDNgrA4mWi01KXzs605fXn6QYI11pliC9E1gjNjL+VccmWtoT58ignMdxqSTiPTxkUsPDUEXrcL9G/Yn0jeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7Mji8cpugZ5I226Rh79H/AeFayDilfkgNXvzswaDuw8=; b=kkjv2bBni9x0nYEMfFaJoVe2x6akcpFi6//Suf1IqaO+0wgJCduq9VIdusRdW6SqEL1FFXDK45UbVGkMrniwc4gQ5PUKsxd3QR1wJOnriS/UtbJArnajs11Tz8J9qqdjZvVaWUT+09beplqrSWcZjLZAUmO+RT4YCZYkfYiiSRlOO2VWcvkoxA95gU+GtQ4Nj5ccHIu/ourJ8uzK7UyTzkj+dHb5Px4us0FUYIkGZDNlLxueJyA29xfbSqS+hSVKZVEOqm5WfqQ8KMUb4iWYvY53Gr3+bnUPgLfrhZ/VMrhQs+Zsy2rPUdOShcLgaTYJx2NlmS6qeSAL1ysB0roAuA== Received: from CH3PR12MB8460.namprd12.prod.outlook.com (2603:10b6:610:156::15) by DM4PR12MB5747.namprd12.prod.outlook.com (2603:10b6:8:5e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.16; Tue, 21 Jan 2025 07:16:40 +0000 Received: from CH3PR12MB8460.namprd12.prod.outlook.com ([fe80::2e9d:7265:3b84:59b5]) by CH3PR12MB8460.namprd12.prod.outlook.com ([fe80::2e9d:7265:3b84:59b5%7]) with mapi id 15.20.8356.020; Tue, 21 Jan 2025 07:16:40 +0000 From: Raslan Darawsheh To: Bing Zhao , Dariusz Sosnowski , Slava Ovsiienko , "dev@dpdk.org" CC: Ori Kam , Suanming Mou , Matan Azrad , Maayan Kashani Subject: Re: [PATCH] net/mlx5: fix the unneeded stub table allocation Thread-Topic: [PATCH] net/mlx5: fix the unneeded stub table allocation Thread-Index: AQHbP+U8W/q+MHLPsUKpwtvXCMzxSrMhKOHi Date: Tue, 21 Jan 2025 07:16:40 +0000 Message-ID: References: <20241126092539.307780-1-bingz@nvidia.com> In-Reply-To: <20241126092539.307780-1-bingz@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8460:EE_|DM4PR12MB5747:EE_ x-ms-office365-filtering-correlation-id: aedc0f8c-aa3e-4e03-129e-08dd39eb8d5e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700018|7053199007; x-microsoft-antispam-message-info: =?iso-8859-1?Q?+W7WiCFfD3Lf3DzlHLldF+HfabF4lxtjUBLFBRRfNe1JYYAas8xbThF6gv?= =?iso-8859-1?Q?NtEh7ha4bjwy3RaxxQSGdaVyb79cg4gqkooM6CKHhDIb7qS0e8YXPA8Q5F?= =?iso-8859-1?Q?YlhUqq7X+vTuEAS+CZzuW3GPEN+TfLWyMjXxOr7ffMKB3D4iiJcKLXlcS6?= =?iso-8859-1?Q?ozK4jjndNfqyWQpC/tn2eg6HfDmTAlpsVBYO3AjhFM2xtM2r1vKBzYCSKi?= =?iso-8859-1?Q?59UjtUVXZBes136DFCBRxybK/fI5CiNerwNl3Qk18lgw3n96XR43fVQZcG?= =?iso-8859-1?Q?rBbQ6846usXARUslPgOcF1trXI2qB7jq/lKRIksxVTSolSgU5cg2VWdfrn?= =?iso-8859-1?Q?3PVR9xHt79/900npBkF9SjICxKP9ru1lkHYFLeVGcITLKIq92IiaYOya+4?= =?iso-8859-1?Q?hiKBAVlGMGoMtwg8kaRLSbVAlwEm1r0C5u7RS0HsdrQoBchv8ujnUq9xdD?= =?iso-8859-1?Q?1+MSNIxlkGlMqqF5WFZ8L6/JMpV98ciDlK1LcMt3V9aW/wojLtdSgNPsHt?= =?iso-8859-1?Q?0dSr70PvssNyVADk2fF8gsJ9j40CHtg6YZQs1zMG9l/FlQmzE6hgB0uaYp?= =?iso-8859-1?Q?NGOchsUSNmZUbv/W5bisjwzTETs5p2RBQGgjmHovvVai1vh0FojOAMgbea?= =?iso-8859-1?Q?iY2h9Zfy18MsXDquAdKtnjA8yvkrd2u9ntL0dqUup1E5EOvmVKpzJ6VVko?= =?iso-8859-1?Q?cTeZ8Ezlg9edMlx52lWiFIq4MBeIUB9nnPpCZ8VrGNAXaVMqv4ETM1dPYd?= =?iso-8859-1?Q?Sp9VpGKKtS0QafPMo/APh8aeaWuwuNl0No50F1Y4sVITt413fPrBmlNw/5?= =?iso-8859-1?Q?isU0Srco2pJQivEKRKEHGCN9hpUnoDZ+YTjvYulBAvqeg1KcHyIQL53iiv?= =?iso-8859-1?Q?3MkjuKi6lQ7gjGSLZkAXGI37Y9jQA5wG31Sp0mqfS/K/YHBsfBS4t5GXGp?= =?iso-8859-1?Q?GLk4eqAC1j+vu4ic/4ZRYTpWa/1nbb8SdD8d/PVfq6Rcxexp2jHDOnkgZF?= =?iso-8859-1?Q?0Qd/oQBVgIa7C2qe26Vntkl8LtXMiUcbM9NxoVr1Z90sfCVTi3AqG9sYOk?= =?iso-8859-1?Q?+U9mlyPy6XnVgIv70DNUZshpc11HN5OeJE8CeGdLoNZBr9uJtBNIi+tSFP?= =?iso-8859-1?Q?QtWlhGVQFhZjQ/c3uUIzSV5B4amjInL7K21maeo5dngOOMbhl9lQnUE0jS?= =?iso-8859-1?Q?N+bKFSCm6pWCuy7Ca4bDWdIiXOhSD+HjGTkhE9o+z73pL8KoCqQWILK7qL?= =?iso-8859-1?Q?P0sCjH5kVzxoCI9/+pBgAFKxOsVBf/Nx7GxZOQMWe4UVTmokgcv2CFt+MZ?= =?iso-8859-1?Q?MTJ0Etxsk2GoY36rrvF7qt9GgODd8JoJz1VflwnZTyVknZe73HkDBHq94E?= =?iso-8859-1?Q?trB8BVJ/VVvwx3AEbpJCbLCoDBzZos3gsFFyGVdGA8aRciz9wej0LejeRu?= =?iso-8859-1?Q?t9W2kbeqGrLLTdN1oZhBoMuGHcE7M60mdoMNbuqcArsN7uVMMeKbNbdkS2?= =?iso-8859-1?Q?Bbdie/fXDICLXLt3kU9IPD?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8460.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700018)(7053199007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?sgsr/fR0JsyjpxAk6sZRwdjQ2bYCK8OC46H+bJcMu2v6ty0QUq0+NJNLVT?= =?iso-8859-1?Q?fjidmevTfc9YXiXJVWYwFakXULGzCND8ggY/tNXsudI9KbXBDidPcnkePs?= =?iso-8859-1?Q?HkgTIlDdBl8JM/Qa+5UmWORCwhx/JwinGWtqXk8bhVs038Ohj/EmeXQjkG?= =?iso-8859-1?Q?LA/ZIfsMBKdGW07D8l3+8LmNt3ZUcbXsxexX6QmXAjC8zYDUk9kn+7rdvH?= =?iso-8859-1?Q?7gchH65I9GbOF/9Rjt4yTpqDR2oveB8ClQTrTv2sGQ4lkOYuntg3igp/Bm?= =?iso-8859-1?Q?ibdaOwAIX42Gfpt5bK1tGpbsQpjuUZ9TGG82xom3wO56akgWH9nyeY4olb?= =?iso-8859-1?Q?FN5BCEGIix9I+3UKvfIe6TxNXVnQSuf6l7ivkMDQmKCDJObvyb5lEowGrJ?= =?iso-8859-1?Q?Yztv3f803vHsDg0GByuzsbKUQyOZg4D7SOhE7HH+8eTFG/ZGEZ64wvFQrg?= =?iso-8859-1?Q?cUbbMYz8O006e2ijSrKg7cAe+RDlf/7kEvJ7frxni2/6rPteXMZzP5wJDg?= =?iso-8859-1?Q?agwW1wyXOkkRbX4vOUDBZLf0uD5jxTilGfgECCQXWvggOqL7O2Zhl+V1BS?= =?iso-8859-1?Q?/eUYcZbq+8OXk6ELms08LrJ4L1BNgqtjNozFcgcuR70NLe4BzYthRnchBB?= =?iso-8859-1?Q?OHV+OFUFekr0YWTzD0AujTd0DbU8ETmDdSU3LEMplQG/+mRCAr3qq0za0C?= =?iso-8859-1?Q?TdI1TlfugTeyxlLn9Okm2h/+2E5DqGQ5fgcNjCmjgtAULhunKN64kvbXF/?= =?iso-8859-1?Q?jWDA7K7kyN9EgSwSON6OJ1UUaY9HonAqT9J/xRY2vFgHxKDajNBWAlkZnZ?= =?iso-8859-1?Q?zxdJzPVkZijOy20mZXaov6zMrnXF5SMWGyE98OVp7zd+Ea2UQYgcD6+/a7?= =?iso-8859-1?Q?xRMo2hxNsOJ7QoQRZDdA1VeGM0F4y5iG1DkH1pxclLu7dtO0Mn2N6rdGex?= =?iso-8859-1?Q?0Qz/MPTm1cVl0Tvbyys4OSVM515qd1P9aof68Ryhfj3jzylq/NDDnAmvlM?= =?iso-8859-1?Q?75OVp8peNY9AehpxNwtEpY7UPJD7WuMqs7pBwUqcOVXKlg9vHOBLJXUk/S?= =?iso-8859-1?Q?MMMhz8svs0NdsjyduDwoSG3y7XBEt+3JQ1o8wsFUEWYC8OF14Da0J8Z4x7?= =?iso-8859-1?Q?WwRtO+BpofIUVD8IITz+3vndmKMPDOyd1Ur+XbanZbbatn9EHMRzRfgDd1?= =?iso-8859-1?Q?ZcFp9XlTIyTe0d4OnNQ0/YVDTLKj3j54TZ2RUnEJJIk3KGhsKGksjmssJB?= =?iso-8859-1?Q?7wJiI8O2Mb7sMsadJtTNesusJv04/4RVLLN2LmzxnwApqNlDQ15Qkh0N0Q?= =?iso-8859-1?Q?lRrgC52wK9LhzEpcAwXpFF2qd39y2fYeb3P19VsMd171IHODk/QziJ5PYi?= =?iso-8859-1?Q?XTsReyMMeccIspvBZJ67GfII7xF7XWgadFIj1rUWjXHBSgvVy16Q6wkOD4?= =?iso-8859-1?Q?VedJ15QU4i34E1UnUZcZESTkDKLzIOI/NdiCjieWAG1p9++NHfju2JbBCE?= =?iso-8859-1?Q?i97+FfBgvKc2QMgMa4bZ7mBUoYd2rzm3uvOPxYu68MnLYPA0qf3CVHQAXA?= =?iso-8859-1?Q?rLsolPxj2qoo4vLhWqHH6IK+Jaa7weyx6GHAETCV9QOOf9+RvFNKE5zqKd?= =?iso-8859-1?Q?sJkUdQPaYfV83RkNhLckmiI1Y7MY8kfAXL?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8460.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aedc0f8c-aa3e-4e03-129e-08dd39eb8d5e X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2025 07:16:40.7832 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3rhHREICrHwbYuEK3aPJ1YUpAEPOiEG0MOox4+gKj2PIexrzvNn5Gb1HYc1Fl1HE/DnzsOWjkSGwQPB2UAqd9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5747 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi,=0A= =0A= From: Bing Zhao =0A= Sent: Tuesday, November 26, 2024 11:25 AM=0A= To: Dariusz Sosnowski; Slava Ovsiienko; dev@dpdk.org; Raslan Darawsheh=0A= Cc: Ori Kam; Suanming Mou; Matan Azrad; Maayan Kashani=0A= Subject: [PATCH] net/mlx5: fix the unneeded stub table allocation=0A= =0A= The HWS non-template flow API is reusing some implementation of=0A= template API to unifiy code logic. So for each rule creation, a stub=0A= / temporary table is used in order to reuse the actions construction.=0A= =0A= Since this is temporary and used only internally, there is no need to=0A= save the table permanently. Only parts of them are mandatory, so the=0A= allocation / free from the heap of RTE memory is a waste and causes=0A= a lot of overhead. By using the pre-allocated workspace and set the=0A= needed fields expliticly will save the overhead and help to speed up=0A= the rule insertion rate.=0A= =0A= Fixes: 27d171b88031 ("net/mlx5: abstract flow action and enable reconfigure= ")=0A= Cc: mkashani@nvidia.com=0A= =0A= Signed-off-by: Bing Zhao =0A= =0A= Patch applied to next-net-mlx,=0A= =0A= Kindest regards,=0A= Raslan Darawsheh=0A=