From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E880245BD5; Fri, 25 Oct 2024 13:54:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2FEE40156; Fri, 25 Oct 2024 13:54:58 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2052.outbound.protection.outlook.com [40.107.94.52]) by mails.dpdk.org (Postfix) with ESMTP id DECBF400D5 for ; Fri, 25 Oct 2024 13:54:56 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Rnzbk2KeCkXyTA2gY8jbAahQmgnrBGi1mjneCbG10CRkcOaRJGtwRdbnIWcvQZFtjG+bWqx4CIp+t8YfWqNIWEsqmXGBWobLoVxBt1x0XuIK8dkLvO085iT+SZtyB3/y1sCkbtDLcOuHj/24Ork9ja/khDU3vPiUTW5fuIAsOmdAEtvKoT6ojni4O5GDPgksu8BU5LD4iSW/YboGmV1nJMC18lQTINlvgeF/mvG86ntpbo2fuupY0UwpF02vbOd8t38pwI00TPBO4zKrlhSlT76nbkpalZ+WrPiwWKBXlhqewGJLWu2LEjXgXx5fZplRGx0Ro8P5mGKGpMAyBW0CQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PgDOPJKneSEEVlQlizeMMGJXf9y2jRsWeTKp5uEX44Y=; b=Ed1sWvkf5SpI8Q818kemK7Jh6Absa3PiOy2KqxQA9gUw7Jue9NP8dRt6Z4F38QotBhMGv8xyT+1Zjsue0O4SKMl3P6i9UExentKFJx4cqB1x/A7mws5xQTAh8SOyOZmLjie7AQYjFQbI1wB8wLaxibJLKx6vP66qe+V1gBAMj3d0msCIYih/Mv+HCz6Zf3GN0DGnqGQMEvfVW4sfJ1P46Lakq5DOSHxca7fMfW6n4v9SPbteJjaU4sd0tlwjtBsMgDiMQM1NYYasUSUCIUjoSFhTsWbDj5JS3nucjxcHz2HTl3JulzsHVSW+l4k1UuBQ1SDxEYR6EOGIPjZ6DyyUsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PgDOPJKneSEEVlQlizeMMGJXf9y2jRsWeTKp5uEX44Y=; b=c/1uOQIgKFJlGxcTYORAwPOxkCwwcmX+KKulM2ZhvjI8P9qT6oeEe+Dg2ocx+sDcUOml31mud8IRdprBkS5OcdNYAOe7gl40z8IjbWJEWMNBMkmTNoebpxf8naSpERjf8DSelH8E8Iz2MKpK07X9uL/SqKmug1734qT0f3T+QG781//NeaClyBUBr4rmF2tZq9WcXNnnQvMQZusbmyHTP4ABnNQO+3QdKrRGMq4OVqtDfbp2BPPYXetKDpbklJaGeoU/D1nWrM/VY14moBGPH1E8u7JqMvPaQXlLa+Ms2zCCoHCNWu4Mh2483szekvYlxRYSM4RnVH1BPl68+Rj9YQ== Received: from CH3PR12MB8460.namprd12.prod.outlook.com (2603:10b6:610:156::15) by IA0PR12MB8207.namprd12.prod.outlook.com (2603:10b6:208:401::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.21; Fri, 25 Oct 2024 11:54:51 +0000 Received: from CH3PR12MB8460.namprd12.prod.outlook.com ([fe80::2e9d:7265:3b84:59b5]) by CH3PR12MB8460.namprd12.prod.outlook.com ([fe80::2e9d:7265:3b84:59b5%7]) with mapi id 15.20.8069.024; Fri, 25 Oct 2024 11:54:51 +0000 From: Dariusz Sosnowski To: Stephen Hemminger CC: Slava Ovsiienko , Bing Zhao , Ori Kam , Suanming Mou , Matan Azrad , "dev@dpdk.org" Subject: RE: [PATCH v2 00/10] net/mlx5: improve MAC address and VLAN add latency Thread-Topic: [PATCH v2 00/10] net/mlx5: improve MAC address and VLAN add latency Thread-Index: AQHbJHrxKQg4s3XmQEi+HmghXWo83LKS6KSAgAR3RzA= Date: Fri, 25 Oct 2024 11:54:50 +0000 Message-ID: References: <20241017075738.190064-1-dsosnowski@nvidia.com> <20241022120618.512091-1-dsosnowski@nvidia.com> <20241022084103.5c89b9a6@hermes.local> In-Reply-To: <20241022084103.5c89b9a6@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8460:EE_|IA0PR12MB8207:EE_ x-ms-office365-filtering-correlation-id: 20ce766f-e351-4dba-0125-08dcf4ebd51b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?54uYzj1SdYhq7o8TH3LAjR4MqB5i80mnNrQbQNzjZ09xLLTa6bA0Y1CC1cUO?= =?us-ascii?Q?8Fo3hV42mhelDs4Pl922ST8Wx+d3q6yR5YUoHT1uOtTHy90CUC4MIv1LFWPt?= =?us-ascii?Q?fZzw8+iHejhf7aztYP42Z7a6hgDD3WPBBGhV/hx7LUN6+m2MrrCes85L2v3Y?= =?us-ascii?Q?l2MMsjVmkb4i3AwO8ne8B+qgibQci1OQk5c/W2989IloQvSx3yUYesc1jqB8?= =?us-ascii?Q?jeQaBcsxz266nCm9+ug2GzIrltPoQiw4PvMugfQ/qfm20puaYJO3/CUgJ5mt?= =?us-ascii?Q?fvg6SBAthFFolbTbGoQjOiGVd96UDNcP640AuzD9KmResZvKnNiod4fbIknF?= =?us-ascii?Q?mGhMgqJP5uiSONfNK7fFfbtwldBWGDdQnBQznLAY5DDnPeQjKaLiFZluEvoi?= =?us-ascii?Q?i9Y/s6I4yPsltS80OcvgCJV5ZFvhZbEyb7eyboaiqpzl8V8IRjMYLLR61yZK?= =?us-ascii?Q?jqlCzIHzXcg68NkIlkNen4yrXTNf44m4y+pl/9xuFpgmUAT0Peo2qlJt/Z2q?= =?us-ascii?Q?zOP4C3qY30NvQEBPOdhQjUTAgNIEBLgEKUxxGPjMOQizziNvVqXaP8cPmUGj?= =?us-ascii?Q?+soGIT9UGepFdDv2YvMxhm4Gj/JTIpo0HLnLizEfCblAgogsDYX68LgvXSdR?= =?us-ascii?Q?jDpvQMEq8QAKtXqyhGv2SKCx9zAirAPFQYhcwJJubZ1ThF1tNVBNizzuDv2O?= =?us-ascii?Q?Zink16N7U+tIYxf5iUq46sosARrCUTDn5/j57hUivw5hn8fZRcSk/xeFLH2e?= =?us-ascii?Q?SPgjY3HG2p+bPL869OUpZn71cY94PMhCwsmYBf4Aai5R2e7Zw8sAJXw+18iE?= =?us-ascii?Q?jBhtUXEpd+JZnUl37QdycZ4EsdLgvhGFVrX+Vr9wFsls4AN3tURkHwjwZxNt?= =?us-ascii?Q?H70s2UDUN233V5nAW9idFg5TfIVZ3+O5f+mbwXrcDo4y4x63ySP7ZHYOvJKr?= =?us-ascii?Q?meuu/VxEWnzBxMThTxxCEgJF0OJ83AJVMFI79rbyz5IzyEbREetTxwuase41?= =?us-ascii?Q?dxfjrm9i5HdxjlQBH9zbZho3uFuAx9I6Pn/iHkkqVqIlSXzTi5IcGMf/mQdZ?= =?us-ascii?Q?Na+HD265oZyRAm/FiCnVa0gI1/PfmlcMw0sYUWOcdCvyCw2z4FttHYmHLdnP?= =?us-ascii?Q?ZtDsRCV+kUzA0GUSnjZmi67x+UGsQSM0k8RGYt1sPY8Cs2G47FbUPyMl703n?= =?us-ascii?Q?N12cG6DHNqawXR3HqO6qOU8k3pGTYxdTxN7L2WFHCGZ4W9/RVk0PXpYeZFk6?= =?us-ascii?Q?eCYlzB06TFpA6sdurF5GxCMwDyLcXgUgxurs5fXhvWrp1Qg/YKZbfxwVPB6A?= =?us-ascii?Q?WNAt0zsJ8StJii7T8ExxbJVVe+QI2eNVQ0Pl4qiDsf/OU4qS0TTKIXIIQeJs?= =?us-ascii?Q?/Id1NO4=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8460.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wzCRsUizGXEJ4/srUojmYnfaC5uYI+GBAmccCRjOKFtCNAir8GPVEEPDVumQ?= =?us-ascii?Q?LekTrtuzTbZneiQpT59w7hAelt06fCr9RIqXC5kjLnRj35u1cMfnXUIup9+6?= =?us-ascii?Q?xdxhDMNDoLMGOisbbzdIyr8F84IyPagaUVw+KnvjWng2TfEoQiQN6dbAgO2f?= =?us-ascii?Q?HRGlvQQulwUXqjTAaVkIak9CUgLo6fhHiOz7emTI9BfSesNE+BqRh3sLu9jY?= =?us-ascii?Q?leNX8leMMepS7e1iqD50/ceyxN+MtSA7pd/GMMlh5p/FKh4Fcz2BC8oqxn+P?= =?us-ascii?Q?cOKHaEVSVz2UVLYl+mwzd0xlT+8C9oR3yo7ENx2RDsyAccCK5NyLQzpeWKFv?= =?us-ascii?Q?B3yBo5YLZSwPVmss9hqDY31JgOlJ3cqkFBmphWJ2fh08bhkPxcDcTGh77U+b?= =?us-ascii?Q?5b357JXQIVcaaS4a41ql8fhEvTK6hclVoadRTjKu+Fhs8P4BDDxFRR7RExJ2?= =?us-ascii?Q?cYO0t/jkPzZCaLf1yeEO3KOu8crJqL8JzDp8fPaFydVYV1E07JVihppk9mzm?= =?us-ascii?Q?xX4bWaXYhxVm5jtfyAbPjp2/KRDFkVj4wnG0z4FFYx/t57S4ABRbf7Nbb3lb?= =?us-ascii?Q?lPA+0yJ/KRXwYD6V132j28ZHZdgNMixRldM7YIkH5u1FAqPZiyzfKP9Lyuk7?= =?us-ascii?Q?QsV3zSsC5Fy+35kjszUfTChYry+QpYyw8vaDpNSYJdoAu51Xx8/0pxtrgUJh?= =?us-ascii?Q?HRzIq0FpuqFHQQJCXyMvNaDHhxo9UiZa+ihMVdHgDUZB/JhGYCXhc2AkLdpr?= =?us-ascii?Q?L3qS8luRCS3OYng7+eaQSQQAg9yZ9UHANwfo5Q69s9whtERZB8yMrbiQ/feY?= =?us-ascii?Q?aQOFWZ0PRn6URaCnRoFtgyhe+9albtKYpw6yt13V7kI64lE+Z9DVKfQ/+zsk?= =?us-ascii?Q?Ix0mYSX3fIsN1LkDTuznb5DnFOpj+eTVu8vDFJgfCsj1fT2urdoDjmhX6iR4?= =?us-ascii?Q?DRmLHG+BOyQE8lcWXlVs5Q4RwdvcGn7Apsf7tOd+T7aevI0PGsbMwuh6Tr8t?= =?us-ascii?Q?nCRJyDedzOW1NK8h/oppimrGI03/GIiYw6oYN8Mg9ExupJqkm+A4jwL6/CRJ?= =?us-ascii?Q?tbRyKziFY5C1LudQZEZlnd/6JVOFc0K4SLuLPEZQSH2chc+T6VcMQQCpup7X?= =?us-ascii?Q?+/39IjiSPbAJDn0cXedHdPKwo+M3Megj9uWe53E/o7A+o9RcoMnWZQUUQbZY?= =?us-ascii?Q?jpw2Lzk7YUTG+X93qk3YgQ4lb5c1rM43XKLv7RfuQ8YtfeNfSUImVE5r1SoQ?= =?us-ascii?Q?p5JGwROsFCSn4plGliKDgmiwaLvCUyvG+EEyXbXWSXxjtMQCF8jdRXZn5gtZ?= =?us-ascii?Q?YAdocjHBqonAgHNC44mqDJbWaKvwwxvazK2kNga3mvQDheNpvTzw+7nkwmJb?= =?us-ascii?Q?dRhKMG7vSDWefcDkZpPswkrXClZOwWXWajQx38v/wdWdVa7zx5aiZNWpkVVM?= =?us-ascii?Q?/eCKNOHOZqUefE8fCeZbcuQgww/1P/j4td3ZHONcH6XBVCi1zl9kxPQxQr+o?= =?us-ascii?Q?wqfbZijsWDQUgtY1YFFk7vPBqfAb9gXAJ3OE+7q23SgK7umEahxHahwAAAfj?= =?us-ascii?Q?8ulZAAeLUO1ADQt5wocm8DcDPCeXCQK2UbC3yboY?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8460.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20ce766f-e351-4dba-0125-08dcf4ebd51b X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2024 11:54:50.9128 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fj571qAZKkCXKEdFOU3hasyB58YinowMLIf+rcR5ho3IATXAt30Rl6z1c523XPlxYw3BV3Yn4/p4+rovBxAWwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8207 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Tuesday, October 22, 2024 17:41 > To: Dariusz Sosnowski > Cc: Slava Ovsiienko ; Bing Zhao ; > Ori Kam ; Suanming Mou ; Matan > Azrad ; dev@dpdk.org > Subject: Re: [PATCH v2 00/10] net/mlx5: improve MAC address and VLAN add > latency >=20 > On Tue, 22 Oct 2024 14:06:08 +0200 > Dariusz Sosnowski wrote: >=20 > > Whenever a new MAC address is added to the port, mlx5 PMD will: > > > > - Add this address to `dev->data->mac_addrs[]`. > > - Destroy all control flow rules. > > - Recreate all control flow rules. > > > > Similar logic is also implemented for VLAN filters. > > > > Because of such logic, the latency of adding the new MAC address > > (i.e., latency of `rte_eth_dev_mac_addr_add()` function call) is > > actually linear to number of MAC addresses already configured. > > Since each operation of creating/destroying a control flow rule, > > involves an `ioctl()` syscall, on some setups the latency of adding a > > single MAC address can reach ~100ms, when port is operating with >=3D 1= 00 MAC > addresses. > > The same problem exists for VLAN filters (and even compounded by it). > > > > This patchset aims to resolve these issues, by reworking how mlx5 PMD > > handles adding/removing MAC addresses and VLAN filters. > > Instead of recreating all control flow rules, only necessary flow > > rules will be created/removed on each operation, thus minimizing > > number of syscalls triggered. >=20 > Looks good. > Is there already functional test which does this? Mlx5 may not be alone i= n having > this problem. I could not find any existing functional test in DPDK or DTS for such a sce= nario.