From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DEF55459CC; Wed, 18 Sep 2024 15:57:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE4B842FC7; Wed, 18 Sep 2024 15:57:45 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2081.outbound.protection.outlook.com [40.107.220.81]) by mails.dpdk.org (Postfix) with ESMTP id ED86442EC3; Wed, 18 Sep 2024 15:57:43 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=s7+ly+YYZ9JZ+MZrK0qCVLuIk9uc4IcdNB7tEd7h6fvJlpELHwPi4X8hJJtki0IOTRL19zlpxkzKv5o+O88xeM6K87wNCgYd5xTrjFrKv+L/00ODOYiZ6KfiVhlJ4rtNkFn4C//2FvRv1yzarA5VNiPPlJo24q7Ph2v2M57qmq1gCZESpgGmvsuMuFYQ2Z/Xg936H5jtP/fWeTsp/DmHwxwoVXWELzFy9u0Cmtbfhs3KoYH0Q+6Q2KdF2a0/btH1JYxdLONaiDgtOMgAE5r3zmF001IhYdzyzqP/ODhcFr8OfzXCeJQQ7FNy2LAeBxSs4DdeYcFST8rmYdfH7fdEaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dd2b/4ioBpNHz/MWtNzcUMtg3h5BykraNCi4p1mmEro=; b=TEbgIFLN28F3zKjlvkjjswWV9b485eonSYhrDO6m6WGmipsM21i+Ygw049IdbO++V//3GvpQZ6d26aAuyxSQe/hHdWD9VI3BXEWbh7SFh7U75UMdHCGWMCMAYUzfKTQLWfHClymzOj6InT62Z//41lFIszGZE4OGqyceVgTEpFIxUUPqQ5WEbEwuVv9T+9oZx9+sNe65diQcNMLjJxcAPZDpLhEscCTUshCBQT7iV2Q/xH8mg62dSmsWK0i/Gfm3O1UrvUhEB0SNLKoRFBM6QEWVA7IYu+fsgmXHEAX7Lcv1u581DU3yotNGoDwdQ1OeDS5tpVNTqixreaXyb902Ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dd2b/4ioBpNHz/MWtNzcUMtg3h5BykraNCi4p1mmEro=; b=YiUcQALW2yzfPoKyywl0IPuwLVIeiqX1zHcfUSLiTfDwI7HjLV3QHoCXpES2Xn4a/L6z0KaaO+35VV5EKqUuLoVOINLfo9T8i0E1DvRHj8YLMMwuoxfCMev6A4kUDvAbjeIo8WcJJRpVFMTJcRWR6Ybfq8vpwS1t1JgD3IVdkf18bV2Wf4BQG+W8EXcV9VWT59vWbrDcwknFLKWa6CH3lg9Oji5Q+lHYkECAXLXF3S4cV+/yk0avtRK3ON10bBqZZObjeTVscXE8IlRBSjcXCqglKS4j+7LIdnYNJrJqaBeE5sukFqFIKZBa3uwdDcvwpJfTjbLdckTgjgrgcmGjHg== Received: from CH3PR12MB8460.namprd12.prod.outlook.com (2603:10b6:610:156::15) by SA1PR12MB6919.namprd12.prod.outlook.com (2603:10b6:806:24e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7962.24; Wed, 18 Sep 2024 13:57:40 +0000 Received: from CH3PR12MB8460.namprd12.prod.outlook.com ([fe80::2e9d:7265:3b84:59b5]) by CH3PR12MB8460.namprd12.prod.outlook.com ([fe80::2e9d:7265:3b84:59b5%4]) with mapi id 15.20.7962.022; Wed, 18 Sep 2024 13:57:40 +0000 From: Dariusz Sosnowski To: Slava Ovsiienko , "dev@dpdk.org" CC: Matan Azrad , Raslan Darawsheh , Ori Kam , "stable@dpdk.org" Subject: RE: [PATCH v2 3/9] net/mlx5/hws: fix flex item support as tunnel header Thread-Topic: [PATCH v2 3/9] net/mlx5/hws: fix flex item support as tunnel header Thread-Index: AQHbCdFA1QKlMndAzUu1p0wZT26lprJdkcXw Date: Wed, 18 Sep 2024 13:57:40 +0000 Message-ID: References: <20240911160458.524732-1-viacheslavo@nvidia.com> <20240918134623.8441-1-viacheslavo@nvidia.com> <20240918134623.8441-4-viacheslavo@nvidia.com> In-Reply-To: <20240918134623.8441-4-viacheslavo@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8460:EE_|SA1PR12MB6919:EE_ x-ms-office365-filtering-correlation-id: 8fa7ed6b-a055-4cf3-6d0c-08dcd7e9dc2a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?nsR77qsmkUCveXJicRHdfO1Y5P5A6Y1mfdQTEg74eN5cKOY5BfmW0O0pwLdE?= =?us-ascii?Q?7KLvcZeDrUdmsSwVcUtvabHucP8Bqf/5OULXWvIDrxXoZ9SFPnLmSVG/YE0O?= =?us-ascii?Q?7Q5f7p8fLvxsxWYd8k0ldSd82dt2zbbhopDvos6+nPi4kCsKV3TqfJQR52M6?= =?us-ascii?Q?YipeJ1kTjAAAr0DAyRyAT+jj1oXOqtqenh5od2yWpOoZI1SE7dEd+9dRYoxm?= =?us-ascii?Q?ndZy5bVsjfJHol8JKloFdTShbBGx2q1xPpT/jytjNmd2lxPHF22B3hfa1lwx?= =?us-ascii?Q?nh1pbtVSeHWCgk6JHNE5J+GsENptmMOTDN8Sem0rDn3MmfbB/XPjfxtG5U2a?= =?us-ascii?Q?ucX09wvMsogimbk2MhltkuTUANWxRfN81Dum84P9irjaTPfGj41q5RawUYvF?= =?us-ascii?Q?9ywY9vLwtZSfnVz07zyaFwRyBy8riIeHk40Ma4L88u3x/MCVSXYyqVuCsUDO?= =?us-ascii?Q?iwYIMUN3wgRbNYZhvqz9edI0FShQUvZPT8wX+R62b5OFpQOGhsk7T+gwt2j4?= =?us-ascii?Q?MJhsO2cWfDkYqCohe/u8JuXdYUgY/4nI8k5ndZoqafbx5ku2pQwGzRMlD8Ul?= =?us-ascii?Q?r6KAGxAeezsuQ1xtJ3hKhGE76K7vhAVVIG8JRQaDLN6+o2skNZZMRPxHNb0/?= =?us-ascii?Q?dkhNK7f8q12bG8dkNvkJDs3Gz6MXiBDbeBElLiddKTnW0OJFlTRkqT88WsUO?= =?us-ascii?Q?xzXTygAWPo0JJ8rt8aEDqPy4mx1SHYLZTZ6DE6x/T1KAVj90uWz58tT/oAje?= =?us-ascii?Q?rOvQskltOQq9yAJkvpCUlXs3FXLXARJp3gi04ec+lLrDry7nGOMksqiTloOY?= =?us-ascii?Q?K89ke69CN9Bi0MjOT6pNLYDtki83IRl5//n5w2kTSfU/4HiVQ2kCORDgdmW4?= =?us-ascii?Q?kj21zKcS3ZY6MowRgjPYYbfsYv4b1bVib1Jy2KGzl/2FUGjOQe58snPLjpm2?= =?us-ascii?Q?7yKnu9wXAuB90V+ir90ZiSaVbpFlEQ+v/gMLjjZqSJLHDAigstpZHEgw57sz?= =?us-ascii?Q?cHu27rJFNF5mMkebQ1r9A0SdaOgjseVRJrXHC8AHh3sxp1mpjuif7D/yWrJk?= =?us-ascii?Q?xo3KPikly8hL9E4XQqPuRINZH9v8VdjRmRboSc9Df1F6CQ9s6YDqbJEnikWL?= =?us-ascii?Q?3KEggbKnOMrFPe1CPUUBP1e7rH0xGCUirji+ZE/E5HqLVZZKjfjhTV4/qhZJ?= =?us-ascii?Q?hyNLR3AOPKauMYfUCVGsRPUTHJNNdjBLjvPOundHK2ubEssafg1QXMKXOEF/?= =?us-ascii?Q?Fi0xOwj6zF1XjpkMIBoXSV6MutaBpEL0YXbzZM80ioDSUJdr2ckZb5i1FHW8?= =?us-ascii?Q?kq1QCVDekTI52+/o8UR6ywPQ9O2plY1BOGZc3+cqsw2f1ohsuSlOBXV/bUSV?= =?us-ascii?Q?lcY6dLk+QlFa481+e/SPNdY4lVY80ilqqnandHgr1eusbJ4Cfw=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8460.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CxTFYfdGKKGfTpTBmeKSZjy19WdTrChnvwESSZlohXcqo41s1qLkfAjnKITw?= =?us-ascii?Q?ZNruND08g7bzJ0fSlwaYaZGMZ9gNLGfoNfOfQvWWdyz0ZYdL8Po0+dKzwfcR?= =?us-ascii?Q?gnqPkHp6XCeFMCOAiA/tsyxsxxtfaMQpM0f3eq+iDJVTRd9usuq8tAmeaO/U?= =?us-ascii?Q?Uw/ZgTTRctwY2TPH2vFjKYbZgd6BvmjirJ//XAkt3YD2/AX+616o02AdJjkB?= =?us-ascii?Q?4/+7PdsY12QqnADyI6S1jshfkZzP3O9AlP51PHEvy0Ce1fdnqhbZrYMEEhmh?= =?us-ascii?Q?ouLIQlhTm4H64YES5oFtiqE3qviuMC+Yjw5pEWI7NOaoHZiJgive3+J8fRiZ?= =?us-ascii?Q?hPhVIlmS21Vu2L2ofLZa4DZ1miqtL44G5iTH13+2XNkATyiz1F2tBuBsBCdT?= =?us-ascii?Q?s/ou1WdoCcIjlg5YPC5bar0Ykua/89R09Rij1LJOZW133MzGV8fBzPXGuWfh?= =?us-ascii?Q?uFtRRqcPFX44JO1sH56EN5BcnqiruZkIRCv8Pp3wM4TQa6ZeiRPi0BL+W+p1?= =?us-ascii?Q?nh7pXiRL9oDBx3EwcH5hx3TB93tABVmGE4NPXpOil2aBSzUQtCWW1P4Xhxl2?= =?us-ascii?Q?qeB3vZNSLsoioyqBxIXw0b2CP1f1iIv4AlPfq+qtzg1SOiwb6KM4n9lxJANX?= =?us-ascii?Q?NQCNgsY1x8erKRdamIsMKHyy9NnNOl52jbgFkSscgWjGYAt2F++bPE499Al/?= =?us-ascii?Q?qBGn6+REKUS2PMg2VT2y2qn+ZuQpUSSulIiagWgY2lkvZGEhYfcF4LKdImxt?= =?us-ascii?Q?OcwV7JtOBvANu6Cn+FkAX9GbPZeYuG2pd1YH+k8fTGjmTyHXSjG/17bKtF0b?= =?us-ascii?Q?ir3OYrphubAlazGQ+bB0xJXMjltz3w4XcNaEi80U+tkRplZyVJFt/vEldbNz?= =?us-ascii?Q?acTU/YObAYS22KYN6Ewpzq2RBW1XqHyThgsdt1i191UU9g9vT2UyZH0DxqLu?= =?us-ascii?Q?rV+H37SlpasaKRhM4ts3T0UHkk78U/MQgCzS+NmP7jaGqdc1JaGr34H0EW5m?= =?us-ascii?Q?UbF+W6vUhSImHDci5arVOhoLWSgKJEoPpqTTwZmWFMolh8fsAgzr1XgLDt+S?= =?us-ascii?Q?DOkYZbb0fg8C6Kb0hLRWEvcjZD8NIXwDqXyp2oVY1XKwrJMortpHnr0TWXgg?= =?us-ascii?Q?dXOlNHbd7jPrnLVCIB/WX0DAwH+ZMX6rRjHilmcWnDuFcTUkCvrRDAErJYCm?= =?us-ascii?Q?Njt7mhweszBI9f749JlDmVCiV46CvIYtMWg3aC1Xc/m+Oz46zZNc7BVrc7TQ?= =?us-ascii?Q?bXnmH0JHAFfliMxyaOqew/gAtRGRejU6I3D0shOx5VgDusH5jCuvTQ1YpXe9?= =?us-ascii?Q?a/qjAGCSuuBU0dWzZurXx8I3iSvpuFYfULbs9PAebn0AZgcJqcFNFygJoP1B?= =?us-ascii?Q?dCGTYi9ufC5a5ETlOqkq9GS1hfwtAFKh10iNYwf+ipWKC3Ce1yN27a+70FGT?= =?us-ascii?Q?0ev+jTeds0UX0Viue+F1XE28uO8XYGwoSsy8kPwAgzfac6Gdlm74QyKkBsrl?= =?us-ascii?Q?EXNY9vb2iSxFD0ds1q6J/HIEVsFMYvgzD/iPj09muX9a4Gfk8c6QOERS736U?= =?us-ascii?Q?/9kPnBisvFs1SvHAqC3knpMpMNQPvuy6VAY7M6Dn?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8460.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8fa7ed6b-a055-4cf3-6d0c-08dcd7e9dc2a X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2024 13:57:40.0297 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ck3nJf46nuuKwtUhsdC/2i/BmvH2ueRAeaCVATJmvBoMCL+w+QchGzVK5RK2GB9HYVnumb/A7OmO9+umjrjvPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6919 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Slava Ovsiienko > Sent: Wednesday, September 18, 2024 15:46 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Dariusz Sosnowski > ; stable@dpdk.org > Subject: [PATCH v2 3/9] net/mlx5/hws: fix flex item support as tunnel hea= der >=20 > The RTE flex item can represent the tunnel header and split the inner and= outer > layer items. HWS did not support this flex item specifics. >=20 > Fixes: 8c0ca7527bc8 ("net/mlx5/hws: support flex item matching") > Cc: stable@dpdk.org >=20 > Signed-off-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/hws/mlx5dr_definer.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c > b/drivers/net/mlx5/hws/mlx5dr_definer.c > index 51a3f7be4b..2dfcc5eba6 100644 > --- a/drivers/net/mlx5/hws/mlx5dr_definer.c > +++ b/drivers/net/mlx5/hws/mlx5dr_definer.c > @@ -3267,8 +3267,17 @@ mlx5dr_definer_conv_items_to_hl(struct > mlx5dr_context *ctx, > break; > case RTE_FLOW_ITEM_TYPE_FLEX: > ret =3D mlx5dr_definer_conv_item_flex_parser(&cd, > items, i); > - item_flags |=3D cd.tunnel ? > MLX5_FLOW_ITEM_INNER_FLEX : > - > MLX5_FLOW_ITEM_OUTER_FLEX; > + if (ret =3D=3D 0) { > + enum rte_flow_item_flex_tunnel_mode > tunnel_mode =3D > + > FLEX_TUNNEL_MODE_SINGLE; > + > + ret =3D mlx5_flex_get_tunnel_mode(items, > &tunnel_mode); > + if (tunnel_mode =3D=3D > FLEX_TUNNEL_MODE_TUNNEL) > + item_flags |=3D > MLX5_FLOW_ITEM_FLEX_TUNNEL; > + else > + item_flags |=3D cd.tunnel ? > MLX5_FLOW_ITEM_INNER_FLEX : > + > MLX5_FLOW_ITEM_OUTER_FLEX; > + } > break; > case RTE_FLOW_ITEM_TYPE_MPLS: > ret =3D mlx5dr_definer_conv_item_mpls(&cd, items, i); > -- > 2.34.1 Acked-by: Dariusz Sosnowski Resending the Ack for each patch separately, because patchwork assigned my = Ack for the series to v1, not v2. Best regards, Dariusz Sosnowski