From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C9C145BB1; Mon, 28 Oct 2024 14:30:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7007740E1B; Mon, 28 Oct 2024 14:30:31 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2086.outbound.protection.outlook.com [40.107.220.86]) by mails.dpdk.org (Postfix) with ESMTP id 520A9400D7; Mon, 28 Oct 2024 14:30:30 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MWyA3uDt5UCVGAMAXuUV7TRFf1Nya7FUe87gOiFEDsSXtcUnbTV5rhWf5izXcI47EkDw9bVmoZmLQCkzrf0po7uAE/nxtTlTY971JDCqwq7hv/7FKem/bFoB8xIxnhBackj+zmXNupdb9wFsLzktKU8aAiWHHO6Jof75jWb0AaKEul+QaZYHikWoPzZc3AMx8RVkU1Fxhv/yboc+n3SdmkbstQCr1MADVLVGA/Ca6q4ANzNi2E3DlwNGMS3R5MZIUBTm7W4efdEL3AuffetwwFQH6cf+t0NKg+5B7KnWnhZCGDaeQTXfYkOWSkKK6JKC2uQktcOS0hEBMlLFyZ1PzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/ml57QMNf5Sct74rsu4+XVR0wfIPOlICRpp9P0/wkpw=; b=sNJFBxHwIYtK20wmPiyb2mHT0JSwhDd4O8PW2OrTC7tFD88IkNi6PHxMThZ94OiFETc0JgIglWcx5T87IqDA5GDP66mclrALK/Didtl0QVWRgOmM2aLwhTmrljGQB5XSyE5QuxtkP4kaiGaGLEy2mnwf0zq4KGGoAHX8FnEGjyC6obSFVpB3dehHOaCD067lUXHU8MVrMdyDdGk9Ri9LCGVo45vzaT44nnzXd9ad7TSX9p0aDYX/F+v9LrTKlaeR0gSLuo2ai7lg4Hqfky7+KIFCjUfeb/Np8f9wpP6czAfYo3S1wsIFMj1h3RWyn8f1RUHpN7fZKU210+pucfwlCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/ml57QMNf5Sct74rsu4+XVR0wfIPOlICRpp9P0/wkpw=; b=NMIy11NeupOBn6sY1pt0YvUkd7SlWcO8kOKpjFyb34Uh39L+O1wMaC5TLbEDkSQfXV5//R+H2WP6Q2tBM468wlavefGsrnAzCDK2dffKXmYkQlnXZZy+Weh+i8NTWOC7h4I8LF8Z07hd8tkSX40Fz4gHYLLAhKMyT1ZJo85+nt79ibTsottMei6jLTTx3TYyXi8U/o/u2I0XJYECe98sdB0kOgHTkXl3uy2wAqi6e18bhgu8Kdd4twk+xtpjxkL2ty3xTt7K89xD77P6KfIBt9lqjRbGGvUGtmgVhkXQwr85Vva47R+rM2VL/vShQkpHqEBwKefZZY8rhoqYiTJm2Q== Received: from CH3PR12MB8460.namprd12.prod.outlook.com (2603:10b6:610:156::15) by MW4PR12MB6778.namprd12.prod.outlook.com (2603:10b6:303:1e8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.22; Mon, 28 Oct 2024 13:30:23 +0000 Received: from CH3PR12MB8460.namprd12.prod.outlook.com ([fe80::2e9d:7265:3b84:59b5]) by CH3PR12MB8460.namprd12.prod.outlook.com ([fe80::2e9d:7265:3b84:59b5%7]) with mapi id 15.20.8093.025; Mon, 28 Oct 2024 13:30:23 +0000 From: Raslan Darawsheh To: Itamar Gozlan , Hamdan Agbariya , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Suanming Mou , Dariusz Sosnowski , Slava Ovsiienko , Bing Zhao , Ori Kam , Matan Azrad , Erez Shitrit CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: Re: [v2] net/mlx5/hws: in NAT64 fix TC to TOS fields mapping Thread-Topic: [v2] net/mlx5/hws: in NAT64 fix TC to TOS fields mapping Thread-Index: AQHbKItOrR2GzGi7o06MKcUBdpAcS7KcKd0P Date: Mon, 28 Oct 2024 13:30:23 +0000 Message-ID: References: <20241007083512.1332053-1-igozlan@nvidia.com/> <20241027161406.142704-1-igozlan@nvidia.com> In-Reply-To: <20241027161406.142704-1-igozlan@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8460:EE_|MW4PR12MB6778:EE_ x-ms-office365-filtering-correlation-id: 62d3dbb0-7759-4774-21b3-08dcf754ad06 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|376014|921020|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?Q?WwYBfbyj73eEpAFD064wy9FEUX9rvRJLJ0z1011CFavyxIcSe4Wac0qoIb?= =?iso-8859-1?Q?5FgIqWTV2V19WQBgdaBg53cTm/eW95vtJJXQZmnWo5wd7tQL8soUwUM2fG?= =?iso-8859-1?Q?QT3hpqFkIezOZmZSyRLEfW4BDXDgSmuZZXBQbgUBLuqrsT/olEww1Y4t2J?= =?iso-8859-1?Q?7v/gD1ckxt7iqxJZAqf3zaL+KB96uzjkGLElqMXaPnqS/nadQ0QUVqGwYD?= =?iso-8859-1?Q?9iyjn0J3cQkkEBUbudiAOfdiz+QPx0j4xrcoVQ51qXdDnjQ3zLtb22WwA0?= =?iso-8859-1?Q?R5Vn75LbrdLRU34BY4C0/nxklgA2JoKgwgp2ydhyGdfHzs2Ipp+RSR/bJ+?= =?iso-8859-1?Q?HW0ue3zjXCu2zBUNHeA8Ln7ToxAJofPRgLbeHwfsWvtVdtVTJrD2vIGyQc?= =?iso-8859-1?Q?0nCXRi7L287qxvHiPe8FLRtVemmqaVMRV3B8hZF1OwEd3QLXHLW9lbDc7v?= =?iso-8859-1?Q?OLfkDPchDb44H85eX/6AzvXx4KrVXbqdoGake6AivoJaEowStezQrLrt0D?= =?iso-8859-1?Q?htofR62col2hxofeWcdTCQ8CkuAYL6MtBWXvfRh9x79F3D0mqwOw2SyKvV?= =?iso-8859-1?Q?R3bRN/G7CZhth9glncNRdMz/XtHj3CttyiQHcAS5qsSj+DZ1HDs8dl0Hna?= =?iso-8859-1?Q?pdbqG4LhotpxKW3JSH2cwPXPW6XzCYxTVXkWGlQhMarr0J3PDRfy5+H0fY?= =?iso-8859-1?Q?gEkKhSxCWdaGREFtcI3sMdruhUWPdZNLxon0gKtJOGcfz2zkP0obuLt4WI?= =?iso-8859-1?Q?lMv4FaTf3U+I63+Az6ZeOzdRdyFDDoJrcSBVmiAifbp0wibXpGnBzTY2F1?= =?iso-8859-1?Q?vntyEHObxsPhaVfILWMI3QIXidSs+KHW4t2uOUwJtcPkiLhPWbUVOLRfmS?= =?iso-8859-1?Q?jhGicK0w8ykl5xcIAVxrZp/OZkH36k3k3sCevUdiGwvXKn+gj66AUXATjB?= =?iso-8859-1?Q?GcKJ7sSeh5NUnv33Zm6/J1v2UuHX8/OVowbsQIyNIQH3T5kgCbSw7fn7wy?= =?iso-8859-1?Q?qjiMm2Wz7+Z3/OMCJcosXfsojsSFcMpn5gkhjLsXSlaZ7LPT4yCBJ+IEXh?= =?iso-8859-1?Q?Y/LbHVax8ba8ISO0pKiMpv9XKAeSKvdtijchTQjYSoqA92nBQxtbXO5i7i?= =?iso-8859-1?Q?SGSKPsf85tEFh1a8NLepZdHlHAvfNebkIfFh1BS+xffANDNH5OBoa8Vzrb?= =?iso-8859-1?Q?9L+Qn37w2wJuE6aWC/wtQMnaZ4ImDUY34yrLAbnOMpu9UXYEKTua9m7Vba?= =?iso-8859-1?Q?CcQRzlB3PZ94Uf6eGWRtmqBRE4Vyu2o7PJ5x6vlmaqcWmA8JyEJv0fga8f?= =?iso-8859-1?Q?6PhiLh61MyyaY6K4WM4yJyem/lksDst4uhN6O0xhxeRd7rm/aih9EI0JNB?= =?iso-8859-1?Q?FR7hIH4kSpBHfiPV5IeD01y4JTLkxGrLfyV9O4tw0X1RREpGPe7jjypDgE?= =?iso-8859-1?Q?cAECpF1b7eu9VIF8?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8460.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(921020)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?VczlWkXLeEqyZ5TnAgoEBcALMC8GWxupmThP+bjfcjnOt/48mNWs18yn0K?= =?iso-8859-1?Q?BzP+z4dby7CKAIE3zRZ4hXnyS6I8FsjKTDNVecekXFaaU+h9IqXJ+ivESB?= =?iso-8859-1?Q?R2RAH2aiQzAA+m3PeeRTbwkYCFl+L55H6ez66HrnW2YNT5FSG9ubJ3wGzi?= =?iso-8859-1?Q?HibwYHRAsvMo4WeNkH1c1I/NNDysVF5ctvBoPbe6g106UFjtiFZCi4h9lX?= =?iso-8859-1?Q?DgjXq8Xwurgn0FIdvVrFVHObKv85QSZb7We679T5cWKDeX08vD7QljJc6k?= =?iso-8859-1?Q?qUotg08aLhjPOP0uZp3wmT/6hdrtEBzzOlo9C0E05LhaQk8F7zK7A+2vuh?= =?iso-8859-1?Q?Re0JgbuHTOvyastw5FfeQ6ZWGJjUrrc9O0Ad5uY1WkuR7Km9QK16WqHv36?= =?iso-8859-1?Q?ZtsN19+MPWXZuBcdNq9wD3o9gK4Mxt86fcRRC5vhEWxDL6nYU0cb4jyHox?= =?iso-8859-1?Q?/lBKfLDk+6mFCsPPYVQvCT8m89vLfW169S0szWLvfZQkF+zWkuaWUYYnAQ?= =?iso-8859-1?Q?ZBcBPg3Lo/DHl6a0AYaFNhBSY9rF4UaMIeDUivLrPF0jF7yzr1xuoNT/2v?= =?iso-8859-1?Q?dzfByHR8q0APO4JSUB0KR/crXGTQ9Q4UfQdwspR1OUqhyw90rqsCk69z0/?= =?iso-8859-1?Q?e6ct5CxaHl2w0PGcyn0vaBHHcYt1svfhYrb2ZBK+ixzaj95hXTnVDsZEIR?= =?iso-8859-1?Q?d95oLJccLmBw9UdQ7VNZn7Zc83k9NikToA//afojR9f7YgHe5HXQQCZxer?= =?iso-8859-1?Q?4/6zHcmHMWc+Hr9Dir3YnFtbxX4B/cVCiEhqrdnzAxKOFvg23mbOmqbNDz?= =?iso-8859-1?Q?wwUa3B24T2EsR+MOHgLRtPZW4yECbHT5itz5FnLH6uq+lhHWROCdMoyVTz?= =?iso-8859-1?Q?3rlySKhXq/xZNJuttxVfyC1Hzy1/qyl1yw9vL7r9s7KiTajUdoqqQpoXkY?= =?iso-8859-1?Q?DV0vFkVhXyEtATlcx5P8jVllHGVDwOmdkd75Jf4p6vYgT8cUOW+pUdOHnq?= =?iso-8859-1?Q?OziFhIfXi82n9/d7q+iGV+U2N6iwiN+05egvMBiwszGuUPYd4B1f4lPbwh?= =?iso-8859-1?Q?6Tw7DT96pPcieYWYDl9i9zKgX5SSNhPNS8byJL661Z5PzavFpAFCL4seGS?= =?iso-8859-1?Q?qgFNtecRdKCDKRYnpJ4nDSE/wxoo0lKsZuH++98ySTyV4rcTbLEqKoiXrV?= =?iso-8859-1?Q?yG89bzwckr1z3xRR4PcdPhsLCtb56wWFpxvJbfjWNe5VfqTvMudXPKxsoL?= =?iso-8859-1?Q?6j06RbY2lJ6a8vWwv66P6MvqdquohKrMX4qMgW7HGuRqwHAADEKPKVHjCq?= =?iso-8859-1?Q?hvIeMQPi6FmLeAfbNqyY3Zd/Uj+t8NbwN1rO0JiNZ7i2fGjlqQ5t+jzBw9?= =?iso-8859-1?Q?++3Su0W6iD+bRFGKd12dkZNxpT5XGFf/HeOtp7RuNkkuJo44UitPcXoaPY?= =?iso-8859-1?Q?9xNasBW9Sy28DKAtTtQm/jtCLd088nkaPQfacMfeQeOvGb/QMctjyJvNVA?= =?iso-8859-1?Q?4Dhbp2MqmiAWuEqe66uct2mjvVApPNuNIr5WH7+xtQ4DFjQQTty72MzQMv?= =?iso-8859-1?Q?yoUI3Q7QLPe3ruke3+PRUgOcOq9dgrKiktZ/qBHs4LBIiDRzrzowzdhFx/?= =?iso-8859-1?Q?/7JsCCCMJnaLd0VSODrw6WSvyX/NfDP3FM?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8460.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62d3dbb0-7759-4774-21b3-08dcf754ad06 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2024 13:30:23.1688 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: i8N7qxI2Cbl4FX6nADrNzAOfNgx1dXX9EUZuAbDFGxQ9bc0Rjjh8MapmFdaWtklhpk+7GjBWApFJ9vhJwG9k8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6778 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi,=0A= =0A= From: Itamar Gozlan =0A= Sent: Sunday, October 27, 2024 6:14 PM=0A= To: Itamar Gozlan; Hamdan Agbariya; NBU-Contact-Thomas Monjalon (EXTERNAL);= Suanming Mou; Dariusz Sosnowski; Slava Ovsiienko; Bing Zhao; Ori Kam; Mata= n Azrad; Erez Shitrit=0A= Cc: dev@dpdk.org; stable@dpdk.org=0A= Subject: [v2] net/mlx5/hws: in NAT64 fix TC to TOS fields mapping=0A= =0A= From: Hamdan Igbaria =0A= =0A= In IPv6 to IPv4 scenario when copying the TC field to the=0A= TOS[DSCP:6 bits, ECN: 2 bits] field the mapping of the fields=0A= get set wrongly, since the destination field of TOS is defined as 2=0A= split fields of DSCP and ECN.=0A= In IPv4 to IPv6 we don't have this issue since both the source field of=0A= TOS and destination field of TC defined as 8 bits.=0A= Example to the problematic case of IPv6 to IPv4, TOS to TC mapping:=0A= TC=3D[abcdefgh], it should be mapped to TOS=3D[DSCP=3Dabcdef, ECN=3Dgh],=0A= but instead it was mapped as follow TOS=3D[DSCP=3Dcdefgh, ECN=3Dab].=0A= =0A= Fixes: 06d969a8c5b8 ("net/mlx5/hws: support NAT64 flow action")=0A= Cc: stable@dpdk.org=0A= =0A= Signed-off-by: Hamdan Igbaria =0A= Acked-by: Dariusz Sosnowski =0A= =0A= Patch applied to next-net-mlx,=0A= =0A= Kindest regards,=0A= Raslan Darawsheh=0A= =0A=