From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7CE9E45D46; Tue, 26 Nov 2024 11:38:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4939840E1E; Tue, 26 Nov 2024 11:38:23 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2061.outbound.protection.outlook.com [40.107.244.61]) by mails.dpdk.org (Postfix) with ESMTP id 61AF24066A for ; Tue, 26 Nov 2024 11:38:21 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qC8GKlxpgzLNsHcO0lPBi699OMxpYUHWAxHYmLx/46vggxzbGeWNjw1o9Hs02PxB8BudvH69s0yUFzUleddakG+nI/3EbNBVNdOCtbZRJO4VmvZH6x4yoyCSshYyFNSkmo13tyeqz8fcN3PBkWmlXD0ZelAV2ac4VBoNRtqV/FINBennei7ikMxILi0EBmoK6suBPgD5fA9BRJQS7cBJtgHgJ+HX5ZTYUMQe9BVmWNITcx6dCR+VXqHLryA9P/psAms7g3xqXzjhs3RSFdIgf7TPpxwW2mG9FrsgPq7613rbIFtnigVizUVLsjlD0KlF/5A5QDLoc0qxkAj+nMsVog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F/GTVO4yWIvb31zjt/3S48Q9TZnXA9wsjvs7axrA1/Q=; b=dczfss/cdzxM3+aCmZuSSaDsqXygjr/Abt4Zbrn7voVQmUVdw/UiB/PGvMr5e3GX0+LMa3t8V7DmG+zz9MccL/GgX8k+0RLVJkUX6EtawSLrCR7MUGx6DAZBIbG2f/AOV8QM3M6mOZGCBS560S8U/rmvOzn7Mtk8w3golZWE3DcLucRWTldmBI7P+zmzLjgKF8UD0t8BHcHRzDE+TzAiuBXIpvtC4rSNjclw3XO2T+lu13vmUc0GuudMWKZlBhP+UIDHZnHJEIgLT+gGlVyee77YkiA8H9eTbF2AdceDJ2GzqmYTJl39TkSp7zl1Fuk8JNS4B+J6CJoleguYcjF0Jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F/GTVO4yWIvb31zjt/3S48Q9TZnXA9wsjvs7axrA1/Q=; b=YWoHMtRfsRTzPnFnGDkLyziepBbM8aJE7DVHDyvLX4I39daC0KfYUFI7EAgk3T9NmqFy+pqgHiKYQ/0WlYQMQXaim95bgSrS7qtKlk1ZBfrMSZEG3xlvOoqVuEHd528IeNdBjStnhAWjdh3UqEF5hfcTUqHIQ1O701XgP0ZZlby1Ym4MPsVYd5bTA/7Dt0m1bYLnIUnYe0iq1Udb3DXfA0XiNZbWFlK30j8/f0giR56OuYs8eVhrMThXD2e0Mrwbiw75Laj2T2XjbMhwVrB6mBAqs99BceG6RU5dRnXcxZ2b8xvx399yCd/4ryd+g91j0Tlb8E/cnTK5OawyhBcnyQ== Received: from CH3PR12MB8460.namprd12.prod.outlook.com (2603:10b6:610:156::15) by BL4PR12MB9480.namprd12.prod.outlook.com (2603:10b6:208:58d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8207.12; Tue, 26 Nov 2024 10:38:18 +0000 Received: from CH3PR12MB8460.namprd12.prod.outlook.com ([fe80::2e9d:7265:3b84:59b5]) by CH3PR12MB8460.namprd12.prod.outlook.com ([fe80::2e9d:7265:3b84:59b5%4]) with mapi id 15.20.8182.018; Tue, 26 Nov 2024 10:38:17 +0000 From: Dariusz Sosnowski To: Bing Zhao , Slava Ovsiienko , "dev@dpdk.org" , Raslan Darawsheh CC: Ori Kam , Suanming Mou , Matan Azrad , Maayan Kashani Subject: RE: [PATCH] net/mlx5: fix the unneeded stub table allocation Thread-Topic: [PATCH] net/mlx5: fix the unneeded stub table allocation Thread-Index: AQHbP+U8W/q+MHLPsUKpwtvXCMzxSrLJXrNg Date: Tue, 26 Nov 2024 10:38:17 +0000 Message-ID: References: <20241126092539.307780-1-bingz@nvidia.com> In-Reply-To: <20241126092539.307780-1-bingz@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8460:EE_|BL4PR12MB9480:EE_ x-ms-office365-filtering-correlation-id: e05218aa-ec3e-4521-e4dd-08dd0e067092 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|376014|7053199007|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?63ZKoC/5Ky55r/02k8tQ8ZRGbVnQQ/YztfIVPethi4zXJYBMr2+7G1BzcDY4?= =?us-ascii?Q?JOY1Pcjig4YslHFwbLW7P+BMqj9wyDl874sEdDp/4z2qQ+nlgpJTNloxYcCh?= =?us-ascii?Q?BbnNroMoTSOXm2s34MVJDYA53fVistDhQuOO7WYvXiDmLBssda8b8w43FWUt?= =?us-ascii?Q?nv3FlvmWmaEtNnzwoCg/Lhl/zwZ/LwHPeQdL4vM1wLZdq4mvWDADO9WvQrA6?= =?us-ascii?Q?szH85h1auWpurxZLKr7IL55A044AbJaNJKtc4sxWkyeRCzLbW2idcdmAbSCX?= =?us-ascii?Q?4a8qUVMye8IRabJJ3jFkjK4UHcRKTD9f1p36It7hYCy9Gl1DhAVTMIL7jinZ?= =?us-ascii?Q?lRot3UMUOTz7I8bf8qLwudH/Gg9CUSrLdvtoTaMCmfIE5r0u+BJHy9Q5yoAz?= =?us-ascii?Q?CGde3RSkrqC0IitUSxwHipamHV4x2pUpjDXNy8tgdTPK6qzR001+1wPlwP6/?= =?us-ascii?Q?MEuw1uHhbsieJLPffR+E9ECnPPotNiPkbiG/W+GtkXy2mjNh52py3c8ZRxWM?= =?us-ascii?Q?yNxK7zw12T0FB1JfOymxUFhRC2kKIlo1/Ast+9/RDNWJr27UmKpQ3CZ7QRrv?= =?us-ascii?Q?ayxVtekmgu4CgSvKmcwJBIGWWuGvWpoO8dBrkOD5RfS1+Fmg/F3NT8jOVOf3?= =?us-ascii?Q?gPuQcgEi/Y34fTAAgVjtmQFOHhHdn90oXo/CrSMxj72eVPnu1XlqO4sMhJ9x?= =?us-ascii?Q?BN330Jf76U+IYEUo/EPOcO9YFeOTIEcF7oD1YTOzeH4Xs56hfWVtlqMf05aj?= =?us-ascii?Q?x8uKa4YH1siowugfumaiOOPOly5nkDSijKBqzPGcCdz0MUoj4cmb2g/0fpaZ?= =?us-ascii?Q?mNkPQuHMn5Z2HKc0/ltM5UTJuzQ4p0gm0eG5HNZ42x9mrKzHGbPV6qBWUo4r?= =?us-ascii?Q?j/B8vaOo0fxdfWk2Ci+JYHNvdgWBwL+xTDx4bqFgbm0bapJrgr0XbV75FGxa?= =?us-ascii?Q?OLH57lsU879wxSo4Wk4LzDUiX0Xc+oPsh9jHcKxOrdZl1v0hzIFvGq1a/bGb?= =?us-ascii?Q?AF0JHMXDjZOUCpApIsTVD27VpQl624hVci5r8jKnNwMPWhh6fPqGwbSpsVuJ?= =?us-ascii?Q?oURT8kChKe8UBbvqU1CHtI5XjGmMOD5XK/BlL0ilZr4PSzfmd7o3se6kUkt3?= =?us-ascii?Q?3hN/BrYHo4ZLegLGmMFvnuYARojzJ+a/M1yIVbrhLz/v60xjKNhBLLCNfNbm?= =?us-ascii?Q?zsBtWWYwvesNoa/tzQK2BVNMp8dbNf0U4rC/s+KsNIl9wmZ9LyX5t7y2a40s?= =?us-ascii?Q?CrA+7pTTPm64nxe7BPCy6UMPHJV0DGexEUVu7r3xwTbXdbzUcoAqOCbHyeu8?= =?us-ascii?Q?ebswTRT+yjsEbAnrNSQXBXwtQTgfS6l2YGOaeGSHLd9zadMxQE2uYDe8mP+k?= =?us-ascii?Q?xTdKO0ZgaviCy4sgzxE0MzhG9TgI4MGbi3CZ5AXXNfyG2tKfAA=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8460.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(7053199007)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vvVDAO1lbZ9k8CbbArxmu+iIuMWxO8LJYN+b0ai/vSjii6MgsShMUVjAqaSV?= =?us-ascii?Q?brJzg3ukozU5/FF5dKLDomZaKMWdidx9kLhKe/5MFXXRdTbA88VqareI8Bzh?= =?us-ascii?Q?Iyj+e47n9h1YTnRWUl2e6pOmBBt4ZF2ojO4HwofCJShcZOVnj2V9TPW271of?= =?us-ascii?Q?PsLMMjDIJcUgR1jCnnbBCa35il3SCYFNMxMwgNhRfww/MYqLEXo6RbAbZjJD?= =?us-ascii?Q?/lq9tSqqAOYunA9CsCRziynDlb01r1n6s8J4/arPA8yHESRqQefydWsZFsBc?= =?us-ascii?Q?JrYmnglCSekm1NFcd5mflxqvq3zVOqqrUlQyyTkIWOEEgBbkfCfD0/uUJy+p?= =?us-ascii?Q?DAwwPLhCHkK0IKRtRy2dq5l/wEuDFuAgym3ooejNhIH52dR8eu1ZPKfEhtzd?= =?us-ascii?Q?mzvBDllyrnewzFMZYBTBdhZlki2D2D2KuQAQ8Gege3JFhY9nscPcHmXG0aSS?= =?us-ascii?Q?4PugYUYYKq3NGGrqfYMjx/SGkUyHUpZE/+Hdwg3VCYGlHP/jcptsti5s/o3R?= =?us-ascii?Q?MIBSJpxFFEes2uX+yZVLuRW8o2DvIOiZH2PMP2tEtcIJzMPjAf3U4cPmGw1b?= =?us-ascii?Q?zenqjHrB6IH7YUZPAebcqKdscS7dzF1j3NERrZIrm3OQNViaycAwhns9HgNd?= =?us-ascii?Q?C36fq3fQZ38p729UoZbAE3nP3xZXnELqiw53xhA1eEhQLwCcfGcViUcuN/Zd?= =?us-ascii?Q?HwYYOCDO5G+g8yf/2y2FWbK15R2zV7Vrgi0DBM3ZvzEi5I7oM+pZNFgCew7o?= =?us-ascii?Q?Ke4FYgn7oIzd1hNBqa4+HBpoK/jIokcAz7/N86Z4l3MgArRGQ4NIel5uuSkC?= =?us-ascii?Q?xDvCi9arlev05KmWgLuyN2pUpZkm05JRfNOaiBmdK2+GmNZuu02AmBuNFoT9?= =?us-ascii?Q?T7kBaJgchtrnOPvG9y+cwCaewlM7y7q1td8aHQOIAu1Hd5ZU8G2z448tpph8?= =?us-ascii?Q?TCwPaqJjqfhQFzle7aN9d3jgFTfPO5OaNwXAYvGA3X2d+321Cwi5tVDFa/fz?= =?us-ascii?Q?If6p0XQmqOUqaWCC76q0joAWoaF4vVjL7zVCg/hZ3E0+mVUyZJCnmdNAci5J?= =?us-ascii?Q?H4KiYWJhTyRZbgTn0y8GJgLtnwSBP/3etaKgSR/fdsSnLPfaXDXvX3kh2Qs7?= =?us-ascii?Q?MnvngorfZs1hnpHq7aOhHeHB6RVcBvZ+aqhn2/CNgQ9XZyNt4mgBD8ym9R0z?= =?us-ascii?Q?LR42UAeZFzPGUtQKd0ovZ82AIzEWvOWZZRfEaVjgl4LK6YVvUmVcAHQnaGYT?= =?us-ascii?Q?1cppSNkqEoGQ+KRLqslI/q2/BBQrVpMh6aFsSJCw2MAhfjPOKIPgK9frt3qD?= =?us-ascii?Q?zB8sJtMHVaSLt38OanBgFtnxlSc/0/sBvFQuTilj7Dk5sDjWjxeuMyb3GoSn?= =?us-ascii?Q?7cVeVslCaxtCtJ0Mw2Pq+yMZUf/NH5s5HCzEX5Sw5JH53s+Rz/GVkAQ7cwlr?= =?us-ascii?Q?j4GXuz5x+qpeQIh0G8k44N1z9Zne5ZhZDdncauPNoqNwwRvfvsqE+Km3B0q5?= =?us-ascii?Q?Wrrjfo05klzl5yeeiyIgnMwG3ufCiP5cfSWpHOX+ANLBkP6P/6IwIQPovRU3?= =?us-ascii?Q?0si8wmg61wib57sZMZ05uNghzouX/APXTYeMbnKx?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8460.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e05218aa-ec3e-4521-e4dd-08dd0e067092 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Nov 2024 10:38:17.7412 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4HVh3KzaOffxK8Q62MkcWY/5XcfYJ87j2Mq+hK8ptL2Nkv9As/Q+vmQReOcc1d7UdUlVJ2ZIWOznS/X1D9pbUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL4PR12MB9480 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Bing Zhao > Sent: Tuesday, November 26, 2024 10:26 > To: Dariusz Sosnowski ; Slava Ovsiienko > ; dev@dpdk.org; Raslan Darawsheh > > Cc: Ori Kam ; Suanming Mou ; > Matan Azrad ; Maayan Kashani > > Subject: [PATCH] net/mlx5: fix the unneeded stub table allocation >=20 > The HWS non-template flow API is reusing some implementation of template > API to unifiy code logic. So for each rule creation, a stub / temporary t= able is > used in order to reuse the actions construction. >=20 > Since this is temporary and used only internally, there is no need to sav= e the > table permanently. Only parts of them are mandatory, so the allocation / = free > from the heap of RTE memory is a waste and causes a lot of overhead. By > using the pre-allocated workspace and set the needed fields expliticly wi= ll save > the overhead and help to speed up the rule insertion rate. >=20 > Fixes: 27d171b88031 ("net/mlx5: abstract flow action and enable > reconfigure") > Cc: mkashani@nvidia.com >=20 > Signed-off-by: Bing Zhao Acked-by: Dariusz Sosnowski Best regards, Dariusz Sosnowski