From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1208460CE; Tue, 21 Jan 2025 08:15:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51384427DA; Tue, 21 Jan 2025 08:15:12 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2049.outbound.protection.outlook.com [40.107.243.49]) by mails.dpdk.org (Postfix) with ESMTP id B522C42707 for ; Tue, 21 Jan 2025 08:15:10 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nc5iDNDNiH/EXYoto7899fBdCSBpxHpVNxBqzz6QAh/X1h9VIiP8UlYTq00koFpRU3VnJ86e+VX//KCPkqwkjxZ9RhZbMRdpt06ovsxSF8KHrWumpYTE4sq3k+h12gZU7JXfS5VCefxuwgqW0j3csLwe6nrh7HRLEr684JEQl7MHAAsJM4CnLrHF2mpwTdJrKrDXqYkSAVuBmvO4fpcXuzWDGBA1P9glnZClS2YWE9F/YFZjB17uj6QekEjJ20f543/MW911cfPu9zgC2zqqv8XvGo6ll7PazYeYFU0DSSY55ycq9S12PBkqmh60SCUYsl4r2hj7BM8FZyW/pxMciA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YBEz3nqbGty0OY3QDLMOTf2JRRDKlgFHA1W4glZcsVk=; b=iTDUyZ21af98HJFD1pLClh1XhO/QEx0/BkzSafVHymOD6PhfeYOzBXrPw/MJWOvICHvHUIRemewNZAgLaP/XLJ+8T8zosETV5Rsh6+/ej83/7ttOwZ7ep9zTK37bFVFdcP7viftVYGqEprFxx+9w5qfouabkyq2jU0QhSyWj4UT1oSYLC1BH0zW2YXRrPrK2I+x/Z2m6GZHhvulRaSXryVRascRXPEEhWCKZgHjcvmoTSTIldO9cWyjnhZ4ufcgSw+xW8xRxlvAC/9zraymRWZGo1m44sQW/W2UMHgMIClTlZGDUhlhzq6gEDpIKubSLNpgRc7ZR9jxO74xxnHZhtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YBEz3nqbGty0OY3QDLMOTf2JRRDKlgFHA1W4glZcsVk=; b=IZ+uGpPaJM1IjwTI0e0Hu4GJKjb5UAAkHv3Ag4LWZt0qEpt9hJVXQ38ji+/sVcoEA/hy1jl4VJSvm/HX4W462faFDA6/XJtGDNq3sfYTA0Msc1Flja8rCI2xEc1YGJ0SHA8EcSjzK4iiRUTte6CLTCgrsXXftur6ZNHVIGXyceeGlHNqhmvWCqV3Wwhg71h81S5vDBIhc/EaejkPmyXkAkM4gYJe+xZMYNqUjeGINmrQKcQNz4am2B5HvFXvQ/xfjg+REDnSHnYUIuPFnjxhtKxsQrE4iFF6Gn3gHTRilvBCu3rOTEAxgfHon9noqXc8L42PzCVPrmMx4EpGRRHHeA== Received: from CH3PR12MB8460.namprd12.prod.outlook.com (2603:10b6:610:156::15) by DM4PR12MB5747.namprd12.prod.outlook.com (2603:10b6:8:5e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.16; Tue, 21 Jan 2025 07:15:07 +0000 Received: from CH3PR12MB8460.namprd12.prod.outlook.com ([fe80::2e9d:7265:3b84:59b5]) by CH3PR12MB8460.namprd12.prod.outlook.com ([fe80::2e9d:7265:3b84:59b5%7]) with mapi id 15.20.8356.020; Tue, 21 Jan 2025 07:15:07 +0000 From: Raslan Darawsheh To: Bing Zhao , Dariusz Sosnowski , Slava Ovsiienko , "dev@dpdk.org" CC: Ori Kam , Suanming Mou , Matan Azrad , Maayan Kashani Subject: Re: [PATCH v2] net/mlx5: fix the leak of action data list Thread-Topic: [PATCH v2] net/mlx5: fix the leak of action data list Thread-Index: AQHbP94gjUxIl/iN/EC3WawgwBOdwrMhKIa0 Date: Tue, 21 Jan 2025 07:15:07 +0000 Message-ID: References: <20241118065259.250538-1-bingz@nvidia.com> <20241126083440.307609-1-bingz@nvidia.com> In-Reply-To: <20241126083440.307609-1-bingz@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8460:EE_|DM4PR12MB5747:EE_ x-ms-office365-filtering-correlation-id: 105ed854-fa65-4987-36d0-08dd39eb557a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700018|7053199007; x-microsoft-antispam-message-info: =?iso-8859-1?Q?PpGihDw13Qeb+XKD56uZylgyx9+OS3jqxIZ+PxfPgeXSJMV3CyeqTop2Nx?= =?iso-8859-1?Q?qq7m3HaZ+xf2XygcElNiIBVt4jan+5vxBgdaCiS0PALwvRpKyktHyWqsME?= =?iso-8859-1?Q?p/ztBlRAYiXdE6hY2DIpaNDq/fCGf0h8GAmFVxBs8+gT+wPPXlvfKUXtcP?= =?iso-8859-1?Q?tRAllAYlvZ1deUKlXSNng6U6a6YUbSIkzUZP23TzTwhWyE9Erj0Bgcvyyv?= =?iso-8859-1?Q?4UxiM2k/2Y8s2dQCryanfO3lwUD4yslj81vklLdATNjPvAHnIFr4VBA5WJ?= =?iso-8859-1?Q?2FQMA95bZ+QLCN7NwxMEA4gKn8x42JldYyAjllN41XEOeML3+7wLyXHrfu?= =?iso-8859-1?Q?VO1AmhuDXxfTi9K9HHq27g1tM4TSJhAy/7DZnPVpZdpHi6ucTM7Xw3wZqO?= =?iso-8859-1?Q?M+jiqVeraoWUp+AlmYfqHO+l8hpABgE7JlHwuEZPs2ZLICdG3FZnw1uvT3?= =?iso-8859-1?Q?psErOnZBftYLRqkcCJV8d9Ho9PW9keZT9zbSEKhszhWsSHE3NtmUfldTMG?= =?iso-8859-1?Q?sF9rQsYseJP4s59WJeyyy8h2iVPhxB3y44RDnEEULS2bevs3GeWS/M8CSu?= =?iso-8859-1?Q?XbxqGxkBr4LJmBI2d+xpoIbwOdw2v1i2kqxQfL/Z0fOEhMf9mpJJBIpnwf?= =?iso-8859-1?Q?MyViV4PiN19uXsAqEBVBzkWkzXkPpOAE6ohJ/vLr3zJMlDkQ18djXqJ5Yy?= =?iso-8859-1?Q?3hptnLWVDh174iGI1vIK8iCIvP7nBcSvB1FkHva5541Y+TVru2PS9vS574?= =?iso-8859-1?Q?xHjswMeRpfIvEgiqReOql6/Vdq2t9cjfbGc5DikUNAQTMovWtcX4kwOtQO?= =?iso-8859-1?Q?Ak7SOIy8EktBf62POUHshfKZtJPMESZ0US+f1qUNgcZpjMfLyCHSXt9Ey2?= =?iso-8859-1?Q?N8Ld6zr48sncTXhgFa6jrqFqPZQhI80RJQvG2WLNnLMCxLh3v34JSi/tQJ?= =?iso-8859-1?Q?mBgU6+KUDeidNLAyJVcsaqUogm5xx2j6CdwiKZyUhNJf3/76xj2oa9PA9t?= =?iso-8859-1?Q?Rlbkzx3fE25zh7dHDFw2hEpyIOmZTZXnu5k9x1p+okqnGELcOREsgKA9ka?= =?iso-8859-1?Q?AuBkAZkN7XYau7pGqcA1EB42RHX6q3Md+QMXSn72SfSY+p7eZc261GhjI2?= =?iso-8859-1?Q?iQ3v6bVdAtOzNZ5C8MrQ7cAkgF1bw3gxWSZKYSgJM51S+wiQ1EZ2Depc5o?= =?iso-8859-1?Q?0g2aoRc6k6mnkhnLL/KzkyYL+sYoNbu9J9tP0tMPv6CdYUQbCqQdH4Qg5E?= =?iso-8859-1?Q?0YMKmQdaHK8TFvNhYbk++cqP2g+WnVmKhUG5/jPdwSUWmzSq3gWmzRlueR?= =?iso-8859-1?Q?B08kw+A9wMeUAJqwPk5746fmtIzyzMUBfKY+aQpIiQMQANLmCn1/rTCjEz?= =?iso-8859-1?Q?v1I5uChjE8Of1SG7B9erqwZxN7uM0Gj/1g4w27dHKo5vy8We7pRiqABVm3?= =?iso-8859-1?Q?j4Uz15iVS0sTCp6JR8gT/zro+Wpo03Dd3vFa3OiratNnn14lHgB+aHcZGX?= =?iso-8859-1?Q?oudET0z6Lbx/WmHSXBj1rj?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8460.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700018)(7053199007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?cJ7zKzkXVev56Ef+1AEvk4yk58hGD+OuQrvdgXRwdTttZkMWoE+FF+GwiW?= =?iso-8859-1?Q?DDS1MYQquVVTdho/qzpUBpAjiFG01zRAcFWy6wPlRf21QeO4vm7JoXr6SG?= =?iso-8859-1?Q?ERoI0DQ/ePy+VnagaqEkuCQPRpx5i9oZQ3ASklTDzq8iSzwo0T+d1f3t5+?= =?iso-8859-1?Q?/h0ZDz+Zxvh4OWPUlZfZVxGlCjZYfEEItmG2QTkxOdJzGMW/pAeuL+U5WP?= =?iso-8859-1?Q?yOVOg7tuSWo4Cs/Y5/MXc2qZMAkNS2IuPMwMoO353mS6Ta5ZVfcnf/C4KC?= =?iso-8859-1?Q?mFdGS5o57T1rK/I41L0lvrpl04rmMx5B0BJHbSlE+tLi81G18UaDBUedOq?= =?iso-8859-1?Q?B1WhEtViK1jiXqTOwKaWu/BWDJvAle3gAX6lAxs63wDBqrE98WmHE4i2Tk?= =?iso-8859-1?Q?xz2S1ziiUpjDoEn9hlIWIqo5/rTHxfmgVTlnNNkfJUNIdKM3uky+JNX/Uj?= =?iso-8859-1?Q?XbMSP2OacA31o8l+s8/bqL5hxyIjSdIlXWnTDptBdrZN+7cPPk94d2KPhe?= =?iso-8859-1?Q?Cd6k+Cl70kwIwXD+JapVamRzpftO4adkT0c25It0+A3OZ6mVVypCSsPz7j?= =?iso-8859-1?Q?o8W+myniqq6E9s4JLE3Bjk2c8Y1xfMQjkPPyanL4jUIz0NCKzijXVB5GE+?= =?iso-8859-1?Q?BrRDQqChZQfjyFkqHYSjqm6dQ8oPtQvwfdXvbTNiwBR/bDyhEIuuhAf3lt?= =?iso-8859-1?Q?qbqv8o1itfb5/eg63UHI+0ELX9+j+EFqJExfkWOMTQy7TkmxlMvVJBWeK4?= =?iso-8859-1?Q?mL6EFwIcehDbolTQK9EJS/mNTAHseVoqavW8iFtYH7afQY/AYhZ3gUwpvv?= =?iso-8859-1?Q?x4tqMi9qnuGyGozFp5sF8JI/lcY+Kfo5NMwX2Y7qEG4ow+LnNNtcKV1tAF?= =?iso-8859-1?Q?GxY3nUMWi3FEegV8WKwY/yqQ59/jENscn3Z/pK0zp0W2g8NPq/oUVxinFc?= =?iso-8859-1?Q?LBfHVAC7KjyBUpjSqi1Q/8RFe839lJLXyQ1RK0Gvaky2sPUv2/sXLe87Ql?= =?iso-8859-1?Q?q4j1rEzmbO3zGLc7MnZdda/QZRZ2C0sJVK/BiTp2Q6cBziBmVOFQUWHKV/?= =?iso-8859-1?Q?KRI05Cbg4yGXSbO+qQGsPPSyiH3LIrKZq0i/xvKG7Lk9Jw3bbBMKwVLire?= =?iso-8859-1?Q?3h7XQaaH/2Q2K+i9cv3rJbHALE0ZWojiKJLnHxx+TlC3ax8lop24u1eSZe?= =?iso-8859-1?Q?fbGok7O0dwyliW/lvyMgKTh/XpcjEHbYLIQldPXCJMzKveUrgyh9dYygRl?= =?iso-8859-1?Q?aKvzaEpDuvH6Bf02okFKfRxhRb2H+3SeG5K/lr92pWQcvcin7MR2Hq2/j4?= =?iso-8859-1?Q?+NM00MlrDLw/v2kXoJgS7gROtBUWL9MYrrE0b9dCJVBqT4MzmALz39vvUS?= =?iso-8859-1?Q?lOtqr4rIvWjSeITKGKfz113Hwi5mwYX+7J+TY5Ys9PtfIm9MPuIvaqdHgR?= =?iso-8859-1?Q?FuYUcJRpQnKuM4ksifmDr+oUjoAUh1RtkIuTRykCVSGeRcP8F30w23J2qO?= =?iso-8859-1?Q?czdI9JIhSn4dnIJbRZ9xZgiKRjIjF5k5hWZaUzCtUk4wfJaLVFqWuyvll4?= =?iso-8859-1?Q?AfZV5RC0ttJjdVPRKyee8uUnqFao9EaKlHHsheFd5QNGpCHarYj3ZRu3vd?= =?iso-8859-1?Q?xzXW2R8UhC9Z3OBVtnABXw7oA9aBhKZIH3?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8460.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 105ed854-fa65-4987-36d0-08dd39eb557a X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2025 07:15:07.0350 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: n1wh2Icx3MyWQ6Xwdb9DeIiMbjY9PkPGyshXB2fJMS97a8Ated1nU2Qa3J+CntDxty+jLPfSdbQBEFNfth4m7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5747 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi,=0A= From: Bing Zhao =0A= Sent: Tuesday, November 26, 2024 10:34 AM=0A= To: Dariusz Sosnowski; Slava Ovsiienko; dev@dpdk.org; Raslan Darawsheh=0A= Cc: Ori Kam; Suanming Mou; Matan Azrad; Maayan Kashani=0A= Subject: [PATCH v2] net/mlx5: fix the leak of action data list=0A= =0A= In the actions construction for HWS non-template API, the `masks`=0A= parameter is always set to NULL and all the actions will be=0A= translated in the "construct" stage as non-fixed ones.=0A= =0A= In the stage of translating actions template, the actions data would=0A= be allocated from the pool and managed in a list. The list would be=0A= released when destroying the template with the actions. In the NT2HWS=0A= implementation, the temporary template was freed directly and the=0A= actions will be destroyed with the flow rule deletion. No other rule=0A= would use this list anymore.=0A= =0A= The actions data in the list should be freed when the actions=0A= construction is done.=0A= =0A= Fixes: ff4064d5b1fe ("net/mlx5: support bulk actions in non-template flow")= =0A= Cc: mkashani@nvidia.com=0A= =0A= Signed-off-by: Bing Zhao =0A= Acked-by: Dariusz Sosnowski =0A= ---=0A= v2: update the commit log=0A= ---=0A= =0A= =0A= Patch applied to next-net-mlx,=0A= =0A= Kindest regards,=0A= Raslan Darawsheh=0A=