DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Robin Jarry" <rjarry@redhat.com>
To: "Ori Kam" <orika@nvidia.com>,
	"Thomas Monjalon" <thomas@monjalon.net>, <dev@dpdk.org>
Cc: "Ilya Maximets" <i.maximets@ovn.org>,
	"David Marchand" <david.marchand@redhat.com>,
	"Aaron Conole" <aconole@redhat.com>,
	"Eelco Chaudron" <echaudro@redhat.com>,
	"Kevin Traynor" <ktraynor@redhat.com>
Subject: rte-flow: unmatched ingress traffic default action
Date: Mon, 17 Oct 2022 16:48:42 +0200	[thread overview]
Message-ID: <CNOA4VLLOBM1.FTSDZQLGKWU5@marty> (raw)

Hi Ori, all,

From what I can read in the docs in the "Isolated Mode"[1] section:

> The general expectation for ingress traffic is that flow rules process
> it first; the remaining unmatched or pass-through traffic usually ends
> up in a queue (with or without RSS, locally or in some sub-device
> instance) depending on the global configuration settings of a port.

[1]: https://doc.dpdk.org/guides/prog_guide/rte_flow.html#flow-isolated-mode

Should I read "general expectation" as a simple recommendation or is it
a requirement from the RTE flow API?

I realize that this eventually will depend on each driver, firmware
and/or hardware. However, would it be reasonable to rely on such
a behaviour to implement preemptive queue redirection prior to regular
RSS?

For the sake of argument, let's say I have 3 RX queues configured with
an RSS redirection table set as follows:

    0 1 0 1 0 1 0 1 0 1 ..... 1 0 1

And I configure a single flow:

    struct rte_flow_error error;
    struct rte_flow *flow;

    flow = rte_flow_create(
        port_id,
        (const struct rte_flow_attr){ .ingress = 1 },
        (const struct rte_flow_item []) {
            {
                .type = RTE_FLOW_ITEM_TYPE_ETH,
                .spec = &(const struct rte_flow_item_eth){
                    .type = htons(0x1234),
                },
                .mask = &(const struct rte_flow_item_eth){
                    .type = htons(0xffff),
                },
            },
            { .type = RTE_FLOW_ITEM_TYPE_END },
        },
        (const struct rte_flow_action actions[]){
            {
                .type = RTE_FLOW_ACTION_TYPE_QUEUE,
                .conf = &(const struct rte_flow_action_queue) {
                    .index = 2,
                },
            },
            { .type = RTE_FLOW_ACTION_TYPE_END },
        },
        &error,
    );

Can I expect *all* ingress traffic *not* matching ether_type=0x1234 to
be redirected to queues 0 and 1 following the default RSS algorithm?

If folks from NIC vendors could comment on their own implementation, it
would be much appreciated.

Thanks in advance.

-- 
Robin Jarry
Principal Software Engineer
Red Hat


             reply	other threads:[~2022-10-17 14:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17 14:48 Robin Jarry [this message]
2022-10-18  7:41 ` Ori Kam
2022-10-18  8:12   ` Robin Jarry
2022-10-18  9:16     ` Ori Kam
2022-10-18  9:36       ` Robin Jarry
2022-10-18 10:11         ` Ori Kam
2022-10-18 11:51           ` Robin Jarry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CNOA4VLLOBM1.FTSDZQLGKWU5@marty \
    --to=rjarry@redhat.com \
    --cc=aconole@redhat.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=echaudro@redhat.com \
    --cc=i.maximets@ovn.org \
    --cc=ktraynor@redhat.com \
    --cc=orika@nvidia.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).