From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6407A0501; Tue, 17 May 2022 12:14:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 50DDA40042; Tue, 17 May 2022 12:14:54 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id A245C40041 for ; Tue, 17 May 2022 12:14:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652782492; x=1684318492; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=0lh4Bek+EI71EsiTUH3ZMkSD+d4a5Dm4iba99e08LbY=; b=EO38mUMoa9EUVW0DvTk2nsTzggqdQbFLEAy1urK63sx0iob+/myVdw/U tjVjFDoivFUUEcLba6wKMrBHumhS1hxwgwI+l67OET+8SFVDoTUhlLnnU u89LauE0qk05qpCQ/g4fxGbi+8BHpkxD/3JHzE+TW+h/AtobiKQGWjAPi fpTaENm1ZxkJw1y4DwB5BRFoUx8IAGTs6RbyKGA3R1z/XRmpXHcB1LDs2 WlItlcxnzAH5CSBGEoJdzgIvtvL1kQBGw0TXaonn7YRjZ+SA0DvX1NEee 1qRhNPmuAQHJ9tC32SX06uvJ93GaXDVDlm39yW/PXZgCvmB5l0OQD1S6P Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10349"; a="269958339" X-IronPort-AV: E=Sophos;i="5.91,232,1647327600"; d="scan'208";a="269958339" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2022 03:14:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,232,1647327600"; d="scan'208";a="660542364" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by FMSMGA003.fm.intel.com with ESMTP; 17 May 2022 03:14:51 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 17 May 2022 03:14:51 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 17 May 2022 03:14:51 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 17 May 2022 03:14:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pk59kXcfbgqkwcZc/x+XV+ZBAn1IzzZCvgRekO/y3qbaCqhGno+trnMLkFibS8+daUpJyQ2M3jlG42h8uKcMmlwIIN7HJpmDHy1qd9iiMdHBkV7g2rK5x8/FsuyUzF0YeNnm6CpkOZM2UbKlgzSni2ZTTxFz8AJ6lXiLdAQkKQe6pdlOsNe/r+wDc2G9oXpATOUF21mWkyunZMPrM8u+nk7aJkUQ+xKFYus27RbV/9NQgMHqjQcdeiZC6/3ALUREBIwTqvXJy1MWy5LkkjQilkSbuTfeNUP4h6twIS0gyCjZ8GvexXMzAnePtpGmdrJIIppVeL7w5CSWj3lVD+vcsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NUuUw7FW6BqXu9kaB4PF78Kdv3bYXfZN1lJ9+N5a1mc=; b=eesVXkR4XuZfXWuWuCB/4jktQ1+lMiYNa/0p9vN7q2JRu/gWvqCrMdZRJ3vKG7ZV/LphHDt1HaSQY4OKUw3AA7Dx8WIUvVrawMBn57BuLKty5lxwIzP+h36EFt9Y6m1Vth+R9Oi6ufBy9N2gjZwIJSGU0LD4C8bBGfJCMBW03aEgftl3uQn0p6mg73573macfKDkLuorfWpRXaLFo/VMvQQ2FY7ubHoJd3WwQHvtHBAwTz7er+3km7Er3NhPWeXIVd63IRAUduzhpwz1O8XSjjshvISOqT2b06oyhHQl3S5Xy/YoEzm9Ji7AWJROzONYYeMVaBG/usAeWz087CzXrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4897.namprd11.prod.outlook.com (2603:10b6:303:97::20) by DM4PR11MB5972.namprd11.prod.outlook.com (2603:10b6:8:5f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Tue, 17 May 2022 10:14:46 +0000 Received: from CO1PR11MB4897.namprd11.prod.outlook.com ([fe80::1045:18ba:7fd7:93c1]) by CO1PR11MB4897.namprd11.prod.outlook.com ([fe80::1045:18ba:7fd7:93c1%5]) with mapi id 15.20.5250.018; Tue, 17 May 2022 10:14:46 +0000 From: "Wang, YuanX" To: "Xia, Chenbo" , "maxime.coquelin@redhat.com" CC: "dev@dpdk.org" , "Hu, Jiayu" , "He, Xingguang" Subject: RE: [PATCH] examples/vhost: fix floating point exception when there is no VMDQ Thread-Topic: [PATCH] examples/vhost: fix floating point exception when there is no VMDQ Thread-Index: AQHYTYBEYXA9VYXuqEabO2AzbioH3a0hreKAgAFjvGA= Date: Tue, 17 May 2022 10:14:46 +0000 Message-ID: References: <20220411163451.572814-1-yuanx.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 90eaf57d-2633-40ca-45a3-08da37ee11ba x-ms-traffictypediagnostic: DM4PR11MB5972:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: s0saG78AbnYqwylNEkSKG/ujPyM91IydkP8avbi/r8zpFPBuVWFVq/Z9XlfaluevGfZNx51z4j4wsTa//KzA5Ma8PjCNO9KXIwwO8RygA2vD38OjB9G5p4smdPcZSola5cM7f9hIDOpTUCuMUfLiSxkcRIy3oUdo9G5lYyhmACyANyhlYFySnJ5KvAe2bRg4wLHCjv4NL2YguDejQyG2SmWwJGji0Ujl7wLyRnM+1BIGneDgm64Qy7ljL1nWD6b/w3QibJZ2ivKSX8peeL0I5UxzqKQIEBBsu0vJCX/J414KR+malfH2TudQh7WBGxv333c2f2+jnXQL7amWUDybNHF4RoXEbSgLzYTWdIndOR+D/1+YE05RCawrhv/yqWbLyaaagetwAvYfcjtgBJRKLLjROvanCLXNr81LKlTjnh+koGf1EdMNFXjVPGNpJUPq5D4ahpet9bZy+WbDNb/kKDG1/ILeZgsRaA6Y1jw9nDE/TGj4JPmDvcd9cFnmLVL3qYX8sqVQf9skB1Yjt4KbSkhzVdw07T4d0hOOP40H+KoLF01kLPLjVgXJ++kHbQBvYnfZAhtdxH/etnsW7T/Et/TezRyT69Vv1uspM7gohzKary5k5SlhULTritrkZNkRMs4smbI3Nh1/6aiZzYEt0KtdkkwBNtA2wQ1GogypcyhWGT3kZegy1geyyVKWgfCF/+VMy/1CCkkC/TfNnYf/GQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB4897.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(86362001)(38070700005)(107886003)(9686003)(5660300002)(8936002)(54906003)(110136005)(186003)(38100700002)(76116006)(71200400001)(508600001)(82960400001)(7696005)(53546011)(26005)(6506007)(52536014)(55016003)(2906002)(66476007)(66446008)(64756008)(66946007)(66556008)(8676002)(83380400001)(4326008)(122000001)(316002)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QX9Y2XLoCg8PsT+AlvzPZyGWYnZHtey4g3BdCViEb+ZVHe/JLiyEnjSCCTK7?= =?us-ascii?Q?v1FayKJDR+MR8yI6pyysqGPaSMpJkoX5SsBdq60NWzOw4KpDXeU3Y9NQJQtj?= =?us-ascii?Q?IjRKa8hvW7wSuVLA+/8lM++yJQFoG71TUiUcDL6BZu18QpR2Dwdmh4CLU5mb?= =?us-ascii?Q?d/RQTLCJL/eRPv7688iHsvF/t3dZv1+qOeF/dRm9CRAXnZKjqO/x+PEnApoH?= =?us-ascii?Q?EmWUaiolQ5wrli6i2xaSricc8dk9cceVMZ4MEkn0XMdlMDBODFF5C+jovtQY?= =?us-ascii?Q?UBVS38i0LyOWcubEXYWVVn4OYKNNvqGrVmgS5TUVs8R/5ftdswB/HXaemtPd?= =?us-ascii?Q?RWboEwMu3g0LK3Eq5NvFaShbE3swVouc37TuLXXe7JaTzLyKAEZbqoFalzN0?= =?us-ascii?Q?5p1F86ajxbuZbro6umTJhw0GDddwqL9MpKLamEYX/gl3UBhg9GcF1lwwyP5z?= =?us-ascii?Q?upCi33kW+IFNfN6UnaiSAhBgFXEM4OeFLCnDt+7jjnnSdqJHJFfFnq8+eoPy?= =?us-ascii?Q?wOFWd7bP8NcL2WTDpmzRbxOTPJoNaDb64snRwgTIEX8My90T8xSPy8nHItr3?= =?us-ascii?Q?8UJefBgm4KQLA8s7Pqpznjl8sC/wRFhULzOD1Sg//GLnKJE1EeI+M/j+rmTa?= =?us-ascii?Q?ru4+0eVn0OwVAB0oQN1EW2kOzp9PuvIk1N/C5Okn72TjQkjmEZvvVhMwxrBL?= =?us-ascii?Q?5RcWBXpuuxQcggMPknt26wRf4RIl9bseKHlJ0TXCv0cov9lfyGAoTcfDyv0S?= =?us-ascii?Q?3h7yauV5Pf+qGKw+rdUhg3NRhkitblRprIAWpkX4wEg6DY5spEy/JHJZWR8Z?= =?us-ascii?Q?iw96PVsUNYesLXa1vcP1XQTUccvXwjAmSLAzoZOjiU2NXrqYmsJDS4ggThwn?= =?us-ascii?Q?xJ9iSrRAj1wtZlJwrzfemYOsMiNwAqCCL0QV+YGpgzZ9vaiWMsHYeEDZ2SpK?= =?us-ascii?Q?S2IBWVYpuLvq+0iz3WNyDiE1bs3Zdm6napo3y3zbIJkkEcVj2pU+EgepvEpm?= =?us-ascii?Q?I2s9EByU6occ2EbCR4/hjZK5nQ59HN4E9NVf/FG/TRbj0EC31bg6/N7uNd+s?= =?us-ascii?Q?mHCrRHcfonJUMlN0XfCRB6AMUiTQPDeEH2OPpEOsr75M89bgy/DD6miV2Nkk?= =?us-ascii?Q?I+W1h67UMI2/eBzfYsP5a4FhPI/wXgNy4DklepzKNSlGhqFPPu4/vkRiZfnE?= =?us-ascii?Q?3o3yH/VDXrg0CtcUPpE+uVuvUNv9HhdWhd4wt/bsC5PCX+6TXiTahZbCoRe/?= =?us-ascii?Q?dAROo8W6MxoqJLGqrm6N4GIy2Jpxc0aaFv5khOjS6sE5cntp02qFKDVf6Iqh?= =?us-ascii?Q?1qaz3aeFAB1bz5JyVwsh0i8butXNrGjgk5qn4m4nTVALTL3SCft1wzvlaA83?= =?us-ascii?Q?jZ/bDu9w6uSJbXwqWGq1OoLGtX/gVAwIRgDYBszZn6AIMtN4jBT5z34tUpC5?= =?us-ascii?Q?D2dvrWtEaty5Bqa5tJVPV9+1ugCbvmKsTbuOkUVeq+hC2M2ZnIAHT9fUHvq3?= =?us-ascii?Q?MbsdM92e/VZGXg2kzvcw7tfpzpEb7Uv5uSrr67esDtR6UfsEal99urxnaaD9?= =?us-ascii?Q?5r1hL2YSfSUEDAF2cjeMLGHvfAq87Fcq0dWafoRke1kNIKsQ5ZfY6Jv31Yyf?= =?us-ascii?Q?XSKJmyoNspxhUjhkpnN4fhKRMhSKpaUvnQtF3n/Vd6cbL1UkRzYtW3cEgL4S?= =?us-ascii?Q?rpB2YsmMUbpKOmsUN3H2jGF5jeI8ftEB0b8crXbfBDk5P0hShAiqahXuMURK?= =?us-ascii?Q?b3sHjNtnDg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4897.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90eaf57d-2633-40ca-45a3-08da37ee11ba X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2022 10:14:46.5040 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xLY8Hy5CPgUBaA/f+jLEJo0bDhd4wgbutlLYzXslwU7Fwy6p4PTJBnVx/eQzgWqrsyCxt/CwlWoQGZRYQlZDAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5972 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo, > -----Original Message----- > From: Xia, Chenbo > Sent: Monday, May 16, 2022 8:57 PM > To: Wang, YuanX ; maxime.coquelin@redhat.com > Cc: dev@dpdk.org; Hu, Jiayu ; He, Xingguang > > Subject: RE: [PATCH] examples/vhost: fix floating point exception when > there is no VMDQ >=20 > Hi Yuan, >=20 > > -----Original Message----- > > From: Wang, YuanX > > Sent: Tuesday, April 12, 2022 12:35 AM > > To: maxime.coquelin@redhat.com; Xia, Chenbo > > Cc: dev@dpdk.org; Hu, Jiayu ; He, Xingguang > > ; Wang, YuanX > > Subject: [PATCH] examples/vhost: fix floating point exception when > > there is no VMDQ >=20 > Based on the error reported by devtools/check-git-log.sh >=20 > Title better be: examples/vhost: fix floating point exception when no VMD= q >=20 > > > > If the VMDQ limits is 0, a divide-by-zero error occurs. > > This patch replaces throwing a floating point exception with a normal > > error message. >=20 > Pls add fix and cc-stable tag. Thanks for the comments, will fix it in next version. Regards, Yuan >=20 > Thanks, > Chenbo >=20 > > > > Signed-off-by: Yuan Wang > > --- > > examples/vhost/main.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/examples/vhost/main.c b/examples/vhost/main.c index > > d94fabb060..815ac1cd57 100644 > > --- a/examples/vhost/main.c > > +++ b/examples/vhost/main.c > > @@ -400,6 +400,10 @@ port_init(uint16_t port) > > > > return retval; > > } > > + if (dev_info.max_vmdq_pools =3D=3D 0) { > > + RTE_LOG(ERR, VHOST_PORT, "Failed to get VMDQ info.\n"); > > + return -1; > > + } > > > > rxconf =3D &dev_info.default_rxconf; > > txconf =3D &dev_info.default_txconf; > > -- > > 2.25.1