From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 79FD2A00C3;
	Mon,  1 Aug 2022 09:09:07 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 71C8E41101;
	Mon,  1 Aug 2022 09:09:07 +0200 (CEST)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by mails.dpdk.org (Postfix) with ESMTP id F2F5B4067B
 for <dev@dpdk.org>; Mon,  1 Aug 2022 09:09:05 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
 d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
 t=1659337746; x=1690873746;
 h=from:to:cc:subject:date:message-id:references:
 in-reply-to:content-transfer-encoding:mime-version;
 bh=KPvI7A/x0/MtTY0SW0N9cAQQtp0moZ2DYzoOPtKcPEw=;
 b=I1jQHem6OX2L0VIYDbWu31y13TEUeCPhcnd2EYY+MOixWLuJ3240ibp1
 0knKjJtEl0FVCf+5S2ZS6gN56THce6dfgVOhv4DxMOlUGvr8nXHarM2+C
 /afceDzbKLY6HIKXMnDuKf1bF1h2rCVxikmIBoWcXH4WIqi3l+KtkQy8w
 9QA5gzBWVUmrQvhZawxaJCYxY5PNuIrfyWey1UWjtI8Sqnwu6Th1SR11n
 QQ4n1DETDzQrKvIH5wsbK6buAVXmz3Nhbo0jzwWb2dgbsNUwb6d99+upf
 p5ppZJvEX7c+AlLUwaR2Jm1Lo+XAoFRdzQoh25UGanLj0wCXa2MUvb3vT g==;
X-IronPort-AV: E=McAfee;i="6400,9594,10425"; a="314902047"
X-IronPort-AV: E=Sophos;i="5.93,206,1654585200"; d="scan'208";a="314902047"
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
 by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 01 Aug 2022 00:09:04 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.93,206,1654585200"; d="scan'208";a="605570017"
Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18])
 by fmsmga007.fm.intel.com with ESMTP; 01 Aug 2022 00:09:04 -0700
Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by
 ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.28; Mon, 1 Aug 2022 00:09:04 -0700
Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by
 ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.28; Mon, 1 Aug 2022 00:09:03 -0700
Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by
 orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.28 via Frontend Transport; Mon, 1 Aug 2022 00:09:03 -0700
Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106)
 by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2375.28; Mon, 1 Aug 2022 00:09:03 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DE4y86CN3b3D8XGXeB7IOBudeXXfejlEwWu0LI7cRnIRELhbeOfJx8tLhG+hAjYdohYeh4zsV8TGi/lvSE/bVhb9arYhZYIK1sszVFYgJOpQoa5WFRtgWCkl7Kx06qGedzZYKZXAqMJor7wogrvCvst2cu43vvwMKfAtjSs+pb/xPczhfPYJBLQMeRM+8Ay1H1DRhszAkaqXqFd2rOyyxczNVypMhpcRZIPqMK3iYrYMVOOGMW6TIij81afZVZ8vhQwHGFy/nqpcMUi5WxHejNjReVXteNaw38lzC8k4ryDB4zp/QKV4Kj9GgYjX9kGP7MZq6pGVnXOZdq8llJ3aJA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gyLYckF9BScBJw/zpKfJvldURNgdwNIe9SoNFRx4ZVw=;
 b=HJfP2hwx7lOy5SPr+OJtsyQ7fxiD0Vlki023eXXurZt3sOlgVauFVFvX8KZOXS4bRIs/26N7XdQSAvVSdSu6vQGfu3jLq30hdLf00/wRoUEoMM0yyYjh7+2e7g5TiJdQLBipw5pmzjvpcR4r7fuW+W4QY2wVsDeNgOWbJ67yWgTcRPR4zVGo3Gy4GPTnmPcfKDIs0n0qkcosvGjcfiHomtNNH43lgUuUfEGBGgjJCJ6V5t1fsNgicSNLJHN33ek4acrkUhSQ1qcHMlnWrTndm2D5/QHU7GlUyJ7GVVcnzG/TS+xnjfesd3rOrVjbj72f2bKyVnqgAmkI3i9Nr50V5w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
Received: from CO1PR11MB4897.namprd11.prod.outlook.com (2603:10b6:303:97::20)
 by BL3PR11MB5713.namprd11.prod.outlook.com (2603:10b6:208:350::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.11; Mon, 1 Aug
 2022 07:09:02 +0000
Received: from CO1PR11MB4897.namprd11.prod.outlook.com
 ([fe80::ad09:b3ab:f943:3217]) by CO1PR11MB4897.namprd11.prod.outlook.com
 ([fe80::ad09:b3ab:f943:3217%2]) with mapi id 15.20.5482.016; Mon, 1 Aug 2022
 07:09:02 +0000
From: "Wang, YuanX" <yuanx.wang@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
CC: "andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>, "Li,
 Xiaoyun" <xiaoyun.li@intel.com>, "ferruh.yigit@xilinx.com"
 <ferruh.yigit@xilinx.com>, "Singh, Aman Deep" <aman.deep.singh@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>, "Zhang, Yuying" <yuying.zhang@intel.com>,
 "Zhang, Qi Z" <qi.z.zhang@intel.com>, "jerinjacobk@gmail.com"
 <jerinjacobk@gmail.com>, "stephen@networkplumber.org"
 <stephen@networkplumber.org>, "Wu, WenxuanX" <wenxuanx.wu@intel.com>, "Ding,
 Xuan" <xuan.ding@intel.com>
Subject: RE: [PATCH v9 1/4] ethdev: introduce protocol header API
Thread-Topic: [PATCH v9 1/4] ethdev: introduce protocol header API
Thread-Index: AQHYfxNApzOFJ40kK0OZCzZ1KpTcxK1ywyyAgCJ+JjA=
Date: Mon, 1 Aug 2022 07:09:02 +0000
Message-ID: <CO1PR11MB4897FFD3AA4F75AF11FE8285859A9@CO1PR11MB4897.namprd11.prod.outlook.com>
References: <20220303060136.36427-1-xuan.ding@intel.com>
 <20220613102550.241759-1-wenxuanx.wu@intel.com>
 <20220613102550.241759-2-wenxuanx.wu@intel.com> <3684735.UjfFaoq8vQ@thomas>
In-Reply-To: <3684735.UjfFaoq8vQ@thomas>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 6700d377-8f3e-4dcd-3f7d-08da738cb684
x-ms-traffictypediagnostic: BL3PR11MB5713:EE_
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: iCEWDfAU8W0CEJSqCLUn8hPhrqr225bFFXBxgymw1S+iaHpVtxXiVgnzRBIZ1asqgrig6BMsZmMp0kvnzaZ3K8BPtnqrTdJD+wTB9QS2wVDGAf8QEEr+SP+bEh1Y3vOMVeARybNVPYLvTTSOkKwShbXVB7nkLeZFQU9JKxgjV7q4geH13qMiV/5MaX5blDVvREZ3wGE0lL1bA0VcLcpTKcCtU+eJpsmBuyJwHn6ZRauN6lVl0lS2dK+leByikYJFeb4cVsp0cLt6ST3Fls9zyo4wE9vOPOn2jqfbakttxwBuh/4KswS9EZSmOVSaLbh8RlQUScMgZtDwCKNhdTbOc+3zOdTCMjipFIWN5g65RSBaI3Pc7T+RRRSrMBrJYgW46nSR22ZXH6NCGRZbrTl6RtVnPV0Juslytnxyw+GvHUj5GlGNnQi7fDIMNTEkqLg9m8nw4yDKdRzFQkyxV7pGqJgXwjvZBkXxrVm6c937jZIL2d/K3uhbGy8p76+zj+vZsSxQ6MuqPwalUPW4zQpqM/+79mabFLtLEduxMlxS8Z0HwAXajhz+Lb95qQq+gv/ckiTSKl9EFaN3OoZzzSA98wH5H/WQd+NTw/HVCEaRL0sD6rpkS2eNzQtZGUZzsQZM7m2ZdgRZ4/vefSMqsbk+eiR2TBLFHUPUYRb2nDpG4z13xJ/5XUcDEKVnsNfpWf8sDKaEITnQqcxw5USCG75MJ880mybwMCYHvf7vV4HJXj8SSTRYLwWT5I5psCsFiBP7hBo3zsPwjFV0zKDo+uBZ+oMte5jrWMymNYlfIjTyT1is0QHQe6kFFizEAXzdllc/
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:CO1PR11MB4897.namprd11.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(13230016)(39860400002)(136003)(396003)(376002)(346002)(366004)(38070700005)(107886003)(26005)(9686003)(186003)(82960400001)(83380400001)(122000001)(38100700002)(5660300002)(52536014)(8936002)(55016003)(2906002)(478600001)(71200400001)(7696005)(6506007)(8676002)(4326008)(53546011)(41300700001)(66446008)(66476007)(76116006)(66556008)(86362001)(64756008)(6916009)(66946007)(54906003)(316002)(33656002);
 DIR:OUT; SFP:1102; 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9YYG+4GQwCBmoeYVhmnS0gpAx8zmAPcDiLasNF7VXtWDY9BqjrFzURIus/Ne?=
 =?us-ascii?Q?bgzFm5SBqQ2mEu+H8J8BxZNfFGsuzAogGCzql/4E43e2VRQ0V53l8UECsJP1?=
 =?us-ascii?Q?pAyM/WcmVHSmW0UoeSuYSLZgov7Hd6jmf/CYYhG+QahzxegZCn6a2i89k6Bn?=
 =?us-ascii?Q?j4T6/MkYObOj3AoYe2WWzY9PdcFVPUU1lTidmCq2MV2bUk9WvYpm3vtcZWN+?=
 =?us-ascii?Q?tEqb5i6FMh5HUGnFtbs4OSEbF2UJ+BnUtGSI+JSJYNiI60jaLevY2TWWFoRQ?=
 =?us-ascii?Q?aBsPB+iTYZIfBnl6sTbka6Nfk6DWJQn3mF+MC7PMU4w8UQEemu50zFVx5VF3?=
 =?us-ascii?Q?EagU0Xat8nzSPXZGU+YRn38mPDjgcYuwrA35jZ8K1tKuLTSs4p07MOu9PRzi?=
 =?us-ascii?Q?fL9U4tHN1vqg6SLOQBOZyMBntUE2+HA/MW6/k12SW4t7lWBfbmxfzlkSLLbY?=
 =?us-ascii?Q?MalTFtgDksbhhqP/wrrU+mGZKu2t3leMUEi6HTZwmYVH82iBmOH9zPBUTWc8?=
 =?us-ascii?Q?vrs5/c2pGr0+w+i7T1JoJ1z7Xp9R2pAxdKjW7/bgbsOaUZ9Plfj9iKZ8n0xy?=
 =?us-ascii?Q?zt5SmLIWpLV7xedbat8F9qSGqchEYdM4W0gktXQq3GCmnqVNAVcK8haNMx/c?=
 =?us-ascii?Q?VSAwRkE8gnsXtUIm37hxABFW5S44nsccpXt2fHsCCiDPDg6UQxJWCKPrLJtn?=
 =?us-ascii?Q?PwZLUnSUiMao6oNjW/0UMO72Lj1kwCTfah2YQsI5cjAed7YfuiWag6dOt7Jz?=
 =?us-ascii?Q?Z810rNS/XVyusbEBzEYqQY+J7mc4fW/wCLYnnRctq5X/eGAn8zRTC7qurNWv?=
 =?us-ascii?Q?slxkBRMZI+Bv5XMoomyarbqAeGMtRAFu1OHLkT6vCKBtuu6HrCnGgsdRpMov?=
 =?us-ascii?Q?97Yk607dZp0vKY/oFYFjIaz3MhNOGym2yTZPsCIseT2ftmnBurEFbtT7IxgY?=
 =?us-ascii?Q?GBQP8eLcuwAr+HcXlTY3+S0MDnTJoc6LAqkEfU+OGSOHNXSsPkLaL0Rdqdwj?=
 =?us-ascii?Q?Nvm1rPMWfZL84UEYTQYhu0XP0yWPD29vi3Ped9os1t9LsiUDZ4zKXnlaJIfI?=
 =?us-ascii?Q?LfZoP6yslfjl1zKrx3XlacdWA1otnModdMcTnG6433CKIVHLzs3n3zhX9fFw?=
 =?us-ascii?Q?6k5XUkJlXBYGqTrQI15IQIX+S8E/VP0ahTVWDNpQl2jyKSh3dy32q+Hv6Y1i?=
 =?us-ascii?Q?Ydc7x9p7cZGjDOE9ZIUzlKsT/zfTNTvDHvAqvIlbH9Gbx51N2HDf1OmtVi0T?=
 =?us-ascii?Q?zkJQU+sDgF4AwnD+g0eGPrqJu9DwbmsPZ1yEpJ/WUJ/I+qd30dOCetcQoPqF?=
 =?us-ascii?Q?As5VnHuu15QANbhygvE3UZz2OOPYfgZAdNRo1XGymto5bIRojB0sBLdImaF5?=
 =?us-ascii?Q?wL4NB8e7tV3Dv4GuuVwbsbr3y6lPQ5hsyv/9QHtybAqOmxMpPqgwN4jVUZKG?=
 =?us-ascii?Q?ZTbw22i5+fUnatYA9wOw5Xo3w5lnq5nJ4Rauac/nnTQGn9yojtnAe5wO7PRB?=
 =?us-ascii?Q?HbIACHFeHej0nfAPApOm/6bUdG/dpRNGKxnftQp5IaVw9RGqkarH7Ql6351c?=
 =?us-ascii?Q?1nEh6MkDQIZRAL6PHNV9bWu/ZRXbV8b3ogpHVwve?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4897.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6700d377-8f3e-4dcd-3f7d-08da738cb684
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Aug 2022 07:09:02.0770 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uHCbp++d4vzLp82675PavSe26VuvFRAOQl0yeynOjzDFLcw1Q5/LEcSbkw/AAi9j/EhiF8Nl2lXhJqDojylwWw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB5713
X-OriginatorOrg: intel.com
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi Thomas,

Sorry so long to response your email.

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Thursday, July 7, 2022 5:05 PM
> To: Wu, WenxuanX <wenxuanx.wu@intel.com>
> Cc: andrew.rybchenko@oktetlabs.ru; Li, Xiaoyun <xiaoyun.li@intel.com>;
> ferruh.yigit@xilinx.com; Singh, Aman Deep <aman.deep.singh@intel.com>;
> dev@dpdk.org; Zhang, Yuying <yuying.zhang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; jerinjacobk@gmail.com;
> stephen@networkplumber.org
> Subject: Re: [PATCH v9 1/4] ethdev: introduce protocol header API
>=20
> 13/06/2022 12:25, wenxuanx.wu@intel.com:
> > From: Wenxuan Wu <wenxuanx.wu@intel.com>
> >
> > This patch added new ethdev API to retrieve supported protocol header
> > mask of a PMD, which helps to configure protocol header based buffer sp=
lit.
> >
> > Signed-off-by: Wenxuan Wu <wenxuanx.wu@intel.com>
> > ---
> > +/**
> > + * @warning
> > + * @b EXPERIMENTAL: this API may change without prior notice
> > + *
> > + * Get supported header protocols to split supported by PMD.
> > + * The API will return error if the device is not valid.
> > + *
> > + * @param port_id
> > + *   The port identifier of the device.
> > + * @param ptype
> > + *   Supported protocol headers of driver.
>=20
> It doesn't say where to find the types.
> Please give the prefix.

Sorry I didn't catch your point, are you referring the ptype should be comp=
osed of RTE_PTYPE_*?
Could you explain it in more detail?

>=20
> > + * @return
> > + *   - (-ENOTSUP) if header protocol is not supported by device.
> > + *   - (-ENODEV) if *port_id* invalid.
> > + *   - (-EIO) if device is removed.
> > + *   - (0) on success.
> > + */
> > +__rte_experimental
> > +int rte_eth_supported_hdrs_get(uint16_t port_id,
> > +		uint32_t *ptype);
>=20
> The function name is not precise enough.
> There should be the word "split" in its name.

Thanks for the suggestion, it will be revised in the next version.

Thanks,
Yuan
>=20