From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C365A09D3; Thu, 12 Nov 2020 16:55:48 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5F371592C; Thu, 12 Nov 2020 16:55:46 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id C170D56A3 for ; Thu, 12 Nov 2020 16:55:43 +0100 (CET) IronPort-SDR: /TGIwN4sy8NhjbryK6CoKXi9plO1YrSdh6V5H4HN00aCrKrdSwfKjlLWynkkT1W4o7sJXUl62h nVpJwXWmFr/A== X-IronPort-AV: E=McAfee;i="6000,8403,9803"; a="231949317" X-IronPort-AV: E=Sophos;i="5.77,472,1596524400"; d="scan'208";a="231949317" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2020 07:55:35 -0800 IronPort-SDR: 8J45nREJZByjEgWJN9egRSE4lrhtYFngABsEODIhgwl1mgM2OC9VdpCu3FqM4865YUDQhwHgcc 1Gr20M/eW9/w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,472,1596524400"; d="scan'208";a="328535969" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga006.jf.intel.com with ESMTP; 12 Nov 2020 07:55:35 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 12 Nov 2020 07:55:35 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 12 Nov 2020 07:55:34 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 12 Nov 2020 07:55:34 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.45) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 12 Nov 2020 07:55:34 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YoaWGnhUyuMtd+xMjlMnRpTuFYTO8XRGvZKjzx5/+6KsNmu2fqirn6SxxRiLePLVpEcK5w3nxGOQjuuk3E/2RZhhbE6zMw8i/HojVxJ2Tvd7lpV1QHkAFuPk03noAM2iVqPO59Mabe3fM9Zi6+Z8a3YuRM4rZaiZ/t7d/5eFX7dktDOWrslkzpO85HBflvNW8FUZADSSbPeZsgZarssWagygnsEERh+D/rJBjtAE61P7Rpa0LHSg8CheL9jmY36psZQcyisp/mUDMfTXu2Uvcix069l6opMMD7sd2bSAHGcQNy3Z5sidOX2thwZUI/tBG0L747yJNVMK9j8awA1r3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q90LV1HdZ8XiSSDFxnffpV3jgjozKDYj0aDDG4oprM8=; b=mdnT27kF0igNrPKvsrUKmZg4DX0WgIm5Lvh+jWhmHOjen7my5Jyvxm+qm4YCijd3NFXTt1H+beCKbw39ST/nkFBs97dwDHlLfOX1dzbQ48oLy630wJyH3Hu6geqEfEGXjV1BiDNNM+1wKdKvdmBDXC16g5sJQrAwT3cbWbPVJQeUOcpZ2/V9fUw9qcjlva3oi5flU9OS9BZ2GRzoH95GGalc/PKNvHOLzfEMlkenooFyXhbAPi483Cm96/oeGafKo4rHUg5S/beeg3jxD/2ig21DwrqDUSM+A1ieNQwzXeYdfWvJBuJDMWOEz0a9HLM9hauVfixMNIqJaTzWH0BpWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q90LV1HdZ8XiSSDFxnffpV3jgjozKDYj0aDDG4oprM8=; b=pVhA31z88el6dJ2pCIWeLn/cD9MOWtGo9Pv1oyI/2XUijgFnORZqOGfXB6jWvNUVCZvNwGC30PuSH/WB+WUHM7w2XTIQb7bhvh0yWtjQ+0ODq2g39fhjIqgU6j/H8ea57NBmeA2KcvCR4lGIywtB22JPsQC+StH6zcBfp90JVBU= Received: from CO1PR11MB4995.namprd11.prod.outlook.com (2603:10b6:303:9f::22) by MWHPR1101MB2238.namprd11.prod.outlook.com (2603:10b6:301:55::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.25; Thu, 12 Nov 2020 15:55:31 +0000 Received: from CO1PR11MB4995.namprd11.prod.outlook.com ([fe80::9ce:5879:9fa:d96c]) by CO1PR11MB4995.namprd11.prod.outlook.com ([fe80::9ce:5879:9fa:d96c%6]) with mapi id 15.20.3541.025; Thu, 12 Nov 2020 15:55:31 +0000 From: "Jiang, Cheng1" To: "Richardson, Bruce" CC: "maxime.coquelin@redhat.com" , "Xia, Chenbo" , "dev@dpdk.org" , "Fu, Patrick" , "Yang, YvonneX" , "david.marchand@redhat.com" , "Hu, Jiayu" Thread-Topic: [PATCH v4] examples/vhost: fix ioat dependency issue Thread-Index: AQHWuPuwPzBcuexRj0SaQxec/Z31BanEl3WAgAAOqTA= Date: Thu, 12 Nov 2020 15:55:31 +0000 Message-ID: References: <20201111111957.46090-1-Cheng1.jiang@intel.com> <20201112134754.96530-1-Cheng1.jiang@intel.com> <20201112150135.GK1309@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20201112150135.GK1309@bricha3-MOBL.ger.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5e3c6c66-4fe1-4156-3b4e-08d887236240 x-ms-traffictypediagnostic: MWHPR1101MB2238: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1728; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: L8rmGMboCKTTXK0wZKfzygUZqXmpdVq6ajWF9dV4HUuBJTFI8NFbvho7eCuLV4jyFRtIHOjQbB5iKhIcvhhZEdligBKspBJuB0l/G09D4vmJhGGd5FsGUd69LMZ7YBAOeT8LJ5ePk8+V4W+XiS3H3oi+ak0OIHX8BTGVfyhWW9Aib7xBPJSyjKXOAoV4msclnuHXSmneg0h846hWhHgswG4/UCSkeqw/P9aHRRSJaNHWSnGCpehajIf6Ofazh6vuBJphM1bLQSx7WYsAkyyGFSZjYrKa14aSECc7Mjy5b3uxTrCs7M2xOVNVw065ithtTx/KwMZ0NTVkbHujZTLGFQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB4995.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(376002)(346002)(396003)(39860400002)(66946007)(33656002)(76116006)(9686003)(66446008)(6636002)(53546011)(478600001)(64756008)(8676002)(54906003)(86362001)(66556008)(4326008)(7696005)(316002)(5660300002)(52536014)(55016002)(8936002)(186003)(26005)(6862004)(66476007)(83380400001)(2906002)(71200400001)(107886003)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: ALzPlhkjctRxb6gesFrN2BYFLHjwQqQnrXvFAf/Q83IOAm2azDBsqV7ENyGTv6jwp1AudTLxga0+Uurq67lUbMlNUAVMr/VAARkXLzhzwfggDaxWCY4J0rWaXmXjchrk5uQ9FYq4skfbQlLCciMsl1MbyEny5KSFWPkwtS1rIUUcmKiG6VSBYTG784yQ3fp3HQokefdyo66tXN0KVFiMt7VFRRHs0+RjgGJX1dU/MkdxuPbVWDwEZgUM5pmj3IYeVPXQ9ytOxBd/u1Q1PR/pOdYWEZrkz2MtwUwnJBAQjhsMMhI4xZgxgDt7uz3jyUtxGzPyB4mJzW98cgZaHAtsP5b/vnnDKCfXqwm7Xwlv4QxZtB8NHV+IWHvIdjaZH4znhNZDSJuJ0PTKgngdNX8JMLV8NzeIRUYTaJkHG9OSVkQ1RhAnp+ba87cmigcPbI6R7zeW4N0cI80K50TnH8+MMiyWFqlNaYuch6/FRkWmUjWNImPpVLWwuSZb6myHSzol9FWIri24W5gPspJ9TVl7hTnSwSeBP6kZV2NftFBk2kCP24O82ZcqZCWurEJSvHoPAvHncI5jinG14l5EBIhD5XtOe8KP0RdBSdFniyWW3mv4c9V3u5dxzowwWDMyIFuCNNrjuNnHl5A/yWSSOV+KBSKDZ+Ddt1fJku2f8VI/ra349J2PkZVQCQ82HQ5q/1RywKngF0bMmaCI6XzbhE6jjlOkWJP7qN9gmcnS8wlUhCRL3LruVXR9UbObl3csrxfZ1mSXBR4A4B5BV0j9Iqi6Z3OJazCkX9jesZZgHrD/2IXr8S4Fx2j0THXvjbwXVH03rSJW9hzDerQLqkWsCV4A7fakpw5KOKRVM9w44N/rcy2w4RxX8dLJY04yGuPTnx/qYE2eI/bH2A0jkdKMUhBLsQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4995.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e3c6c66-4fe1-4156-3b4e-08d887236240 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Nov 2020 15:55:31.2925 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9vIUqpD4yFN0L5pFG72G5D3kxfpWFsB5gqt2seH8Wulivv8lUH9WUwdeUGytKmbkP2Gk525yYq+tVb001iYfag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2238 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4] examples/vhost: fix ioat dependency issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Bruce Richardson > Sent: Thursday, November 12, 2020 11:02 PM > To: Jiang, Cheng1 > Cc: maxime.coquelin@redhat.com; Xia, Chenbo ; > dev@dpdk.org; Fu, Patrick ; Yang, YvonneX > ; david.marchand@redhat.com; Hu, Jiayu > > Subject: Re: [PATCH v4] examples/vhost: fix ioat dependency issue >=20 > On Thu, Nov 12, 2020 at 01:47:54PM +0000, Cheng Jiang wrote: > > Fix vhost-switch compiling issue when ioat dependency is missing. > > Change 'RTE_x86' check into 'RTE_RAW_IOAT' check in meson build file. > > Use 'RTE_RAW_IOAT' to control conditional compiling in source file. > > Clean some codes. > > > > Fixes: abec60e7115d ("examples/vhost: support vhost async data path") > > Fixes: 3a04ecb21420 ("examples/vhost: add async vhost args parsing") > > > > Signed-off-by: Cheng Jiang > > --- > > v4: > > * Use macros in ioat.c for conditional compilation instead of changing > Makefile. > > > > v3: > > * Added fixes lines in commit log. > > > > v2: > > * Cleaned some codes > > * Changed RTE_RAW_IOAT check method in Makefile > > * Added ioat function definition when RTE_RAW_IOAT is missing > > > > examples/vhost/Makefile | 2 +- > > examples/vhost/ioat.c | 6 ++++++ > > examples/vhost/ioat.h | 32 +++++++++++++++++++++++++------- > > examples/vhost/main.c | 22 +++++++++++----------- > > examples/vhost/meson.build | 2 +- > > 5 files changed, 44 insertions(+), 20 deletions(-) > > > > diff --git a/examples/vhost/Makefile b/examples/vhost/Makefile index > > cec59d0e0..8c969caaa 100644 > > --- a/examples/vhost/Makefile > > +++ b/examples/vhost/Makefile > > @@ -5,7 +5,7 @@ > > APP =3D vhost-switch > > > > # all source are stored in SRCS-y > > -SRCS-y :=3D main.c virtio_net.c > > +SRCS-y :=3D main.c virtio_net.c ioat.c > > > > # Build using pkg-config variables if possible ifneq ($(shell > > pkg-config --exists libdpdk && echo 0),0) diff --git > > a/examples/vhost/ioat.c b/examples/vhost/ioat.c index > > b2c74f653..6f87d7bba 100644 > > --- a/examples/vhost/ioat.c > > +++ b/examples/vhost/ioat.c > > @@ -1,13 +1,17 @@ > > /* SPDX-License-Identifier: BSD-3-Clause > > * Copyright(c) 2010-2020 Intel Corporation > > */ > > +#ifdef RTE_RAW_IOAT > > #include > > #include > > +#endif /* RTE_RAW_IOAT */ > > #include > > > > #include "ioat.h" > > #include "main.h" > > > > +#ifdef RTE_RAW_IOAT > > + >=20 > Minor nit is that we generally include system header files before DPDK > headers. Following that policy, we can move sys/uio.h up to be before the > first #ifdef, and then we can just merge the two #ifdefs together to just= have > one at the start and one at the end. >=20 > Acked-by: Bruce Richardson Sure, fixed in the next version, thanks a lot. Cheng