From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13781A09D3; Thu, 12 Nov 2020 12:30:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 786A85928; Thu, 12 Nov 2020 12:30:11 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 9D5F7493D for ; Thu, 12 Nov 2020 12:30:05 +0100 (CET) IronPort-SDR: UGjuOiNNeJIBFytHnnGTKAbS10olDmL55Zh+Sc1uinhX8D+RDjth69HNjiM2g8+0JuFCMBrTxA gL0NxhgfRpOg== X-IronPort-AV: E=McAfee;i="6000,8403,9802"; a="166787083" X-IronPort-AV: E=Sophos;i="5.77,471,1596524400"; d="scan'208";a="166787083" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2020 03:30:03 -0800 IronPort-SDR: zdsnge0LhFRLYdJNfyKvuWf0EhA9GWpmIRsoBaOzn8AiN/Oy1iKUomjmDbRPmGmU1W+8TSAvvT /4mMyxr3Y7bQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,471,1596524400"; d="scan'208";a="530641507" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga006.fm.intel.com with ESMTP; 12 Nov 2020 03:30:03 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 12 Nov 2020 03:30:03 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 12 Nov 2020 03:30:03 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 12 Nov 2020 03:30:02 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZMLvWXL2R+ZYTI5KXkYUnhbP7VzzfNSrXmJxAqCVJuYCGaQPdf3Ywuxll9KnACJ+dfpBFeivfHirfbmd657l06V0z5yIpOtP16YDCQ1UXZow60FXrhSpn3M/tL2BElQT99a8YslWA1QcHa1J+IeQFxGSR6U3EtGggFXIvW8F86ZAwwNMHYrx2STBlbgiJjI4CQT0oUSelDK8gJe/5yaylreQWph27sDZheisfumJr0K5tLnvw7nbSH6oaR5e6KEpt2W2/IVoGwnFqjs4DHpv4/hGGaOqxAe2bFlCxId7yunSSPw+si9a7Y6wa/sXMvUnAsTNDgkc1Om6KI5AgTmt+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=32wPoHKkX45H7kvjZToWj16F3t43Cb9AG0vuXEm/Qz8=; b=C9RmJJ63xIICXkTWWTb12/9iU4EmWf20UP1AglTA8eSU+Q2exYCi8lh6ZF0roqBtPvO52UTkpCLMDnZSrDK4AjUIqL3Nk9obG4ncjhlxQz4QEqv9jrA5Gmd1wbYQXk/iqZIEVTlhq1xRE2+KXTjkMpkWSDOJpETxU/MqgEkTx6PNsm/GAGVs1csYu9/RMM74NBXfQ3tiZvDUKrIjYWmfDl5ykF3VSwIurbhs2KNbqxNDWE6jvnp1sBIFrBhm7L4L9httpbUPH0ApHxtIFKVaNo0M2J4Ad8zGZCcnJ72W20jPz6LJlWcJ9oQG7FOgIdI0aHFXX1aT3Owt3Fjmj+pfHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=32wPoHKkX45H7kvjZToWj16F3t43Cb9AG0vuXEm/Qz8=; b=fDfnrASz4greflaIutGGmOOaSZx4My6huDi2lbwTOEVMmiIZt6BYS3pPl2jI42XAikv/0eMDf0WvXQ/wYAh5kGeqHLW81bdFjjcE0hCR1z1B3rIzCyZrmZfJUvQG44ZQi5TFJCZMNfPVHkFE7E58rGLvkGyx3RXvfWokGVd6tJw= Received: from CO1PR11MB4995.namprd11.prod.outlook.com (2603:10b6:303:9f::22) by MWHPR1101MB2111.namprd11.prod.outlook.com (2603:10b6:301:4d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.24; Thu, 12 Nov 2020 11:29:57 +0000 Received: from CO1PR11MB4995.namprd11.prod.outlook.com ([fe80::9ce:5879:9fa:d96c]) by CO1PR11MB4995.namprd11.prod.outlook.com ([fe80::9ce:5879:9fa:d96c%6]) with mapi id 15.20.3541.025; Thu, 12 Nov 2020 11:29:57 +0000 From: "Jiang, Cheng1" To: "Richardson, Bruce" , David Marchand CC: Maxime Coquelin , "Xia, Chenbo" , dev , "Fu, Patrick" , "Yang, YvonneX" , "Hu, Jiayu" Thread-Topic: [dpdk-dev] [PATCH v3] examples/vhost: fix ioat dependency issue Thread-Index: AQHWuMXAXL53XxVhQEWs63s1N0jznqnEPSUAgAAOWACAAAJnUA== Date: Thu, 12 Nov 2020 11:29:56 +0000 Message-ID: References: <20201111111957.46090-1-Cheng1.jiang@intel.com> <20201112072147.4345-1-Cheng1.jiang@intel.com> <20201112102810.GE1309@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20201112102810.GE1309@bricha3-MOBL.ger.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9f378b90-b133-4a61-b0fa-08d886fe48a3 x-ms-traffictypediagnostic: MWHPR1101MB2111: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2IVL0xL+a6BuT43d+FORXQxAAuAl7OayGCzAnKlXuUX9ylzLQSEGjnY/i5x09Bk5bbq0lnjUFTIRuAcnptNkhRyftvQPfpxfl/7B8BfQDC1ZdOn/qaBvAH8xQpgvejC2g/Use8V8EtypWSMECNvVOJikiQHLLa4Xal3Mi9YG7J4583qM6LBQp7Xm6QHsRFphf1s6oUwc8pzraG0RCnYQgRsFu3rIXVq/r+4+DfU4YdFMa8/w68Vi6pM3fZL4HGXJasDgXd3GSoeDuLpwIkIYAQxQi6fiZpM+5WLUKYpyo63hviUbteAkFp/MyMmcZjiG x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB4995.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(346002)(39860400002)(366004)(376002)(76116006)(83380400001)(52536014)(6506007)(53546011)(71200400001)(4326008)(33656002)(316002)(64756008)(5660300002)(2906002)(9686003)(66476007)(66446008)(8936002)(86362001)(66946007)(66556008)(478600001)(8676002)(110136005)(26005)(107886003)(7696005)(55016002)(186003)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 2DQzTOdt0jR82mPwUvzc6CKHdL5Ek3smWEARWiZxI77/VoPUFF7HWCzgGacLN+XNBNCwRb2DF1IweypLaIcky3lR5a0pjCn0fwosfXnpZdjxTtfbDEd4EEJK64MHx5taXGrKJJZ3EYnqTOFPbTCMeKf0cq5o7CSp4HP0zUd8UeiJJf07K+HWtV95r64axTP7xWfbsPJsg01JBrADC/t4v+Zt7lUECjoaHqCWC3SLiAhB7GYzWkQD77UcPBvZDnCUHuTGX47W2BcbN3lqrqDtuYYIPzZCBGjDeSXt6cksC8IOsGiOJwPNpSQRURul2G3TVWivxGQ/q4RSb5GgbyaM/ps3HL5KZLa+BNQwsKn01JlnoiTfBdvACxrsobMPZTkS8eai7CYLHOin1jKfdvSzWq5vy9MMKWWKhycuL5vxSSvBxw4SxKGp5Hg/0RTGwfE3HjF4erC3QPHy0Mbu03iUAoNrPHF0JUCx3+5/y5EI+y1zalEChBbidFXLEZpGj5+vZCiHUkxfuuUHjZ+cDdXEpwNUOtRsayAlrEahccLiRoSDwZxr57xiO9nhSghx6huhnDetB8fLhXKxAO+Qc5BiaZcRjjETJ0R2FTDqiLBUS/eVT7n/60wFxXss7EGBMz9UzyG5jtaChxacbSeWVxhJC2ey7+Pb28jTrw3dAcPxVVQOojNM6X4riReoZvh0gW6ZJG9a0469bnZVYXErELYIPB4hheP8kkDo4m8BFBNpC0oM12Ap1GbVYsNgqRi8+ODkdxt7c5j0G8sbS3GjhIL2QRDqIq3keTicVqWz+kypArEGyfhVXAd0NXVAI3Dq2d+B85hn5HHH/Nwvv/V9EkCJpOOiozYL1z2KIOV95/OwKMAcsjjsHGysmzGMWzgFhn5QL2e26DTUTzKwdfMMvZQi/g== Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4995.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f378b90-b133-4a61-b0fa-08d886fe48a3 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Nov 2020 11:29:56.9804 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: n8F2+VXHlrGU1CEXPW5YMhB27I7TYUOcOzlWowEGtCdPXkcwjMQv8/1WL3AE4Y0N9cGTgBrtXZAMAnuqMguzsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2111 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3] examples/vhost: fix ioat dependency issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bruce, > -----Original Message----- > From: Bruce Richardson > Sent: Thursday, November 12, 2020 6:28 PM > To: David Marchand > Cc: Jiang, Cheng1 ; Maxime Coquelin > ; Xia, Chenbo ; > dev ; Fu, Patrick ; Yang, YvonneX > ; Hu, Jiayu > Subject: Re: [dpdk-dev] [PATCH v3] examples/vhost: fix ioat dependency > issue >=20 > On Thu, Nov 12, 2020 at 10:36:50AM +0100, David Marchand wrote: > > On Thu, Nov 12, 2020 at 8:30 AM Cheng Jiang > wrote: > > > > > > Fix vhost-switch compiling issue when ioat dependency is missing. > > > Change 'RTE_x86' check into 'RTE_RAW_IOAT' check in meson build file > > > and update Makefile. Clean some codes. > > > > > > Fixes: abec60e7115d ("examples/vhost: support vhost async data > > > path") > > > Fixes: 3a04ecb21420 ("examples/vhost: add async vhost args parsing") > > > > > > Signed-off-by: Cheng Jiang > > > --- > > > v3: > > > * Added fixes lines in commit log. > > > > > > v2: > > > * Cleaned some codes > > > * Changed RTE_RAW_IOAT check method in Makefile > > > * Added ioat function definition when RTE_RAW_IOAT is missing > > > > > > examples/vhost/Makefile | 5 +++++ > > > examples/vhost/ioat.h | 32 +++++++++++++++++++++++++------- > > > examples/vhost/main.c | 22 +++++++++++----------- > > > examples/vhost/meson.build | 2 +- > > > 4 files changed, 42 insertions(+), 19 deletions(-) > > > > > > diff --git a/examples/vhost/Makefile b/examples/vhost/Makefile index > > > cec59d0e0..cbe56f742 100644 > > > --- a/examples/vhost/Makefile > > > +++ b/examples/vhost/Makefile > > > @@ -28,6 +28,11 @@ CFLAGS +=3D -O3 $(shell $(PKGCONF) --cflags > > > libdpdk) LDFLAGS_SHARED =3D $(shell $(PKGCONF) --libs libdpdk) > > > LDFLAGS_STATIC =3D $(shell $(PKGCONF) --static --libs libdpdk) > > > > > > +HAS_RAW_IOAT=3D$(shell echo RTE_RAW_IOAT | $(CPP) $(CFLAGS) -P - | > > > +tail -1) ifeq ($(HAS_RAW_IOAT), 1) SRCS-y +=3D ioat.c endif > > > + > > > CFLAGS +=3D -DALLOW_EXPERIMENTAL_API > > > > > > build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build >=20 > >=20 > > I'll let Bruce and Maxime have the last word on this patch. > > But at least it works for me, > > Tested-by: David Marchand > > > I don't have a really strong objection to this, but I still would rather = see the > ioat detection done in the C code only rather than in the Makefile. > I'm concerned about us adding too much complexity into our makefiles, so > would like to keep them simple as much as possible. >=20 > Therefore, I'd like to see ioat.c always included in SRCS-y, and ioat.c j= ust have > #ifdef RTE_RAW_IOAT to block out any ioat-dependent code. >=20 > /Bruce Tomorrow is the deadline for RC4, it's a little bit rush to prepare a new f= ramework to cover the conditional compiling. Considering we have test effor= ts and CI check already on-going based on current patch, I would prefer to = keep current code structure. Plus, pure C code change could also introduce = more readability problem when we have more than one async callback implemen= tations.=A0 Thanks, Cheng