From: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"gakhil@marvell.com" <gakhil@marvell.com>,
"Dooley, Brian" <brian.dooley@intel.com>
Subject: RE: [PATCH v4 2/4] cryptodev: add ec points to sm2 op
Date: Tue, 8 Oct 2024 21:00:50 +0000 [thread overview]
Message-ID: <CO1PR11MB50097357AF3467786268D85A9F7E2@CO1PR11MB5009.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20241008134626.282bf9f3@hermes.local>
Hi Stephen,
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Tuesday, October 8, 2024 10:46 PM
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Cc: dev@dpdk.org; gakhil@marvell.com; Dooley, Brian
> <brian.dooley@intel.com>
> Subject: Re: [PATCH v4 2/4] cryptodev: add ec points to sm2 op
>
> On Tue, 8 Oct 2024 19:14:31 +0100
> Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com> wrote:
>
> > + RTE_CRYPTO_SM2_PARTIAL,
> > + /**<
> > + * PMD does not support the full process of the
> > + * SM2 encryption/decryption, but the elliptic
> > + * curve part only
>
> Couldn't this just be:
> /**< PMD only supports elliptic curve */
SM2 encryption involves several steps: random number generation, hashing, some trivial xor's etc, and calculation of elliptic curve points, what I meant here is that only this EC calculation will be performed.
But when I read it now, I probably may need to add some more clarity to it.
next prev parent reply other threads:[~2024-10-08 21:00 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 18:59 [PATCH 1/3] " Arkadiusz Kusztal
2024-01-29 18:59 ` [PATCH 2/3] crypto/qat: add sm2 encryption/decryption function Arkadiusz Kusztal
2024-01-29 18:59 ` [PATCH 3/3] app/test: add test sm2 C1/Kp test cases Arkadiusz Kusztal
2024-02-01 8:07 ` [EXT] [PATCH 1/3] cryptodev: add ec points to sm2 op Akhil Goyal
2024-02-01 13:25 ` Kusztal, ArkadiuszX
2024-09-24 16:30 ` Akhil Goyal
2024-09-29 17:29 ` [PATCH v2] " Arkadiusz Kusztal
2024-10-01 7:57 ` [EXTERNAL] " Akhil Goyal
2024-10-03 14:39 ` Akhil Goyal
2024-10-07 8:29 ` Kusztal, ArkadiuszX
2024-10-08 6:28 ` [PATCH v3 1/4] cryptodev: add partial sm2 feature flag Arkadiusz Kusztal
2024-10-08 6:28 ` [PATCH v3 2/4] cryptodev: add ec points to sm2 op Arkadiusz Kusztal
2024-10-08 11:27 ` [EXTERNAL] " Akhil Goyal
2024-10-08 11:46 ` Kusztal, ArkadiuszX
2024-10-08 11:49 ` Akhil Goyal
2024-10-08 6:28 ` [PATCH v3 3/4] crypto/qat: add sm2 encryption/decryption function Arkadiusz Kusztal
2024-10-08 6:28 ` [PATCH v3 4/4] app/test: add test sm2 C1/Kp test cases Arkadiusz Kusztal
2024-10-08 15:40 ` Dooley, Brian
2024-10-08 11:46 ` [EXTERNAL] [PATCH v3 1/4] cryptodev: add partial sm2 feature flag Akhil Goyal
2024-10-08 11:48 ` Kusztal, ArkadiuszX
2024-10-08 18:14 ` [PATCH v4 0/4] add ec points to sm2 op Arkadiusz Kusztal
2024-10-08 18:14 ` [PATCH v4 1/4] cryptodev: reorder structures in asym crypto header Arkadiusz Kusztal
2024-10-08 18:14 ` [PATCH v4 2/4] cryptodev: add ec points to sm2 op Arkadiusz Kusztal
2024-10-08 20:46 ` Stephen Hemminger
2024-10-08 21:00 ` Kusztal, ArkadiuszX [this message]
2024-10-08 21:09 ` Stephen Hemminger
2024-10-08 21:29 ` Kusztal, ArkadiuszX
2024-10-09 13:01 ` [PATCH v5 0/4] " Arkadiusz Kusztal
2024-10-09 13:01 ` [PATCH v5 1/4] cryptodev: reorder structures in asym crypto header Arkadiusz Kusztal
2024-10-09 21:03 ` [EXTERNAL] " Akhil Goyal
2024-10-09 13:01 ` [PATCH v5 2/4] cryptodev: add ec points to sm2 op Arkadiusz Kusztal
2024-10-09 20:51 ` [EXTERNAL] " Akhil Goyal
2024-10-11 12:17 ` Akhil Goyal
2024-10-17 18:54 ` Kusztal, ArkadiuszX
2024-10-09 13:01 ` [PATCH v5 3/4] crypto/qat: add sm2 encryption/decryption function Arkadiusz Kusztal
2024-10-09 20:49 ` [EXTERNAL] " Akhil Goyal
2024-10-10 7:49 ` Kusztal, ArkadiuszX
2024-10-09 13:01 ` [PATCH v5 4/4] app/test: add test sm2 C1/Kp test cases Arkadiusz Kusztal
2024-10-11 12:16 ` [EXTERNAL] " Akhil Goyal
2024-10-08 18:14 ` [PATCH v4 3/4] crypto/qat: add sm2 encryption/decryption function Arkadiusz Kusztal
2024-10-08 18:14 ` [PATCH v4 4/4] app/test: add test sm2 C1/Kp test cases Arkadiusz Kusztal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB50097357AF3467786268D85A9F7E2@CO1PR11MB5009.namprd11.prod.outlook.com \
--to=arkadiuszx.kusztal@intel.com \
--cc=brian.dooley@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).