From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D282A04FF; Tue, 24 May 2022 16:30:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 119F340140; Tue, 24 May 2022 16:30:39 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 028CE400D6 for ; Tue, 24 May 2022 16:30:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653402636; x=1684938636; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=rTddW+65so42rYOZd0ojR87rlgGlAjdI0QCb7tH1+Ek=; b=SLqhl1WCqjDLUVMymhBDWw5Qj30YfBjRaA93nIrzhceMzJkMFHU17gfM ZBXiZWDK2DL/deph2zzDNaLhR6eS8EJY+Ru0qFBC0YKn8iAanQxVyDdGy to2hkIGLOIczuHAkfsJMlZPObsZJAVDmYo2h/H9Q4tah2M89LutIvyVbC xTEa7SSlJwIlXBObzv4YFqfM1VXHnOeT1+ED1ePkRROpvn1RPVMW/h0Vn jv8jxAnZuylqyTo+gQY/qxjvnuUuWhaxfgcZ485vvn6Wq+C5Tueii+KOz toX01SVzmzK5NKj8CPCj4icKnwThNnhrclgMv+qF5yb3nanneMdTs4JYQ Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10357"; a="271119414" X-IronPort-AV: E=Sophos;i="5.91,248,1647327600"; d="scan'208";a="271119414" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 07:30:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,248,1647327600"; d="scan'208";a="572682215" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga007.jf.intel.com with ESMTP; 24 May 2022 07:30:31 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 24 May 2022 07:30:31 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 24 May 2022 07:30:31 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 24 May 2022 07:30:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ThGvSTVoAIiVltnejKnFgY1fwtwEgdYu5YK/GWdmowIW1gz/Ou6DQWlBgOQZvlPSARzR4zCXBOBVTeY8h3A/9usJcqT0VRFLzLeVV+cI93RpfABiBPMFC7EHqBWyt65UNovhZh7WvvMsnOeuqOikJdTbFzvn9TbtU3fhozHDthDXVJdGUKk3JIDXYTye9VaakgjuyNb4cS2IMj9gMUH3Djw/rC3ePn2VUOhLWv2YFjeJFeWoMYJZBUzorvUPqbRYStcNKZ9H4NHP2kPL3t/Ie8XDO8wO35j1FRL/GLbDpWeyVhCrdQ6m+PFL0aMdncKqZAZZwoYyX/X4fBc7sJGNKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZuoFOZiuzG8kIosbQEkxICzC+ohZ4mWuZOpYmuBbMlo=; b=ZzX6n/aN/xOvHB3GPxxmDlOgBwUDRwjBohl1pdudOqzEv7oWEnxPvpAjdn0v180lDVnF9H8PCUfhEbtclvrqbhEgI/DA+1Fr9wCTsA1gO/sX6eVdz/JIg4fjxUtSQNoNmxsekFo2tuKCdKFWmueIF4YZLC7vzvr7LSF3NHD//jOLj0+RKo2Vn1i0DWAcYdAH4vCLyyhAzvBnDl8bZ65CjN6C21Ji2fYqGWV6QHqsujXf5+hgmYfhdIb2khrruljZooj/kXpkzAgmTQnsdmGmww0txMCokBSzqkW4WGVpSRQwckT0TlE2DrVyr8HvkIePcAeEdopr1FzQsWR347Oeaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB5009.namprd11.prod.outlook.com (2603:10b6:303:9e::11) by BL1PR11MB5288.namprd11.prod.outlook.com (2603:10b6:208:316::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Tue, 24 May 2022 14:30:29 +0000 Received: from CO1PR11MB5009.namprd11.prod.outlook.com ([fe80::f538:5980:ef0d:b634]) by CO1PR11MB5009.namprd11.prod.outlook.com ([fe80::f538:5980:ef0d:b634%6]) with mapi id 15.20.5273.023; Tue, 24 May 2022 14:30:29 +0000 From: "Kusztal, ArkadiuszX" To: Akhil Goyal , "dev@dpdk.org" CC: Anoob Joseph , "Zhang, Roy Fan" Subject: RE: [EXT] [PATCH 38/40] cryptodev: clarify usage of private key in dh Thread-Topic: [EXT] [PATCH 38/40] cryptodev: clarify usage of private key in dh Thread-Index: AQHYbBfSa8ljPLJwUU2D14eIKmC2V60uAyYAgAAY3dA= Date: Tue, 24 May 2022 14:30:29 +0000 Message-ID: References: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> <20220520055445.40063-39-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 45fd5f70-a48a-498c-cf36-08da3d91f39b x-ms-traffictypediagnostic: BL1PR11MB5288:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 53fuw4DS+ZFTk+AWPhTM+UORZwRlLySfzrcmkVmw9qjxX24NsPg5kQL+uRNEEVJ1bDCE52H7TI0v+NLfXMntaUszfHQy763NR7dOaELq7OBO6SOwFoz2sJ0mkyALcBDv+rgpZMcP6qYwCjzCoNJZc98/ANfFH8JpoL+FrA0WC5/oT+f57XtWqV6VpygFEDN8Xn0bt5NbonEHifVUX6gvkylak49jlb3svyTxzv9E6v5rPahxzm61NmO+GnPz/mzLTRENGBuzzFjqdE71TY5OIFZ6D4MvtwmuTh47pD17iLf0C9M47E213kuDb2+1AmDUNOrjwwOG4HAkKZDLRGrV0SSie541Zei5u6HtbuoEP8bmlmIcXR22fcKnDWWLWZKWmaMpGM53PPf2rTw+4xqzWUTnfsEwigCWmt5BkSym6nIcsmM7ZL/B0ROYUF9ThdJLg1eNuF3tenGGB5Yp4yI1jNQ5f/L+xSubffy1VXsiw1PPYApi8Js/Bhr/A4Y2FQAHM/Pum6GkpMb8kyrhG8Y9V9GG4eH+mW5ymKnM6sOTCMc983/UJrSRRGBLAwi0l59jt2X9xCsTL7mD1ZtpAM6QcIOMUQr1NUwOgxWW2U5vhXvckbJmIUCJ6P1iLwFHeDTS9IkqMlCq7XFJpasW/FweC6beQ4SP4zmhfFYN2azsscvrXshUS3C9VJ0YojZcZmEocf4lKcTeHaTxNka23e/A4A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB5009.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(316002)(53546011)(7696005)(54906003)(110136005)(26005)(9686003)(76116006)(6506007)(86362001)(38100700002)(2906002)(71200400001)(38070700005)(82960400001)(8676002)(122000001)(64756008)(66556008)(66946007)(4326008)(66476007)(66446008)(8936002)(52536014)(5660300002)(508600001)(33656002)(83380400001)(55016003)(186003)(107886003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?csXAsyXfCGU9sS4QCVpeh46CilE1AKNMGDNNdvIYbW7xiMBLN/gb6+K3yP7m?= =?us-ascii?Q?F5nb9BmpnhBrRFvibX6MYwTfG3ikK23Ipqz3GSBz/vy1j2LJDI7npkYWOB0d?= =?us-ascii?Q?0Gtk9OCvUuUmCRFr3sRujjhO76Cgx6S+lIMjjt+NShrZ7e7Ps2VQr1SI+k3v?= =?us-ascii?Q?JlHExvVubho3UhaDnYT/tA8IIv55VHy6XMmxiFRf9lEOpQnfsR2H+jABu5of?= =?us-ascii?Q?fIQpPqIgz4RLajxr3dchZF/8so48+ObsVhdD3TSfQdrLMsgGVyhmcjENbFRU?= =?us-ascii?Q?3lT4k+03B8CsR7MyCpU5gDCqFGacXXhHzAHE1TYQnHIUuj6aDFbXkI0zfwBq?= =?us-ascii?Q?Che3BZXv+/vGNLBjU6qn0OqbbBLCVSypyjxPBMllFyX+YJAnHSeZb+4DiZXD?= =?us-ascii?Q?tkCkWjoBPU/6tRgMolNvsPJ3xByTHK/NAqdvGtfXoDYzPUF/wQHW8zcgRDKW?= =?us-ascii?Q?2yKlRMqCGkG8vucZc9t845MEE6KtnfXQkHi25pAODb7NkwkjJTkNgeL06O8v?= =?us-ascii?Q?EqzDFjlxF/Fits2zuyhP6PmKI/XjAFVt7nNrLfZ4ZPdilDIKZS3Mb14/Be6Z?= =?us-ascii?Q?WymTzUevj54QZ+u0WxI/Sc+Am+cUkXFDFfwc89WVpwt4KzFAU0TpbyFzDND7?= =?us-ascii?Q?N7KFf+a+AhD3VTWcFi7MUOG7OLR7/3chDml9QlCqe/f4WVMmSQL4pz28Robw?= =?us-ascii?Q?TkORe2KHO/qpFccz2wW7lvVAjtnu2x62hytIM8k+idplflh9px6Kp5hXjlRr?= =?us-ascii?Q?4WVmCQvF6+iwZUMmZT/WGWCcsbxRW8KxPAXfJO8DytZ+zxKJ644HRZZGiBj1?= =?us-ascii?Q?yn4pEO1WBatD4RvHmNWW4+NjVuybWVj7ACPE/lcywUse0VD/luWMG0L78QlY?= =?us-ascii?Q?tZQTWVm0dGYkZzIpVFcyzBEJ6unCJTORaysk7O/Ci9f/F7y7rjeZiL7M0uLj?= =?us-ascii?Q?/5hNRBOZSPCnMIXGsVIulZQ0+w3QItbTzflgzjHeiQcM/1OeLTBrQXQA8JwJ?= =?us-ascii?Q?d0tNwRnwo7YpsyJttyBmgqE4zoQVKrWNs6zBDtvPdB2+B0Xw+4PaLbPyEWmn?= =?us-ascii?Q?OfkB44ka49TBCdNYcGMw1NAKOjhO+i4JsZ6vtpPVJ/Zadxb45gPA3SAidqFa?= =?us-ascii?Q?CzKytp3PcM8LAPnoyAzCxvgCFtu0xfAdQS98VeTAPrbYObAe90sBJhPG/1Ut?= =?us-ascii?Q?CE9GUr3CRxcAUQafv3ovqp855S+aYEzoTythDTBMoR0zTp6RZ6OGV6841DgZ?= =?us-ascii?Q?9Emq887kr8R33NLQ6jrUpaqx2P9dtg9O8DyGIxJIqVVgCHj8D5mt5drTlQc7?= =?us-ascii?Q?2NZDob7Jjh1z5rO53cJ2tVpGNbx/0KxDD0aG1wXUXVW3A4tFsEBK0i3zbPXr?= =?us-ascii?Q?09yhPI2+JTb0quszGZmPF70KL6ik0ZgVVa+7tt1rW2tvAC+ugOcX8+j9e/wd?= =?us-ascii?Q?l+F5nTk1XL5Y4vEXPQy+91uoUc42OlqctWalf5kVuJe7qoAes9qSzL/uoimJ?= =?us-ascii?Q?DY1F9TfSdbhruF2kEQ11O8n71M2dR5Jn/T+ivsb7Wo/Z0eP/J7ReRoyBPJBk?= =?us-ascii?Q?FD/6AEelndB4FLJ/ByHp4sTtfW6aO0KOlUPJJ424HhpMbkLC5GJfDEg5r46q?= =?us-ascii?Q?V6e7V1BtW2DkomcgW0fDWH2skiS1N/mF3MNWcyvskiopqpHliMttjLh2CWH6?= =?us-ascii?Q?QbidQnfKXyKBpuJ1L57GlJUpcIn36Rw/298gRSCFVAkSycnXzHsNoNzwbGX+?= =?us-ascii?Q?1jFBMJn6gON8beMi0LkbIIG2D5zN+kI=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5009.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45fd5f70-a48a-498c-cf36-08da3d91f39b X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2022 14:30:29.2660 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JtJ5wKe5HcsCCB5yNq7jyz8aWdivJ+jWXrrnjgE7t1C+syoauvc+ppM5w+pv6Q14Oe/n8BfAJo7j8kMpJAcSEgnpQEf7FSQ5cDSpSI2okGQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5288 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Tuesday, May 24, 2022 2:56 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Anoob Joseph ; Zhang, Roy Fan > > Subject: RE: [EXT] [PATCH 38/40] cryptodev: clarify usage of private key = in dh >=20 > > - clarified usage of private key in Diffie-Hellman. > > CSRNG capable device should generate private key and then use it for > > public key generation. > > > > Signed-off-by: Arek Kusztal > > --- > > lib/cryptodev/rte_crypto_asym.h | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/lib/cryptodev/rte_crypto_asym.h > > b/lib/cryptodev/rte_crypto_asym.h index 01b1fdd074..a6bb70ca3f 100644 > > --- a/lib/cryptodev/rte_crypto_asym.h > > +++ b/lib/cryptodev/rte_crypto_asym.h > > @@ -459,6 +459,10 @@ struct rte_crypto_dh_op_param { > > * Output generated private key when op_type is > > * DH PRIVATE_KEY_GENERATION > > * Input for RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE > > + * In case priv_key.length is 0 and op_type is set with > > + * RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE, CSRNG capable > > + * device will generate private key and use it for public > > + * key generation. >=20 > What is expected for the device which does not support this? > How will the application decide? [Arek] - it is similar issue as in DSA/ECDSA 'k'. Or we will add some PMD f= lag to determine if PMD is CSRNG capable or it will be stated in PMD .rst f= ile. If device does not support random, packet will be rejected (send to re= sponse queue with NOT_PROCESSED). This comment should probably be added. >=20 > > */ > > union { > > rte_crypto_uint pub_key; > > -- > > 2.13.6