RE: [PATCH] net/iavf: check PTP capabilities during init

["Keller, Jacob E" <jacob.e.keller@intel.com>]

> -----Original Message-----
> From: Richardson, Bruce <bruce.richardson@intel.com>
> Sent: Wednesday, November 26, 2025 9:01 AM
> To: Keller, Jacob E <jacob.e.keller@intel.com>
> Cc: Hore, Soumyadeep <soumyadeep.hore@intel.com>; dev@dpdk.org;
> Greenwalt, Paul <paul.greenwalt@intel.com>; Medvedkin, Vladimir
> <vladimir.medvedkin@intel.com>; Jiale, SongX <songx.jiale@intel.com>
> Subject: Re: [PATCH] net/iavf: check PTP capabilities during init
> 
> On Tue, Nov 25, 2025 at 03:57:10PM -0800, Jacob Keller wrote:
> >
> >
> > On 11/25/2025 5:12 AM, Bruce Richardson wrote:
> > > On Tue, Nov 25, 2025 at 10:30:37AM +0000, Hore, Soumyadeep wrote:
> > >> Hi Jacob,
> > >>
> > >> Currently PTP features are not enabled in DPDK. We only have the Rx
> timestamp API in place. Typically the change that you want needs to be
> implemented in ethdev_ops.timesync_enable(), which is not implemented.
> > >>
> > > At this stage we are post final RC for 25.11, so taking this patch would be
> > > risky anyway. Let's target 26.03 for this, and then look to  backport to
> > > 25.11.1
> > >
> > > Thanks,
> > > /Bruce
> >
> > Sure. In that case i think we need to revert the other change that
> > checked the RX_TIMESTAMP flag as it corrected one issue but caused a
> > regression in Rx timestamp offload when it *is* functional.
> >
> > I think its commit d21c2fe6e5a1 ("net/iavf: fix check for PF Rx
> > timestamp support"). That commit without this fix will incorrectly
> > prevent enabling Rx timestamps.
> >
> I've sent a revert patch now[1]. Please verify that this revert is correct
> and ok for inclusion as a last-minute fix in final 25.11 release.
> 
> Thanks,
> /Bruce
> 
> [1] https://patches.dpdk.org/project/dpdk/patch/20251126165943.1536164-1-
> bruce.richardson@intel.com/

Looks good to me, and thanks for fixing my mistake quickly!

Regards,
Jake