From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF345A0503; Wed, 18 May 2022 08:36:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 600254068B; Wed, 18 May 2022 08:36:22 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 1DB2440685; Wed, 18 May 2022 08:36:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652855780; x=1684391780; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=0omBrvDsoNwGhuQ6BsLWxOH5av5jk5DIhZg6aoYeARo=; b=T4NDrC0pRCnb+DXoiQnED2vGCvaCE8Mfi/C+4JQdW8IR4tVCjJO7/hOl KmPvfXEzQFPEWLGoMldur/PLhE64SFv4euM+oZrMwJWgOxx/pOSCQSLDJ lF93xQw0CMaffXWvncYWvYEynhkqahcK3tfhYm4DVu9/J4nWvGNjMm1ph M5YTM7vuh65wUrBuEvsUTmlXRugZCz2+cCKwo/Ve0R/S0yMY7lqo4b6Cb h4i6R3JP5Ocdfl+890EfqfGBoSTdTTg2SOMQnBup/N5g98phs7A+jgJmZ VN52CrDkwR0j6QTkTfHDRfKiPN+HLGFqsveteZUCu0ShNiaMHMlUdZyk4 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10350"; a="296795885" X-IronPort-AV: E=Sophos;i="5.91,234,1647327600"; d="scan'208";a="296795885" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2022 23:36:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,234,1647327600"; d="scan'208";a="569288839" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga007.jf.intel.com with ESMTP; 17 May 2022 23:36:17 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 17 May 2022 23:36:17 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 17 May 2022 23:36:17 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 17 May 2022 23:36:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UqNR3SMRbfvUxCOnecSdPHU9BvC3bkIYrEmF9vL72/N1II+C8NpxjVORxEXkR3Fsk+k8XOHq52qyTt8t/mtF6r2Q4f+BTxSpTRsf8AvsCGR7a5udlw7YYRlxWCM7mLZKWx6w7Q1QwvdQFO8QFqGsDzNPeo9MauA+Z54h9uNT0sZFElpOAIiZIgxVUUkPJJ0MpvWdqXjQfD37FOxeoU3gPHD60v6r/ZAmhykzmNVs12tNGWezAaAJiZ8cg7qRm+zNxT0IQUpHWjfIvr6lyPmBkvFge9s3feYjnNDwKuCfu8k7UyJojsbCPcDh6VaDPhnLdgHJW1N3ZiCD6idQKDLBxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0omBrvDsoNwGhuQ6BsLWxOH5av5jk5DIhZg6aoYeARo=; b=cNzzm64MlJXCMwXbG+4novi0zOG/VKvnTMJxEYaC+7bOFSf42LjJfKeRGJELa8hj52eWXRKYQos4QT+aPo/eXGBie+UwPRd5ubEZR4R98qtdzt67TOs/WQzLIrnpgNgp3mu6kUTnpiiJ4N4DIbwthJEiIQuPfGqv7VRAJsudriblOMlrZl7xGaeUtVyjR4PCH1loLn8cEJgQxLXZsa5HMV8i9wa9FU3zkx/Bic2DwnLZ/rXVOOQ110an5ZYD/JRXgn31eoKjMJ15PehkjiAWF/KgyDVgBPS8St2yd/Eju2YqGrISSNmuM0OhNd++IlGuBQbJtXi//vC1rFDMqwZwqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB5105.namprd11.prod.outlook.com (2603:10b6:303:9f::7) by SJ0PR11MB5597.namprd11.prod.outlook.com (2603:10b6:a03:300::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Wed, 18 May 2022 06:36:10 +0000 Received: from CO1PR11MB5105.namprd11.prod.outlook.com ([fe80::2818:cd70:9fce:bf07]) by CO1PR11MB5105.namprd11.prod.outlook.com ([fe80::2818:cd70:9fce:bf07%5]) with mapi id 15.20.5273.014; Wed, 18 May 2022 06:36:10 +0000 From: "Zhang, Peng1X" To: "Zhang, Qi Z" , "Yang, Qiming" , "dev@dpdk.org" CC: "stable@dpdk.org" Subject: RE: [PATCH v2] net/ice: fix DCF state checking mechanism Thread-Topic: [PATCH v2] net/ice: fix DCF state checking mechanism Thread-Index: AQHYZQyJs2HPAynx70K42sw2r9Zofq0it2CAgAGBMiA= Date: Wed, 18 May 2022 06:36:10 +0000 Message-ID: References: <20220511154930.509436-1-peng1x.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2a2908aa-deb2-4528-1da2-08da3898b253 x-ms-traffictypediagnostic: SJ0PR11MB5597:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7kSFxvqmA2c6oduqTaECBIv0piN5n3Nza8Sr9w5tbKqnVV96XnuHCAL8E895HVkZPSCyrjC3NWyEju+sRZeVN2nyDdLlMIAsg6KUIKfXJ/zNVhyji5hea2tXgtzUAG0eSq8xvMMhibnpAkyuEFdSRoozCOZZXZCrpRVvYUr4zaIb7ReMypRxQITqAgyZJX+dp0Ylqeaw/1NG9UKtEW+XgfcphnQdZDLdI2NR2d7DcPhKQE4DhgD+aDczECc1xSIZk8KzoZb2PvdxF+jwP25LOuoRqHkyXr7WbTej0VNTWFs6dA9THbB4ixO7nUZ6iVQX20mgyYcCRRYJSUTEl3ELlK/WRqBh+iVxBgBs+grL4fWNRE6i1oHV0bvF8Mxxtt/TIZgScW3t+ZB0aiND4eU+KxSSVs3jZ6V1RnrU2qlI0pqabsC8QCfHASFT/4KZREToBMG1WH0BPAF+wWXDrXUcAZRI5huqHRctEbo7dYsErUEanxY4If3TeTRbASXLdQqlfPmGH/fJVuLT746mxdjR7xPlGDdCe4NddNDqzc3ipVa3CP3s5xwohlLpMqGm3AG4YRjVhQJ29b/T5rg/+UH4TaGTEMS0k/PcqD5PianXzLnkek0/0rjwRfRLggBGkZ4xEKAjNZj+aFKSD2g5G0KvpFlOqFn+X9HnEhN7oV87ydc9qCrEYUYP9XHYDhG/ELl6Ro90mQGgWR1ZVLIhn1ZCmw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB5105.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(4326008)(86362001)(71200400001)(76116006)(450100002)(38100700002)(38070700005)(5660300002)(7696005)(64756008)(66446008)(66556008)(508600001)(55016003)(53546011)(82960400001)(66946007)(2906002)(52536014)(8936002)(316002)(186003)(110136005)(9686003)(122000001)(6506007)(66476007)(33656002)(83380400001)(8676002)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?d98PY5oBnIa495E+XolIqK7j/JHrGFgLf18+Uwaj3/26AZnYQ/5Jau29ex6W?= =?us-ascii?Q?y2kBRp98rIux/q6BAhB2ZX0qUSXzM4gbvQY/2H3dXG1LEZubF64g2FnUh/ky?= =?us-ascii?Q?C3RwSxlaL9mvFyjdekEku6ywCMGzi1+CrDtOIAe+ERZPLi+vxh9CVzbxSbz6?= =?us-ascii?Q?ww7HqYz9ZRxoZ9pgcYuxoE0BdvWMx1yLRARuKlwRvBD0SGTG+A8b1MLTLTff?= =?us-ascii?Q?2/VobR/AnaaQoNENnQPQE6cBzM4eiAqwKTZpCbKUgshGHNcXzrGUJR/y4TbV?= =?us-ascii?Q?s7XWoKKbJeasargbiRy2VbNx5IPI+SBtUrxPVLdC0vmd5BvxSUkm2KAVyRJM?= =?us-ascii?Q?+vkAXgDU/iKaXg+ncFqy4Blg/ZnMUJ7hBZ2Ime0zgowL+3KJCIovPnV5u5G+?= =?us-ascii?Q?wCQtQ36U6CPpOVDb+onuUcLHPGo2qohw7BNnpetQJl3namPSy00EuOn6t193?= =?us-ascii?Q?OKW/zB5LL5SmODJMoc50UJ4f0JLQ+u6gNrYZEkoS5famxqjPlBoU1dn2/lOs?= =?us-ascii?Q?29rsD72WaUPHs6xE7Vdmpoz+aq7fTzTcydxeC878j1ICzYHLjlPikngBNCHn?= =?us-ascii?Q?sggo08HihY1NX+oPOjV218FJPVKBtfu7I1+y5fdYqDxHin9oyVgBZ50taiJ5?= =?us-ascii?Q?XOvo1oguuvVLJ1W6dFU9NXqNzsBQRsra6xpZ+/rq+vk+rvzIx0mLwcJGqQuj?= =?us-ascii?Q?/OSF0UMFFT3nwTWBH4kcZ56/krVFI1FjZYhbPMbkYMmBrr7OwHN8oIe4IpFd?= =?us-ascii?Q?ARVkLJ+yN1d+jNvB8pXk/wxfusfC3dMTKzuW1Pzic0m1fcDo3MfbOd5ZQl2i?= =?us-ascii?Q?aiVXgjLry0Zs61C0dGTUGWlYooIdhX75F/mpEkFtBfE+e9akKBQh/y5NrShG?= =?us-ascii?Q?9mHSLVp2yRHOU9KCf7ZRMae0GthXEjq1iPiUT25FNl8C83b/UtAaoeP6hYAl?= =?us-ascii?Q?XsUXuCTiF4se9q63IjadlCfUR1FbGi2+kWEsVv+Rzqp2m9yQo0kFOHz8RzBj?= =?us-ascii?Q?58T1eatU7Np3E16f95sNnXWuAJ1FMmlL97yT3x8WWmno+2/M438CBmCVYL0l?= =?us-ascii?Q?FIXH2U/1FDquPWqOvQS6pRTyhiJtNGKpqSkcjc7NGTxkW/QmTHFhNwp+o3pC?= =?us-ascii?Q?2mPC1vcWHbZhsn8WfYXBKoLxvsIdpm5f5g3vU5ravN+fUGMzifGgcXL5A41y?= =?us-ascii?Q?b1qNbMKCIclTendr0LEnVvG9qqd2f4oKhrPFD3K+rCnZboxMj6Hli0UfImLx?= =?us-ascii?Q?ACrAQ6khubATwTg8Exs+CDKO2mKbP6Dxst9p7Zqf1QjSyGdQ/agyIER5Sc9j?= =?us-ascii?Q?FLZfF8qvJZYBZtZ1CYsmXps+k4GtfXIoTp1GQiNc4RjFAqk5lNlVe0e90IpN?= =?us-ascii?Q?y1UmE1Q3GL9F9o9dd5sACwKucA5OcGaKryx5PZ+IvtjWhV+VXKgvOO50xQcJ?= =?us-ascii?Q?hvVHdE4iwFjB2D8mpOL7bAoW482MQLXANOPcqTlELSqhJIEOlF8rlV2pNuDP?= =?us-ascii?Q?d6YQ+xqM2g7yrtuR44OP6i2QmTnPZmt0FUA/9EA1OFfdpAdVTnkrApU8nT7J?= =?us-ascii?Q?sO1Pmv6Qob2JiodYOhVk+s+SrcIRaebJzQTKINSfgCtigX04n2mkzZYL6od1?= =?us-ascii?Q?72kCLR4c5SFkkBXPiFlIlFjdHHZwUacAI0ifJCM2P4ZBU5WH/01uBgq8+58h?= =?us-ascii?Q?KfMRNFYDB4VHAdMPMaWkUzI6bHLtnTTnj/BPSIWAMxnllyWO7NoORQ/QUFi4?= =?us-ascii?Q?bXYdZPzYjA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5105.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a2908aa-deb2-4528-1da2-08da3898b253 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2022 06:36:10.4166 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UiPdc1/BeAAkuMQzF9GVxPzVDQOx5XbAPe3XXUWEmYqKwAGBtC7qY2GlJ7hG0g1WE5vEMJIkojZvS+7rXhqeww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5597 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Ok, because error phenomena happens during the period VF reset again and ag= ain following situation will possible happen as following steps describe: step 1. DCF state has been set to on after VF has reset. step 2. A VF reset happen, kernel send an event to DCF and set STATE to pau= se. step 3. Before DCF receive the event, it is possible a rule creation is ong= oing,=20 then in virtual channel queue, the rule request is in front of the "re-conn= ect", then it will be rejected. step 4.But the DCF state is not set to pause, according to previous logic e= rror code will be EINVAL, while not EAGAIN. In conclusion, in upper situation error code which should not be EINVAL and= EAGAIN is expected. > -----Original Message----- > From: Zhang, Qi Z > Sent: Tuesday, May 17, 2022 3:36 PM > To: Zhang, Peng1X ; Yang, Qiming > ; dev@dpdk.org > Cc: stable@dpdk.org > Subject: RE: [PATCH v2] net/ice: fix DCF state checking mechanism >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Peng1X > > Sent: Wednesday, May 11, 2022 11:50 PM > > To: Yang, Qiming ; Zhang, Qi Z > > ; dev@dpdk.org > > Cc: Zhang, Peng1X ; stable@dpdk.org > > Subject: [PATCH v2] net/ice: fix DCF state checking mechanism > > > > From: Peng Zhang > > > > DCF state previous checking mechanism can not fully detect DCF state > > whether is on or not,so PMD will report uncorrect error code in some > > cases and mislead user.Fix DCF state checking mechanism which will > > mention user resource temporarily unavailable when DCF state is not on. >=20 >=20 > Please describe at which situation which error code is uncorrect and whic= h is > expected. >=20 >=20