From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D82C9A0503; Thu, 19 May 2022 08:06:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7888042685; Thu, 19 May 2022 08:06:51 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 3AF7640140; Thu, 19 May 2022 08:06:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652940409; x=1684476409; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=8CjtjMYmePOQjBsGE3DAce370TWLC19d5a0dlLpd6ag=; b=bXTyXTjKDoExKDsHkL0f+AQxqQiRUYf9aX1HSxlCgoy1Vp9rynpdX1m4 CoME0WLs05jg1gQ2mB79KrH7ATbLR6/0oWW8i2WRLZddSfrr1Zyy+SdTL PY6UVteq+mha/YjWkoPxfKsQY3Bv0jDtKlyhr/hKY/eMUPUa2cn5H27a0 nNKfwr6A8a1xXzzsxjyyan2o/iRPL5NEnrFV9bCU3YIsaeZ9FNLUcjnYe 9PUFhJ70nv90NywdQwPVhMr5iZwq33ktSbI6+nl0m6sIDeGQCRaMMGa7w NAwBdEOVJznam/j8GRLpJ6ZWWMpV7RMZkalZCWpoa4fK4fwxG3I4W/SiW g==; X-IronPort-AV: E=McAfee;i="6400,9594,10351"; a="254086622" X-IronPort-AV: E=Sophos;i="5.91,236,1647327600"; d="scan'208";a="254086622" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2022 23:06:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,236,1647327600"; d="scan'208";a="606318586" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 18 May 2022 23:06:36 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 18 May 2022 23:06:36 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 18 May 2022 23:06:36 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 18 May 2022 23:06:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aL+BULDGeRCf6u4+TRZqgfU8uL2D/6/s2i7USCnNpPsqC9fXnEIqglsg0FtZ9gk1oRDCskvCmjWRtN6LMexG4Q/3OkUwA4UZaWSgSS7F8/2KfSDgLMjt7MT3rWSkp6H05YNld4GBLusUA8Ubebb/x5RyqwpoDzhKBScX9Zor1w78rd5WT0OdPplJqvWnf/6dTNhypxkndzPexNabiRpnwUifGFi8+q/zFZ70kcB5qyMMAiSsHWCpSHLH+HkxE3yugxUvkD+/fdV89H4Jw3YPBGbKlIQQestSQwNt5fgTLXfDph04ljN6lCm8RlG2vfiQbJTYrtA6sDlhYhnn4UKjyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8CjtjMYmePOQjBsGE3DAce370TWLC19d5a0dlLpd6ag=; b=XEKYk3nA0EwIHHE+y+1rDQ9gVsZ3T1aYyTkYx9kcWgPjt+IS0vlw+D3MtKK5JKNYjr7ftrDV1elD20CeXS3IlTnT2/tW0GI0zeVatPfc0VjQT1UoNbURwPM7z/Ee5mjfG5n5My19xARgzG3F1x2xxy7q9aC36y8uPoVBSzR/bUclzcD7rMlqc6bOcgcAE5LhdGf0LzbSmbkdgaFAOKavHEiq7PC9gL3h/qUSANxV0vNOlyJZVBK0RgImMf3u7CInf2x1rZb0eXz4uTXHco442J2j7wRCMEtfkJmd4H7ZPMoG0TU50vwU5V2NKAt+PUEd0yOtJrVLqUvBzlKVpPNycg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB5105.namprd11.prod.outlook.com (2603:10b6:303:9f::7) by BYAPR11MB3047.namprd11.prod.outlook.com (2603:10b6:a03:8b::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Thu, 19 May 2022 06:05:44 +0000 Received: from CO1PR11MB5105.namprd11.prod.outlook.com ([fe80::2818:cd70:9fce:bf07]) by CO1PR11MB5105.namprd11.prod.outlook.com ([fe80::2818:cd70:9fce:bf07%5]) with mapi id 15.20.5273.014; Thu, 19 May 2022 06:05:44 +0000 From: "Zhang, Peng1X" To: "Zhang, Qi Z" , "Yang, Qiming" , "dev@dpdk.org" CC: "stable@dpdk.org" Subject: RE: [PATCH v2] net/ice: fix DCF state checking mechanism Thread-Topic: [PATCH v2] net/ice: fix DCF state checking mechanism Thread-Index: AQHYZQyJs2HPAynx70K42sw2r9Zofq0it2CAgAGBMiCAAAMgAIABho4g Date: Thu, 19 May 2022 06:05:44 +0000 Message-ID: References: <20220511154930.509436-1-peng1x.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e17a5a70-5221-476b-945d-08da395d9c9e x-ms-traffictypediagnostic: BYAPR11MB3047:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9oyEQqvQb9xRqKn6ECxLZsQg1CIHCRbolgnZ1sPn3+nQ6Dy68ggULtrV67r7Y68p5p9ZX/qxEhYTniPwP4wURU1KeYgRFJVP0fUs0nEW4xner54HXtiy1xc7Ej0QvfcxXq68HMuYjCCSzQHB+i/5iAsZ5x5QSK9zpDY6AbffDxCFTBKD7XCWobpMEDIx8pkJks5x8R8WuKg5hXqXXUdMoHmM+5i3AIlPtOUbWjGgdf4KB6aA0sQylF32L9PuxA+AcMB+BW2OxoEzhK2/L/tZk4J+Onb3cknqG/YJ5ocLE+ncF38TVrle3f6t/4Z6pT+TQ4lB8bGJuCnXqO622KHJlQCy23NLF8g+Kr4md1MJidqT6JT/vZ6AohFtpIxgRR9So2SbsS1Frr93eeB7MWg+KOe27+6qZd1KepZ332M+UweN8+/v/0U9BY3wFKWz1poUO80KkQRIhAb0/O3sPG1Mriq5uD9eQTAXU6C7gMPKtGiXYpy1pHAf3pPd1eKnta7T98wquxz99xOU7wtifFRbZHhtx+avSZls8ZQWofYTaEbnMTy3ho5HudNHp9yBQthXr1n8xfoX0exSgInOUE9LnURGp8OB3l/ndbBTBBIjlNdq0857l8ZKaWkCYhCEmS3Dtu+/rygq0R+fIIhq2Tp2oqx1OxVJhkR7jv35RCpQUsZVgYlbLVdQD1L/jMGM4EztVF/uVPRRuzQ8Y6v69usOLQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB5105.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(186003)(53546011)(86362001)(52536014)(83380400001)(38070700005)(82960400001)(122000001)(38100700002)(76116006)(66476007)(66446008)(450100002)(8676002)(66556008)(4326008)(64756008)(55016003)(8936002)(66946007)(5660300002)(33656002)(2906002)(6506007)(508600001)(316002)(26005)(71200400001)(7696005)(9686003)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?n7iMNsodVeiQi3NeumSTZ9SE2ZZ1Kw4KK8ef6TpsXx14g0N96gyQJSWI9er4?= =?us-ascii?Q?3NW89HMFeN5vDShLfWDslstevT7s4A+TgA12WDgiU62/fKV+dXxxdLdD5cmE?= =?us-ascii?Q?WwpfKxs9zUsWgvg/Pa6Kh2IQAlqVgyduG07DhIR8A90vzWP3xKa69p+08dod?= =?us-ascii?Q?Z+t62W2fwJVPlLOMSNufs52PUMz32qINV86R0/QxBs2hONq4FZU399oUUOn5?= =?us-ascii?Q?x7+4WHPDIa3cYUgrQRKqT9zL1xkDzWIM30tJiP8lLRX/iRruGX0WeFzM780H?= =?us-ascii?Q?fOiPG3e3goIKk4r323/MbD8Ge6OQmjTJxZQQ30AV3/lrooD9POw1CduC+r3x?= =?us-ascii?Q?fAFrjDALHsQRvnMv1we3YkxpWC04JWg9i9CV6oZMhn/57KSeVag+n6+W648V?= =?us-ascii?Q?PNLzLBhmH3Kr0+4uA39lNhI95V0mpqT1TJl86cg0E2HaBbMD6e0dKMBcsZcO?= =?us-ascii?Q?BJv4rDRtF9GVy5KiZJ4QEXqA9PPpC1l3j6Pf/tjW+pLYBAhAaVS13b5I8C8b?= =?us-ascii?Q?5pSr3BcsRG5jQL1Vk6acZv1gPgm+F/JONmY4OAizjpomtLlG9qUZsQVEQBBA?= =?us-ascii?Q?TTPqnSNkfmiHEsPBgMPAUubq35HgGzS1TrX/O+yjTzjhgioTiod6g7b010tH?= =?us-ascii?Q?mr8zhYwXx0EeDqQWXM07IDWaTpmfPZSyECGwunbtNlHC7X+9EBWdOeM29kPr?= =?us-ascii?Q?q9QiwkQFtTQyLn2gP2pPbdrHFcm90+AX4th9UIC0XfB+A2lXqXinQVVRpjBr?= =?us-ascii?Q?iuiHTxRVENZjIo0us4GfIzzi7f+NIt6fDDGq96P8gpkTrQlm2LjlqTUiLNt4?= =?us-ascii?Q?HUUxlFXawUqU0OgZoL89bwAc0BxsF+vmJPMRcZiE4MHi0uDI2vuqG5ajqUoF?= =?us-ascii?Q?cgreOzBPvzJX/RAcKL/Z6CHvBpuP1/KfyRTRqlk3Xx8IAVnwMIcvIVQl2XpY?= =?us-ascii?Q?pKi0cmpnUH1RBrehY3ad0p0drQK4x5Y5peKwwursayUJr+SaGVvrEFiKEMi0?= =?us-ascii?Q?pV4luq7PJaEPjj0ltYcpV4XIWLy4jyE/16nvTXwWlI25dz6F8UvO/BKQbz5z?= =?us-ascii?Q?oH3avnFFhdXKrZoxkTXGwDjVMw+FLHemz5rQWN5S3JM8HJeVZxd7iXSRNkY9?= =?us-ascii?Q?fCP4HPlVkpShEk7T3fKdZ1I080QP0HgoAE3UxS7rTWU1a5ripWp0iW0r5n/0?= =?us-ascii?Q?VRo5oFPp5JnF3Byy0X/CXv0/SHxaMX/tNCqtkobwF4CRDD7NGPUnk3Jil7bg?= =?us-ascii?Q?1W5H0jklLBNDh/RCPnsi8m2zx5GwHf/hFM93FR+gJcy3FF+XJZLbT6SzjWl1?= =?us-ascii?Q?H8Ws3v8uFw7CvjuvLflxiArtrrZ6Iz88j4E1WdOXY4y/UqH8SyinfQYabzTI?= =?us-ascii?Q?/QBGWeKgvOPo0v+bYwJJmW8CchtWuiy4g4ptAEfFjc1d+Dnwnjd5fa3wuWGg?= =?us-ascii?Q?5RJ8cgXYSp832uErH9kkYsL6CENBsuZsVFr0QZfNb8dX25g6TeS7jnPfxdIG?= =?us-ascii?Q?ELurucsohPQjHNpr04g3ArSuBMb8xcEgwWy8jMPWic3qgPr5c7yzat2LTAFN?= =?us-ascii?Q?+9ldCItp0Sr7X+qon24eOJ91aOU/6c/1z9xnGWw4ylY1Mc34MKo1z4+srabq?= =?us-ascii?Q?sTmoXUw1Qkwl7FaIG+EeI27j3g619Dx5wIDhuCv0RUrKxzpgRItNAWIUBz+f?= =?us-ascii?Q?cc9xKRixsGUlpmx8Rz0C94QSULP9XfbwNmG8xYryAaHXN+Xn7tZgE4FwxpU5?= =?us-ascii?Q?F03WTAO8pA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5105.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e17a5a70-5221-476b-945d-08da395d9c9e X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2022 06:05:44.8570 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CVt+ny6bSaARjzyDeFad3MiStuD1DjsRVDumW/lfur5qjZ9IitA6gAOsbJdjPTafQaLvNWKl4MfMy8sYE73T4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3047 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch is aim to fix the mentioned situation. After having failed to create rule, error code is EINVAL or EAGAIN depends = whether DCF is enabled and DCF state is on or not. In this patch conduct DPDK DCF state by create or destroy rule successfully= or not. Before patch is applied, the steps of error phenomena: step 1. DPDK DCF state has been set to on after VF has reset and multiple r= ules are creating. step 2. A VF reset happen immediately, kernel send an event to DPDK DCF and= set STATE to pause. step 3. Before DPDK DCF receive the event, it is possible a rule creation i= s ongoing,=20 then in virtual channel queue, the rule request is in front of the "re-conn= ect", then it will be rejected. step 4. But the DPDK DCF state is not set to pause, error code will be set = as EINVAL, not EAGAIN. After patch is applied, the upper error should be fixed for the upper situa= tion. Because in step 3,because rule request is rejected, then create rule fail. DPDK DCF state will be still pause state, and DPDK DCF is enabled. According to the logic of conduct error code after create rule fail, error = code is EAGAIN. > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, May 18, 2022 2:46 PM > To: Zhang, Peng1X ; Yang, Qiming > ; dev@dpdk.org > Cc: stable@dpdk.org > Subject: RE: [PATCH v2] net/ice: fix DCF state checking mechanism >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Peng1X > > Sent: Wednesday, May 18, 2022 2:36 PM > > To: Zhang, Qi Z ; Yang, Qiming > > ; dev@dpdk.org > > Cc: stable@dpdk.org > > Subject: RE: [PATCH v2] net/ice: fix DCF state checking mechanism > > > > Ok, because error phenomena happens during the period VF reset again > > and again following situation will possible happen as following steps d= escribe: > > step 1. DCF state has been set to on after VF has reset. > > step 2. A VF reset happen, kernel send an event to DCF and set STATE to > pause. > > step 3. Before DCF receive the event, it is possible a rule creation > > is ongoing, then in virtual channel queue, the rule request is in > > front of the "re-connect", then it will be rejected. > > step 4.But the DCF state is not set to pause, according to previous > > logic error code will be EINVAL, while not EAGAIN. > > > > In conclusion, in upper situation error code which should not be > > EINVAL and EAGAIN is expected. >=20 > Ok, Please send a new version