From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3957BA034F; Fri, 12 Nov 2021 21:25:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 015DA40E25; Fri, 12 Nov 2021 21:25:38 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id E07DE40692 for ; Fri, 12 Nov 2021 21:25:35 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10166"; a="213925969" X-IronPort-AV: E=Sophos;i="5.87,230,1631602800"; d="scan'208";a="213925969" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2021 12:25:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,230,1631602800"; d="scan'208";a="733769567" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga006.fm.intel.com with ESMTP; 12 Nov 2021 12:25:34 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 12 Nov 2021 12:25:34 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 12 Nov 2021 12:25:34 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 12 Nov 2021 12:25:34 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n+SaRFPuSnfgPRoQYiC7RIfxWPewPz0YzNgc7eneCHk4UUo8b28HNbHox4EereRQ/HaANB71KLPKs2r/Xc6r1vjtYLIo2rrTmR7kttSDM6SHsUN4gIMtDV1enYmruLk9KKYbHS9AMXAg6tUgB8T5kDHOk7FJRl0l6zau5jn1cxVWmiWUWJBRARYuwWr/+tRwwCFrpaRGn+Gj9Vl+qOO7Rq1064WxpSmXM9aPwAT0ASd1NvIX6qt2d8FQgxpKsqdTMIwZJq7icLVyqen80nOXtF4F4cuwhp8UK+O4IYuPJIgDjg7s6+FDHjpjreKjZtAvqz3nW7YVg4x5aUr+igafbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MP0NE+uZYkRlHrBZlaYKJov75zG4c/OexHtR0L1K6Ug=; b=J8BuEgZa3urohZlGobIYxb0I51LVLnbytk+PcNvK2oqubVlH4qXYOMql/mjQPWujfU86e8EVVhD5CApRvI7ZmQknHAzhUkPqEOxal/Vz2LCg9YyHuymiPRAyQEimqkOHct/6akbvRbC7whLD8PaBXStMXHsSkKGKbov2vdu4WVxuqCrQFfR2Kv0eJ+8gt0noSVZKOopjuSAJK9fLaZDsak+B+auhd341ZiB7NGFiUOeLJTHPhRvJEhwJuP02LqVAmk/8cnYrikpggruOigAx3Zyu8znIvjLPNzLrAnbP8r1nzLFxfhIwZiy3rb9nVoVvInnyJK+WrbUKFvycIRRI3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MP0NE+uZYkRlHrBZlaYKJov75zG4c/OexHtR0L1K6Ug=; b=dJscF70A3YfvnkfQfCMmZZg1coOHKcuXaTPOFcErGS18LQKysenp0RoXOGxysdig7cVClEr303c1k86R+OJ3GlyXNCwDB0B3fgAjoeJKt1DQcpmBmd6bVQFXKHoNey0wIxB7CDZs1n0bnQqLzCAsbqoEy8RZIOn6vFkDfgVNTdo= Received: from CO1PR11MB5170.namprd11.prod.outlook.com (2603:10b6:303:95::10) by MWHPR11MB1791.namprd11.prod.outlook.com (2603:10b6:300:10f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.16; Fri, 12 Nov 2021 20:25:30 +0000 Received: from CO1PR11MB5170.namprd11.prod.outlook.com ([fe80::6c14:53a:9bad:b7b0]) by CO1PR11MB5170.namprd11.prod.outlook.com ([fe80::6c14:53a:9bad:b7b0%9]) with mapi id 15.20.4690.026; Fri, 12 Nov 2021 20:25:30 +0000 From: "Chen, Mike Ximing" To: "Shetty, Rashmi" , "dev@dpdk.org" CC: "jerinj@marvell.com" , "Van Haaren, Harry" , "Pathak, Pravin" , "McDaniel, Timothy" Subject: RE: [PATCH] event/dlb2: fix delayed_pop test in dlb2_selftest Thread-Topic: [PATCH] event/dlb2: fix delayed_pop test in dlb2_selftest Thread-Index: AQHX1/5kkaszMslagUenIxMKpnoIq6wAVj9Q Date: Fri, 12 Nov 2021 20:25:30 +0000 Message-ID: References: <20211112194857.1342664-1-rashmi.shetty@intel.com> In-Reply-To: <20211112194857.1342664-1-rashmi.shetty@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 673fa5e1-33ce-4383-6572-08d9a61a928f x-ms-traffictypediagnostic: MWHPR11MB1791: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: k8u4/jZH6coh7a9KP0+u65fJCLuA3EHzCJcibMpqQ8htEN9CBX9p/cVmqz9f5dRk30HeX/eJzkoEkaAgtDFN4ma/movRMOCzyXBtbSM47phdfFjNeQP13y7OUMFq4zarEJcvcOdmp0dNFl2fEONCD2t7LM793bJw82wgasmJBrmWTJ+rDqvBoQyuZLFjurzKEZMMb6GjPtfZNW7UYJgVMGLvbPxWBSPDadqNuQr2CeYC+oFfRO8V1bGsY2glfEIejtZSDB/pkyjrBoKIYKFsiOKgT/QMNdk5mqzCXIocWLuFxUCOs3ccUawr598ezxB3AN9bcDOhO+NEjLuBuRY02SlJrEul2oNV/7rZOxKyR+4ktFUtRLkqSHtfwoPpywwSciGUsVOIOm8d73Gp+YiQ0UA0e1NsWV5f9TJyORfsDbA+ebEPSuCqtd8aYwTOWAA6YGx5lY+z1phDIuF8/K7b9W40egl3+J3JmGSwCLjbnHfRZSX+jM5awffRbZJAGv7k17CWsZffC02e54X+seniSeoDNOyiWAoHsUwWjxsA8OIJh9ks1ZwfGeo30Mf5v/+wQCq36kUo5NxTGMyxFevQNfGn4SsI+y4hh7nbIZ1VInjXUFqS+MDHIcdN71osoVrKnLj5kS+JhXJ6rtqj358TzmBCy3IB598Oca/86dtWTZkCnmdR9VSCk/83Bw+0LGBCUW47bAVa5hwedO+w6VaZrg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB5170.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(38100700002)(107886003)(122000001)(26005)(66556008)(64756008)(66476007)(86362001)(52536014)(33656002)(2906002)(76116006)(186003)(82960400001)(508600001)(66946007)(316002)(7696005)(8676002)(55016002)(4326008)(66446008)(54906003)(5660300002)(110136005)(83380400001)(8936002)(71200400001)(9686003)(38070700005)(53546011)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?T5nIaXP1GLDaAQeU9T8EU0I8zc7aZk/KlROAWhyrKTnbMvCueXXi7ZsTRK/i?= =?us-ascii?Q?PO7H5DTC62UfGF2noxn22NnsikZSpdriirub1LWU1ROM4f5i0ZxjDMxOtSNw?= =?us-ascii?Q?iIfcsxn7INyu8a+bj8AJt2F2ikTLTGiPeA3ENq+oKstblm+cQQgNxZvbi5P/?= =?us-ascii?Q?+Ns+57J89A74nn7otoIVCeB7FfovvgG6o/qdtFuFMj5hAIFmtT7cVgARfWcM?= =?us-ascii?Q?do/ZGTvMAl9r89Dr8AA53r0AjZGLBjd9FNUFIHzgyh4VuG5AR211IboT8dge?= =?us-ascii?Q?HDceSyE4ky1SoMWv4FDGtNDHn1t82dCyKCQJxrUkHUghlSPqehpapktoqoE7?= =?us-ascii?Q?tPgfrD1bq2A9kO/0TkilEh+xQjAxcKoealWyfd4W1Y+vw3TVJjuGbG2RTZmj?= =?us-ascii?Q?Wj+c8g41IRWqZwdZ2WSyRmvhKQdF2mY4U80zXcaHpSsi6ohXQ1JJrlSSduwu?= =?us-ascii?Q?EnS6uAmLdKXQx8juhbUU7H9ve8+eU3vzo1WxUjJTdMqlCYThhaw4mHD7y7I1?= =?us-ascii?Q?pX5BB7JdwBeEobTD4nuIhA77fjFarSb8+k/1Vx+nJ9MaVd/3Hm4QInfLU3a1?= =?us-ascii?Q?sY0eNpDkZQ9+v9z/cN1ZBxTG/dxIKPIsB0rLTY8p6GCD7ZjQ4hNVQqBv2U6R?= =?us-ascii?Q?dRrPbjAJhUmxr2bty8IrWWOkpgz91a4bFa+WIxfOhjXYdUD34mMI1srYIG8S?= =?us-ascii?Q?zYENrvbnvzCTHt1xipskVDEWX7iKWjRX97NbEfW6N/4og8DuHuNjFZBw+DY1?= =?us-ascii?Q?MSwqUfiR2LQYC9lPuWm4WxmoWXxQKW3eOgdOl7LHsj9CMNOnOqBaMkYn34YO?= =?us-ascii?Q?+9kz88WEOITCjDT5VSUCQS2V59AT5g/Z2ISqbvx835JaRGiWa9GyQFPw1AxS?= =?us-ascii?Q?kbBE2ZWLsjbUf1TH5QVL2vqBdbhrvjSSGJzYYGpqGVRNIgTdjGvBgIHiYmXB?= =?us-ascii?Q?SEKTwMCkB8H/hRSqsj4D4VAiLrv/DzAfiKmLaRugN3m2G1EUg4P15ZKh4xli?= =?us-ascii?Q?5e4fzRPWAYFoB1pdTeb2Dqd9Zic+40f2QhkSVnzRR0AeqRWNBKVsj8iTQ4P9?= =?us-ascii?Q?RGD+oZrBaq677fCSay10x6tGf1D0p9anonBHPsicrP6ZqX71DABOyWaUOsrx?= =?us-ascii?Q?GlfyObryLYsiS7ghSlXOiP4KZxWB8omQ6X7EgUVuMSBMxBuRfKybFlpXp9yW?= =?us-ascii?Q?hmKOTH+Wgt8bgYC3T9fm8wHZbxE4RVtRfi9KzPQ5jkuotsQFyzZmKuru9qcB?= =?us-ascii?Q?gbxKmV8zIWcibZhC+YXuwkzJH/k7OPAF3y0nJyWj0Bg88J0O1+wlfJfBOV47?= =?us-ascii?Q?PasKeOnTtmHAQoc12RlqLkeK6u8v98M1/+VEm2E+VXYsHK7a+aHljD3r1gYW?= =?us-ascii?Q?eQJow4SjhXj6FnAhwb1fQJ0RmCcrzH21/hW/di9XRh0GiJ4C+ngqzOV32Nwd?= =?us-ascii?Q?38/WiSlRdkRKnb/r78WeChZrjfSpgZAlh6fR1s2YLFHHQVgOfEl0cd0bW9Mz?= =?us-ascii?Q?y/0/UJDIFKPJuES+eWrwNohtCvGbi4Vf98uojWocizd9sbphWnZ3rct+9A8M?= =?us-ascii?Q?8oR61oXrMpif4FQemYYS46dvnj/uEXu+/2xVACirNP3J+j6WqSKE4Kn4yc2p?= =?us-ascii?Q?R4UD0apM7T/84fafB5yo+Ech+N+/HAhVftXBed1EjbGbFjjpP8wJrHuJeN4s?= =?us-ascii?Q?SO6asg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5170.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 673fa5e1-33ce-4383-6572-08d9a61a928f X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Nov 2021 20:25:30.7359 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KkloGAxNWS/qsRMTIkTHAdSIMA2Uuu/w89ccBQrylpLK/1y5EO0Lq0kpLrTOOYYJ4gm3MYN0pdywOqIDSyP9VeJn5B7M91m3Id7lh1LOKcc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1791 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Shetty, Rashmi > Sent: Friday, November 12, 2021 2:49 PM > To: dev@dpdk.org > Cc: jerinj@marvell.com; Van Haaren, Harry ; P= athak, Pravin > ; Chen, Mike Ximing = ; McDaniel, Timothy > ; Shetty, Rashmi > Subject: [PATCH] event/dlb2: fix delayed_pop test in dlb2_selftest >=20 > Number of events scheduled and available for dequeue after token pop was = set to dequeue_depth-1 > instead of dequeue_depth in test_delayed_pop. The expectation is that all= dequeue_depth number of > events can be dequeued once the last event is released. >=20 > Signed-off-by: Rashmi Shetty > --- > drivers/event/dlb2/dlb2_selftest.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) >=20 > diff --git a/drivers/event/dlb2/dlb2_selftest.c b/drivers/event/dlb2/dlb2= _selftest.c > index 5cf66c552c..2113bc2c99 100644 > --- a/drivers/event/dlb2/dlb2_selftest.c > +++ b/drivers/event/dlb2/dlb2_selftest.c > @@ -1354,7 +1354,7 @@ test_delayed_pop(void) > } >=20 > /* Release one more event. This will trigger the token pop, and > - * dequeue_depth - 1 more events will be scheduled to the device. > + * dequeue_depth more events will be scheduled to the device. > */ > ev.op =3D RTE_EVENT_OP_RELEASE; >=20 > @@ -1366,7 +1366,7 @@ test_delayed_pop(void) >=20 > timeout =3D 0xFFFFFFFFF; >=20 > - for (i =3D 0; i < port_conf.dequeue_depth - 1; i++) { > + for (i =3D 0; i < port_conf.dequeue_depth; i++) { > if (rte_event_dequeue_burst(evdev, 0, &ev, 1, timeout) !=3D 1) { > printf("%d: event dequeue expected to succeed\n", > __LINE__); > @@ -1374,14 +1374,6 @@ test_delayed_pop(void) > } > } >=20 > - timeout =3D 0x10000; > - > - if (rte_event_dequeue_burst(evdev, 0, &ev, 1, timeout) !=3D 0) { > - printf("%d: event dequeue expected to fail\n", > - __LINE__); > - goto err; > - } > - > cleanup(); > return 0; >=20 > -- > 2.25.1 Looks good. Reviewed-by: Mike Ximing Chen