DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Wang, Yipeng1" <yipeng1.wang@intel.com>
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "mdr@ashroe.eu" <mdr@ashroe.eu>,
	"Dharmik Thakkar" <Dharmik.Thakkar@arm.com>, nd <nd@arm.com>,
	"Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>,
	nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH] hash: promote APIs to stable
Date: Thu, 14 Oct 2021 01:54:30 +0000	[thread overview]
Message-ID: <CO1PR11MB5172FDEEF9823FD59B527125C3B89@CO1PR11MB5172.namprd11.prod.outlook.com> (raw)
In-Reply-To: <DBAPR08MB5814BF7F347F539E236D2C7198B89@DBAPR08MB5814.eurprd08.prod.outlook.com>

> -----Original Message-----
> From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Sent: Wednesday, October 13, 2021 5:19 PM
> To: Stephen Hemminger <stephen@networkplumber.org>
> Cc: dev@dpdk.org; mdr@ashroe.eu; Wang, Yipeng1
> <yipeng1.wang@intel.com>; Dharmik Thakkar <Dharmik.Thakkar@arm.com>;
> nd <nd@arm.com>; Medvedkin, Vladimir <vladimir.medvedkin@intel.com>;
> nd <nd@arm.com>
> Subject: RE: [dpdk-dev] [PATCH] hash: promote APIs to stable
> 
> <snip>
> 
> >
> > On Wed, 13 Oct 2021 16:38:58 -0500
> > Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> wrote:
> >
> > > --- a/lib/hash/rte_hash.h
> > > +++ b/lib/hash/rte_hash.h
> > > @@ -430,7 +430,6 @@ rte_hash_get_key_with_position(const struct
> > rte_hash *h, const int32_t position,
> > >   *   - 0 if freed successfully
> > >   *   - -EINVAL if the parameters are invalid.
> > >   */
> > > -__rte_experimental
> > >  int
> > >  rte_hash_free_key_with_position(const struct rte_hash *h,
> > >  				const int32_t position);
> >
> >
> > Need to remove @warning EXPERIMENTAL in comment.
> Agreed
> 
> >
> >
> > What about all the other experimental functions in here?
> > It looks like all of them should be promoted.
> I just changed the symbol that was reported by the tool.
> rte_thash_*** were added on 4/19/2021. Vladimir, are you ok with
> promoting them?
> 
> Yipeng, if you are fine, I can promote rte_hash_lookup_with_hash_bulk,
> rte_hash_lookup_with_hash_bulk_data and rte_hash_max_key_id. These
> are around more than a year.
[Wang, Yipeng] 
Thanks Honnappa, please go ahead and have them in your patch. Thanks a lot!

  reply	other threads:[~2021-10-14  1:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-13 21:38 Honnappa Nagarahalli
2021-10-13 22:41 ` Stephen Hemminger
2021-10-14  0:19   ` Honnappa Nagarahalli
2021-10-14  1:54     ` Wang, Yipeng1 [this message]
2021-10-14 16:46     ` Medvedkin, Vladimir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB5172FDEEF9823FD59B527125C3B89@CO1PR11MB5172.namprd11.prod.outlook.com \
    --to=yipeng1.wang@intel.com \
    --cc=Dharmik.Thakkar@arm.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=dev@dpdk.org \
    --cc=mdr@ashroe.eu \
    --cc=nd@arm.com \
    --cc=stephen@networkplumber.org \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).