From: "Walsh, Conor" <conor.walsh@intel.com>
To: "Laatz, Kevin" <kevin.laatz@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Laatz, Kevin" <kevin.laatz@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: RE: [PATCH] dma/idxd: fix return value for pci device commands
Date: Tue, 7 Jun 2022 10:56:59 +0000 [thread overview]
Message-ID: <CO1PR11MB5201E39F5B766EA5DE106DD8FFA59@CO1PR11MB5201.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220408141655.1320288-1-kevin.laatz@intel.com>
> Subject: [PATCH] dma/idxd: fix return value for pci device commands
>
> When sending a command to an idxd device via pci bar, the response from
> HW is checked to ensure it was successful. The response was incorrectly
> being negated before being returned by the function, meaning error codes
> cannot be checked against the HW specification.
>
> This patch fixes the return values of the function by removing the
> negation.
>
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> ---
Acked-by: Conor Walsh <conor.walsh@intel.com>
next prev parent reply other threads:[~2022-06-07 10:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 14:16 Kevin Laatz
2022-06-07 10:56 ` Walsh, Conor [this message]
2022-06-08 8:54 ` Thomas Monjalon
2022-06-08 8:57 ` Kevin Laatz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB5201E39F5B766EA5DE106DD8FFA59@CO1PR11MB5201.namprd11.prod.outlook.com \
--to=conor.walsh@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).