From: Ashwin Sekhar T K <asekhar@marvell.com>
To: Jerin Jacob <jerinj@marvell.com>,
Nawal Kishor <nkishor@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>,
Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar Kokkilagadda <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>,
Harman Kalra <hkalra@marvell.com>
Cc: Nawal Kishor <nkishor@marvell.com>
Subject: RE: [PATCH v2] common/cnxk: fix atomic load in batch ops
Date: Thu, 23 Jan 2025 04:33:50 +0000 [thread overview]
Message-ID: <CO1PR18MB454096E723033D85807D89F8BFE02@CO1PR18MB4540.namprd18.prod.outlook.com> (raw)
In-Reply-To: <BY3PR18MB478575A81A4468CB686A279CC8E12@BY3PR18MB4785.namprd18.prod.outlook.com>
Yes. It is a candidate for backport.
Thanks
Ashwin
> -----Original Message-----
> From: Jerin Jacob <jerinj@marvell.com>
> Sent: Wednesday, January 22, 2025 10:31 PM
> To: Nawal Kishor <nkishor@marvell.com>; dev@dpdk.org; Nithin Kumar
> Dabilpuram <ndabilpuram@marvell.com>; Kiran Kumar Kokkilagadda
> <kirankumark@marvell.com>; Sunil Kumar Kori <skori@marvell.com>; Satha
> Koteswara Rao Kottidi <skoteshwar@marvell.com>; Harman Kalra
> <hkalra@marvell.com>; Ashwin Sekhar T K <asekhar@marvell.com>
> Cc: Nawal Kishor <nkishor@marvell.com>
> Subject: RE: [PATCH v2] common/cnxk: fix atomic load in batch ops
>
>
>
> > -----Original Message-----
> > From: Nawal Kishor <nkishor@marvell.com>
> > Sent: Monday, December 2, 2024 10:28 PM
> > To: dev@dpdk.org; Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>;
> > Kiran Kumar Kokkilagadda <kirankumark@marvell.com>; Sunil Kumar Kori
> > <skori@marvell.com>; Satha Koteswara Rao Kottidi
> > <skoteshwar@marvell.com>; Harman Kalra <hkalra@marvell.com>; Ashwin
> > Sekhar T K <asekhar@marvell.com>; Jerin Jacob <jerinj@marvell.com>
> > Cc: Nawal Kishor <nkishor@marvell.com>
> > Subject: [PATCH v2] common/cnxk: fix atomic load in batch ops
> >
> > In roc batch alloc wait code, __ATOMIC_RELAXED is changed to
> > __ATOMIC_ACQUIRE in order to avoid potential out of order loads.
> >
> > Fixes: 50d08d3934ec ("common/cnxk: fix batch alloc completion poll
> > logic")
> >
> > Signed-off-by: Nawal Kishor <nkishor@marvell.com>
>
> Fixed the following issues and applied to dpdk-next-net-mrvl/for-main.
> Thanks
>
> Is it candidate for Cc: stable@dpdk.org backport?
> common/cnxk: fix atomic load in batch ops Contributor name/email
> mismatch with .mailmap:
> Nawal Kishor <nkishor@marvell.com> is unknown in .mailmap
>
>
> > ---
> > v2: Fixed review comments
> >
> > drivers/common/cnxk/roc_npa.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/common/cnxk/roc_npa.h
> > b/drivers/common/cnxk/roc_npa.h index f7cb4460e7..8525038810
> 100644
> > --- a/drivers/common/cnxk/roc_npa.h
> > +++ b/drivers/common/cnxk/roc_npa.h
> > @@ -255,7 +255,7 @@ roc_npa_batch_alloc_wait(uint64_t *cache_line,
> > unsigned int wait_us)
> > /* Batch alloc status code is updated in bits [5:6] of the first word
> > * of the 128 byte cache line.
> > */
> > - while (((__atomic_load_n(cache_line, __ATOMIC_RELAXED) >> 5) &
> > 0x3) ==
> > + while (((__atomic_load_n(cache_line, __ATOMIC_ACQUIRE) >> 5) &
> > 0x3) ==
> > ALLOC_CCODE_INVAL)
> > if (wait_us && (plt_tsc_cycles() - start) >= ticks)
> > break;
> > --
> > 2.34.1
prev parent reply other threads:[~2025-01-23 4:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 6:51 [PATCH] common/cnxk: use atomic load acquire " Nawal Kishor
2024-09-19 18:13 ` Jerin Jacob
2024-12-02 16:57 ` [PATCH v2] common/cnxk: fix atomic load " Nawal Kishor
2025-01-22 17:00 ` Jerin Jacob
2025-01-23 4:33 ` Ashwin Sekhar T K [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR18MB454096E723033D85807D89F8BFE02@CO1PR18MB4540.namprd18.prod.outlook.com \
--to=asekhar@marvell.com \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=nkishor@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).