From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13A1A460F3; Thu, 23 Jan 2025 05:33:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4F2E940294; Thu, 23 Jan 2025 05:33:56 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 75F9940279 for ; Thu, 23 Jan 2025 05:33:54 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50N0tRGk020166 for ; Wed, 22 Jan 2025 20:33:53 -0800 Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2174.outbound.protection.outlook.com [104.47.59.174]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 44bbn2r9vx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 22 Jan 2025 20:33:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lPbiwtntXjDlEah5jIg7ovsJnLoWLhEnchRdZmTg4Wmfs/7JxJZOs9iJXcQaHHIxawuB3lniMNDc7U14VKxQuvo+Y3gsX5+MfCyGNNTlccQribBL6MveqwN/WZDQjQNmUYOmPnGDPG0JmmEjfZKP6eJ3RFInu3tHce4PNF7x/ACx8DLF0k5TQ8X/dIR3YpTu7L2TP8JBhf5ffHq14DGf5GM9K9eUTEGUOaq/xaeWLgZn7rq909nPZH4lXq5pwyP6rfm5nNTeX1zy6ChwQt8rlI9Z0kCndBY/ljYnBHLtvX7LTwEEFPDJYxX5aRnftNjR92BHQszJDOYmOXXXgX18iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gjvwQmFUeroyYj4qPlCPuVg2mwrLO2F5oakXxrrFS7M=; b=D8hnz5XcBGJUlfbCE5rYxTbpGqxpVAHcnQUidJwwPFttgzqfi+Kd1inUuPQ+BC4jgMbafheSLlw5h1Nn7kfp1m3qae5LfMIlFdrCsf7etCNpTOdOjmGxe3MLmBHumS+mawRFnAT00ZOAlIH06M2XAdnx6bRtS2gVLhTdyR5CDV8SIVTG9S9vo9fDQ5JRNKVkR2xipVGIIloRVa+uuy7ajAm0DcXyQH3en/IPvPmu4aSaEjOEboFIeVoe0raMV32QloZhd9SDkfgzs2S0BvffuGd/4tE7HRrB1s2NRvnk7yz45tqCGWYV0XoVamUIllBLyilSJZ98AbBBG3RikYiFXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gjvwQmFUeroyYj4qPlCPuVg2mwrLO2F5oakXxrrFS7M=; b=qI+wQbHqYCOyF9pWkDneCwYpNSw988JaBDDCXdti+l/PVXHwlAoUpkR0Bnfmic5ih+MlGntsw4liX0jm6846BUICRe6VZMrfnDDOtfvN6ltr9VG/fii1mN6v9UXa9KFeYfgHTrBrb9vwSoXofpA/F+l3CKlJU2uvnTJRmq+PUIw= Received: from CO1PR18MB4540.namprd18.prod.outlook.com (2603:10b6:303:ff::13) by DM4PR18MB4126.namprd18.prod.outlook.com (2603:10b6:5:39a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.17; Thu, 23 Jan 2025 04:33:51 +0000 Received: from CO1PR18MB4540.namprd18.prod.outlook.com ([fe80::ce95:46c3:6f02:8b8f]) by CO1PR18MB4540.namprd18.prod.outlook.com ([fe80::ce95:46c3:6f02:8b8f%4]) with mapi id 15.20.8377.009; Thu, 23 Jan 2025 04:33:50 +0000 From: Ashwin Sekhar T K To: Jerin Jacob , Nawal Kishor , "dev@dpdk.org" , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda , Sunil Kumar Kori , Satha Koteswara Rao Kottidi , Harman Kalra CC: Nawal Kishor Subject: RE: [PATCH v2] common/cnxk: fix atomic load in batch ops Thread-Topic: [PATCH v2] common/cnxk: fix atomic load in batch ops Thread-Index: AQHbRNtdd6fW2GGFHkeiFcq71InOrrMjVLKAgADBbfA= Date: Thu, 23 Jan 2025 04:33:50 +0000 Message-ID: References: <20240823065104.2254919-1-nkishor@marvell.com> <20241202165739.1896876-1-nkishor@marvell.com> In-Reply-To: Accept-Language: en-US, en-GB Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR18MB4540:EE_|DM4PR18MB4126:EE_ x-ms-office365-filtering-correlation-id: 0a78af83-19e9-4dd7-ab81-08dd3b67225f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|1800799024|38070700018|7053199007; x-microsoft-antispam-message-info: =?us-ascii?Q?Sd7cpP+W2KNO7qNlEBYA7o+mUNVbG3l6OH46IdEUwiZX2c6Qt+LTq6fRS5DH?= =?us-ascii?Q?F/u4RgSphvuqk26fn39mdmWi/O+yjEgwvxXcY0iwgnwRu4VjRjjQ3/ZJ2iQ5?= =?us-ascii?Q?Y87pf9GbnwnGNUKXYU7xdV/b6RnqT/qYJOo61rDK+piL6qRarFulNXBeTn3D?= =?us-ascii?Q?2sK0vmAIgzvyFVzmHEwbGCOue/x/3wKsKOBb9KBuZ6yzLrEDkfRwE9woRhy6?= =?us-ascii?Q?xheI9qbXvzGik+aC3HxMYYAPepy/PqZV/vt+8vwcOuTrUHXn59ka2ho4ST+w?= =?us-ascii?Q?L74feP5biLnjJAw2VSxAFqIVtbgT+InkKDC627izKCFOWZT42qY2UwQIwsk7?= =?us-ascii?Q?K+Z1+im+EMIoDpjE+FcysPF2xzIEQ19BUK7H18ttgPmNxZwFwoeyVRxFWH3Z?= =?us-ascii?Q?G+4cH+n4BSLE9tydsSotDfx99uoXDapRuU1pSWXq63wBfoikm1YcVzNRk9Z+?= =?us-ascii?Q?DAcDy35BcKAFNk/mp4smLh/Fl+IuRThh6xJK9P6w1D4gpI8DSUmsl+Rocgmd?= =?us-ascii?Q?N/f4YZTKM2BxQwiBBrAQPU3TPPKgPrxqp5mbEo1l5lVwGBrbrx+I6PjL1C5y?= =?us-ascii?Q?f6L/p0Wmas2kvDjslPLEC4y5kILTlB6Lg49XFFpSVF/3gSgVDYe2s0cHqugA?= =?us-ascii?Q?kJIG7FAA50WSv7TP/qzp95s2kglWYp8O6ni+SLtFNKAGp0SuDCZUqxSRnFJ8?= =?us-ascii?Q?ZVqde/MkT8ePqOGJEVG7lk+KmBdN1N4Xw+YHLqWBpXzbiMXdORt8OeOMUpBE?= =?us-ascii?Q?ilFVn8svNoTzdNh6j2d9+6DifLoUKKDJSDPpJM+5nvwx0Zx2FNUlWYZciaLd?= =?us-ascii?Q?3odWIWO7YX0NP7ZGTJuEQme9mT5wnQciemTZLKIwf9+p9cc0uVxBiM94IWxb?= =?us-ascii?Q?N3pAjRm7F8Vm2GFxzj4Jt2WEsjxuzT728+IU7XMThax5yzYPJjd48aQvYzPi?= =?us-ascii?Q?hBmbcB6olFLYRkkpxSaEtOpTAqmjTEKQVZHckd5PLPN19RH7jQUXgNhcI8bD?= =?us-ascii?Q?yY5M0lhB2ldw3lBXs/JztWYz2nfd7aOFnQzCqLSvSB+pn2fitAoaSiS2Gvsh?= =?us-ascii?Q?IKUk86dteJ6LtWOsK01rKwyUPmP812cWoP2CoSrdu51kZFlxC+17leQpyR/o?= =?us-ascii?Q?yxEoH+M4tWPDDDLuEzdZTqk2r7Tq6PZZpCgUzNNPjMescYDDoRe9U6Goox+u?= =?us-ascii?Q?IZ3wKynsEVp9XKVPFqD24uCSg+/PkuSP5+MLRzG6A8Mgn2OWN3/HfpKafsV8?= =?us-ascii?Q?J11gjFqefTB+/mBfMSvdl+HARPdh6H4GhrmNj1FCkHRM/vEg+p4hKL+NGTmM?= =?us-ascii?Q?pdh1VqBNLQoiFv87v2dMoibpM4dsUZXGBJ73ov6kBmAEuz/20MJPXOunhbMu?= =?us-ascii?Q?xBAj+EZQEZo6IKo1+uZ9Ea2VJQkC6kudDxkFUJju2rPX/pvmMYqbbyhSEevJ?= =?us-ascii?Q?9r84sjAH985G7+Bavljnkr1hfXm1sEaM?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR18MB4540.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(38070700018)(7053199007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9clNYjw79P6SZZKItSgAuzlqC31B9/MGgWiqqb+KjO7FbK1Nqo/2lr1xB90U?= =?us-ascii?Q?oF0oD/jIXBgpBS31733Oaumcv8DjZwccRDWTUHUOOzZaF9Uut2/6MNxVUbok?= =?us-ascii?Q?mu5jqnkEftZMq+4lRoONEDQ4wWY1hhseuX9fGjlzP2nY1ClZugAUVrXa8Bq6?= =?us-ascii?Q?B9FQobUktt/KWs1oDzoTZIC6sxdkSsmUaUPw7nP9CYiKd59Jy7pwf3LuK6iU?= =?us-ascii?Q?Mmz9L2m3ChWVvIpG6Vosz6dkmHjXI9g4I8pKR07fDkC8JvjYb3VFzj9I4/tE?= =?us-ascii?Q?6SHifaeM7+J6w9uTt1mh9f22c7vyNFLJQ88nfk4vtV4+5YagufXRnZfchTgO?= =?us-ascii?Q?rQlShBdaby8ZvhLdOAKcH0/QvRphC4p//51XIjtiSzJG3o1Eaj+VbrK1cM9h?= =?us-ascii?Q?wZfV7CljEY3X4iXbq/X8jW3GjOrPZvM8twIZ8R2m8a6FnGwXs4x/mGL2kq8H?= =?us-ascii?Q?sElwI3ZpkYAIEvCcDhoIqzlKeTPJaBO38tSQitKd/Yc7JchF9qOYpw7Rbt++?= =?us-ascii?Q?suRdpxlQ1YxTTLDwrEDZW9BSnKPdPOYond76PRSj2Yigs+whBUrD+nvKRYHA?= =?us-ascii?Q?+rv6Bcqtk12TJWtFJDSIhnWGd4NlL9uoywGfpwUUsjPEz+XvZfPleDEUMbRo?= =?us-ascii?Q?NtXJZ1dnzljORja9YvEcWGhA8e4F5xa8BJ5hwHAKs6YqGfc/hI4hT0gkFsts?= =?us-ascii?Q?tvpEQ5er1xRIynkocoAAaQcPtWwkilo9ErjJIh7rxbyZDLk8bV38B6EZnI6U?= =?us-ascii?Q?FH+HlieAstsFHJOcw3I5rPU4/xX5pXInUVpJYDNvNl5OHwCPEn6vhYfKjO5r?= =?us-ascii?Q?pCBDMGhxFl7eRCu1tyXF/eP4XzkDAmcYvnO/aGDYPZsYiEaQ8aqNRUHMMTpv?= =?us-ascii?Q?IfS8l9PQ40snQiXej7kcg4rTiu862DT+XR0ZXPisa2QNMhB0/Maghfj54jp0?= =?us-ascii?Q?I4qG1q2kLPcpsvxB6gqx4+dVY8/fqAiLTJ1PPGqHObX99FCEOhuOniWfer5s?= =?us-ascii?Q?/cYlOAhPgWS+TfK4FuO/ypcqcgsar+Hfx18FxnH8w8A1UMU2VwpLv0w7hekX?= =?us-ascii?Q?ANBHCrhv6vWLwDavXxpwDmZLeAdW7hc/T3PLmd4tdJ3WRPZvdPkkkoT8TzDh?= =?us-ascii?Q?PjfFfvw0iSGlLgR5ElcvdKgeMtFP13r5XZ0yPDIJOMy9dj8Ahv8yw/BP+6c4?= =?us-ascii?Q?JccggR5aJdXkyX0PbwtQ1ys8pTFLBpYL6ZcULI8y1x6nB8tDRgbGiX6MnmCT?= =?us-ascii?Q?KlsKammFM65GpBOHZLhanxN5ltHSIOhEc+BrzwWgEkjJMzRJEQdywTkO8nvk?= =?us-ascii?Q?K93eKrBb68/Fysy0fnZAFIvo2KgkIRiynLS3WTNQ+xrzJKH3yS57+xuUqG24?= =?us-ascii?Q?//Z+G1o6q0d7ib2b+Y5QO7IK2+VqR/U6KtfJ533Z6YWtsvMwD2UpYZDND9ag?= =?us-ascii?Q?yjB60wcf0xm+w2v34QyVrpTdbdzXTk+QLmJFLYnhG5ssrL3J1K4GcbHr2Dj2?= =?us-ascii?Q?5JJQERsXooNa7qPDjCK9DPxHoY+ceWKus92VNGFM60Tf4XRp4W+oypcB/8LN?= =?us-ascii?Q?Xd13yYm8uchVWENaaV/CIfhB0taUOTxVFP1QodyS?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR18MB4540.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a78af83-19e9-4dd7-ab81-08dd3b67225f X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2025 04:33:50.0718 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TwFAzgFv9GqPVVTOjYpZoPYMRSyGyh4ACxChMN9Pb+ydCeRNA7uwFSjOY1o1+MdspmuMpbw/ebM14P+OV5L5pw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR18MB4126 X-Proofpoint-ORIG-GUID: JMwOJPdWntnvgcAAu1jYrMOCfMksM7r4 X-Proofpoint-GUID: JMwOJPdWntnvgcAAu1jYrMOCfMksM7r4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-23_01,2025-01-22_02,2024-11-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Yes. It is a candidate for backport. Thanks Ashwin > -----Original Message----- > From: Jerin Jacob > Sent: Wednesday, January 22, 2025 10:31 PM > To: Nawal Kishor ; dev@dpdk.org; Nithin Kumar > Dabilpuram ; Kiran Kumar Kokkilagadda > ; Sunil Kumar Kori ; Satha > Koteswara Rao Kottidi ; Harman Kalra > ; Ashwin Sekhar T K > Cc: Nawal Kishor > Subject: RE: [PATCH v2] common/cnxk: fix atomic load in batch ops >=20 >=20 >=20 > > -----Original Message----- > > From: Nawal Kishor > > Sent: Monday, December 2, 2024 10:28 PM > > To: dev@dpdk.org; Nithin Kumar Dabilpuram ; > > Kiran Kumar Kokkilagadda ; Sunil Kumar Kori > > ; Satha Koteswara Rao Kottidi > > ; Harman Kalra ; Ashwin > > Sekhar T K ; Jerin Jacob > > Cc: Nawal Kishor > > Subject: [PATCH v2] common/cnxk: fix atomic load in batch ops > > > > In roc batch alloc wait code, __ATOMIC_RELAXED is changed to > > __ATOMIC_ACQUIRE in order to avoid potential out of order loads. > > > > Fixes: 50d08d3934ec ("common/cnxk: fix batch alloc completion poll > > logic") > > > > Signed-off-by: Nawal Kishor >=20 > Fixed the following issues and applied to dpdk-next-net-mrvl/for-main. > Thanks >=20 > Is it candidate for Cc: stable@dpdk.org backport? > common/cnxk: fix atomic load in batch ops Contributor name/email > mismatch with .mailmap: > Nawal Kishor is unknown in .mailmap >=20 >=20 > > --- > > v2: Fixed review comments > > > > drivers/common/cnxk/roc_npa.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/common/cnxk/roc_npa.h > > b/drivers/common/cnxk/roc_npa.h index f7cb4460e7..8525038810 > 100644 > > --- a/drivers/common/cnxk/roc_npa.h > > +++ b/drivers/common/cnxk/roc_npa.h > > @@ -255,7 +255,7 @@ roc_npa_batch_alloc_wait(uint64_t *cache_line, > > unsigned int wait_us) > > /* Batch alloc status code is updated in bits [5:6] of the first word > > * of the 128 byte cache line. > > */ > > - while (((__atomic_load_n(cache_line, __ATOMIC_RELAXED) >> 5) & > > 0x3) =3D=3D > > + while (((__atomic_load_n(cache_line, __ATOMIC_ACQUIRE) >> 5) & > > 0x3) =3D=3D > > ALLOC_CCODE_INVAL) > > if (wait_us && (plt_tsc_cycles() - start) >=3D ticks) > > break; > > -- > > 2.34.1