DPDK patches and discussions
 help / color / mirror / Atom feed
From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
To: Emma Finn <emma.finn@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "kai.ji@intel.com" <kai.ji@intel.com>
Subject: RE: [EXTERNAL] [PATCH] examples/fips_validation: fix dangling pointer for SHA test
Date: Thu, 28 Aug 2025 09:42:22 +0000	[thread overview]
Message-ID: <CO1PR18MB471416C114E8D59E97EEBE2FCB3BA@CO1PR18MB4714.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20250828092822.2791101-1-emma.finn@intel.com>

> Set vector pointer to NULL after free to avoid calling rte_free() on the same
> pointer twice in some cases.
> 
> Signed-off-by: Emma Finn <emma.finn@intel.com>
> ---
>  examples/fips_validation/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c
> index f21826e9d7..60ee9f8dd4 100644
> --- a/examples/fips_validation/main.c
> +++ b/examples/fips_validation/main.c
> @@ -2612,7 +2612,7 @@ fips_mct_sha_test(void)
>  		rte_free(md[i].val);
> 
>  	rte_free(vec.pt.val);
> -
> +	vec.pt.val = NULL;

Same could be the case for fips_mct_shake_test also.

Thanks,
Gowrishankar
>  	rte_free(val.val);
>  	return 0;
>  }
> --
> 2.34.1


      reply	other threads:[~2025-08-28  9:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-28  9:28 Emma Finn
2025-08-28  9:42 ` Gowrishankar Muthukrishnan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR18MB471416C114E8D59E97EEBE2FCB3BA@CO1PR18MB4714.namprd18.prod.outlook.com \
    --to=gmuthukrishn@marvell.com \
    --cc=dev@dpdk.org \
    --cc=emma.finn@intel.com \
    --cc=kai.ji@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).