[PATCH] crypto/openssl: fix SM2 for older openssl version

[PATCH] crypto/openssl: fix SM2 for older openssl version

[Ciara Power]

Currently when configuring the session for SM2 asym on OpenSSL PMD using
an older OpenSSL version than 3.0, an error returns,
showing a failure status for tests.

This should skip tests, as the SM2 support is for OpenSSL version 3.0+.

Fixes: 3b7d638fb11f ("crypto/openssl: support asymmetric SM2")
Cc: gmuthukrishn@marvell.com

Signed-off-by: Ciara Power <ciara.power@intel.com>
---
 drivers/crypto/openssl/rte_openssl_pmd_ops.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
index fe38e4ebd8..9497da41ef 100644
--- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
+++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
@@ -1324,6 +1324,9 @@ static int openssl_set_asym_session_parameters(
 			OSSL_PARAM_free(asym_session->u.sm2.params);
 
 		return -1;
+#else
+		OPENSSL_LOG(WARNING, "SM2 unsupported for OpenSSL Version < 3.0");
+		return -ENOTSUP;
 #endif
 	}
 	default:
-- 
2.25.1

Re: [PATCH] crypto/openssl: fix SM2 for older openssl version

[Ji, Kai]

[-- Attachment #1: Type: text/plain, Size: 1478 bytes --]

Acked-by: Kai Ji <kai.ji@intel.com<mailto:kai.ji@intel.com>>
________________________________
From: Power, Ciara <ciara.power@intel.com>
Sent: 15 June 2023 09:03
To: dev@dpdk.org <dev@dpdk.org>
Cc: Power, Ciara <ciara.power@intel.com>; gmuthukrishn@marvell.com <gmuthukrishn@marvell.com>; Ji, Kai <kai.ji@intel.com>
Subject: [PATCH] crypto/openssl: fix SM2 for older openssl version

Currently when configuring the session for SM2 asym on OpenSSL PMD using
an older OpenSSL version than 3.0, an error returns,
showing a failure status for tests.

This should skip tests, as the SM2 support is for OpenSSL version 3.0+.

Fixes: 3b7d638fb11f ("crypto/openssl: support asymmetric SM2")
Cc: gmuthukrishn@marvell.com

Signed-off-by: Ciara Power <ciara.power@intel.com>
---
 drivers/crypto/openssl/rte_openssl_pmd_ops.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
index fe38e4ebd8..9497da41ef 100644
--- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
+++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
@@ -1324,6 +1324,9 @@ static int openssl_set_asym_session_parameters(
                         OSSL_PARAM_free(asym_session->u.sm2.params);

                 return -1;
+#else
+               OPENSSL_LOG(WARNING, "SM2 unsupported for OpenSSL Version < 3.0");
+               return -ENOTSUP;
 #endif
         }
         default:
--
2.25.1


[-- Attachment #2: Type: text/html, Size: 2918 bytes --]

RE: [EXT] [PATCH] crypto/openssl: fix SM2 for older openssl version

[Gowrishankar Muthukrishnan]

Acked-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>

Thanks,
Gowrishankar

> -----Original Message-----
> From: Ciara Power <ciara.power@intel.com>
> Sent: Thursday, June 15, 2023 1:33 PM
> To: dev@dpdk.org
> Cc: Ciara Power <ciara.power@intel.com>; Gowrishankar Muthukrishnan
> <gmuthukrishn@marvell.com>; Kai Ji <kai.ji@intel.com>
> Subject: [EXT] [PATCH] crypto/openssl: fix SM2 for older openssl version
> 
> External Email
> 
> ----------------------------------------------------------------------
> Currently when configuring the session for SM2 asym on OpenSSL PMD using an
> older OpenSSL version than 3.0, an error returns, showing a failure status for
> tests.
> 
> This should skip tests, as the SM2 support is for OpenSSL version 3.0+.
> 
> Fixes: 3b7d638fb11f ("crypto/openssl: support asymmetric SM2")
> Cc: gmuthukrishn@marvell.com
> 
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
>  drivers/crypto/openssl/rte_openssl_pmd_ops.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> index fe38e4ebd8..9497da41ef 100644
> --- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> +++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> @@ -1324,6 +1324,9 @@ static int openssl_set_asym_session_parameters(
>  			OSSL_PARAM_free(asym_session->u.sm2.params);
> 
>  		return -1;
> +#else
> +		OPENSSL_LOG(WARNING, "SM2 unsupported for OpenSSL
> Version < 3.0");
> +		return -ENOTSUP;
>  #endif
>  	}
>  	default:
> --
> 2.25.1

RE: [EXT] [PATCH] crypto/openssl: fix SM2 for older openssl version

[Akhil Goyal]

> Currently when configuring the session for SM2 asym on OpenSSL PMD using
> an older OpenSSL version than 3.0, an error returns,
> showing a failure status for tests.
> 
> This should skip tests, as the SM2 support is for OpenSSL version 3.0+.
> 
> Fixes: 3b7d638fb11f ("crypto/openssl: support asymmetric SM2")
> Cc: gmuthukrishn@marvell.com
> 
> Signed-off-by: Ciara Power <ciara.power@intel.com>
Applied to dpdk-next-crypto
Thanks.