From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50A744305C; Mon, 14 Aug 2023 09:49:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE3EE410DC; Mon, 14 Aug 2023 09:49:18 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 66B5340A7F for ; Mon, 14 Aug 2023 09:49:17 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37E7jvV4011744; Mon, 14 Aug 2023 00:49:16 -0700 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2101.outbound.protection.outlook.com [104.47.58.101]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3sfg1pr0vr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Aug 2023 00:49:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kpX4Dkan5AfvTxPAAcnLT52lpaty2gMvstG9l895HepxaumhXEn6ABGPSAXXSC8AzV7nZvT2vmDbjOCwiJNAgedXldjZ3zxNSrANG+u9UpfYFjaYAGCzlqgizP1JreHlkiqgBSlPIXVDgUKWMMEC3hB4H6k2ZexU1+ssptN8G9jdCfmdRDTnBluF5SjinXaDlX172HfSbD+2YS46TMHXS69jeQXt6H47t0YjkP54nF+YzNTE095kxq2p/FhSrnMpW+KUhXE07GsnF0xnDIweOR8iP/dF/gTMsqv1DHXyxSFSEmik8nfsfYFPsX4M/Wlii4vgb0BhFO4OHk0ty57uDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LMBpaBsEiPWVJK3+XnkLB5Z+fu0fHpYjLWKU8qKedIc=; b=a/geRqZYp+loG5e0BwmwwEb/H2vBpUP13Ui0UKZo1LeuiUxn0GJ8RGk8YLtxT0p3sz7GUfs+1K++dxmQGp4EGzfC54Dj1fEyLANtswuxzNKAB8XH2KslSwJSd/Bgc9YZ9knM0MHxRW6u9dABqXANgFfg2Kxf2UB7+3Y6fBUIy3nkbviNP3I/K+Jyn0CMUXgTL4BSPlunJ7Qn6gFmu+Nv5KU5NOcFLq8qE95XuFUmjQeS7X0fsHxyslBOdGv7Oivj2v7broeJlHi9c3B7+9PX9uNdKepzw57JkLfDuVOV1GBjms4vViUVerd3W+NwCRPW3cT4K4qA42qdMyaZmbqMWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LMBpaBsEiPWVJK3+XnkLB5Z+fu0fHpYjLWKU8qKedIc=; b=pNwHO3/eC9LJ+wqEODaV9HNv5TRBZNkU/1u9fP8xbXZ8fY/T8Q37cqCUxlyhruHs9mJbNkyTf7UuEyxMNJy+g08wsRsxph4yzMiTSiz05zadz5XfnzWbRRTYdmJVuNxUELBUjifdWk4ale3+JLQoLN5KncvaYve9+jBMxySVENQ= Received: from CO1PR18MB4714.namprd18.prod.outlook.com (2603:10b6:303:e9::18) by PH0PR18MB4954.namprd18.prod.outlook.com (2603:10b6:510:119::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.24; Mon, 14 Aug 2023 07:49:11 +0000 Received: from CO1PR18MB4714.namprd18.prod.outlook.com ([fe80::19a:75f1:ff79:f17b]) by CO1PR18MB4714.namprd18.prod.outlook.com ([fe80::19a:75f1:ff79:f17b%5]) with mapi id 15.20.6678.025; Mon, 14 Aug 2023 07:49:11 +0000 From: Gowrishankar Muthukrishnan To: Arkadiusz Kusztal , "dev@dpdk.org" CC: Akhil Goyal , "kai.ji@intel.com" , "ciara.power@intel.com" Subject: RE: [EXT] [RFC] cryptodev: refactor sm2, add plain message flag Thread-Topic: [EXT] [RFC] cryptodev: refactor sm2, add plain message flag Thread-Index: AQHZzHrZ6xu92KoDjUKOY1OFaOWhBa/pYxCg Date: Mon, 14 Aug 2023 07:49:11 +0000 Message-ID: References: <20230811173944.2550303-1-arkadiuszx.kusztal@intel.com> In-Reply-To: <20230811173944.2550303-1-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: =?us-ascii?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcZ211dGh1a3Jp?= =?us-ascii?Q?c2huXGFwcGRhdGFccm9hbWluZ1wwOWQ4NDliNi0zMmQzLTRhNDAtODVlZS02?= =?us-ascii?Q?Yjg0YmEyOWUzNWJcbXNnc1xtc2ctMGJjOWNmYTYtM2E3Ny0xMWVlLWEwYTYt?= =?us-ascii?Q?NTQ4ZDVhZTlkZGUxXGFtZS10ZXN0XDBiYzljZmE4LTNhNzctMTFlZS1hMGE2?= =?us-ascii?Q?LTU0OGQ1YWU5ZGRlMWJvZHkudHh0IiBzej0iODMyOSIgdD0iMTMzMzY0NzI5?= =?us-ascii?Q?NDc4NDg1NzY1IiBoPSJPUHU0K1daNk1HU0hLbXJOeitybWs2NnF3cm89IiBp?= =?us-ascii?Q?ZD0iIiBibD0iMCIgYm89IjEiIGNpPSJjQUFBQUVSSFUxUlNSVUZOQ2dVQUFO?= =?us-ascii?Q?NFBBQUFGbHlIT2c4N1pBVDFaZjdTcVRzOHFQVmwvdEtwT3p5b1pBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBSEFBQUFCdUR3QUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBRUFBUUVCQUFBQUk3cVRwQUNBQVFBQUFBQUFBQUFBQUo0QUFBQmhB?= =?us-ascii?Q?R1FBWkFCeUFHVUFjd0J6QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdNQWRRQnpBSFFBYndCdEFG?= =?us-ascii?Q?OEFjQUJsQUhJQWN3QnZBRzRBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFB?= =?us-ascii?Q?QUNBQUFBQUFDZUFBQUFZd0IxQUhNQWRBQnZBRzBBWHdCd0FHZ0Fid0J1QUdV?= =?us-ascii?Q?QWJnQjFBRzBBWWdCbEFISUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFC?= =?us-ascii?Q?akFIVUFjd0IwQUc4QWJRQmZBSE1BY3dCdUFGOEFaQUJoQUhNQWFBQmZBSFlB?= =?us-ascii?Q?TUFBeUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refone: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5n?= =?us-ascii?Q?QUFBR01BZFFCekFIUUFid0J0QUY4QWN3QnpBRzRBWHdCckFHVUFlUUIzQUc4?= =?us-ascii?Q?QWNnQmtBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQVl3QjFBSE1BZEFC?= =?us-ascii?Q?dkFHMEFYd0J6QUhNQWJnQmZBRzRBYndCa0FHVUFiQUJwQUcwQWFRQjBBR1VB?= =?us-ascii?Q?Y2dCZkFIWUFNQUF5QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFB?= =?us-ascii?Q?QUFBQUFBQUlBQUFBQUFKNEFBQUJqQUhVQWN3QjBBRzhBYlFCZkFITUFjd0J1?= =?us-ascii?Q?QUY4QWN3QndBR0VBWXdCbEFGOEFkZ0F3QURJQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFB?= =?us-ascii?Q?bmdBQUFHUUFiQUJ3QUY4QWN3QnJBSGtBY0FCbEFGOEFZd0JvQUdFQWRBQmZB?= =?us-ascii?Q?RzBBWlFCekFITUFZUUJuQUdVQVh3QjJBREFBTWdBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFBWkFCc0FIQUFY?= =?us-ascii?Q?d0J6QUd3QVlRQmpBR3NBWHdCakFHZ0FZUUIwQUY4QWJRQmxBSE1BY3dCaEFH?= =?us-ascii?Q?Y0FaUUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reftwo: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQmtBR3dB?= =?us-ascii?Q?Y0FCZkFIUUFaUUJoQUcwQWN3QmZBRzhBYmdCbEFHUUFjZ0JwQUhZQVpRQmZB?= =?us-ascii?Q?R1lBYVFCc0FHVUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdVQWJRQmhBR2tBYkFCZkFHRUFa?= =?us-ascii?Q?QUJrQUhJQVpRQnpBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUF3QUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNB?= =?us-ascii?Q?QUFBQUFDZUFBQUFiUUJoQUhJQWRnQmxBR3dBWHdCd0FISUFid0JxQUdVQVl3?= =?us-ascii?Q?QjBBRjhBYmdCaEFHMEFaUUJ6QUY4QVl3QnZBRzRBWmdCcEFHUUFaUUJ1QUhR?= =?us-ascii?Q?QWFRQmhBR3dBWHdCaEFHd0Fid0J1QUdVQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCdEFH?= =?us-ascii?Q?RUFjZ0IyQUdVQWJBQmZBSEFBY2dCdkFHb0FaUUJqQUhRQVh3QnVBR0VBYlFC?= =?us-ascii?Q?bEFITUFYd0J5QUdVQWN3QjBBSElBYVFCakFIUUFaUUJrQUY4QVlRQnNBRzhB?= =?us-ascii?Q?YmdCbEFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5nQUFBRzBBWVFCeUFIWUFaUUJzQUY4?= =?us-ascii?Q?QWNBQnlBRzhBYWdCbEFHTUFkQUJmQUc0QVlRQnRBR1VBY3dCZkFISUFaUUJ6?= =?us-ascii?Q?QUhRQWNnQnBBR01BZEFCbEFHUUFYd0JvQUdVQWVBQmpBRzhBWkFCbEFITUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFB?= =?us-ascii?Q?Q0FBQUFBQUNlQUFBQWJRQmhBSElBZGdCbEFHd0FiQUJmQUdFQWNnQnRBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-rorf: true x-dg-refthree: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFB?= =?us-ascii?Q?QUFBQUlBQUFBQUFKNEFBQUJ0QUdFQWNnQjJBR1VBYkFCc0FGOEFad0J2QUc4?= =?us-ascii?Q?QVp3QnNBR1VBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFBbmdB?= =?us-ascii?Q?QUFHMEFZUUJ5QUhZQVpRQnNBR3dBWHdCd0FISUFid0JxQUdVQVl3QjBBRjhB?= =?us-ascii?Q?WXdCdkFHUUFaUUJ6QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFBYlFCaEFISUFkZ0Js?= =?us-ascii?Q?QUd3QWJBQmZBSEFBY2dCdkFHb0FaUUJqQUhRQVh3QmpBRzhBWkFCbEFITUFY?= =?us-ascii?Q?d0JrQUdrQVl3QjBBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUJBQUFB?= =?us-ascii?Q?QUFBQUFBSUFBQUFBQUo0QUFBQnRBR0VBY2dCMkFHVUFiQUJzQUY4QWNBQnlB?= =?us-ascii?Q?RzhBYWdCbEFHTUFkQUJmQUc0QVlRQnRBR1VBY3dCZkFHTUFid0J1QUdZQWFR?= =?us-ascii?Q?QmtBR1VBYmdCMEFHa0FZUUJzQUY4QWJRQmhBSElBZGdCbEFHd0FiQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFu?= =?us-ascii?Q?Z0FBQUcwQVlRQnlBSFlBWlFCc0FHd0FYd0J3QUhJQWJ3QnFBR1VBWXdCMEFG?= =?us-ascii?Q?OEFiZ0JoQUcwQVpRQnpBRjhBWXdCdkFHNEFaZ0JwQUdRQVpRQnVBSFFBYVFC?= =?us-ascii?Q?aEFHd0FYd0J0QUdFQWNnQjJBR1VBYkFCc0FGOEFid0J5QUY4QVlRQnlBRzBB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reffour: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFB?= =?us-ascii?Q?QUFDZUFBQUFiUUJoQUhJQWRnQmxBR3dBYkFCZkFIQUFjZ0J2QUdvQVpRQmpB?= =?us-ascii?Q?SFFBWHdCdUFHRUFiUUJsQUhNQVh3QmpBRzhBYmdCbUFHa0FaQUJsQUc0QWRB?= =?us-ascii?Q?QnBBR0VBYkFCZkFHMEFZUUJ5QUhZQVpRQnNBR3dBWHdCdkFISUFYd0JuQUc4?= =?us-ascii?Q?QWJ3Qm5BR3dBWlFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCdEFHRUFj?= =?us-ascii?Q?Z0IyQUdVQWJBQnNBRjhBY0FCeUFHOEFhZ0JsQUdNQWRBQmZBRzRBWVFCdEFH?= =?us-ascii?Q?VUFjd0JmQUhJQVpRQnpBSFFBY2dCcEFHTUFkQUJsQUdRQVh3QnRBR0VBY2dC?= =?us-ascii?Q?MkFHVUFiQUJzQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUVBQUFBQUFBQUFBZ0FBQUFBQW5nQUFBRzBBWVFCeUFIWUFaUUJzQUd3QVh3?= =?us-ascii?Q?QndBSElBYndCcUFHVUFZd0IwQUY4QWJnQmhBRzBBWlFCekFGOEFjZ0JsQUhN?= =?us-ascii?Q?QWRBQnlBR2tBWXdCMEFHVUFaQUJmQUcwQVlRQnlBSFlBWlFCc0FHd0FYd0J2?= =?us-ascii?Q?QUhJQVh3QmhBSElBYlFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FB?= =?us-ascii?Q?QUFBQUNlQUFBQWJRQmhBSElBZGdCbEFHd0FiQUJmQUhRQVpRQnlBRzBBYVFC?= =?us-ascii?Q?dUFIVUFjd0FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJ0QUdF?= =?us-ascii?Q?QWNnQjJBR1VBYkFCc0FGOEFkd0J2QUhJQVpBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBRUFBQUFBQUFBQUFnQUFBQUFBIi8+PC9tZXRhPg=3D=3D?= x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR18MB4714:EE_|PH0PR18MB4954:EE_ x-ms-office365-filtering-correlation-id: bb192ff5-7d57-4b4c-baf0-08db9c9af289 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MyJsjjCOw/7gXqDrpPur+87Ro4kyCq2hNUlgTiGwuxMsjbeXQDy94laTWb+jd6QlTVEGfMROh5bQD+dgbKPd69yL9J82khqMI0YChG/mmh7tqCu/0G8G1hFsBXCz6/Cia6XPbniAB0frrZo1idGq48YYD4Nl/T4wWvByeGUTd5GiuK0O9gcK6ImVlTz2uSLgX6u7lWfQ/vRlfnAOOeqmUKuzSbwGhqIeDnKGsknJXxeZJB3FJZFZq4z54jLqNjrbumxfe8OnMSFL0Szrx6J2jthtlmPdDUfNKjUc8c66fsgE/WR3eCEQiPXwha3qVP7iGuBAQQAEyDEdDWAXZM+5iyX5Tz5HMAgONHwM2WI7J259pAgC4xN+LiFhkdPQXAw+AJzEFRYrQJqZmWwLWFBdDjE5j0kZeTXMpQlomuK/dM5B3JGc88cOIkFDB2nIwTK5Zd897CYAS/l5wkcvgC6Hj7vgBCR7hNGDX3vnbPvlfc/+o/JzsWeWby1qhpqkD5EoEY3hkdeML3brinBqLvEn0Un7vn152CMOYSTsm2p+IhiiywdIUm0JMlJBbxf3FThojRcT0Y4VtLmRfGZaHaJoQQSRnCj4coqnJMr9O6SKJf3ZD46oEstYn0358FELQ9xvOq3uElhdjDshVYD25jsuMw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR18MB4714.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(39850400004)(376002)(366004)(136003)(396003)(1800799006)(186006)(451199021)(6506007)(41300700001)(8936002)(64756008)(76116006)(66446008)(66476007)(66556008)(66946007)(316002)(8676002)(9686003)(966005)(83380400001)(71200400001)(7696005)(122000001)(478600001)(38100700002)(110136005)(55016003)(54906003)(15650500001)(33656002)(86362001)(4326008)(5660300002)(2906002)(52536014)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SZXdJNkmRllEjwDNnxOBiRpcFu9uSNBlYwGkDbSD4bwoF09ksJxBhVC28hWO?= =?us-ascii?Q?agXBJCFP3sRJNvSEuETGNsMM2PXS7+e6q9HO/uztTwXjU6IxRkXvBem177jw?= =?us-ascii?Q?/rbJnCNWnGCMBiytacb/VrUe5OPd9epKALY6jWIRGVCeouBOceKbYmJtg/wE?= =?us-ascii?Q?nvdLFqRiQj5jsRkWE3PqttUEKb+YhhmkJbRD2dOW01aDtNuNuuX2hvYFncMk?= =?us-ascii?Q?kKC1uvHlIW2MPwIc7tCpieEZzs8+yA4TEnAqYv09OsVfsiFWUOsmrGmhGpeE?= =?us-ascii?Q?xCNRtQNOgem0ssNHqbJSUSnDHoUdf0bCh17dv8TqV5+CJxoby1Swk9nNNBa0?= =?us-ascii?Q?KzDp/vkaNUGR1W9jocR3fmHMM/X2NhPDElV8WaxizxxpKbEqgI3mQcVfCHOb?= =?us-ascii?Q?RUdykYBEGzAdnDOf3j5I4t97TKMfP280vY5qXZCX35pcecMB40kmIUPU9ESJ?= =?us-ascii?Q?PeFYX60u+6qQkCfD9mulu5U7jH6hu4J4f3GyHk10GiAqgtUVZHHHOznZ5iRz?= =?us-ascii?Q?nKOO6X8EIf9OwtXNljDJec3sXTrpApysytclxxksq29TmUl362BM7koQBTYX?= =?us-ascii?Q?u7t9NidQFKFCjqTC+VDKMiHteXny4c2D2NYzs6E5W+0ueFUTppLxeGJ1kBbH?= =?us-ascii?Q?sskaxMNLYM6I2bzmYoAI3xSd29Fd4FjBGehm22nio3hbkv/CcztNLvFowXBi?= =?us-ascii?Q?wqnD5GpNYQQ0BQl8yw4CeJYUUL9I+HaFlRHmIy3R6zqg42y+6p4bJJY+iteO?= =?us-ascii?Q?O0BSUJPOvySDKTMMm8JKrBiaEcpgotcsOvcqeA7mFVU2jTyjsjGt49s49PUr?= =?us-ascii?Q?Znk8T3xs4pjZBxU0uMc2/QVt7DXGzQ5LA1CCp9woQY7Ki70fdM+TtVrokRPW?= =?us-ascii?Q?22bMIgYEB9A96qnY6zKSkdWAwDuVG+DZbJf3bcgCJfe/iDTVa+TI+kbpuXmb?= =?us-ascii?Q?3f04cD+2df0NR87KmyhecE3M+a1xiuNafNdaL26vFEEWcS/bYc84AsThhro8?= =?us-ascii?Q?rNmq4/31LsJhuQwLPPZULSVVy6gnG2h1nLVvWjl0JkG20aUQ61OvAoh1ix0g?= =?us-ascii?Q?comkuLtXImiLPcfl4R8I6AwJ/7AbPQZ5vNGOc7Q2neLlDb65CfnFFvwEH/5O?= =?us-ascii?Q?MM4sxi4ENspRZfQYKgeum/Gi2+vNkHHU8yK7Qt4wOB5JdtWNTuKmyGC/8Z++?= =?us-ascii?Q?kLj+oOV1uIf3D5Aey7yR+eupibvM4Y7IXr9pc+EvTNj9ASNerg4O5KpAJ8to?= =?us-ascii?Q?FVTmMcMZOQ+opollcyyOmiWpZUP+qVG92tBBHNRlqVfEIs1lIPikIrK7UeEg?= =?us-ascii?Q?owSoTH1tC72zb3EBGnm9ZMr82rcFFmMXKFQbmNUJTxwgQvxaPZ/VX/0q70LM?= =?us-ascii?Q?uhBIanfMMYAqfXCFKIy8x3oUjKDc/3/9RQ0Xcf1sh16osLhgEnqG99LPJL/q?= =?us-ascii?Q?0CxOamqK1hPTSxK8356vrtJz0XKkkmoStyPcMAZgRyFdFBrOLgjFfbh6WZNL?= =?us-ascii?Q?7i0jM42lbH2Td6h4wpAf1QRNvkFnTH8zs/mZTZe6xQWIMXV6fvHp9fTMjCr5?= =?us-ascii?Q?77RK0h5o12cedzATdPw=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR18MB4714.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb192ff5-7d57-4b4c-baf0-08db9c9af289 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2023 07:49:11.1038 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7JtRmnR7BunGj+GuyeP3wI5n88NkQ5AtSXYr9CSyL+CRNkWGnjMFKVHe4WJ526aaCJtoH/wVvYtP7UcV6Mzrle+wDPzS1bN9Zg/Uy8h3Q3I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4954 X-Proofpoint-ORIG-GUID: pWjQfRBuxXJ_ng4pdHcWzSCHMJa-tjZN X-Proofpoint-GUID: pWjQfRBuxXJ_ng4pdHcWzSCHMJa-tjZN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-14_03,2023-08-10_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Please find my comments inline. At the same time, may I request you to=20 review my patch series : https://patches.dpdk.org/project/dpdk/list/?series=3D29149 > SM2 asymmetric crypto operation was split into cipher and signature > operation. Now it corresponds to the other crypto algorithms and facilita= tes > addition of other SM2 components like the SM2 key exchange. >=20 > Flag to distinguish between a plain message or a hash used for signature = was > added to the DSA, ECDSA and SM2. >=20 > Signed-off-by: Arkadiusz Kusztal > --- > lib/cryptodev/rte_crypto_asym.h | 116 +++++++++++++++++--------------- > 1 file changed, 63 insertions(+), 53 deletions(-) >=20 > diff --git a/lib/cryptodev/rte_crypto_asym.h > b/lib/cryptodev/rte_crypto_asym.h index 8b5794fb7c..43bdb392c5 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -54,6 +54,7 @@ rte_crypto_asym_op_strings[]; > * and if the flag is not set, shared secret will be padded to the left = with > * zeros to the size of the underlying algorithm (default) > */ > +#define RTE_CRYPTO_ASYM_FLAG_PLAIN_INPUT RTE_BIT32(2) >=20 > /** > * List of elliptic curves. This enum aligns with @@ -379,16 +380,6 @@ s= truct > rte_crypto_ec_xform { > /**< Pre-defined ec groups */ > }; >=20 > -/** > - * Asymmetric SM2 transform data. > - * > - * Structure describing SM2 xform params. > - */ > -struct rte_crypto_sm2_xform { > - enum rte_crypto_auth_algorithm hash; > - /**< Hash algorithm used in SM2 op. */ > -}; > - > /** > * Operations params for modular operations: > * exponentiation and multiplicative inverse @@ -540,7 +531,12 @@ struct > rte_crypto_dsa_op_param { > enum rte_crypto_asym_op_type op_type; > /**< Signature Generation or Verification */ > rte_crypto_param message; > - /**< input message to be signed or verified */ > + /**< > + * Pointer to the input data > + * In case RTE_CRYPTO_ASYM_FLAG_PLAIN_INPUT flag is set in the > op flags field, > + * it is a message to be signed by the PMD. > + * Otherwise, it is a message hash. > + */ If a PMD does not support plain message but only hash digest, then this new= flag cannot help, as it is set by application without checking PMD capabilities.= =20 Instead, I had proposed adding hash capability for any EC xform in general (as other EC curves too can benefit out of it). https://patches.dpdk.org/project/dpdk/patch/086351e84370ce65dcf947dba12a46f= 9c62ae79b.1691658879.git.gmuthukrishn@marvell.com/ To note, more than one hash algorithm needs to be supported as in ECDSA for= eg. so I made it bitmask of hash algorithms supported by PMD. For SM2, today we set only SM3. With this, the application can check the xform capability and set op params= as shown in : https://patches.dpdk.org/project/dpdk/patch/f3be0a425170ee26a1396d34f52a8e0= 7941f7ce5.1691658879.git.gmuthukrishn@marvell.com/ > rte_crypto_uint k; > /**< Per-message secret number, which is an integer > * in the interval (1, q-1). > @@ -579,7 +575,12 @@ struct rte_crypto_ecdsa_op_param { > /**< Public key of the signer for verification */ >=20 > rte_crypto_param message; > - /**< Input message digest to be signed or verified */ > + /**< > + * Pointer to the input data > + * In case RTE_CRYPTO_ASYM_FLAG_PLAIN_INPUT flag is set in the > op flags field, > + * it is a message to be signed by the PMD. > + * Otherwise, it is a message hash. > + */ >=20 Please find above my comments for this flag. > rte_crypto_uint k; > /**< The ECDSA per-message secret number, which is an integer > @@ -652,52 +653,20 @@ struct rte_crypto_asym_xform { > }; > }; >=20 > -/** > - * SM2 operation params. > - */ > -struct rte_crypto_sm2_op_param { > +struct rte_crypto_sm2_signature { Yeah, it will help picking params for the application easily. Just a suggestion: could we retain _param suffix. Say rte_crypto_sm2_sign_p= aram. > enum rte_crypto_asym_op_type op_type; > /**< Signature generation or verification. */ Now op_type can either be sign/verify here. > - > - rte_crypto_uint pkey; > - /**< Private key for encryption or sign generation. */ > - > - struct rte_crypto_ec_point q; > - /**< Public key for decryption or verification. */ > - > rte_crypto_param message; > /**< > - * Pointer to input data > - * - to be encrypted for SM2 public encrypt. > - * - to be signed for SM2 sign generation. > - * - to be authenticated for SM2 sign verification. > - * > - * Pointer to output data > - * - for SM2 private decrypt. > - * In this case the underlying array should have been > - * allocated with enough memory to hold plaintext output > - * (at least encrypted text length). The message.length field > - * will be overwritten by the PMD with the decrypted length. > - */ > - > - rte_crypto_param cipher; > - /**< > - * Pointer to input data > - * - to be decrypted for SM2 private decrypt. > - * > - * Pointer to output data > - * - for SM2 public encrypt. > - * In this case the underlying array should have been allocated > - * with enough memory to hold ciphertext output (at least X bytes > - * for prime field curve of N bytes and for message M bytes, > - * where X =3D (C1 || C2 || C3) and computed based on SM2 RFC as > - * C1 (1 + N + N), C2 =3D M, C3 =3D N. The cipher.length field will > - * be overwritten by the PMD with the encrypted length. > + * Pointer to the input data > + * In case RTE_CRYPTO_ASYM_FLAG_PLAIN_INPUT flag is set in the > op flags field, > + * it is a message to be signed by the PMD. > + * Otherwise, it is a message hash. > */ Please find above my comments for this flag. > - > rte_crypto_uint id; > - /**< The SM2 id used by signer and verifier. */ > - > + /**< The SM2 id used by signer and verifier. > + * In case RTE_CRYPTO_ASYM_FLAG_PLAIN_INPUT flag is set this > field is unused. > + */ > rte_crypto_uint k; > /**< The SM2 per-message secret number, which is an integer > * in the interval (1, n-1). > @@ -719,6 +688,46 @@ struct rte_crypto_sm2_op_param { > */ > }; >=20 > +struct rte_crypto_sm2_cipher { > + enum rte_crypto_asym_op_type op_type; > + /**< Ecryption or decryption. */ > + rte_crypto_param message; > + /**< > + * Pointer to input data > + * - to be encrypted for SM2 public encrypt. * > + * Pointer to output data > + * - for SM2 private decrypt. > + */ > + rte_crypto_param cipher; > + /**< > + * Pointer to input data > + * - to be decrypted for SM2 private decrypt. > + * > + * Pointer to output data > + * - for SM2 public encrypt. > + */ > + rte_crypto_uint k; > + /**< The SM2 per-message secret number, which is an integer > + * in the interval (1, n-1). > + * If the random number is generated by the PMD, > + * the 'rte_crypto_param.data' parameter should be set to NULL. > + */ > +}; > + > +/* > + * Asymmetric SM2 transform data. > + * > + * Structure describing SM2 xform params. > + */ > +struct rte_crypto_sm2_xform { > + enum rte_crypto_auth_algorithm hash; > + /**< Hash algorithm used in SM2 op. */ > + rte_crypto_uint dA; > + /**< Private key. */ > + struct rte_crypto_ec_point PA; > + /**< Public key. */ > +}; > + sm2_xform is no more required, but ec_xform can be reused as I had proposed= in: [v1,4/6] cryptodev: use generic EC xform params for SM2 So, to summarize, may I request below of this patch to go above my patch se= ries If you agree. (1). Splitting sm2 op params into sign and cipher ops. (2). Move private and public keys from op param into EC xform. For DSA , should we move public key into xform as a session param ? Thanks, Gowrishankar > /** > * Asymmetric Cryptographic Operation. > * > @@ -743,7 +752,8 @@ struct rte_crypto_asym_op { > struct rte_crypto_dsa_op_param dsa; > struct rte_crypto_ecdsa_op_param ecdsa; > struct rte_crypto_ecpm_op_param ecpm; > - struct rte_crypto_sm2_op_param sm2; > + struct rte_crypto_sm2_signature sm2_signature; > + struct rte_crypto_sm2_cipher sm2_cipher; > }; > uint16_t flags; > /**< > -- > 2.34.1