From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47B9CA0C46; Tue, 24 Aug 2021 10:53:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 23FD440687; Tue, 24 Aug 2021 10:53:47 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 6E2214014E for ; Tue, 24 Aug 2021 10:53:45 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 17O472Z6021106; Tue, 24 Aug 2021 01:53:44 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2172.outbound.protection.outlook.com [104.47.57.172]) by mx0a-0016f401.pphosted.com with ESMTP id 3amfwj2x0w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Aug 2021 01:53:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bc7y+c9RwwD9A8MPTtH8nG95qDQ82CTHRAkMZyOiL9s+8AF9x8sosdxr8lM6ueE4DCTURs+n+eVWtGxpDxe0Gfv1cEf9Sk5mnlM7DoEPXCDGYSREs0cPpeAampxhXg853ES1BhgHJ1vEiIZMNxwCrwWG6sNAybrVODCKzEBw13ff/OhW+4PCoJ9ILEWVsxQQYh5qutKXxdIcLB3kRzm6JiI+3V1lPbzOW2MgV+cnlXoZgKqc8FKS5H8Nlf7mok8llQF8fbjauBLfzgkFu3x8myOQLSblXJ1EOvGBYsIfgcsGpMWVe3XZkDQMyNa39aDWWeTdS+yimKRZ/MRorJjqmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C4cAPX1Vgj+CTeQrPR1q6799VowRJCqzupf00+Ze0FA=; b=fzuHmwC+H1PrtoiiMMUTT8LbXQlEWCalEwHHYC163faXElUsb4wFatV0+HIXqoaLvj+4B6fUdey0FTcvKicaIde5OQ6+NQPc7E98qZcKddS+HgQTx2dBgnneOtnoQfJpTBI248zPSTD/gCLJEnKcmUHGvPXpGHzYrDhaVtbxCUGKv0RV9Cb7fj6G/yRD/ipH0/CiFuOd6m9XbFHlBXCItIK2VKl7vOA3FYF9ZUIlG6HLTxsG1wVRhORqWIRxF+xetrmHJiwif1A8TxRFvsHq5GDHqFYAy2OYn5SQwtfYCV9vFiA7lP/pFG4vrnmwE0ulVJQWxJQhfDSDPgWrBDDN9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C4cAPX1Vgj+CTeQrPR1q6799VowRJCqzupf00+Ze0FA=; b=K1/XnXbS2y4UEfodyFXtyCEjcV5igkveRKJzIIT0oi91ZkOKR84xdrfcWyVHsDZi2Htj3URDpx5xZZwAZV4HmPSmxUkq/OENO3Fh8WQa0GoJK0SQybxot18mpEzJ86tmp+kqsFAIjv6fApDhfZBmSGPOU4dhjIHIqdaLPRL3kJQ= Received: from CO1PR18MB4714.namprd18.prod.outlook.com (2603:10b6:303:e9::18) by CO1PR18MB4796.namprd18.prod.outlook.com (2603:10b6:303:ef::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.21; Tue, 24 Aug 2021 08:53:42 +0000 Received: from CO1PR18MB4714.namprd18.prod.outlook.com ([fe80::c515:b091:df51:cc6c]) by CO1PR18MB4714.namprd18.prod.outlook.com ([fe80::c515:b091:df51:cc6c%2]) with mapi id 15.20.4436.024; Tue, 24 Aug 2021 08:53:42 +0000 From: Gowrishankar Muthukrishnan To: "Power, Ciara" , "dev@dpdk.org" CC: "Richardson, Bruce" , Jerin Jacob Kollanukkaran , Kiran Kumar Kokkilagadda , Nithin Kumar Dabilpuram , Sunil Kumar Kori , Satha Koteswara Rao Kottidi Thread-Topic: [v3, 0/3] common/cnxk: enable npa telemetry Thread-Index: AQHXiD5hJEkYojpFFU+T06KxW2gkbatug0OAgAACiaCAE/Rn4A== Date: Tue, 24 Aug 2021 08:53:42 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4976ad10-ae69-4e78-adc6-08d966dcac90 x-ms-traffictypediagnostic: CO1PR18MB4796: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /Eii1+ycSwHmIcBzawXWiKxpP1ocnGLFFH54gfuu17l9tsyQfyClzrOM4S0MT0pIzf5nfuzX/T7WaV51JXUGDpN1eFB97zHvxTs9+r1dvTbbm5TLn8+vz0txrneDdO57hCRYlXS+kQGYiAqGmv0bJ88wEx95w80c9zoDEHSclyvjLam+kHTcfmh8WnLVMcHLEq4dTOtIzfigcCG53GLDopo5ESAdr6pllqIqDZMGhGwIb0fehiRvuiKckYmZMiK3bd2wQIuLH1wyGpz4nMhHSzGtWzhuMLhA3qZfZg44OzY64iPQi05ogzzFLPb9tvKk27CnYxroVDjfEBtRK/F/vHUcVQ+QPQYZU5y3iVKVe3PaO+ASqNvRF0NPRT12fEovppIX+jMPatVjsWq5910b/nL1cbagOln3v3PpXf9ugMxy6pu0CTiPlkSThgmbSflGKbXCy3VoOwCEnjoCmZ1LA2dltu2T6zzVsRhe0/bWchJ1AuAmHGB3eTK6JzKIhj1Y0jLBfgttPBi+YOGfTMRkDFsAQZIPIcT4SL7HjWe/A35l7pV1/EnHVcFosyJ4JKUBkr8JR2+v/kZICFouad/cx0fWMTqBrRubYRMB+Zp2KXlsvyu0/X0kLET4LmYwcyXu7y5OV/sfwSXRfyKSutYyQAlp4vB6zIZZFIRcUvqSAWlQVLZuSEmNh7RfxRlpQJDc0p3swNiXsCK7dUJe4RZnkA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR18MB4714.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(136003)(376002)(39860400002)(366004)(396003)(7696005)(478600001)(9686003)(110136005)(33656002)(76116006)(6506007)(52536014)(54906003)(4326008)(316002)(86362001)(83380400001)(66446008)(122000001)(66946007)(107886003)(53546011)(71200400001)(38070700005)(66476007)(38100700002)(66556008)(64756008)(55016002)(5660300002)(8676002)(8936002)(2906002)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BZ3TmB+Jw/Qzc0B2lroFVmS7ddRzcCzZe8VQ/qpmboSZsBxJrYnJjsQKwpKw?= =?us-ascii?Q?pruWwJvh7N43HiHmKA6r7uJjUi/Osk+3BlX7icRK41cZIas9i8oTHpvdGOwF?= =?us-ascii?Q?ltjy1TEVYN1V1/MGkqvj1+rA+3iRC5KnZajc36E7NeQ2dtPJ6WzY7puloBTl?= =?us-ascii?Q?/mw4z1H5rx6LRtfIsS9HQ9GWfBKUNDq1FGh+c7JZGnS6rH9O39PpcNp8RMkk?= =?us-ascii?Q?ZMUo5Zwl5KnKF+tcjRSFAyGHok5D2xow8lv3WdqrtG+DHpfxd0XjiONETUkh?= =?us-ascii?Q?Asme3ujSqi12K7mEcds+0pkHXt/HNU9N9pxzB3gPnk2K6b8XwXImv3vMP9IK?= =?us-ascii?Q?mfD1fGZTvRhv1Tz2QhHElVAqrpZ5BaUlMrxfZFEoDwKN6Sse3rKM2toTaICh?= =?us-ascii?Q?5bsgrJqRdGaIa5EvcRkrtpskKwH0vAZXGjlUBMOY6mwwSBVGCG1SPUZJ2F+b?= =?us-ascii?Q?3EvQAIe9f77bABORHlN7o4CoGiELdbgVfpW9g77wour1Cyyiq9GFMJxQazI+?= =?us-ascii?Q?WD1uLEtg9M4TNyamjGGXSqHiQb2UyzP7pRe9SEmt5BRAHPtVQ3s78uVtjA6u?= =?us-ascii?Q?adVi/dha+OLpSAjrbHafFNJiGQn/WRCS18oAgWQ70OCctR+h0guKyX9NyAvN?= =?us-ascii?Q?d4XtrZwKqRXBSRVpOTWC++/6aPOLy5ZVO3Ln7ZwhHpRw7OIoAATipnvMC/6n?= =?us-ascii?Q?6/2I/ScdV/xz89C6bszzl8Cq+TyccgyYufLDV1YsPu0Pti9HBgbx/O8Jqmky?= =?us-ascii?Q?Vpxq5HvIwEOvgDRwnfvdCBoQKw7wkqdnsUyuf9/3wHwI1mxXW8HM/eHexjTK?= =?us-ascii?Q?8yoJai38nkmMNMP8OhThfSQVgDzf0Gs89wNqBQtFzXoi1bV6tNmQE8JEZFj5?= =?us-ascii?Q?wKyDCx7T9n1DBzNR4JSZtCGLfLxCdE4rCLaMGCjpFZNMjJiq5zmoDA9uQM7e?= =?us-ascii?Q?sEDNmCDFieoNZoHGnonmSNrRer5r5E99N3k9NREnrcVD9VqSbIx+e7WP7BZ4?= =?us-ascii?Q?WhTLTiCcIGmoBqrv9y8e1nUOCDfZiZGsIdjW+PwuwOxjsp27+FkKTaBiOtgM?= =?us-ascii?Q?RwC9h7MPrUXIJpueKZSidvF+KivCvs8rn898nWbQOuvedD9u0R/NfZuGsZwB?= =?us-ascii?Q?yTVsPDQlOiFzhpmoBBMK+qzQaRgK++ckHbLl2ASsPuoSuRqGsGWfeKTQ1Gjr?= =?us-ascii?Q?irplMOajK+FHJ59X9BNCXH7GZqqrHFf4bU369mQR8gRkuJFkV5qvzLDWey2O?= =?us-ascii?Q?rlSmHlH0+dyVfL+f2459NOVt/bq1bcVMk0qm0P1GmEXOiP2QNiLnAazr31PU?= =?us-ascii?Q?EzC4UC5DGa6M+1Bwpj3LwxWjkXMqqu4RRmow91oJRMVyLPlrGKQmyNGT4aSz?= =?us-ascii?Q?01E3r43HygFvc8Qo96A87k7NZlGD?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR18MB4714.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4976ad10-ae69-4e78-adc6-08d966dcac90 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Aug 2021 08:53:42.0948 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: B8kosocs+CVYeUpoDhWVU0XUf9VSl40GXeioQNFIYDYGQDpmJ32qvv5MzwlwTInAwJrmzPKcX1kl8nLH4b7XKMgnC1ZVp2sC2S2TcCikei8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4796 X-Proofpoint-ORIG-GUID: PABXGDnWja4HpV2fAQybe5OwFN3_A3z- X-Proofpoint-GUID: PABXGDnWja4HpV2fAQybe5OwFN3_A3z- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-08-24_02,2021-08-24_01,2020-04-07_01 Subject: Re: [dpdk-dev] [v3, 0/3] common/cnxk: enable npa telemetry X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Please let me know if any other info is required. Thanks, Gowrishankar > -----Original Message----- > From: dev On Behalf Of Gowrishankar Muthukrishnan > Sent: Wednesday, August 11, 2021 9:49 PM > To: Power, Ciara ; dev@dpdk.org > Cc: Richardson, Bruce ; Jerin Jacob Kollanukk= aran > ; Kiran Kumar Kokkilagadda ; > Nithin Kumar Dabilpuram ; Sunil Kumar Kori > ; Satha Koteswara Rao Kottidi > > Subject: [EXT] Re: [dpdk-dev] [v3, 0/3] common/cnxk: enable npa telemetry >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi Ciara, >=20 > > -----Original Message----- > > From: Power, Ciara > > Sent: Wednesday, August 11, 2021 9:30 PM > > To: Gowrishankar Muthukrishnan ; > > dev@dpdk.org > > Cc: Richardson, Bruce ; Jerin Jacob > > Kollanukkaran ; Kiran Kumar Kokkilagadda > > ; Nithin Kumar Dabilpuram > > ; Sunil Kumar Kori ; Satha > > Koteswara Rao Kottidi > > Subject: [EXT] RE: [v3, 0/3] common/cnxk: enable npa telemetry > > > > External Email > > > > ---------------------------------------------------------------------- > > Hi Gowrishankar, > > > > >-----Original Message----- > > >From: Gowrishankar Muthukrishnan > > >Sent: Tuesday 3 August 2021 09:06 > > >To: dev@dpdk.org > > >Cc: Richardson, Bruce ; Power, Ciara > > >; jerinj@marvell.com; kirankumark@marvell.com; > > >ndabilpuram@marvell.com; skori@marvell.com; skoteshwar@marvell.com; > > >Gowrishankar Muthukrishnan > > >Subject: [v3, 0/3] common/cnxk: enable npa telemetry > > > > > >This patch series enables telemetry in NPA LF of cnxk. > > > > > >v3: > > > - fixed format specifier for uintptr_t > > > > > >Gowrishankar Muthukrishnan (3): > > > telemetry: enable storing pointer value > > > test/telemetry: add unit tests for pointer value > > > common/cnxk: add telemetry endpoints to npa > > > > > > app/test/test_telemetry_data.c | 125 +++++++++++++ > > > app/test/test_telemetry_json.c | 29 ++- > > > drivers/common/cnxk/cnxk_telemetry.h | 26 +++ > > > drivers/common/cnxk/cnxk_telemetry_npa.c | 227 > > >+++++++++++++++++++++++ > > > drivers/common/cnxk/meson.build | 4 + > > > drivers/common/cnxk/roc_platform.h | 8 + > > > lib/telemetry/rte_telemetry.h | 37 +++- > > > lib/telemetry/telemetry.c | 21 ++- > > > lib/telemetry/telemetry_data.c | 40 +++- > > > lib/telemetry/telemetry_data.h | 2 + > > > lib/telemetry/telemetry_json.h | 32 ++++ > > > lib/telemetry/version.map | 2 + > > > 12 files changed, 539 insertions(+), 14 deletions(-) create mode > > >100644 drivers/common/cnxk/cnxk_telemetry.h > > > create mode 100644 drivers/common/cnxk/cnxk_telemetry_npa.c > > > > > >-- > > >2.25.1 > > > > I am still unsure exactly what the use case is here - why are we > > choosing to publish the pointer values through telemetry rather than > > using a debug log for example? >=20 > Pointer values are useful sometimes for more debugging through telemetry, > hence this proposal. > As I mentioned in v1 thread, this is architecture compliant approach rath= er than > assuming pointer value is always 64 bit, when there is need to use pointe= r value > in current telemetry path. >=20 > Thanks, > Gowrishankar >=20 > > Maybe I am missing something here. > > > > Thanks, > > Ciara