From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 227D8A0C43; Thu, 23 Sep 2021 07:53:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C50E410DC; Thu, 23 Sep 2021 07:53:25 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 688F1410D7 for ; Thu, 23 Sep 2021 07:53:24 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18MKC4tc031889; Wed, 22 Sep 2021 22:53:23 -0700 Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam08lp2176.outbound.protection.outlook.com [104.47.73.176]) by mx0b-0016f401.pphosted.com with ESMTP id 3b8ba69p3n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Sep 2021 22:53:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aRR298I3Wq5mzPxU6dQlG9XZH5d89gG3LlD8K8LCwbR+Zcq3pLSoBWgG91Kzg3qoGvyhHwRkY2rY3eg3fRqbbWN4nfVwQptrLRgqOMKA2Eb32H3o8Fd7V3xSAncUGGvnfiWPS/nRskEg3b5b20sG/GlP2LFJUZtaQmM1hSNy1Q2JXpPVcspax2wZWYZ5asa6hUhKtWoimqUcq1mYmVQXnc6U4knySG6QGqlQS/4yMr/2QZ52whXHuNJAQymDpT1ceA23Sy13EW90OGCu8N4mnhrJ2yjFh+qxWlXivVFlLFler3zSCAGBcft3y2rnO3XoYgoUW5mNzO/c4oYcmxgkxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=b/8XZemETPN4/+Ehd4z79Ob9DwSNQLFV9a6xdJ/nfJI=; b=mS7AP7ruGzeD/AYondQJmyNu63zcWXVQw08np265KEHXEjwq8QS1HdYbItTYvUUJNBRSRlIqPx/2WOui9jBU+QkxGFbOFDxVDRI581lLd4AA9/PhibZ3yevCuwoAbXKNXbJMAlFqAg9gKWajh9xu4U2tpXNE+Y/M/EnAs0jIEtlCs+3lKvuidK/ZBfQsmKvvkbcrB8BWto75kL1ML5C7pRALnE+ovUunWjH2Vk0lOBbgCrkyhNmuYHL88lQS/l03SQt8hfpxihcerdWMjqfs5XKZiIRYX1GyNbGYKnoAaQXRkf7pxDYVkLNN4y8L94mtTf7qpVXJKrdqLMLNxxr3oA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b/8XZemETPN4/+Ehd4z79Ob9DwSNQLFV9a6xdJ/nfJI=; b=PEknCKQf0NotuDYTGh79wZ1vYldARX2riLM8sV6lG6ZTrDgRNMcWp9CqUXDrDh/CsZiZnArQi921OuvB+fi73d45r6nCRtuxUwZ1GG/AkracVR/j3nf8uBtdGyJMmLQDPmLDCuhnERNAEHs9cnhKMQQddbLKIFXqyOCX0RxJLAs= Received: from CO1PR18MB4714.namprd18.prod.outlook.com (2603:10b6:303:e9::18) by CO1PR18MB4732.namprd18.prod.outlook.com (2603:10b6:303:eb::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Thu, 23 Sep 2021 05:53:21 +0000 Received: from CO1PR18MB4714.namprd18.prod.outlook.com ([fe80::8c05:ddeb:f02:7b5c]) by CO1PR18MB4714.namprd18.prod.outlook.com ([fe80::8c05:ddeb:f02:7b5c%9]) with mapi id 15.20.4544.015; Thu, 23 Sep 2021 05:53:21 +0000 From: Gowrishankar Muthukrishnan To: "Power, Ciara" , "dev@dpdk.org" CC: "Richardson, Bruce" Thread-Topic: [v2] telemetry: fix json output buffer size Thread-Index: AQHXrtg6MmPSd4ObGUu60JBuDu7u+auvyKWAgAFW1WA= Date: Thu, 23 Sep 2021 05:53:20 +0000 Message-ID: References: <5a95b25b81e7ee57edfdcea73b9266bc8dae8d77.1631120194.git.gmuthukrishn@marvell.com> <20210921110243.1919933-1-gmuthukrishn@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cb2dc4eb-a896-411d-6300-08d97e5672ec x-ms-traffictypediagnostic: CO1PR18MB4732: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BPdrJqqdRxdNT+P+PCv/d91VHoMzoGLC0kv+gbx+50O3SnEODWK0XJoJNxxjEzMs0gZcosCb4pPUDzXeCNT4Fj4HK6xcanq551+IztniN791OkdlpHhXkTyGI0QuZD67qw9Q8bujkiqsJHAC1Vs6bIITSMuUgT+0/fUrrgaMZ0BIFTONlyJP/V+hDlgq3qfqMeGpFhFTqWtO0TEq1uhU/IxfNEGqyOiqyHe/TqF270i/zEFxC4ch7525hP1MP8jNfWTEh7nhXwxjLjCWA12CAz00+UhQ5n7gIGkO4LPFevGyOv0GPdRcX0NA7+d1jftIBPLlIGWmwj7GFoBWPeTIWsllDSjycedvXn5Ncf4jWPsUl73bFLDAQlApsLBDmtrLvuMuMz/YUmVe6lWbMNPpcXKPfpVbqe9PBXI9OO3KpmeN8tu6sRg6AUnzQPXKmwfU0OOI44Z2vwUeIiHzcY36yhQ2CZr2LgjXgalY8OgCC65Zte5xmve69rFn/HUj8R3zyDMaMe5xlPzQq0/iF+pB/a4+qa/FC/8YPX2F8XZuBrnJ0XtrgX+Dp3EdY5VIg0axLD3X3oGlGET+86o+VSMaM1iESEcXDckqpT7riZE5FIBwGGSa5pKERjfNl7dpuf+vqiYIqJIXHesmhpvtgztrKQOW+vpFFGkjyzecqltU7RIzatlTdRw0SFLZDftPZ3recxHGCeXx6twK0Ww0XsBHJA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR18MB4714.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(76116006)(55016002)(86362001)(66946007)(6506007)(9686003)(7696005)(26005)(83380400001)(38070700005)(316002)(186003)(33656002)(122000001)(38100700002)(508600001)(66556008)(4744005)(71200400001)(8936002)(4326008)(64756008)(5660300002)(66446008)(8676002)(2906002)(66476007)(52536014)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sMOVCFEDhSYslA+0tcKyi/qqj4DwuOE42aUyrnN7mpUOMm8Sddfh2W74AgeE?= =?us-ascii?Q?qmzqwzECHW74nKzqhqrr3rj0rliv+2TWcvylt1NzJgsRZKu2ALaHJwKSjJJK?= =?us-ascii?Q?Ucl3mbvUN+r21pwsycVjRw3NOR064kYdB5Wy/SA+BZZXXX4zzqdz1CNV07h5?= =?us-ascii?Q?+ZjclY0Ph19UAmMsrPDMPYgI2rO764YTkV3FxRAJ4MV9KILkwz2SNwQITigy?= =?us-ascii?Q?nBiozkJVY5mmBuXkf7mZh4lNzN1npt/bxtYiIJXmcZQytsEvPIbqwcJePTd4?= =?us-ascii?Q?LXA4zpas3qx8mXP6XWIXvqIInePci1iOfFE+WTtduOhrf/6apEbizyqe/Eo6?= =?us-ascii?Q?lSfDLt9SOLG6YmsFM7BZdy2CEpU8/JhOsraKrgNYoXwqLlC5FN4Yf9/bjgiK?= =?us-ascii?Q?FxvLTXkg1bNLfY5XUbe/jIAp/+laiArM+7xp9pUIJZ4Dx12MlxMITGdGBjFg?= =?us-ascii?Q?d0pda5oELRnDnUvW1F/k5whiA5WiwDKPOFgzQ7Z0dT9tPghs+8Q7RZCWq4Ew?= =?us-ascii?Q?e/h9miTCopcmac+Krwq2e+LfFqCpOYVdRPu+6imykdm2T2gGnOnnxV5q7RNJ?= =?us-ascii?Q?dvb6av2FDqFBBCE646ZV+AIwKNVe8r2WDtkXcK8LlG3xqpskrRymrXANdMYH?= =?us-ascii?Q?lihH7oQgMwKf/mlLnBeK27I3AxDyY9x3+4DXYCM3w14vNz0rQ/+6yqUUnymT?= =?us-ascii?Q?8BxVPFibrWOcqYrFV7FDb5rA92cpdvYasQWLtZ2mWfOvScxbtNsh10Kkxgaw?= =?us-ascii?Q?piKObA3lqk6GAToveHFG2QegZ5O1u7I5GuT/oWRPS5vhg/SIqNfll5keilyr?= =?us-ascii?Q?lmu05bYimEbpgN4faZdnEVmMGWTws0kojJ77orROQBOwUaFTNpD0VNQlW4HJ?= =?us-ascii?Q?bnLs4yuSBaY1nZ0ioEA+CPFqK2vrkKDGfEK2KC0lmG/aV5CC2IKKXKj7Iqfj?= =?us-ascii?Q?s9a26dOcTO6+9BzB/rGGURYcSBLu1fPDvYAXZOzYvt5v3YfjpURVRcb9yJXA?= =?us-ascii?Q?c/BLHXJhS0CRFHEqIKUG5DvVYPaopvtO+JxVeNB4Zl7pfDr+lMMNqqMNhmGg?= =?us-ascii?Q?ZJWMHQVXUg8yfVlSdYBZvHgOXxFT21ZUXIwpmwnY1/Dh85Dr6FEpL/WvAo+7?= =?us-ascii?Q?AsC8+TR1eW7SAyx5rEpsKgt9K+paKaQswQ0CYnrO0Bek5EeI9/tMnxzIdVEg?= =?us-ascii?Q?j1K1b0Y9gpPtir6ss8b2e0pUEKkYOthPehI99HmEnZ4XMKFkgjm/ruUg1Qlr?= =?us-ascii?Q?hLEXJwOm9incPd232g+LDorT5wW9wRKf1D3X9jV4RA308ug0hfpga8xi3jsJ?= =?us-ascii?Q?ebV7GwPolfbHg6PN+7ZeQOJa?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR18MB4714.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb2dc4eb-a896-411d-6300-08d97e5672ec X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2021 05:53:20.8782 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JDcU/dzvvot/CbDqfP+XmFKvN9lwo/b7ik+3mhzfEEXjL4+VmTmrHUrqFDI7h11+1/iHHjTQjN6XFD8DHIONEAqWGpgXq96DBc53IozbEg4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4732 X-Proofpoint-GUID: BYF5BPwmqvadb3kdZIkfUfFAItIpo1af X-Proofpoint-ORIG-GUID: BYF5BPwmqvadb3kdZIkfUfFAItIpo1af X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-23_01,2021-09-22_01,2020-04-07_01 Subject: Re: [dpdk-dev] [v2] telemetry: fix json output buffer size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ciara, > I am not sure about why we would want this to allow for > "RTE_TEL_MAX_SINGLE_STRING_LEN - 6". > The RTE_TEL_MAX_SINGLE_STRING_LEN is used to represent the max size of a > singular string value e.g. the response to client being {"" : " here up to max size in length>" } >=20 > I wonder could we use the "len" parameter in some way here, that would be= the > available space to be filled of the "buf" being passed in, allowing the f= unction to > copy in the maximum amount to fill the buffer. Got it. Yeah, "len" is actual available space. I ll send next version based= on this. Also, I propose if we can have platform defined upper limits (esp MAX_CMD_L= EN, MAX_SINGLE_STRING_LEN etc) so that, we need not revisit lib/telemetry for platform needs (and I don't think one size fits all platform, may be excess= too). Thoughts ? Thanks, Gowrishankar >=20 > Thanks, > Ciara