From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A48A45DB0; Wed, 27 Nov 2024 07:50:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC56840264; Wed, 27 Nov 2024 07:50:30 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id C88944025D; Wed, 27 Nov 2024 07:50:28 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AR2QjNI030621; Tue, 26 Nov 2024 22:50:28 -0800 Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2170.outbound.protection.outlook.com [104.47.59.170]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 435tn5rh20-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Nov 2024 22:50:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=f1bdHxMRv1BW7pDiPo/kVt/silDdzst57TA6f1vH+vlWCegu25oRJznscKpOca92KvQ4SOA16WKNhb/CFSZ65620WMP6VRXwzrcX/wzIMRh+WcdvVC70b5UPyiqx4xwUYQJWe0SvdkE83IGy6zQVd6pWNQLlTkIP5BibhzDdrvuD8MDT6+plkRDmZIiJI8MQhv2WO8G/bxk8z01lgp4YzG35QTThSGGBqP+u7In4MdOjvf9X7ibG/WV1wI1e97iGljUXDCaPpIMYJzqHKtNCL9CsETMHacWaBXciDbHpPtulWfYtF/XzOh49PTTx8Fb3J031znldnjx55U1LtA8YcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SpPA3fycVUD7JtYvf2ogNFYiP16BF42vBpJXc62xI5k=; b=fqvnW1NLLe0T4uQw9vTKE/rRnaYfJvwJGHU41nNm6/+QLMbf3BzAVSrTIuRmTxy7q9UGAMPRnobqleyzZwqwoiY3RN7wFYBgew4jziH4wCNZR5Zr2EmQ6UB0zQ6rCKi9FsCBw1U9r1DtTeoI2diVlbta6MhmviUff4nKdXvzzajVk7WAq41Qc24/axIt5vQVbp5fvXpi7Iprj9nlPqCw6WEjkSMAelv2PsnKfkglebeKkp+mdjZVandnXDpGtZNhMyiQxSsTcTb9QIKao+EIuKNfba/kpT+5KVn+BeNSQufcXKgVHVKNDxP2N6MULBCHX2uYaDr1sSllowe0ZTcJWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SpPA3fycVUD7JtYvf2ogNFYiP16BF42vBpJXc62xI5k=; b=sdt0uFA63x9TDa8fMOhEcEN4MQwqsU6kxbOS6BnfEJcwFiKUSkUIMKnMCwCsJsmC8WBKvvKHrRSnzG5nuf0IpxAD9rNFlHAv6X956/U8f4yPTfJpj8z6wEcgwnJ9yDf8HlejV8qFRWD4mMJ3KaexV+aRVEEY+CMjAdUpFeWbY2g= Received: from CO1PR18MB4714.namprd18.prod.outlook.com (2603:10b6:303:e9::18) by SN7PR18MB3839.namprd18.prod.outlook.com (2603:10b6:806:f5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8207.12; Wed, 27 Nov 2024 06:50:23 +0000 Received: from CO1PR18MB4714.namprd18.prod.outlook.com ([fe80::26fb:729e:a947:3e06]) by CO1PR18MB4714.namprd18.prod.outlook.com ([fe80::26fb:729e:a947:3e06%4]) with mapi id 15.20.8182.019; Wed, 27 Nov 2024 06:50:23 +0000 From: Gowrishankar Muthukrishnan To: "dev@dpdk.org" , Maxime Coquelin , Chenbo Xia , Jay Zhou CC: "techboard@dpdk.org" , Anoob Joseph , Akhil Goyal , Jerin Jacob , Fan Zhang , Nithin Kumar Dabilpuram , Thomas Monjalon Subject: RE: [RFC] crypto/virtio: add vhost-vdpa backend Thread-Topic: [RFC] crypto/virtio: add vhost-vdpa backend Thread-Index: AQHbPD+boFXmOnArQkW+u6qHjEBNkLLKscKw Date: Wed, 27 Nov 2024 06:50:23 +0000 Message-ID: References: <20241121180219.1234-1-gmuthukrishn@marvell.com> In-Reply-To: <20241121180219.1234-1-gmuthukrishn@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR18MB4714:EE_|SN7PR18MB3839:EE_ x-ms-office365-filtering-correlation-id: 230c6b06-ed75-4f0b-29fd-08dd0eafc46a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|1800799024|366016|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?Ku6EwSGezgurx4JcB5pTBnFUYtUd2EebcfdOaPgX4/Jj4oNL2Xz/u6loSa7h?= =?us-ascii?Q?91EJFtHaY7dK2MChpwuLX853S5Ucm0gaz5e8ptV7Vm/I8+O9E8dFvFQZDcze?= =?us-ascii?Q?OEnyQw43ZGeNaLjmwe8pyaNDiQEuUzfFdrWqwlhOJa8ObziphAZe0wZGrS86?= =?us-ascii?Q?0sRiE6nsvwvytKjzF1AiqdvZ9V3M7hUfpMTkaU0+Wt5VLjlWiyvPgJAYbT40?= =?us-ascii?Q?Ha+d1W8rof4iiFHwFj6+P6n8wO8dQ35yT2hOCeFSHs14G/b4q1qICDfmMlt1?= =?us-ascii?Q?0GaOv92kzlqjGuMy3x8BAO1/JB40rVk14Z6AHmP7zaIqQPEpLmC1lYiJu2Vt?= =?us-ascii?Q?XUP95U81Ej+NmKoaH7V06KQqKJzrYK9IE8KI2Us7GP2SFVW7vqnZBduiSB5W?= =?us-ascii?Q?jK0zUAwbW7dVRdLOCHFRcZIaqYIPM5oT/0dgj1HoaTCoBMo+k7Ag2dlm/4IS?= =?us-ascii?Q?IQ6xztIRtU9UiAPOsCC8VFslqp2JrbLHarWZjitK5kWPAVcHrF3lVcySZ1Sk?= =?us-ascii?Q?U2TOL2uRJseWarcvA095tog92bq3GTGYa/wlfpLS7CJD1K9uCB9o4TyAIo6V?= =?us-ascii?Q?bUDTMENtJP+eFUvaPPkbFDj0kcnANPYlk50zHS6i4oyvTzBXQc69mQW07JVn?= =?us-ascii?Q?M6PL1A7kiBWLcLOf3ceWBwrAX1cuLMcSWP3idmeIoUIltwfsKZrdOrbzoj0j?= =?us-ascii?Q?Bzi6gNxhZLyw8IxvE2y8SU8GR6S37hQwO4/+Az8jRLYhStl+lAJwQwFi9Hgn?= =?us-ascii?Q?fl2rKcfdeFFMGEUeiOgtpviF8G+rC1P1pSIPl0pxPG+QpNJUaSFoD6V3WC5Y?= =?us-ascii?Q?7lBfoQMuiOWFmcgpnws5wCrXiJsYnEsHeNTuWitAYi1lCEyKAG0X1er+8bP1?= =?us-ascii?Q?dQh/2hqcEjOLuPRWoZ/BY8k5l/1XDrREsA/+X1T0UPCNT+XdHLJBkxMMHWMA?= =?us-ascii?Q?MZBPM8hKk6d+S7Kw5lGhlCw3I5CvAL8UbldtGJ/ShhBrdAttxdk/fjaEFZ0B?= =?us-ascii?Q?gRvG6pb0IL70OaHFHWr1K8NAqKXZjCNUcmC+0EtIQDF/D138tc6NYk18vxVH?= =?us-ascii?Q?iSq1oCqTlfPwJFNHOE2zUiJD7GPioRCifNa9A8PwSWhZMBqElsjPHECEzhT5?= =?us-ascii?Q?X3+CEwTVjlcvM5CyDC94w9d7goHD3ZYrnrL1FzBYkbYjrdU+F1Tj3NN53Bg0?= =?us-ascii?Q?rCCtjgV5wQDlz3Wp0861rml01izd7rZiXO2qEHBR+jGI51kce8/DBQElc+D1?= =?us-ascii?Q?wp/Fn616++tROHl8MsiZZNzPZ9CNNJM1sXoGl3dyu0kTZpLSX0EPMOjkBvjY?= =?us-ascii?Q?oVzoXf5wYjBtTjMKNtE7mWcexiPvZZ448ucnCQu13aa/DZ42Zw8oEMxOYj9D?= =?us-ascii?Q?7m/syVSka2ouJ6ZoPs4ZtamXZ2WWmxoh58Rl5NksWzXCMAdR7g=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR18MB4714.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZOaLzsafaDPh3RwahVVWwseinhog67SKOC+bKIwJmrSCpOG4LKhsdv1Q4oMl?= =?us-ascii?Q?HDZO0ffb4aPrDou7bYB+g0z1LGAuritznLkqUN32IMYLRL651wB2L0j+swii?= =?us-ascii?Q?YtkN4/nAaS6lb/qG1teRMoMoRa6jI0/sOwBduFjzRbtZ5lfuAJlD7XtBgthU?= =?us-ascii?Q?qBe0/RHRtdUCx5sxzBovQhd6ebdlG2BRINtjRzDfvQbTn22FVLX2lEOALpNP?= =?us-ascii?Q?N/JeMvay3f8LChS84fjlqj8Meq2Lh1cmo+2KqIdTEl5pEUP2CEroEJaqoC0D?= =?us-ascii?Q?G/T1cNvTv2L1bwY7ieSY3OPpyWJNpwPEWFtJj6YiLe0vVyCOameXtLBxoPsC?= =?us-ascii?Q?Ns6Aeby/BIFbYnGDBl8NcwrSXU4rg8yLacNYk9I8XVoFXq4O5ZITDC9giQ2h?= =?us-ascii?Q?YIBwt6vt6uf24daoA0stGEaGu5vEJ7lSwzQeZgwjjm+MssLXbgkp/C6fwRBU?= =?us-ascii?Q?cR4wkB349wvs8hxcaEv5k2lT43CxQOEsLrteivQ6ls4jWUZTyZVXdltRcmEu?= =?us-ascii?Q?sVMsJqDyjBaczpxJPNrv+rd0zPTcRliwIRzFJBtMS01BEv5nPQiKABuDaydh?= =?us-ascii?Q?hfakpu77mwlkfnsT715M2ZEPyC1KzZqTga5wOTu5yIQYXqnarFNfNgZ8imL4?= =?us-ascii?Q?kxUhl9FulAkihB0eY6jOdtoVDLBbkCQqCv+tgWHyulrxAvtDlyDFLeSTJ2QB?= =?us-ascii?Q?BQ/NljIXn5FAV9ZtbQpsR5x2HTJzgamB5OoAyn7zjlAchzRXBUiV7gx5lXu5?= =?us-ascii?Q?EF/FQ5v8vpt8f7SJR17LTqxEVdwERrQr+/hGcR0P8FPzUWud5iKVJTk3eEHE?= =?us-ascii?Q?QrpHhASXmXItbVSpbpaKZ+FbfPeZZaQFYEGW8pJ1yGwVxENY4CJAQ1pKVKg2?= =?us-ascii?Q?PJgdbAwWI+z0uUng/7kpsH+XB0sisqzdmoPmY4bKNaHY8jY/NcL9oIoSCf4+?= =?us-ascii?Q?pDVaouOfKKJJdqn+RtAgbm/3w7B6YiPVJgMXCGnZLw6dZgrQqRc8FqMxtI5k?= =?us-ascii?Q?9g8S3xmrT206w3BrajjZ2VJtIHMu68bhgYBAi8fOL2b43ZXj6JFGAixE+EPz?= =?us-ascii?Q?Q7YpnIU4rPCMgeydicxFG3czvtDycBKn/mBMB2vyH1N3Nd7znct1FpBzO6jt?= =?us-ascii?Q?CHvOu8yTk7L3SSrLb5n6s7pWy4UG+g8uEFswI8f2fpR1n96ozkXMcay7u3Wi?= =?us-ascii?Q?nG2OCN/idYamnLd0hEypEsUlyduu84hFJVTtKXVY3JZ/zm2fk3Mhycjd1HhC?= =?us-ascii?Q?BzdNSQmcl914zQlGJHQEk1hpFdKcdKVhuwOUPsYBjrzM51ZOb6eKBdR8D7F8?= =?us-ascii?Q?K/oP3787XjERBm42K9MQ7276ols8gfMBd1TQuGYItk0kx5YrE1Iuv82AGaAc?= =?us-ascii?Q?VwYNRnXWCIxRlYxEtAxqMUX0JzJQ+SEjaJACR1IWSD7icH1EWurJyh5Xxz1B?= =?us-ascii?Q?ULc7KK27krGw8Jb3b7CvKSuwhQYHf6yXTj5PX3uKYBPyml34tZSHyXnTNqsP?= =?us-ascii?Q?DfXyAq6QaLKoQDMPZS0EuJh0+yVI8OH4RnOx1L+kXDWF1InTRqwfz5pN+pzv?= =?us-ascii?Q?qpBEKFCVpiAjHypoL9qlE4snQfQ5TQGe/M6RkuP0?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR18MB4714.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 230c6b06-ed75-4f0b-29fd-08dd0eafc46a X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Nov 2024 06:50:23.3426 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8j8f5ZCK81nLt5QxATNurtSu1y6P1AE+a63G+npc5KwZU8/6+0uLDu0cwOZUG+M0vowH/fXqSz7BHwl89yA+65C9y5ME85jqgkfew7ucYAU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR18MB3839 X-Proofpoint-GUID: gMmBxpsMLBwP097k27uBXY--Ny_Cw8i9 X-Proofpoint-ORIG-GUID: gMmBxpsMLBwP097k27uBXY--Ny_Cw8i9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, I wanted to follow up on my previous message regarding the development of a= vhost vDPA host driver for crypto/virtio. We have proposed creating a driv= er/common/virtio/ directory to hold common implementations for both net and= crypto functionalities. This approach aims to help in fixing common issues= and extending virtio functionalities efficiently. As we plan to include this feature in DPDK 25.03, we would like to conclude= on the implementation direction soon. We would greatly appreciate your val= uable feedback or any suggestions on this proposal. Thank you! Thanks, Gowrishankar > Hi, > We are adding support for vDPA user backend for virtio-crypto PMD in DPDK= . > We have come up with functional changes which is similar to the support > available in net: >=20 > commit 6b901437056eed3ed7c9932c333ba24ac5be116f >=20 > net/virtio: introduce vhost-vDPA backend > vhost-vDPA is a new virtio backend type introduced by vDPA kernel > framework, which provides abstraction to the vDPA devices and > exposes an unified control interface through a char dev. >=20 > Our current development reuses some code from net/virtio/virtio_user/, an= d > we realize that we could keep a few things in common between net and > crypto, such as: >=20 > -> vhost_vdpa.c (and its header file) from net/virtio/virtio_user/: > Except for VHOST_VDPA_GET_DEVICE_ID and enabling queue pairs, > virtio_user_backend_ops can be reused. > -> virtio_user_dev.c (and its header file) from net/virtio/virtio_user/: > virtio_user_dev_init and its capabilities differ. > -> virtio_cvq.c (and its header file) from net/virtio/: > There is a difference in the usage of the first and last descriptors f= or the virtio > header and status (net vs. crypto). >=20 > We need to standardize these codes to ensure they work universally. > Therefore, we propose creating a driver/common/virtio/ directory to house > them. This approach will help address common issues and extend Virtio > functionalities shared between crypto and net. For example, the crypto PM= D > can benefit from packed ring support. We welcome your valuable feedback > and any suggestions. >=20 > Thanks, > Gowrishankar > -- > 2.37.1