From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95AEFA0548; Wed, 11 Aug 2021 18:18:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F72E410EC; Wed, 11 Aug 2021 18:18:39 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 4FCA540C35 for ; Wed, 11 Aug 2021 18:18:37 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 17BGF6Gx028697; Wed, 11 Aug 2021 09:18:36 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2171.outbound.protection.outlook.com [104.47.55.171]) by mx0a-0016f401.pphosted.com with ESMTP id 3ac6qtjf5t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 Aug 2021 09:18:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZZklsQYVkkHjyPH0+LpatOwB/Aro2d7Qo35Bq1vN5GGmrjMmdZuaJcv/QPNy8TssrooofYizCe9vb6WSXKMUG3c7GlAp6BpRy7xNs+1ligcWzk+wv33JDHMLejl4uva1h6z/Zr5E0EHamou/x8XinfmiOPKGikU8DlPvAHkoID9znRYqUh8jsrB0JqX6ahOwD3TUeFxbnhDS968YnseV0BDFgFbSxNm9C2exh4EcjB61SJyKK6PLBwGAZlL2JHTmS792Cy36XZHibi29agSVOk0PQvVsaKfqRbayRqIGpQPYn/+PQiwDHfoqFYUsevwYLXX7zSGPFKsqFD9keHKG0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T3bl3WfLmamzLEiheJFBt2YgwujpgwmUCvsgSftGUmw=; b=iJXrYyQITNAWTin3G8RrV7avTx827QmbQegYsdNj63f8EMEeBIl8Z10wkiLGuDFeeYUK458vbs3+RWq9ZIhowGC0GIF3oIj/Uc4uODMn9VUksOmMATQQsnywbwvBFV8WuKgRd349UiByYJNbi6Tai7JuGtE019D26qKFEgCH0Awyaorstjo2YtiU6IZMdXoANfcWVEfpbtqV7NW/j2gxKHGAoTWUpybaoKn4Wk/kuXVDYDApcAeL4oUo6pWZo9Ygk4ayNapwZsRYUdnriMejapLyN8tuAVDRLbCejZ55Ldp5JZQcQeze+H2JmOOxtU8sNX3heV81yuoCa623YHk4Tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T3bl3WfLmamzLEiheJFBt2YgwujpgwmUCvsgSftGUmw=; b=cSlN0ZMI8RNIdV8wBgMOxcnbeCrP0/AJadaxl4Z/Tst9ZxxXXgETq9d/+wQyBbdBiMeX65tr5gx9CQnqFl++rWn5E2dQ1WnDEorNQ+o6iqOFd23okWh6fvHKGKgBFUleg3m/bbclGrqE2J41SfiPQ93gz/+4NHf67661MQwKt5c= Received: from CO1PR18MB4714.namprd18.prod.outlook.com (2603:10b6:303:e9::18) by CO6PR18MB4450.namprd18.prod.outlook.com (2603:10b6:303:13f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.17; Wed, 11 Aug 2021 16:18:34 +0000 Received: from CO1PR18MB4714.namprd18.prod.outlook.com ([fe80::c515:b091:df51:cc6c]) by CO1PR18MB4714.namprd18.prod.outlook.com ([fe80::c515:b091:df51:cc6c%2]) with mapi id 15.20.4394.023; Wed, 11 Aug 2021 16:18:33 +0000 From: Gowrishankar Muthukrishnan To: "Power, Ciara" , "dev@dpdk.org" CC: "Richardson, Bruce" , Jerin Jacob Kollanukkaran , Kiran Kumar Kokkilagadda , Nithin Kumar Dabilpuram , Sunil Kumar Kori , Satha Koteswara Rao Kottidi Thread-Topic: [v3, 0/3] common/cnxk: enable npa telemetry Thread-Index: AQHXiD5hJEkYojpFFU+T06KxW2gkbatug0OAgAACiaA= Date: Wed, 11 Aug 2021 16:18:33 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ac28012b-d201-4752-d8b2-08d95ce3aaa5 x-ms-traffictypediagnostic: CO6PR18MB4450: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8Knkkq4kt4GUjOL11Gt/9hCM6oT8HYVtvaeOBPVDRcxznk7apcnMx5EFhwxRXzRXYiS0p8DD4XigJ4f5DWZAZgDyh00Pq+HlPj5e5NTyDqlN9xUZYCjjAhYY9xhZP7i18OBIbolPBbxdbFhC7ryxnWw5ZAm66yPCSTYoKKjDxGXAFMkH2YH2G7hHyTc+WmMFxh7/v2Xa6pSj2PIQfVanE5C7lavcI94m3EsfH/xUHVaHIOfHBXGItT/TMCwd2Jcs4vDoEZg1OSAK69MBVrngtnakXe0ipkBb/lKaA/8Vi9SE/O9D1J2UwuR12zTHQoaCt13p1dhiEQf3fTSW1HSZxUPD8mioSjl9qiXT8I50Ma2Nqi59Eth2bgMdO8hMetrbXswsOlC5IP0pqWIZ0d3fBbmasRavUQjYb08BHuW+iQofoM4H/ZkYAyRgyrLRVUd34b6uODMxLqDWglz35+Rv1J0xq4KQxQezkbo0cs8OZXCRgWFp71vtw8dVgqjcJkGGQtrGCpiV6MeVdI5ohj8wDgsPpKM5ImnoQt7tj4HrYf5XQNRvv1vOMWg6fVEXa4j3Z1vKkiIc5siENl8GIFws2y601lHMq8aJNjOxLjxn64joA9d+I6uJmB6MfEF9lRaSsN8gDqLThtpfcrVzhLXHzADldvl8bvlZCYQ/N5cxBdMd1UtRV/KYmUqWkmDA0VP1 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR18MB4714.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(346002)(376002)(136003)(39860400002)(54906003)(110136005)(52536014)(5660300002)(478600001)(83380400001)(86362001)(316002)(7696005)(66476007)(66556008)(66446008)(64756008)(186003)(71200400001)(9686003)(66946007)(76116006)(53546011)(38070700005)(38100700002)(2906002)(122000001)(107886003)(33656002)(55016002)(6506007)(4326008)(8936002)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QeAbbSgg9pubJFi+jJwtjZo98p0SoHxEOl9UqDgKHmt7RljpmgNZKbLDs8B6?= =?us-ascii?Q?oad13JNWOQ/Bc20e6vmzIkXBvGYNArSl3dnC3VMq2Y7p9BHE8dP+bd6bLpzh?= =?us-ascii?Q?AcJLG4nJrCJ/00PySHiJZaCwe3OLQsiBk/Ob+6T4nSkSBMFXSVVEkivZDbM+?= =?us-ascii?Q?VHJy5RS2B+2VEtYw+adKg4PY0agNWN1MJGmFt4n51aKZyxJTsj9ysIa/tP3J?= =?us-ascii?Q?9U14Aa/BFtX0/yght5IxHYAwcjOwuRPmWHvzapuRGGvBmm91sGE23XY9sX9u?= =?us-ascii?Q?g2QWURMtWQaIOU/rxPXa8iYZpV8ywHy41JlNS15/qxFVOeZRKE+e3N32VetT?= =?us-ascii?Q?u4Geyzp7Ays2O8PPUYKWm3ERN8iYPHnuJF9Vd0vlxgamUrwkAIM2MfT2Njh3?= =?us-ascii?Q?7YHNGmUoPV+mfRslg1/YsR66dBiWOjld/pM1XwDor4VKDDq10DFwf/p53lkg?= =?us-ascii?Q?In5M14+gaJZVvmrpB09UglDCCAywFTnxtxz48FUaE7aWMxz/p73K0YUU6cd0?= =?us-ascii?Q?XAGBsmD+n4fBHPlMXeBv563tYkt6wGlh+8Adv16YSDnXRP7aOH4akUYm8V28?= =?us-ascii?Q?MBaLMHHzY5RLHktcDS6OZcyzboDdZ5vUE36PiLQVPe3Y/fbTdvaJots9MmOQ?= =?us-ascii?Q?AFKubvhN1CTSRC3pDag4y7PE16VHE3yeTX5k6iIwnB8ojR3DQEqDUronT958?= =?us-ascii?Q?PPCgY2abji7o1WWMkF5WSo9SMReSf/8H+QanFWauF6ym8hLWdUeVNjQBZTiX?= =?us-ascii?Q?krnvSBnpOimfK5/IBde6z37jwE9WWujUopgKlQtSosn6lHSG9vPBdt0lCqmb?= =?us-ascii?Q?M9rB+/c6T7wFdNyn5T+SZDvg7pZkvCDgRf3A1rU/Qt2Bwvo92jFTGyTe958v?= =?us-ascii?Q?dpNk6fn53SuVDfUviPWvKHSJtFfGlrXtDNOJ8PPNTlt7Uv5ZDpFj/gq4REUv?= =?us-ascii?Q?riXBkrNSQbGZelEeo9bTk018BuaRJeEgQnomT/eCTNIgyMagR5IPy0v+HUU3?= =?us-ascii?Q?B5oodFKhFx1Q6thNZt6yJfvlYoKbvzKjHIQ2p76as0/bPkK0pZZyM6W41mNC?= =?us-ascii?Q?n69B4gCdsPhWZdvahO1tPvBMUptCHSRigCdY25h1x5VNWy6wHL0Dgyyr+Qc9?= =?us-ascii?Q?gmxe9Ml8sJu6Rc0o1eea01R7s3m3w67lUcy/IL2WsBfizKyUyx9v5EDmqc39?= =?us-ascii?Q?vpjjddHvDAteIJTtj+1VrvAHov6eMnSPGT7JvBY5dKqbg+X9pNpQzmYcQJry?= =?us-ascii?Q?IiN7yZ+Ot719g7qQY+4+Yx2i+18SCamFj057GnA8lhRzmERdgUD5z5igZ0NS?= =?us-ascii?Q?Q0B++1piYcw7SOB80KhJ/pMz9HqUa5luZbEloDYb8eNp/AbX/iqYZ4oU19IV?= =?us-ascii?Q?FLUl4Lw=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR18MB4714.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac28012b-d201-4752-d8b2-08d95ce3aaa5 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2021 16:18:33.6936 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pHrydQrBm+J55TJLxxti67WQyJbImHwC1klpZJw8Tybyx/Q8oZzilPWMecebE0EHe9AHN43s2DLJh/KUDz6bUQ6VCqkoB/gzmE8Djr/2YL0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB4450 X-Proofpoint-ORIG-GUID: yVo32PUzlwa77I9G-BKIoaLj4hKKkBFt X-Proofpoint-GUID: yVo32PUzlwa77I9G-BKIoaLj4hKKkBFt X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-08-11_05:2021-08-11, 2021-08-11 signatures=0 Subject: Re: [dpdk-dev] [v3, 0/3] common/cnxk: enable npa telemetry X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ciara, > -----Original Message----- > From: Power, Ciara > Sent: Wednesday, August 11, 2021 9:30 PM > To: Gowrishankar Muthukrishnan ; dev@dpdk.org > Cc: Richardson, Bruce ; Jerin Jacob Kollanukk= aran > ; Kiran Kumar Kokkilagadda ; > Nithin Kumar Dabilpuram ; Sunil Kumar Kori > ; Satha Koteswara Rao Kottidi > > Subject: [EXT] RE: [v3, 0/3] common/cnxk: enable npa telemetry >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi Gowrishankar, >=20 > >-----Original Message----- > >From: Gowrishankar Muthukrishnan > >Sent: Tuesday 3 August 2021 09:06 > >To: dev@dpdk.org > >Cc: Richardson, Bruce ; Power, Ciara > >; jerinj@marvell.com; kirankumark@marvell.com; > >ndabilpuram@marvell.com; skori@marvell.com; skoteshwar@marvell.com; > >Gowrishankar Muthukrishnan > >Subject: [v3, 0/3] common/cnxk: enable npa telemetry > > > >This patch series enables telemetry in NPA LF of cnxk. > > > >v3: > > - fixed format specifier for uintptr_t > > > >Gowrishankar Muthukrishnan (3): > > telemetry: enable storing pointer value > > test/telemetry: add unit tests for pointer value > > common/cnxk: add telemetry endpoints to npa > > > > app/test/test_telemetry_data.c | 125 +++++++++++++ > > app/test/test_telemetry_json.c | 29 ++- > > drivers/common/cnxk/cnxk_telemetry.h | 26 +++ > > drivers/common/cnxk/cnxk_telemetry_npa.c | 227 > >+++++++++++++++++++++++ > > drivers/common/cnxk/meson.build | 4 + > > drivers/common/cnxk/roc_platform.h | 8 + > > lib/telemetry/rte_telemetry.h | 37 +++- > > lib/telemetry/telemetry.c | 21 ++- > > lib/telemetry/telemetry_data.c | 40 +++- > > lib/telemetry/telemetry_data.h | 2 + > > lib/telemetry/telemetry_json.h | 32 ++++ > > lib/telemetry/version.map | 2 + > > 12 files changed, 539 insertions(+), 14 deletions(-) create mode > >100644 drivers/common/cnxk/cnxk_telemetry.h > > create mode 100644 drivers/common/cnxk/cnxk_telemetry_npa.c > > > >-- > >2.25.1 >=20 > I am still unsure exactly what the use case is here - why are we choosing= to > publish the pointer values through telemetry rather than using a debug lo= g for > example? Pointer values are useful sometimes for more debugging through telemetry, h= ence this proposal. As I mentioned in v1 thread, this is architecture compliant approach rather= than assuming pointer=20 value is always 64 bit, when there is need to use pointer value in current = telemetry path. Thanks, Gowrishankar > Maybe I am missing something here. >=20 > Thanks, > Ciara