From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"ciara.power@intel.com" <ciara.power@intel.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Kiran Kumar Kokkilagadda <kirankumark@marvell.com>,
Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>
Subject: Re: [dpdk-dev] [EXT] Re: [v1, 1/3] telemetry: enable storing pointer value
Date: Fri, 30 Jul 2021 12:08:06 +0000 [thread overview]
Message-ID: <CO1PR18MB4714E9D5DF604B119909F78BCBEC9@CO1PR18MB4714.namprd18.prod.outlook.com> (raw)
In-Reply-To: <YQLN2tAqquyjMnlR@bricha3-MOBL.ger.corp.intel.com>
Hi Bruce,
> I'm a little curious as to the usefulness of having a pointer value in telemetry
> output? How would a telemetry user be expected to use pointer information
> returned? Printing pointers seems something more useful for a debugging or
> tracing interface than a telemetry one.
>
Thanks for the quick review. I enabled _ptr API keeping few things in mind:
1. User need to explicitly type cast pointer value (ie address) to uint64_t
which otherwise can cause compiler warning (Wint-conversion). Although
u64 is large enough for holding address as value, type casting is problematic
for non-64 bit machines (eg 32 bit). One other option is to use uintptr_t
as a holder.
2. With this API, code walk could be easier as user can interpret the accessed
data better (ie ptr is address value). _ptr API is meant for pointer variables,
though it is up to user to choose.
3. Also while debugging telemetry date using script like usertools/dpdk-telemetry.py,
perceiving address as hex is quicker than same as u64.
Answering on returned data, user needs to convert stringified hex to pointer value.
Regards,
Gowrishankar
next prev parent reply other threads:[~2021-07-30 12:08 UTC|newest]
Thread overview: 121+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 15:25 [dpdk-dev] [v1, 0/3] common/cnxk: enable npa telemetry Gowrishankar Muthukrishnan
2021-07-29 15:25 ` [dpdk-dev] [v1, 1/3] telemetry: enable storing pointer value Gowrishankar Muthukrishnan
2021-07-29 15:48 ` Bruce Richardson
2021-07-30 12:08 ` Gowrishankar Muthukrishnan [this message]
2021-08-01 17:40 ` [dpdk-dev] [EXT] " Gowrishankar Muthukrishnan
2021-07-29 15:25 ` [dpdk-dev] [v1, 2/3] test/telemetry: add unit tests for " Gowrishankar Muthukrishnan
2021-07-29 15:25 ` [dpdk-dev] [v1, 3/3] common/cnxk: add telemetry endpoints to npa Gowrishankar Muthukrishnan
2021-08-01 17:37 ` [dpdk-dev] [v2, 0/3] common/cnxk: enable npa telemetry Gowrishankar Muthukrishnan
2021-08-01 17:37 ` [dpdk-dev] [v2, 1/3] telemetry: enable storing pointer value Gowrishankar Muthukrishnan
2021-08-01 17:37 ` [dpdk-dev] [v2, 2/3] test/telemetry: add unit tests for " Gowrishankar Muthukrishnan
2021-08-01 17:37 ` [dpdk-dev] [v2, 3/3] common/cnxk: add telemetry endpoints to npa Gowrishankar Muthukrishnan
2021-08-03 8:05 ` [dpdk-dev] [v3, 0/3] common/cnxk: enable npa telemetry Gowrishankar Muthukrishnan
2021-08-03 8:05 ` [dpdk-dev] [v3, 1/3] telemetry: enable storing pointer value Gowrishankar Muthukrishnan
2021-08-03 8:05 ` [dpdk-dev] [v3, 2/3] test/telemetry: add unit tests for " Gowrishankar Muthukrishnan
2021-08-03 8:05 ` [dpdk-dev] [v3, 3/3] common/cnxk: add telemetry endpoints to npa Gowrishankar Muthukrishnan
2021-08-11 15:59 ` [dpdk-dev] [v3, 0/3] common/cnxk: enable npa telemetry Power, Ciara
2021-08-11 16:18 ` Gowrishankar Muthukrishnan
2021-08-24 8:53 ` Gowrishankar Muthukrishnan
2021-08-25 10:09 ` Thomas Monjalon
2021-08-25 14:38 ` [dpdk-dev] [EXT] " Gowrishankar Muthukrishnan
2021-08-26 17:15 ` [dpdk-dev] [v4, 0/2] cnxk: enable npa and mempool telemetry Gowrishankar Muthukrishnan
2021-08-26 17:15 ` [dpdk-dev] [v4, 1/2] common/cnxk: add telemetry endpoints to npa Gowrishankar Muthukrishnan
2021-08-26 18:06 ` Bruce Richardson
2021-08-27 6:43 ` [dpdk-dev] [EXT] " Gowrishankar Muthukrishnan
2021-08-26 17:15 ` [dpdk-dev] [v4, 2/2] mempool/cnxk: add telemetry end points Gowrishankar Muthukrishnan
2021-08-27 6:41 ` [dpdk-dev] [v5, 0/2] cnxk: enable npa and mempool telemetry Gowrishankar Muthukrishnan
2021-08-27 6:41 ` [dpdk-dev] [v5, 1/2] common/cnxk: add telemetry endpoints to npa Gowrishankar Muthukrishnan
2021-08-27 6:41 ` [dpdk-dev] [v5, 2/2] mempool/cnxk: add telemetry end points Gowrishankar Muthukrishnan
2021-09-04 3:25 ` [dpdk-dev] [v6, 0/4] cnxk: enable telemetry endpoints Gowrishankar Muthukrishnan
2021-09-04 3:25 ` [dpdk-dev] [v6, 1/4] common/cnxk: add telemetry endpoints to npa Gowrishankar Muthukrishnan
2021-09-04 3:25 ` [dpdk-dev] [v6, 2/4] mempool/cnxk: add telemetry end points Gowrishankar Muthukrishnan
2021-09-04 3:25 ` [dpdk-dev] [v6, 3/4] common/cnxk: add telemetry endpoints to nix Gowrishankar Muthukrishnan
2021-09-04 3:25 ` [dpdk-dev] [v6, 4/4] net/cnxk: add telemetry endpoing to ethdev Gowrishankar Muthukrishnan
2021-09-08 17:03 ` [dpdk-dev] [v7, 0/6] cnxk: enable telemetry endpoints Gowrishankar Muthukrishnan
2021-09-08 17:03 ` [dpdk-dev] [v7, 1/6] common/cnxk: add telemetry endpoints to npa Gowrishankar Muthukrishnan
2021-09-08 17:03 ` [dpdk-dev] [v7, 2/6] mempool/cnxk: add telemetry end points Gowrishankar Muthukrishnan
2021-09-08 17:03 ` [dpdk-dev] [v7, 3/6] common/cnxk: add telemetry endpoints to nix Gowrishankar Muthukrishnan
2021-09-08 17:03 ` [dpdk-dev] [v7, 4/6] net/cnxk: add telemetry endpoing to ethdev Gowrishankar Muthukrishnan
2021-09-08 17:03 ` [dpdk-dev] [v7, 5/6] telemetry: fix json output buffer size Gowrishankar Muthukrishnan
2021-09-21 11:02 ` [dpdk-dev] [v2] " Gowrishankar Muthukrishnan
2021-09-22 9:21 ` Power, Ciara
2021-09-23 5:53 ` Gowrishankar Muthukrishnan
2021-09-30 8:47 ` Power, Ciara
2021-09-30 9:00 ` Gowrishankar Muthukrishnan
2021-10-07 9:04 ` Power, Ciara
2021-09-23 6:21 ` [dpdk-dev] [v3] " Gowrishankar Muthukrishnan
2021-09-23 6:26 ` [dpdk-dev] [v4] " Gowrishankar Muthukrishnan
2021-09-29 4:18 ` [dpdk-dev] [v5] " Gowrishankar Muthukrishnan
2021-10-06 17:38 ` Thomas Monjalon
2021-10-07 4:58 ` [dpdk-dev] [EXT] " Gowrishankar Muthukrishnan
2021-10-07 7:22 ` Thomas Monjalon
2021-10-07 8:36 ` Gowrishankar Muthukrishnan
2021-10-11 10:54 ` [dpdk-dev] [v6] telemetry: remove limitation on JSON output buffer length Gowrishankar Muthukrishnan
2021-10-13 11:06 ` Power, Ciara
2021-10-13 15:25 ` Thomas Monjalon
2021-09-08 17:03 ` [dpdk-dev] [v7, 6/6] crypto/cnxk: add telemetry endpoints to cryptodev Gowrishankar Muthukrishnan
2021-09-21 11:32 ` [dpdk-dev] [v2] " Gowrishankar Muthukrishnan
2021-09-29 6:45 ` [dpdk-dev] [v1] cryptodev: add telemetry endpoint for cryptodev info Gowrishankar Muthukrishnan
2021-10-22 12:28 ` [dpdk-dev] [v2] cryptodev: add telemetry endpoint for cryptodev capabilities Gowrishankar Muthukrishnan
2021-10-22 12:37 ` [dpdk-dev] [v5] crypto/cnxk: add telemetry endpoints to cryptodev Gowrishankar Muthukrishnan
2021-10-22 12:59 ` [dpdk-dev] [v6] " Gowrishankar Muthukrishnan
2021-10-22 12:57 ` [dpdk-dev] [v3] cryptodev: add telemetry endpoint for cryptodev capabilities Gowrishankar Muthukrishnan
2021-10-22 16:02 ` [dpdk-dev] [v7] crypto/cnxk: add telemetry endpoints to cryptodev Gowrishankar Muthukrishnan
2021-10-26 13:44 ` [dpdk-dev] [v8] " Gowrishankar Muthukrishnan
2021-10-26 14:10 ` Akhil Goyal
2021-11-03 4:43 ` Gowrishankar Muthukrishnan
2021-10-30 17:41 ` [dpdk-dev] [v9] " Gowrishankar Muthukrishnan
2021-10-30 17:45 ` [dpdk-dev] [v1] security: add telemetry endpoint for cryptodev security capabilities Gowrishankar Muthukrishnan
2021-10-31 5:24 ` [dpdk-dev] [v2] " Gowrishankar Muthukrishnan
2021-11-02 14:42 ` [dpdk-dev] [v3] " Gowrishankar Muthukrishnan
2021-11-02 14:52 ` [dpdk-dev] [v4] " Gowrishankar Muthukrishnan
2021-11-03 19:37 ` Akhil Goyal
2021-11-04 4:29 ` Gowrishankar Muthukrishnan
2021-11-04 5:11 ` [dpdk-dev] [v5] " Gowrishankar Muthukrishnan
2021-11-04 10:50 ` Akhil Goyal
2021-10-25 7:26 ` [dpdk-dev] [v3] cryptodev: add telemetry endpoint for cryptodev capabilities Akhil Goyal
2021-10-26 13:13 ` [dpdk-dev] [v5] " Gowrishankar Muthukrishnan
2021-10-26 14:12 ` Akhil Goyal
2021-10-26 15:44 ` Gowrishankar Muthukrishnan
2021-10-26 18:34 ` Akhil Goyal
2021-10-26 12:52 ` [dpdk-dev] [v4] " Gowrishankar Muthukrishnan
2021-09-29 7:01 ` [dpdk-dev] [v3] crypto/cnxk: add telemetry endpoints to cryptodev Gowrishankar Muthukrishnan
2021-09-29 8:56 ` [dpdk-dev] [v4] " Gowrishankar Muthukrishnan
2021-09-16 8:52 ` [dpdk-dev] [v7, 0/6] cnxk: enable telemetry endpoints Jerin Jacob
2021-09-21 10:52 ` [dpdk-dev] [v8, 0/4] cnxk: enable telemetry endpoints for mempool and ethdev Gowrishankar Muthukrishnan
2021-09-21 10:52 ` [dpdk-dev] [v8, 1/4] common/cnxk: add telemetry endpoints to npa Gowrishankar Muthukrishnan
2021-09-21 10:52 ` [dpdk-dev] [v8, 2/4] mempool/cnxk: add telemetry end points Gowrishankar Muthukrishnan
2021-09-29 6:40 ` [dpdk-dev] [v1] mempool: add telemetry endpoint for mempool info Gowrishankar Muthukrishnan
2021-10-13 15:21 ` Thomas Monjalon
2021-10-13 15:26 ` Bruce Richardson
2021-10-13 15:40 ` Bruce Richardson
2021-10-22 3:28 ` [dpdk-dev] [v2] " Gowrishankar Muthukrishnan
2021-10-22 5:55 ` David Marchand
2021-10-22 16:11 ` [dpdk-dev] [v3] " Gowrishankar Muthukrishnan
2021-10-22 20:38 ` Thomas Monjalon
2021-09-21 10:52 ` [dpdk-dev] [v8, 3/4] common/cnxk: add telemetry endpoints to nix Gowrishankar Muthukrishnan
2021-09-21 10:52 ` [dpdk-dev] [v8, 4/4] net/cnxk: add telemetry endpoing to ethdev Gowrishankar Muthukrishnan
2021-09-21 11:27 ` Jerin Jacob
2021-09-21 11:53 ` Bruce Richardson
2021-09-21 12:16 ` Olivier Matz
2021-09-29 4:25 ` [dpdk-dev] [v1] ethdev: add telemetry endpoint for device info Gowrishankar Muthukrishnan
2021-10-11 14:40 ` Ferruh Yigit
2021-10-11 15:40 ` Bruce Richardson
2021-10-11 15:44 ` Ferruh Yigit
2021-10-14 21:47 ` Ferruh Yigit
2021-09-29 6:54 ` [dpdk-dev] [v9 0/4] cnxk: enable telemetry endpoints Gowrishankar Muthukrishnan
2021-09-29 6:55 ` [dpdk-dev] [v9 1/4] common/cnxk: add telemetry endpoints to npa Gowrishankar Muthukrishnan
2021-10-14 15:22 ` [dpdk-dev] [EXT] " Harman Kalra
2021-09-29 6:55 ` [dpdk-dev] [v9 2/4] common/cnxk: add telemetry endpoints to nix Gowrishankar Muthukrishnan
2021-10-14 16:37 ` [dpdk-dev] [EXT] " Harman Kalra
2021-09-29 6:55 ` [dpdk-dev] [v9 3/4] mempool/cnxk: add telemetry endpoints mempool Gowrishankar Muthukrishnan
2021-10-14 16:43 ` [dpdk-dev] [EXT] " Harman Kalra
2021-09-29 6:55 ` [dpdk-dev] [v9 4/4] net/cnxk: add telemetry endpoints to ethdev Gowrishankar Muthukrishnan
2021-10-14 16:47 ` [dpdk-dev] [EXT] " Harman Kalra
2021-10-19 11:27 ` [dpdk-dev] [v10 0/4] cnxk: enable telemetry endpoints Gowrishankar Muthukrishnan
2021-10-19 11:27 ` [dpdk-dev] [v10 1/4] common/cnxk: add telemetry endpoints to npa Gowrishankar Muthukrishnan
2021-10-19 11:27 ` [dpdk-dev] [v10 2/4] common/cnxk: add telemetry endpoints to nix Gowrishankar Muthukrishnan
2021-10-19 11:27 ` [dpdk-dev] [v10 3/4] mempool/cnxk: add telemetry endpoints mempool Gowrishankar Muthukrishnan
2021-10-19 11:27 ` [dpdk-dev] [v10 4/4] net/cnxk: add telemetry endpoints to ethdev Gowrishankar Muthukrishnan
2021-10-19 16:42 ` [dpdk-dev] [v9 0/4] cnxk: enable telemetry endpoints Jerin Jacob
2021-10-20 13:30 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR18MB4714E9D5DF604B119909F78BCBEC9@CO1PR18MB4714.namprd18.prod.outlook.com \
--to=gmuthukrishn@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).