From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC896A0503; Thu, 19 May 2022 07:31:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B1A8B40150; Thu, 19 May 2022 07:31:31 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 8FF4940140 for ; Thu, 19 May 2022 07:31:29 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24ILMP2r010292; Wed, 18 May 2022 22:31:29 -0700 Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam08lp2048.outbound.protection.outlook.com [104.47.74.48]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3g50as3p8b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 18 May 2022 22:31:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oALCxS+4beL/saM2ES7f23ehtTB+6mGHzzvGlRjk/2a9Bkx6t2m/0My3DBBNRBfZl/h3XFxuAZKz7T2wHXKaPIoUH1tFAzl7LvkTyV5jOduVY/u0n7m0Isu3kP2Feez9w50kBV2UGEHH6QF/dXxnFB4vOZmk6dcRA3mQEibBDrr50/kpwc3gCIfuFR0DDcRTTUalnlAD8c65v97yB9KoIAyDU9OYgn6+RdnsBHHB/NXHLPHoXxtKeTdlOhbsTBhvnJum+x38B/DgRpPBJSSCE38a+f0nI7FMZbVpc+V9KLnfY3b6CO+wRcZGbsxyVDmSZ6NN+BcOGBuX6ngaQVwFFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QYmVr2glBr7GVXJD3UyugaPAt/FXfc3toDJVV/55Evg=; b=V5No7xL3FiWQLx/CD1TdZggH+ooyJHp5MDhcJKe5ETmPeIgseo0QWUL2W0gfViMwIZD8L2FNvTHPlTYkoDq/zn0UH7BySmZfkOTnLquyQcJT/LypSMnnYVmQnN3evC4TxyHCOeOXgPw8+fWAjli+Yj7ml7tdo8RSn2Oov/2CrihgxEvTsQyGN90cZw+1Vc+FP9jLK1ufdhTny5Iox5RcnBiFPymF9y4ZK4BDjtmdzT4Yf06DU5OzOw2sMKFzxgNbtjjtClraf8h+F1bPkEx2nax6mUF7QNP41GDt1pCmhEgQj6eNFCli6Kpw1pBfknrR1E3HMdDN5XsuQNqej8xS4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QYmVr2glBr7GVXJD3UyugaPAt/FXfc3toDJVV/55Evg=; b=C8b/YmGcVkRs/HI/CGp0NK4lrOyEyzxhp6KejgaGOnJwFdg9xvEabrwozie4gbjF3fXjxxfFHzL8DsYy+StAddrCHnJ4l10REzCRn/frzLs5vxYfpFcDOJNnq3ik+XXXoljljzV2R1sbLHk8u99/IsobeJqeGzDmD+OMrBoTT/E= Received: from CO1PR18MB4714.namprd18.prod.outlook.com (2603:10b6:303:e9::18) by BN8PR18MB3028.namprd18.prod.outlook.com (2603:10b6:408:9f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Thu, 19 May 2022 05:31:26 +0000 Received: from CO1PR18MB4714.namprd18.prod.outlook.com ([fe80::f83c:2654:ed5:fd1f]) by CO1PR18MB4714.namprd18.prod.outlook.com ([fe80::f83c:2654:ed5:fd1f%6]) with mapi id 15.20.5273.014; Thu, 19 May 2022 05:31:26 +0000 From: Gowrishankar Muthukrishnan To: Brandon Lo , "roy.fan.zhang@intel.com" , "ciara.power@intel.com" CC: "dev@dpdk.org" Subject: RE: [EXT] [PATCH v4 8/8] examples/fips_validation: add parsing for cmac Thread-Topic: [EXT] [PATCH v4 8/8] examples/fips_validation: add parsing for cmac Thread-Index: AQHYW+SQFV82Z3l360yi4iPZ5GC1Z60lyHCg Date: Thu, 19 May 2022 05:31:26 +0000 Message-ID: References: <20220129175514.746925-1-blo@iol.unh.edu> <20220429161559.415645-1-blo@iol.unh.edu> <20220429161559.415645-9-blo@iol.unh.edu> In-Reply-To: <20220429161559.415645-9-blo@iol.unh.edu> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 304e0a2f-a9f7-4dd9-193a-08da3958d1c2 x-ms-traffictypediagnostic: BN8PR18MB3028:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DS06V0WZjE9S9h4FTen5tRQpsaXFXvrxzoTrHI1H+PEcOYYIoGqTAFCKGmt/Eh+rwO/AYWJff+9//NJ7u9jURur7BaU1geTXzRkTft6v8EJG8qsA5rxoHH2IoYpfDFQGPlcccoe8EaIc7AMJfXxBIaQsIqC8cQOMR3ldFVPA8nW7WhW5wPfQ7aeuT6WYSFlletyR/B8l1STY0M3QD8RCYrWpnZ1BZ104z8A1x1mhUc0aLzcSQUDVAhgDefmFjOMJ+s7dXuzkMcu0VhOa0trk0M55osQO1gIuSQGELeBvD+1fUojclvhYrvN9n3HGpYa/vPJwgsNFjYj1R+2AJUNL5mcIT+4UoRN0KjLtazNYhNF4Gj2Ay6MObs3P9+rCCsSlknqgWsX6WCHNPZUzDiHXg7Im+jBGyHMr3LK27mIHA5UfuTGS6yvTlTeRaNcVBeMp4vB4A/JnZyaC8wkWhwL+PHrQ/FhAiChNo5gRW1RRfOAhF+h3+1paeTOY5LhQpCQW7EmyB2dQKw+FtuFwj3Ao4lB6dC7Tcc1P3GtgoEORiizq2P1iIkqV9h+rGN5UtoQxNnC5hWEtSLlYmemSiscb+00noC2ek/6Su3ah1kLLv/VtVEUjgT6dmb40t8ATg4uvQZo/fHwKGAGgH8zra0dkLmyold2TOyJXAX86e/xSG80Rh4roITccQ8UUVSuqvShj7GWaBznup8yDgU1lm1btrA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR18MB4714.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(33656002)(71200400001)(5660300002)(86362001)(316002)(110136005)(508600001)(8936002)(8676002)(122000001)(83380400001)(38100700002)(38070700005)(186003)(2906002)(53546011)(6506007)(55016003)(26005)(9686003)(66446008)(64756008)(66556008)(66476007)(7696005)(76116006)(52536014)(4326008)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YY9PfAWcxD53IY9Biw/h4FgkhrBXxtndRVNze80ZMLcDO4VF/XR8PUJ4Z8J2?= =?us-ascii?Q?RpQwBXTXr2vDPbUh5o3LzfPnlK2RyBbKkVePKMtvDeyI8+bn6FgWvWUDuAqZ?= =?us-ascii?Q?Ne3+hH23bkrwuWWZtUzFfKrUyTtJoVLNY4CTKBWH/zK4flK3vzXKrMH8EGXV?= =?us-ascii?Q?eqTvrKhbALEhwxy0Us8iFnJffGOrmRb7jN8YDE6qskL+qWwzvb1iMsR9i+hL?= =?us-ascii?Q?uqiC1WqbrNS/a3NlfnC+NhD1Nm3jDh0MhBq7KBzeigoAbnA9DDf3pXWegjGV?= =?us-ascii?Q?qU6gM859dA7bB1fOVoPhFCWz9DsKMZLeFzIZ1CHRsMtmK/WupO9rV2xFrHuP?= =?us-ascii?Q?BJEz6Oy4ZslmRtcUR1Wjg6SRAkQ6420bUVcpikSePFZVPN4axWjEv5WNZbPJ?= =?us-ascii?Q?k8eY/SrZUrKHWV1+4ttxQDx3dWI+IuewlUCDj8zysGhPydtMZdYY/XJHd1dT?= =?us-ascii?Q?H/gLipMmjttyOvlN+t4UwHxcYuahodP8t6oQH6ko3xY3BzIXZcTRzEnRIkyy?= =?us-ascii?Q?nbU8mufct4nrJg+ExhpK14iG6FIgdrZEHNtahB6EAuSwsNee0GN/nMqO9bMg?= =?us-ascii?Q?o6DzTjNsXh1sV+sp5sOb4+lmTBPVJlfZQv9ZYiepMy2XiN7BArIRMK1t3A4/?= =?us-ascii?Q?IC3+6PHcoLWr9DKw2rEeoRZLLMj2sVPjT5Hccisu8G6WWRJ6dEsyzj1ljaJa?= =?us-ascii?Q?kBMu2odXk5p8+5zvouhUc58F7N9ZXm5zp2CCfZlcpOjbBBcan7pI3Oij5Jhn?= =?us-ascii?Q?yoT8zvaJQX9ZF1Mzodn2cT5dzl9/HNBGSkkAYx2FACuGG/yBKXpSV6/jN+Xv?= =?us-ascii?Q?XToHPYuaTPPi88bEEVtCUJ6QJZFfqxBdiliVMVLZdHyfZSKEoxNqbZKiUl3P?= =?us-ascii?Q?Z3cTBZL3ZWGIlL3XqirD4tTzdWjrBz9MDH5XUaUxumMp2EfNohib57Sr9ZDu?= =?us-ascii?Q?wmbA9gkp806dsA8dakB6OVqkmZhZNz31MIEwul2q6BZDzGYLW+aLVmib5+xQ?= =?us-ascii?Q?mhm3ytaoa6oE6cR6mVz0YgKndIC7Dhu4TWtYdMXUYniRGhRg2RA362unNkfs?= =?us-ascii?Q?WzkWqEwU4UVMz0tze6SXl5lRKUpUGNkGqCPvHTaEHJNhgEVlLis2SkNNx9I5?= =?us-ascii?Q?rpjnvtP65BFUl4GfBkNyzCeBBkTngRzDg8Y9mnub9EpfqsfBdMDOo4TFMN23?= =?us-ascii?Q?8JLhn1lamelVShRSkCBT+VsTM3TI83VXblMcSt/WBYXOjM5AnANIewRUVKba?= =?us-ascii?Q?Bb5GxGGtzSrDi65Cdl2JrhgccqWQm96v4dOWjFqmxrPQRHhV7rZx8SlLep3u?= =?us-ascii?Q?KtcqBSHrGneoz/K/2L17pUzyVa1I3ZJfrOpa/6NfEsjdcsfv/bUSt7zbv2fr?= =?us-ascii?Q?rSUMRuw9pGWT4zR/b+tilYOg26r26zdxTd8UPt1uu8taakEuQD1y38YzMywy?= =?us-ascii?Q?oTsiIbRd9h2rYcdeOr76NgYFq/On5VDR1lMqwXDik4/Q5V1P2QJEsD3Kb/cm?= =?us-ascii?Q?ftnNm+LKSAlkzWPZRhD2qxsmMmB9MTzWvf0IXaSblEo/g6qnOO/sYEmb+GqX?= =?us-ascii?Q?NpYoseIZET/e1ztix8vrfZ97f0/keBBqtp1o7iK2/b1ekn94RUixZG+PpCR/?= =?us-ascii?Q?qV7NuIRop0IFDfQWx6f5JPP1eov3KgJekvPlmgy0BWd2dyhyZnb+n+ZWXLep?= =?us-ascii?Q?j/dfKFLOaj98ygel4gziTY8ksks64gyJAFJqPtxZVLMnspagqUiFpq7EKkZc?= =?us-ascii?Q?gurJ/sHLJUKAWlcPv8rCF8yMTwbAT7E=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR18MB4714.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 304e0a2f-a9f7-4dd9-193a-08da3958d1c2 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2022 05:31:26.5254 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 09jSQsWkiuZdyZrtpq3IgjbLrWQ0DbE6W2L/qbIFWhJ1b84Sgm8I65WkwpmBryWVLdL29l2i5Edg/Jl3TN1/lhgjHhNcpBntpnIOnUDA1nU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR18MB3028 X-Proofpoint-ORIG-GUID: _A4GAGuW3_zbVWF2SQawGQZjul6F5oVu X-Proofpoint-GUID: _A4GAGuW3_zbVWF2SQawGQZjul6F5oVu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-18_09,2022-05-17_02,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Please find comments inline from CI point of view. > -----Original Message----- > From: Brandon Lo > Sent: Friday, April 29, 2022 9:46 PM > To: roy.fan.zhang@intel.com; ciara.power@intel.com > Cc: dev@dpdk.org; Brandon Lo > Subject: [EXT] [PATCH v4 8/8] examples/fips_validation: add parsing for c= mac >=20 > External Email >=20 > ---------------------------------------------------------------------- > Added function to parse algorithm for CMAC test. >=20 > Signed-off-by: Brandon Lo > --- > examples/fips_validation/fips_validation.c | 31 +++++++++++++++++++--- > examples/fips_validation/main.c | 3 +++ > 2 files changed, 31 insertions(+), 3 deletions(-) >=20 > diff --git a/examples/fips_validation/fips_validation.c > b/examples/fips_validation/fips_validation.c > index 04dfb85262..8e0a55c624 100644 > --- a/examples/fips_validation/fips_validation.c > +++ b/examples/fips_validation/fips_validation.c > @@ -460,6 +460,8 @@ fips_test_parse_one_json_vector_set(void) > info.algo =3D FIPS_TEST_ALGO_AES_GCM; ...... ...... >=20 > +int > +parser_read_cmac_direction_str(__rte_unused const char *key, char *src, > + __rte_unused struct fips_val *val) Can this function be static in fips_validation_cmac.c which is more appropr= iate also ?. Thanks, Gowrishankar