From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 670F7A0503; Wed, 18 May 2022 17:46:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 567FA42B6F; Wed, 18 May 2022 17:46:18 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id BFAD942684 for ; Wed, 18 May 2022 17:46:17 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24IBrJkm010292; Wed, 18 May 2022 08:46:17 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2176.outbound.protection.outlook.com [104.47.55.176]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3g50as0wng-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 18 May 2022 08:46:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JzOLVTzx8Do1sPY/bySZeBBET61G56QMXY4wW2cbBudTHn228ndjNeUpnXXwa32z1xSU1ltYkocpk50jpFCgfSuAPdGzsAlzHc6LOVMZyuZn4rMTMCBoyy+/o0F3KAU5Bd4VPdp7HAqQ1e7EaZksHZomCKh4d9DEyM0/a1IcQu1bG0ljlHuuAif9at+YZY9uz9WCrvlkcJNJdY9MP4iJJxSt0/oGboPjjeVg+5cyIp+B9SY7kIAsM/MoAtHJmUOP/kC+PosrMNl/D7lO2N6c5tm1LIy05MSpVKV8xfofvfKXsOVn7KiM0iAOUFMDECmrtfFHZULtUZFTeYXlk4L9GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=chlAiQt5UuZf2fPgrT6K4osvcv0yDP9c16JshWhTnMI=; b=ThfBmLMTVj9LWa6ZWzswAmk4TTzW8Jm+opHTDLy5+xTy4zbmXVeHFLqx6J3jVVWpws+dd5QVvyG6egRY1JfCphqYnVbz7WT1zxR4Fn6pYfqO4VEEtQwQkHsIPwoo6eMM3hPjrcXcvJNDQ8Qpgm+0J152jGWf4aVxFuZQbrcfh6uLn3IU9zLx8zKsMSQKd/fMY3W3rmCMvHuQhhfTnwsvvxu1Dhr8Ha/4s29PV/57bXqRsD6bEIN5VN4+qp5A7yWcYWht1Zq6cbd/tkaEMSqa7vOKTohvGh48RQcDkGe3N5NZsPyhM+InMCWAucTS1gJP1wP74MmQ6J/M0AxIaxNgYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=chlAiQt5UuZf2fPgrT6K4osvcv0yDP9c16JshWhTnMI=; b=id3wEEUqPVll03JEeiBqF1x1kJKIXerafLhfFqrpAJdY/TK63cSncO3c7JpHt0edxTVMDVx9wmcR2i6NxWCh0XwTru7WY7rIrskMnCBxXvcYlzOt4MyOqpxG2kuna/c1USKjrAVCBwcv4cl8KO5pj249ueU07dUIZBeW1/IFD3c= Received: from CO1PR18MB4714.namprd18.prod.outlook.com (2603:10b6:303:e9::18) by MWHPR1801MB1936.namprd18.prod.outlook.com (2603:10b6:301:68::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Wed, 18 May 2022 15:46:15 +0000 Received: from CO1PR18MB4714.namprd18.prod.outlook.com ([fe80::f83c:2654:ed5:fd1f]) by CO1PR18MB4714.namprd18.prod.outlook.com ([fe80::f83c:2654:ed5:fd1f%6]) with mapi id 15.20.5273.014; Wed, 18 May 2022 15:46:15 +0000 From: Gowrishankar Muthukrishnan To: Brandon Lo , "roy.fan.zhang@intel.com" , "ciara.power@intel.com" CC: "dev@dpdk.org" , Akhil Goyal Subject: RE: [EXT] [PATCH v4 8/8] examples/fips_validation: add parsing for cmac Thread-Topic: [EXT] [PATCH v4 8/8] examples/fips_validation: add parsing for cmac Thread-Index: AQHYW+SQFV82Z3l360yi4iPZ5GC1Z60k5P2w Date: Wed, 18 May 2022 15:46:15 +0000 Message-ID: References: <20220129175514.746925-1-blo@iol.unh.edu> <20220429161559.415645-1-blo@iol.unh.edu> <20220429161559.415645-9-blo@iol.unh.edu> In-Reply-To: <20220429161559.415645-9-blo@iol.unh.edu> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7a240072-cd02-4c45-b960-08da38e58ac3 x-ms-traffictypediagnostic: MWHPR1801MB1936:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: N35LcZbD+61ofrCtqDoMl0/WHyR7jhRg4JETj1DK/4r3V32gj3CQsXUTpwAja1LC3IXw5fywzaOWEI2RHqxESp1FmYpZVy6VeUYTNJNzr+JqUwudWQ4wARFVARBKzpI1LG6KGQZtRrm+KLkmKxQRgMVATWuS+9mVV2UvxlmFShLXzi/VdcZzM2EVHwj05v8dntrOBHMwJLxIkGMzDaU9Bszd3he9gxa6w9Dh8LBOhs07sz9hoxt0aj+AEynfxI8zToVR5dmvFgx/YPMvjJBSeURT3ogOcEI4Ys+d6XZuG0dKDrel5GugudsBJKQkPiy3EoIHHF0eJZdGMVNWbAifoYOGjy/AiMo1U6yUODtnOFCE1HPXFNyWk0nu6sVrkuqfKtjcW3Cjfgqf29FDAAnpqDXk5NLB9T/IPc9cbbvEKWKfpsu3mvY5Jz6Voh4CmcN3V8LGNIZgDrLL2KpwoTWKzF1m6NN07NHxYHK6NkFIJdiCQYc5Pbca3no3eq48NrcsZ41i0a66e8qY/Il80AxZ+5nv6ROcy8zP9fGkgqsDoCuncka99zcFzVkNhkWrJ+M9YfP1MJyippbEWF1aJOYMcjHpToIGAWIbvRqn4NWRIOhsqgkmgPBPIFK6SAyp7O0qrSIybJ4J4Gte53nKiuFBGp8zYaOqr6KDJVTsRfpnWAWJtKlWWIpDbtTeeY9tLoDYs3R4wIqAbHpFFCXzuDyc3w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR18MB4714.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(4326008)(8676002)(122000001)(38070700005)(7696005)(76116006)(66946007)(66556008)(66446008)(64756008)(2906002)(66476007)(71200400001)(55016003)(52536014)(5660300002)(508600001)(8936002)(33656002)(38100700002)(110136005)(54906003)(316002)(107886003)(186003)(26005)(6506007)(86362001)(83380400001)(53546011)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0oJ32IRzkAvZ9bWmHdS5CCv0ptk13/JrwBCugXTGXe00BMSKlO0kdFgeua7t?= =?us-ascii?Q?z+F2u95uazk7he5A6L2BPBVErycpBPxO6GpkSCbSfBdFYe7/JYVjWhQUGUQh?= =?us-ascii?Q?NTkgU2A2DakFf2+fYIG5mmRuIduxnwR9fERAxwiL53Mnkjr/S2AAXN7WBOnm?= =?us-ascii?Q?D1/kRA6cqgMnPOLyT6b4kS68i9+C+uvPSehLye+y/ShNuiFc7CdYnDTP7shQ?= =?us-ascii?Q?CW3Hp8IWgQ6vUiutRCLCrGCm8JNtv8U1+kXxIjl83juNfVDGjVkqI7lGj0RH?= =?us-ascii?Q?UtDgL0fiViRC5dEGP2VtjIajl13wwg4hgd5Gd+Ay0FM/lrFUvyDLpQkPjwsR?= =?us-ascii?Q?4bcUWugsH+XjAK9EtUjdFWQt2kMxd1a/JG39vJEPM612MVoTXSZzDJ2m4f5v?= =?us-ascii?Q?8G2vrY+ytJwo58RtY0DdUubUuagw++vqOYBv7WPbGGdrKeQAFG4ZAGSkTY7U?= =?us-ascii?Q?m0SGbzFK79krL8Newsft7UvEMX+qUq+9aWs0/PipSiwK4Verur0SvFziGKBi?= =?us-ascii?Q?sgnljME1UL3gbXECHahvt/K3Hw8WyX33UX8N3ZkJbHkrrpOU8gvApBUC7CI3?= =?us-ascii?Q?S5FRHFCcp2RchS/tZHAlO/TzjeLaNhi83cb9GG9xJAvCeKmltVE0w++QhhB8?= =?us-ascii?Q?zo31a2yCdTZMk3xZPQEIFGR7LuhOZ3LLcOoEOzaxhHi/NFdwAyh4FEe2qYuI?= =?us-ascii?Q?RyiPuluxq2jd4ngnTbYcEeLvpNnKkv3sB7o4zj5B5mI9+duNOAr/5v7vSNJf?= =?us-ascii?Q?EZNFyiM116Akmg61rzQ18nk6X2gJo6apVS7bEpOEQHJJJbc9cp8VPZvHzcxV?= =?us-ascii?Q?8jxm+D0M31maGE1Nkeb2Ba/eU0BVkQqhRVCVAQ2MjpWNPzIr7gsZqzTbacJS?= =?us-ascii?Q?4gKUu5E+oll+Uo85J4s4gbC2FqtVnZnm5ejpIhE3BPEiNXB02PcktN6Y0n9i?= =?us-ascii?Q?+uhVMyKe2OQnG/ULzH7u0zM+Su6IB3HSfd4QWKtA0doBsQGl9tlBWsyo/3cl?= =?us-ascii?Q?+xAcpgKd2lCuxvPUhJ6LwM29+kK4wDMh0Op4axShnpzIqtoDd1Jqzzl3p/aY?= =?us-ascii?Q?qXYzy4zNUtPHQehcE/LRBRaBZnHa0roxeY9Tz0R+Emx984rGhJS/nNoNJqyp?= =?us-ascii?Q?gPE/B5a6zBSCBy5L6vjuMNFjFXH5DqwFXhAaCTb93teLs9u5N8FtgvAh6v8R?= =?us-ascii?Q?nVGogrTV9AoJlg+VWBhRK+90Oh1BXDOsfnMQP6kWLAkX4zagfdprNAvTy+Vk?= =?us-ascii?Q?S5hXFIFMG4YjybKhFU9jxCJcUdZRCwA2CRP/kQnX0HlQ8U3ovVEP4broZonr?= =?us-ascii?Q?GTogrjk0tAXsq7OpjqOwkI91CeJfcHW0tgu86fdkXEzoGj98DP8Hvn/7z6s4?= =?us-ascii?Q?Lk4xz57xBonOhknKusYvXDEb+WHVl0M8VbtrlU9X1bFIWc+O5x9BWmilUbsj?= =?us-ascii?Q?ppHJHi9PUsLb1wsoXuFJHe44oPRXDzT9h7c31xDFQshyBGjn1Jr/DXGlvuse?= =?us-ascii?Q?iIfb8O9mw0WSMNR1JrPpLk7Tr/FTWDi7HDARL6cPsMIX/M7w5fV2hZEQlccS?= =?us-ascii?Q?KYdKiQ3Zlz+AKB7qtASu76LffMidWn0vhKHQ0SB8KKRqhx5MJTLZ3vF5u0zb?= =?us-ascii?Q?PyRNsRhuTPutFc6TBpyYoybFsZLnxagWdeJwD4/C4jtGVlKq1wQYp1ZmukO8?= =?us-ascii?Q?fDd8d1ZFheQnHA9mo2iXCLBGDDc7R83dNikprWZTUfbScnAkUlhNbfUsgfMl?= =?us-ascii?Q?XeqYzxCUoQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR18MB4714.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a240072-cd02-4c45-b960-08da38e58ac3 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2022 15:46:15.2626 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iElcyXRXY2z6zlRiTsrvRJXjAXhbrlW1yYG5bHlEbM/Vi9MDY1RQWCFBe+pdSQb0BgGv4uYnqBbfkhDu74agPtWR2bHwg39hPA1ttczQhWk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1801MB1936 X-Proofpoint-ORIG-GUID: 9UWymkJVRp0u1dvEIQy5tfsov5z4gpFO X-Proofpoint-GUID: 9UWymkJVRp0u1dvEIQy5tfsov5z4gpFO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-18_06,2022-05-17_02,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Verified the functionality changes and looks good to me. Acked-by: Gowrishankar Muthukrishnan Thanks. > -----Original Message----- > From: Brandon Lo > Sent: Friday, April 29, 2022 9:46 PM > To: roy.fan.zhang@intel.com; ciara.power@intel.com > Cc: dev@dpdk.org; Brandon Lo > Subject: [EXT] [PATCH v4 8/8] examples/fips_validation: add parsing for c= mac >=20 > External Email >=20 > ---------------------------------------------------------------------- > Added function to parse algorithm for CMAC test. >=20 > Signed-off-by: Brandon Lo > --- > examples/fips_validation/fips_validation.c | 31 +++++++++++++++++++--- > examples/fips_validation/main.c | 3 +++ > 2 files changed, 31 insertions(+), 3 deletions(-) >=20 > diff --git a/examples/fips_validation/fips_validation.c > b/examples/fips_validation/fips_validation.c > index 04dfb85262..8e0a55c624 100644 > --- a/examples/fips_validation/fips_validation.c > +++ b/examples/fips_validation/fips_validation.c > @@ -460,6 +460,8 @@ fips_test_parse_one_json_vector_set(void) > info.algo =3D FIPS_TEST_ALGO_AES_GCM; > if (strstr(algo_str, "HMAC")) > info.algo =3D FIPS_TEST_ALGO_HMAC; > + if (strstr(algo_str, "CMAC")) > + info.algo =3D FIPS_TEST_ALGO_AES_CMAC; > else > return -EINVAL; >=20 > @@ -470,7 +472,6 @@ int > fips_test_parse_one_json_group(void) > { > int ret, i; > - json_int_t val; > json_t *param; >=20 > if (info.interim_callbacks) { > @@ -478,8 +479,20 @@ fips_test_parse_one_json_group(void) > for (i =3D 0; info.interim_callbacks[i].key !=3D NULL; i++) { > param =3D > json_object_get(json_info.json_test_group, > info.interim_callbacks[i].key); > - val =3D json_integer_value(param); > - snprintf(json_value, 255, > "%"JSON_INTEGER_FORMAT, val); > + switch (json_typeof(param)) { > + case JSON_STRING: > + snprintf(json_value, 256, "%s", > json_string_value(param)); > + break; > + > + case JSON_INTEGER: > + snprintf(json_value, 255, > "%"JSON_INTEGER_FORMAT, > + json_integer_value(param)); > + break; > + > + default: > + return -EINVAL; > + } > + > /* First argument is blank because the key > * is not included in the string being parsed. > */ > @@ -673,6 +686,18 @@ parser_read_uint32_bit_val(const char *key, char > *src, struct fips_val *val) > return 0; > } >=20 > +int > +parser_read_cmac_direction_str(__rte_unused const char *key, char *src, > + __rte_unused struct fips_val *val) > +{ > + if (strcmp(src, "gen") =3D=3D 0) > + info.op =3D FIPS_TEST_ENC_AUTH_GEN; > + else if (strcmp(src, "ver") =3D=3D 0) > + info.op =3D FIPS_TEST_DEC_AUTH_VERIF; > + > + return 0; > +} > + > int > writeback_hex_str(const char *key, char *dst, struct fips_val *val) { d= iff --git > a/examples/fips_validation/main.c b/examples/fips_validation/main.c index > de6dedaf75..aa8034c29f 100644 > --- a/examples/fips_validation/main.c > +++ b/examples/fips_validation/main.c > @@ -1946,6 +1946,9 @@ fips_test_one_test_group(void) > case FIPS_TEST_ALGO_HMAC: > ret =3D parse_test_hmac_json_init(); > break; > + case FIPS_TEST_ALGO_AES_CMAC: > + ret =3D parse_test_cmac_json_init(); > + break; > default: > return -EINVAL; > } > -- > 2.25.1