From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BFDD0A0548; Fri, 3 Dec 2021 10:09:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 83CA94014F; Fri, 3 Dec 2021 10:09:08 +0100 (CET) Received: from na01-obe.outbound.protection.outlook.com (mail-cusazlp17010002.outbound.protection.outlook.com [40.93.13.2]) by mails.dpdk.org (Postfix) with ESMTP id 39AC24068C for ; Wed, 1 Dec 2021 19:58:31 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=azJ7CM+cRQ32t0A12lu4hfB1zZAdcQdh5YlSmrpGxqgN5N7+Hlm1YstHBg/bJBiN3efLNeEuBQ/OoEWgGXYUSbj90U+sE5Dk+ZMyzXCxzJgpDzMLdm2KYbJzMmhElDFHiXGoGHpxhnZq+AAvySN8E4yKQ2btdCreut2RvGVdcOJxxBSNv55un1XUsMT2AC0e1uh19YBXCe9JxUx64xjqAwzv2GQB4O9iHN7N0wzZA64MXHyuZXO6oDKs3+IcBmoJHAhljOpkywYo92bQbcON92N8tPMJTns6n+8KaWQVphWOnhEBibry6KRPKQeL15PnBidZMxuEYARgGIL3bGD7gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EPNJ+39zy86aFSwBdxlcvYl/En3aUSJ/55GZYvZBO7E=; b=EjTA8Wux/OT6WYfJpUi+aURUKBnunBWxXi4IBUK9Ol92tPT0LsuCy1WdfAX0pRlRinVLlKE83sJN3yiBdsRDN/FMONs1o3ZZSSZDG59IfCVu9dUCbLToSSXm2NBTFV8aRhhWxHNWIlVr+0EZoaqkKj7l9C/HWTsEPNk0F+1DUpuTCMdEfrlaqaM4LnKIvxSKTv2UClLBOpimaqNTDxtmEURoLVz2d7cuae7jDbpFDNYmwNhuZH3519SsB3MltHwTCd+rWlamTPo7qb6SAedqcywowIbgN5E1gpaqzs9jjWEXrBMbjK/bp/R3Fb9XaQdhwvTzlb40oKVAXbxu0alCLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EPNJ+39zy86aFSwBdxlcvYl/En3aUSJ/55GZYvZBO7E=; b=A2y6XxQJufsRDTwaTj/2EaLvd2oxId85ZBo6jNG8G9dKZYYltniTZk5PT2u8NVQo7IoEJuUVy+fBqQvpQ5nioqyu2G4umiP8g/76nNPVPqkmunPHm1Do81OdLtzLlijRiJGlRRmkaKyuR2WHGRwvFCk4aVDI/fK9oS+Ck6MLA28= Received: from CO1PR21MB1297.namprd21.prod.outlook.com (2603:10b6:303:160::6) by MWHPR21MB0288.namprd21.prod.outlook.com (2603:10b6:300:7a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.1; Wed, 1 Dec 2021 18:58:26 +0000 Received: from CO1PR21MB1297.namprd21.prod.outlook.com ([fe80::1c1:7cfa:e7a0:7fa6]) by CO1PR21MB1297.namprd21.prod.outlook.com ([fe80::1c1:7cfa:e7a0:7fa6%4]) with mapi id 15.20.4755.004; Wed, 1 Dec 2021 18:58:26 +0000 From: Tyler Retzlaff To: Stephen Hemminger , Jie Zhou CC: "dev@dpdk.org" , Dmitry Kozlyuk , "navasile@linux.microsoft.com" , Dmitry Malloy , "Kadam, Pallavi" , talshn , thomas , "aconole@redhat.com" Subject: RE: [EXTERNAL] Re: [PATCH v9 9/9] app/test: enable subset of unit tests on Windows Thread-Topic: [EXTERNAL] Re: [PATCH v9 9/9] app/test: enable subset of unit tests on Windows Thread-Index: AQHX5uOkslPvIWTkkkWzOHGJzSaeAawd+/Sg Date: Wed, 1 Dec 2021 18:58:25 +0000 Message-ID: References: <1635216361-23641-1-git-send-email-jizh@linux.microsoft.com> <1638381938-6113-1-git-send-email-jizh@linux.microsoft.com> <1638381938-6113-10-git-send-email-jizh@linux.microsoft.com> <20211201104535.207b57c6@hermes.local> In-Reply-To: <20211201104535.207b57c6@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=22c8f310-8960-44d3-bcbe-bb1d7120f0a0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-12-01T18:54:28Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c724c097-23bc-4e9d-7230-08d9b4fc8e44 x-ms-traffictypediagnostic: MWHPR21MB0288:EE_ x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cRYPzmGh1KFKVfw8mB3/z0JT2o1ec2YmjWWYsb83zoT0YJRx59p6lwbs++BpKiDQwesMe6AWanjSLAvWMhVWdI6BoBAtSoAHZSLggka2DCGL/BKUulsAgfbO0QIRqH+xiugbDnDZE6fdVxWXHV19huSbtvVzcUfxtYMGagWgpewqGKS4AFNBa0OFt7moume6STgVU/xGoS9caAJ4JEGgLnyN4nDs2F/KYaBc9teK6LZKNyCsFWfdVa16O2d15rnl6SoJTWKB6utAYU9hcHSQy0Q2cL5SESSXQCYDZKqxDBWrpxaNpeIfb+JKU1/CoOisey372R1L30Nj8nnCS6yaI21HHfMrAHCZNce8FFU44wvPN+jeRL0Gob1CSUAOIPVe/24dz9+5N4Ee5cCZj2x7Uslu7mXqMLJC2kQnOaNv5rTmXLX1vYtz+2II58fNhdjVuH2IdftFoOEBKafmXuWktGjn3PKVJO2PpG0Kian7PqfMvHQVCMwgKdrxUOKT9qNm0jv/c5w6jH9EpSwhhRxMzV1CBpYS0WqN5pW7hSp/Mex4O0pXIpZ1/UDh0rzHVbG5b6OZQwaKeLtTBsSTb0D60O9QBe5580BMYu+k5R3CqhgunrQF7cFWJGqYbzhc8LlUnXA+o7HANQYYBfakdEO6mGgQgeEqPIaeo+J5jN7LFMvblsmltH3j6Yc/mjtebu/ogbHPlgsaGtzoLq/gHIIgCnTiEyV9zFnZqGOXgzK1U82N2p/tEW6J3IjfuB8fbZ+g x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR21MB1297.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(8676002)(2906002)(86362001)(8936002)(38070700005)(83380400001)(33656002)(54906003)(52536014)(9686003)(53546011)(66446008)(66946007)(64756008)(76116006)(66556008)(4326008)(66476007)(508600001)(316002)(55016003)(8990500004)(26005)(186003)(6506007)(7696005)(38100700002)(10290500003)(71200400001)(5660300002)(82950400001)(82960400001)(122000001)(110136005)(20210929001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zd3pw06ObJR9/kF/cdYk8ob7Iiw654aftczFR+0eGWZO6IApVp7IfWxeiT0Y?= =?us-ascii?Q?nD20JrE5R/AYMZWXlMJQyiNN8ML8eXXB6oeEEXbtWyMY+Ke+947jyqUzdhTP?= =?us-ascii?Q?kaM6iSkSP4En28Tnqwl9oPqhnLbhC1cl44ubWeufyH8oAMcTbtVqpMF0AeAP?= =?us-ascii?Q?q1o1nw6wtGaFBDC9VPPJs8F8lycLYGUw7W8R3KjDA+OmTIaCNJC+lgI5/kXU?= =?us-ascii?Q?MOiYOHrwBoVSoRBKU4v2YXUUGcwAfTbnJ6bq7RyF02Zm7eNkwVdZ8gCDvMLS?= =?us-ascii?Q?rrzd0wuSrB7THTYuCoTNZka02Ray+Y0dwAaZ8TQVKwXbkfyCooBtPpzTqiR/?= =?us-ascii?Q?gHbVtBVW1te/7YQM9Gg6WRKwAYcYNJWZj/RjGQYx9xx7xsQSTCJchu6UOuPZ?= =?us-ascii?Q?WGU18QOvbTQLC4tMOAh8XNe6uJLNi5Wi0O+AanRt6d87qiJTEJtUgquFapFU?= =?us-ascii?Q?5y7FONWTfOQ/Xyt9uIgDE6IHzLh1THFDGIvmr01fpqJkxbhsUSFoUCK3/L54?= =?us-ascii?Q?WNwbETewTAXDz6Gap7J7eI13G+NGPc5kMY/p/IKt+TJe6VVp39PRHoUEFkMU?= =?us-ascii?Q?T1F6EXig8tGQFS8Z41WRO0aPnBRF7m2xgsimHzfd4xQvgJEURRGFG4ek5x6E?= =?us-ascii?Q?1eet5a1ao+2b4ske8qwdEi+PqNHsTAhuUto50J79f2eakaTpJkU2GUVMXj6y?= =?us-ascii?Q?JTuuJwAkFyTM8I2aA1BrkNvc8c3oJnLDWLOJXZR4Q7CkOzCMsCFrdPSfiC4Q?= =?us-ascii?Q?TidFqX/LxNhnNkk5+EqVjphb1lAORYOhpWSee/2pMNbcrBNHpJ7kpOiVpeld?= =?us-ascii?Q?BVyH1CkAFH7jkjx76GH6sDSV87ZOgmjVv0DNd4FM6uMgFo7/4fPemrMyJ8dV?= =?us-ascii?Q?ojOAGxcr91thwtFAPpdc66nRuWf1qz1YT0Yk02AyFoQqTl0u/h4cqB06Z/4M?= =?us-ascii?Q?tJzNZPzb4kukaXrlzZ6DOk41f5gREc2nTKvyfq5bbHE9vH0rOBBJo/lbztmR?= =?us-ascii?Q?KiKKUHZjzdEV0+ctZ8I/B0/KqEjiPT7k02y94dB+DMQHdyWnvX45gIS2le+V?= =?us-ascii?Q?N82awmfB66xEoIn5L1auUqjZSzJEelKP2+IK+yqw4VWQiISp+NKPCl0E44IF?= =?us-ascii?Q?MTlAjlog9P48ZQTODyRqh+sKJq7y4fiBF2o5bpQq1XPVOutESg0pGfiLYIgX?= =?us-ascii?Q?/4Vic0Q4YXzy+yFly6UoYMyzEtIr6BOzpPLXI170hjRYDfRSdSRuWRa0jbm3?= =?us-ascii?Q?EuP+l9jZXcJQU9rwUH+YlOkfMj5RgAHQFnc9Rbgr/rIylenRgxteh4q6y8M2?= =?us-ascii?Q?jcxc6IV+NkZy6oRyCw9J/+30fNgfwwn7HOhNzdKsPgeucH8OcIftzNJ9tHhM?= =?us-ascii?Q?jOzORl8+8jYciVbhkZob5yuRkKzR88MF26y47MgmFtqgqkRjWgQsfdbLvBJ3?= =?us-ascii?Q?dLCWOc6Cl2djPCc+VjOYIuW3dFRlap6CppGV86I/pGTXC7v23Z/dOz1iRpHr?= =?us-ascii?Q?5OsMWwOn/6KOFbBQs7o97Dy8YHFQbgU1pwq2ZUTDvSTLnOq5FvA3LQbTl9LX?= =?us-ascii?Q?CPxoR/RQ5TMuas0+2A0GMqA8+wNDyC+0qB0hdk3c00Y884cMb+YJg9Mo+v1P?= =?us-ascii?Q?qg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR21MB1297.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c724c097-23bc-4e9d-7230-08d9b4fc8e44 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2021 18:58:25.9045 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dpqK57gfUlznPqo9AxkcpNFG+651pd592SsoKkHj0FPXNn0h3nBlI/2SjAM7WArZGtBZMIYVcR5qiHHnp4tg2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0288 X-Mailman-Approved-At: Fri, 03 Dec 2021 10:09:07 +0100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Please don't delay integration of this patch set further to port individual= tests. Individual tests can be ported to windows with significantly reduc= ed sensitivity to the churn once the conditional mechanisms are in place. We spend enormous amounts of time continuously rebasing it every time one o= f the existing tests is churned or new tests are added it's a losing game g= iven the rate of review the community provides for windows patches. Thanks -----Original Message----- From: Stephen Hemminger =20 Sent: Wednesday, December 1, 2021 10:46 AM To: Jie Zhou Cc: dev@dpdk.org; Dmitry Kozlyuk ; Tyler Retzlaff= ; navasile@linux.microsoft.com; Dmitry Malloy ; Kadam, Pallavi ; talshn ; thomas ; aconole@redhat.com Subject: [EXTERNAL] Re: [PATCH v9 9/9] app/test: enable subset of unit test= s on Windows On Wed, 1 Dec 2021 10:05:38 -0800 Jie Zhou wrote: > diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c index=20 > b206db27ae..c2ea9090cf 100644 > --- a/app/test/test_dmadev.c > +++ b/app/test/test_dmadev.c > @@ -2,6 +2,17 @@ > * Copyright(c) 2021 HiSilicon Limited > * Copyright(c) 2021 Intel Corporation > */ > +#include "test.h" > + > +#ifdef RTE_EXEC_ENV_WINDOWS > +static int > +test_dma(void) > +{ > + printf("dma not supported on Windows, skipping test\n"); > + return TEST_SKIPPED; > +} > + > +#else Rather than littering code with ifdefs is it not possible to just not build= these tests on Windows?