From: Ankur Dwivedi <adwivedi@marvell.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Anoob Joseph <anoobj@marvell.com>,
Akhil Goyal <gakhil@marvell.com>,
Tejasree Kondoj <ktejasree@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
dpdk stable <stable@dpdk.org>
Subject: RE: [EXT] Re: [PATCH 1/2] common/cpt: fix compilation with GCC 12
Date: Fri, 17 Jun 2022 12:39:21 +0000 [thread overview]
Message-ID: <CO3PR18MB500509805655483BA00471D8DDAF9@CO3PR18MB5005.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8zYRKNAjnSfFAzD_YtJSJgoUS=0qeKdWj+e5Y-_m-ep5Q@mail.gmail.com>
Hi David,
>-----Original Message-----
>From: David Marchand <david.marchand@redhat.com>
>Sent: Friday, June 17, 2022 5:38 PM
>To: Ankur Dwivedi <adwivedi@marvell.com>
>Cc: dev <dev@dpdk.org>; Anoob Joseph <anoobj@marvell.com>; Akhil Goyal
><gakhil@marvell.com>; Tejasree Kondoj <ktejasree@marvell.com>; Jerin
>Jacob Kollanukkaran <jerinj@marvell.com>; dpdk stable <stable@dpdk.org>
>Subject: [EXT] Re: [PATCH 1/2] common/cpt: fix compilation with GCC 12
>
>External Email
>
>----------------------------------------------------------------------
>On Fri, Jun 17, 2022 at 8:15 AM Ankur Dwivedi <adwivedi@marvell.com>
>wrote:
>>
>> The following warning is observed with GCC 12 compilation:
>>
>> In function ‘fill_sg_comp_from_iov’,
>> inlined from ‘cpt_zuc_snow3g_enc_prep’ at
>> ../drivers/common/cpt/cpt_ucode.h:1672:9,
>> inlined from ‘cpt_fc_enc_hmac_prep’ at
>> ../drivers/common/cpt/cpt_ucode.h:2472:3,
>> inlined from ‘fill_digest_params’ at
>> ../drivers/common/cpt/cpt_ucode.h:3548:14,
>> inlined from ‘otx_cpt_enq_single_sym’ at
>> ../drivers/crypto/octeontx/otx_cryptodev_ops.c:541:9,
>> inlined from ‘otx_cpt_enq_single_sym_sessless’ at
>> ../drivers/crypto/octeontx/otx_cryptodev_ops.c:584:8,
>> inlined from ‘otx_cpt_enq_single’ at
>> ../drivers/crypto/octeontx/otx_cryptodev_ops.c:611:11,
>> inlined from ‘otx_cpt_pkt_enqueue’ at
>> ../drivers/crypto/octeontx/otx_cryptodev_ops.c:643:9,
>> inlined from ‘otx_cpt_enqueue_sym’ at
>> ../drivers/crypto/octeontx/otx_cryptodev_ops.c:668:9:
>> ../drivers/common/cpt/cpt_ucode.h:415:36: warning: array subscript 0
>> is outside array bounds of ‘buf_ptr_t[0]’ {aka ‘struct buf_ptr[]’}
>> [-Warray-bounds]
>> 415 | e_dma_addr = bufs[j].dma_addr;
>> | ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
>> ../drivers/common/cpt/cpt_ucode.h:416:48: warning: array subscript 0
>> is outside array bounds of ‘buf_ptr_t[0]’ {aka ‘struct buf_ptr[]’}
>> [-Warray-bounds]
>> 416 | e_len = (size > bufs[j].size) ?
>> | ~~~~~~~^~~~~
>>
>> This patch resolves the warning.
>>
>
>Bugzilla ID: 861
>> Fixes: 9be415daf469 ("common/cpt: add common defines for microcode")
>> Fixes: b74652f3a91f ("common/cpt: add microcode interface for
>> encryption")
>Nit: No need for this blank line.
Thanks for the review. Will send a v2 with the changes.
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
>> Reviewed-by: Anoob Joseph <anoobj@marvell.com>
>> Reviewed-by: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
>
>
>--
>David Marchand
Regards,
Ankur
next prev parent reply other threads:[~2022-06-17 12:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 6:14 [PATCH 0/2] " Ankur Dwivedi
2022-06-17 6:14 ` [PATCH 1/2] common/cpt: " Ankur Dwivedi
2022-06-17 12:07 ` David Marchand
2022-06-17 12:39 ` Ankur Dwivedi [this message]
2022-06-17 6:14 ` [PATCH 2/2] crypto/cnxk: " Ankur Dwivedi
2022-06-17 11:36 ` [PATCH 0/2] " David Marchand
2022-06-17 13:39 ` [PATCH v2 " Ankur Dwivedi
2022-06-17 13:39 ` [PATCH v2 1/2] common/cpt: " Ankur Dwivedi
2022-06-17 13:39 ` [PATCH v2 2/2] crypto/cnxk: " Ankur Dwivedi
2022-06-20 9:08 ` [PATCH v2 0/2] " Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO3PR18MB500509805655483BA00471D8DDAF9@CO3PR18MB5005.namprd18.prod.outlook.com \
--to=adwivedi@marvell.com \
--cc=anoobj@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
--cc=ktejasree@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).