From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00245423B7; Thu, 12 Jan 2023 14:25:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF59542D22; Thu, 12 Jan 2023 14:25:13 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id F092D40E25 for ; Thu, 12 Jan 2023 14:25:11 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30CCJJDK005392; Thu, 12 Jan 2023 05:22:33 -0800 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3n23b2hyby-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Jan 2023 05:22:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D650OaEAIiuZE3udA3VFVbnPqjThEpYYJhkR1hfadOmntxXliSsHRnsqIx0YhmB7GDHHUiIxpwKGS3lAYFFunkhhl93+aY6ocGa+kpIoqmnQJJX88iS+6DgzlAv06qx7Oj+HnrJir7Oto40jhPOKezrOD2pW4G1tAM1cKv1fQYxWpseJm57z//OF62ISA+ZFlsxdfRgS+pxwewI7LSqKgZPhPpW1XgrsDP+mX9z9i4UQSm+kR7yBGBZJbgwy706WS6tKgEYEPWxuxIxvRVbr7IOnnFi2hWg81o1ZsnCJIsJFwEJwOZoEipDsmUbky/IjJnr6RJ2yAQLNV8iPaagBTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FMWaIJ4IKsCN9fjhuSX8AK51yPWQaKnCm/hplM8oDNk=; b=RvnDjkQdiRmbmu45Wg0Ry+h20+tCEk0nj34DEY3rsPQdSGx6Vi+R+13sIxhSbEY3gc99GX0M9DTq7nVfV+pb4xMLhCviTdzAD6sDorj84RX7Lt/Gdj+dH5jWPzm0KtcpAYTahfeRuiHyHYfnRVqISxE64eC9GzshsrPErZL67TBfcg8UV2hlc4dkd/gjvIptWVTxA+OicH7gT18R9VBuGQ6P/jC1KBw9daAHy3XhZTPdnXm8BmLqg8SEczZ9SSJTSYuR3o3jgi4cmliL91fzVZcF0xDIvJWDx92pJBwh1Ay+sBkfbH6+ucxCEjHTFJ4E1j2FszuBROosqNMzsE8LTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FMWaIJ4IKsCN9fjhuSX8AK51yPWQaKnCm/hplM8oDNk=; b=MM1oFzYCdl31ZkXLlGRDCz4XUjao4Y8NUa5xJsTM2j1Vo7cIDvc2TP/lBu01J2L+nnUAjoteCZ7zjmwSQTgzd+E7SjPgFy0zfRg4FaLKeCL2vhWFK71eQCOL4XuRe51vzL/ZCqB6OKkTm54Kobw9eCLFszFeLR56VFyqe73YAOo= Received: from CO3PR18MB5005.namprd18.prod.outlook.com (2603:10b6:303:17e::22) by PH7PR18MB5059.namprd18.prod.outlook.com (2603:10b6:510:15e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 13:22:29 +0000 Received: from CO3PR18MB5005.namprd18.prod.outlook.com ([fe80::305c:f1fa:266a:4058]) by CO3PR18MB5005.namprd18.prod.outlook.com ([fe80::305c:f1fa:266a:4058%4]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 13:22:29 +0000 From: Ankur Dwivedi To: =?iso-8859-1?Q?Morten_Br=F8rup?= , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "mdr@ashroe.eu" , "orika@nvidia.com" , "ferruh.yigit@amd.com" , "chas3@att.com" , "humin29@huawei.com" , "linville@tuxdriver.com" , "ciara.loftus@intel.com" , "qi.z.zhang@intel.com" , "mw@semihalf.com" , "mk@semihalf.com" , "shaibran@amazon.com" , "evgenys@amazon.com" , "igorch@amazon.com" , "chandu@amd.com" , Igor Russkikh , "shepard.siegel@atomicrules.com" , "ed.czeck@atomicrules.com" , "john.miller@atomicrules.com" , "ajit.khaparde@broadcom.com" , "somnath.kotur@broadcom.com" , Jerin Jacob Kollanukkaran , "Maciej Czekaj [C]" , Shijith Thotton , Srisivasubramanian Srinivasan , Harman Kalra , "rahul.lakkireddy@chelsio.com" , "johndale@cisco.com" , "hyonkim@cisco.com" , "liudongdong3@huawei.com" , "yisen.zhuang@huawei.com" , "xuanziyang2@huawei.com" , "cloud.wangxiaoyun@huawei.com" , "zhouguoyang@huawei.com" , "simei.su@intel.com" , "wenjun1.wu@intel.com" , "qiming.yang@intel.com" , "Yuying.Zhang@intel.com" , "beilei.xing@intel.com" , "xiao.w.wang@intel.com" , "jingjing.wu@intel.com" , "junfeng.guo@intel.com" , "rosen.xu@intel.com" , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda , Sunil Kumar Kori , Satha Koteswara Rao Kottidi , Liron Himi , "zr@semihalf.com" , Radha Chintakuntla , Veerasenareddy Burru , Sathesh B Edara , "matan@nvidia.com" , "viacheslavo@nvidia.com" , "longli@microsoft.com" , "spinler@cesnet.cz" , "chaoyong.he@corigine.com" , "niklas.soderlund@corigine.com" , "hemant.agrawal@nxp.com" , "sachin.saxena@oss.nxp.com" , "g.singh@nxp.com" , "apeksha.gupta@nxp.com" , "sachin.saxena@nxp.com" , "aboyer@pensando.io" , Rasesh Mody , Shahed Shaikh , Devendra Singh Rawat , "andrew.rybchenko@oktetlabs.ru" , "jiawenwu@trustnetic.com" , "jianwang@trustnetic.com" , "jbehrens@vmware.com" , "maxime.coquelin@redhat.com" , "chenbo.xia@intel.com" , "steven.webster@windriver.com" , "matt.peters@windriver.com" , "bruce.richardson@intel.com" , "mtetsuyah@gmail.com" , "grive@u256.net" , "jasvinder.singh@intel.com" , "cristian.dumitrescu@intel.com" , "jgrajcia@cisco.com" Subject: RE: [PATCH v5 1/6] eal: trace: add trace point emit for blob Thread-Topic: [PATCH v5 1/6] eal: trace: add trace point emit for blob Thread-Index: AQHZJng5/m1CA7HluUqTaSpcmmYntq6auLWAgAAHf+A= Date: Thu, 12 Jan 2023 13:22:29 +0000 Message-ID: References: <20221222063306.3383695-1-adwivedi@marvell.com> <20230112112140.807233-1-adwivedi@marvell.com> <20230112112140.807233-2-adwivedi@marvell.com> <98CBD80474FA8B44BF855DF32C47DC35D87669@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87669@smartserver.smartshare.dk> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-rorf: true x-dg-ref: =?iso-8859-1?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcYWR3aXZlZG?= =?iso-8859-1?Q?lcYXBwZGF0YVxyb2FtaW5nXDA5ZDg0OWI2LTMyZDMtNGE0MC04NWVlLTZi?= =?iso-8859-1?Q?ODRiYTI5ZTM1Ylxtc2dzXG1zZy0yMDZjYjllNC05MjdjLTExZWQtOTUwZS?= =?iso-8859-1?Q?1lODZhNjQyNWYwOTJcYW1lLXRlc3RcMjA2Y2I5ZTYtOTI3Yy0xMWVkLTk1?= =?iso-8859-1?Q?MGUtZTg2YTY0MjVmMDkyYm9keS50eHQiIHN6PSI1MTY1IiB0PSIxMzMxOD?= =?iso-8859-1?Q?AwMzMzOTMyODUxNjEiIGg9InpWVGlIVXVPbmhkSGhreEZzeDZXZjF0TjMw?= =?iso-8859-1?Q?ST0iIGlkPSIiIGJsPSIwIiBibz0iMSIgY2k9ImNBQUFBRVJIVTFSU1JVRk?= =?iso-8859-1?Q?5DZ1VBQU5nSEFBQXAySlRsaUNiWkFXT215aG4zR1RxTFk2YktHZmNaT29z?= =?iso-8859-1?Q?TUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFIQUFBQUJvQndBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFFQUFRQUJBQUFBM1R6RkFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBSjRBQUFCaEFHUUFaQUJ5QUdVQWN3QnpBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5nQU?= =?iso-8859-1?Q?FBR01BZFFCekFIUUFid0J0QUY4QWNBQmxBSElBY3dCdkFHNEFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQVl3QjFB?= =?iso-8859-1?Q?SE1BZEFCdkFHMEFYd0J3QUdnQWJ3QnVBR1VBYmdCMUFHMEFZZ0JsQUhJQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJqQUhVQWN3QjBBRz?= =?iso-8859-1?Q?hBYlFCZkFITUFjd0J1QUY4QVpBQmhBSE1BYUFCZkFIWUFNQUF5QUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refone: =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFBbm?= =?iso-8859-1?Q?dBQUFHTUFkUUJ6QUhRQWJ3QnRBRjhBY3dCekFHNEFYd0JyQUdVQWVRQjNB?= =?iso-8859-1?Q?RzhBY2dCa0FITUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFBWXdC?= =?iso-8859-1?Q?MUFITUFkQUJ2QUcwQVh3QnpBSE1BYmdCZkFHNEFid0JrQUdVQWJBQnBBRz?= =?iso-8859-1?Q?BBYVFCMEFHVUFjZ0JmQUhZQU1BQXlBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQmpBSFVBY3dCME?= =?iso-8859-1?Q?FHOEFiUUJmQUhNQWN3QnVBRjhBY3dCd0FHRUFZd0JsQUY4QWRnQXdBRElB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdRQWJBQndBRjhBY3dCckFI?= =?iso-8859-1?Q?a0FjQUJsQUY4QVl3Qm9BR0VBZEFCZkFHMEFaUUJ6QUhNQVlRQm5BR1VBWH?= =?iso-8859-1?Q?dCMkFEQUFNZ0FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBUUFB?= =?iso-8859-1?Q?QUFBQUFBQUNBQUFBQUFDZUFBQUFaQUJzQUhBQVh3QnpBR3dBWVFCakFHc0?= =?iso-8859-1?Q?FYd0JqQUdnQVlRQjBBRjhBYlFCbEFITUFjd0JoQUdjQVpRQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reftwo: QUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCa0FHd0FjQUJmQUhRQVpRQmhBRzBBY3dCZkFHOEFiZ0JsQUdRQWNnQnBBSFlBWlFCZkFHWUFhUUJzQUdVQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5nQUFBR1VBYlFCaEFHa0FiQUJmQUdFQVpBQmtBSElBWlFCekFITUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBVndBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQWJRQmhBSElBZGdCbEFHd0FiQUJmQUhRQVpRQnlBRzBBYVFCdUFIVUFjd0FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFBPT0iLz48L21ldGE+ x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO3PR18MB5005:EE_|PH7PR18MB5059:EE_ x-ms-office365-filtering-correlation-id: 646ad053-07ae-4d3d-d77d-08daf4a00df8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TPYKNcvrYgn14LBY+vbcM8qi8yjw2fLyxWPYIXFNFy84cpBXwjLqDkMVGeUNLbHyeHSfqxWul3hgaaECki7vYGcmeWXt15bMa8fd5tsp83ZVbdz++z+e9RTYF7zYrV8KLOYovLgVMO0CJlxwVRkdg5v0AkXJOhhnl/fl471MdGQ0TDzKJ9Y5XQlLIpyxDeKRpgckeHgn3oxE/yEG1bjQZ6xAklA5p6IKGIO7HyooARBvtSGHlZ9P7GqMg2TC2Du0HTkIESiSc/nUs6VZ1ca++pNH0Q1Mipj1b8a6zBy+iLfbsNr7a2euMZv8nmVq+88aZbWFTM7WsG0kdznY6b2/zWGpHKU+Rc+wchD7JQVnmFngaxwfL40H5m5zYyPyzVCVEuizio1PtzmYO7gRPCpqIOj3SaTj/Zj0oWKxsYakuQSFydMX8tCl5B9SmpAQC/DMUDocixjw6iuEX3o+hsGvS5h8+aQm8KKLi+YAJd6Jdem9UEfm7f731ValfQYTpVk5cr68jbUensPoT9yHkCjK94wpwIWKax1V90ffPRCd7HVpP/ZL1ygJa2DXyHlbEecXsHd0rRJ6Mat/CN0CLo1Y2YLnMwENSXxz3Tg6O5eSMu7LH/jVF+v4cdOAqUIzbUseRXL5I/4DoAfh3d61765UOfJ6mxQ1HU9y5PPZBtPmcAWsWATT4xKGd4v8NxODOMocFVif0Cgc90xNlI+cAuJLUA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO3PR18MB5005.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(136003)(39860400002)(396003)(376002)(346002)(451199015)(33656002)(7416002)(7696005)(316002)(9686003)(86362001)(71200400001)(26005)(7406005)(5660300002)(186003)(478600001)(7366002)(45080400002)(64756008)(41300700001)(66574015)(66556008)(4326008)(66946007)(66446008)(54906003)(66476007)(110136005)(76116006)(52536014)(38070700005)(8936002)(83380400001)(8676002)(55016003)(6506007)(122000001)(38100700002)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?kiOf+sx2/6CVg4r4kOc5woHD8mQxSblUbQuKQRGM8I7NVrFkD0TPt2WWzw?= =?iso-8859-1?Q?inYS6b1Ft9ZjyD6qRBU8T/p7kyz+3soRGYMeMx48ukiv0gnPnOBKNtsl6U?= =?iso-8859-1?Q?r1qPBb9b0oTUgW7W50GCZHH1Dqx0jsSjekjiACNjs8ab8xXSXrX51wBHT1?= =?iso-8859-1?Q?lJjsOXpCxQPthlEfZBQGZ4/AURxipw0rcPSCyOt2CpdLjtJxjQig6Z0o3b?= =?iso-8859-1?Q?uw45sU2pYh6ipJ1HH7iaL17Yzqd92jOINDuQLUugUUGdUtF3xhuSslTy+X?= =?iso-8859-1?Q?eFNAZdcjTMTqcIlqdqsGKdxt2PvHeL/UETgnBt6bZqemOnM/pfEgpcOxEK?= =?iso-8859-1?Q?rbzAu+gcR2TnouZTI8LzKGzvloPrcDQunCZGwlsmF9ShtBsYcsAoZzKaeS?= =?iso-8859-1?Q?AqDk+mhppjnCpeCYZFDUvGw/SznUSz1lkNnglg/spVcx+Ja6lP+MkUO2Hq?= =?iso-8859-1?Q?RtE+eeA9UfvfVx/IFmkbbOd5F6OThmMtQDDk302Ylw/eAQO3Hyd7+CPnD7?= =?iso-8859-1?Q?mgJCdslnjgjilo5ighQVZ7bxMWvajlltAZDkcH6v9Zf5qIg58dLkZf5B6Y?= =?iso-8859-1?Q?QDtu0GIrEhc96yz87gJRDpzR5d2OlcwmWPJpiG9RjTCC1Y7n7h9/itJzHH?= =?iso-8859-1?Q?+tXpzkrV2lCSQa5wmWp0GBdyT7O/gnXpmkos4LQIC3hp596wAzs35Z58Ar?= =?iso-8859-1?Q?PXPpkGY9sbPVG1vbdlp3BIUOUUYhmOHx6CtBxZ6PWjRDSiaToSCVMvmuaf?= =?iso-8859-1?Q?pcDTin8hHkTwUNeilQymxGoEzHmOSTEv2TrPyXdJs58LdLgpHlMwy00OFE?= =?iso-8859-1?Q?AIgvNib4qoV3TfDm8v2Tkkm77H6t7IbY+/kSTWomSRnHAoBhm/o46nWBxA?= =?iso-8859-1?Q?MPaJyo8s/QtzdgAvA1E4FkFJDAmi6FhIBqr7H/reJJ4da8MYZ4fPS31g9R?= =?iso-8859-1?Q?/BnnVsdjCL/DqV9XIgw9n/3NKNISfUQdS5xQ1P5W3Vkq+db6qqwBP5y5oM?= =?iso-8859-1?Q?y0eYIcs08rz0B6NokiA9llNKK4WEZig7k2kIcq0B73d5smSnesUzl0Eet/?= =?iso-8859-1?Q?2VLt17jYgnfK2FyPOQsKdxmF5QUHaeTidiq/zDxEDSACaGomYK643ivfXt?= =?iso-8859-1?Q?DKm8nQCxNKz1ZOTWXnN0s7BMhIhs5hLxw2yiBZJn8YYdIbuu+JZWtcIeaN?= =?iso-8859-1?Q?86aiUzGwIxH5fAWY4kHFs6fjqo5LL3ba4YRgi7RQlUqClDL1LaokIrwHNk?= =?iso-8859-1?Q?cQ6MTLm3tEXysPhtfMTVlEDagN1mXoG+oK9z4wpTtuIgwEjpFn24O1cnQ7?= =?iso-8859-1?Q?R1q/NwWCJiqCVv2kvJsC3rGNtYI/LhjLNNSazxH8RvFrY96+NaDb6BZKXH?= =?iso-8859-1?Q?NUHs7MlmLd8zXFMaYXuHF8YXiBPAkAYv/9sgVgRPA2prla4oBccyN5T/3v?= =?iso-8859-1?Q?0v9wFCBiJC8dFCW1zOtxUPW5lMeWxEEp7dTXzrwzAcmBKQa8of4yFyGu+5?= =?iso-8859-1?Q?FxkzjfJWmlY0Ek0fDDv5k7dyQNrADxsl8RpCzVuygQ/jupW6jSLHAA1MEM?= =?iso-8859-1?Q?nnjS7sa9JL6K+4DKd2pEQyjxeJpQVifzgU2z9VGAIRY3vb4Xxm+c9+AgLH?= =?iso-8859-1?Q?OU7VwYUpRSCVYVWZLjj2+hcRgkZqmZCr9z?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO3PR18MB5005.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 646ad053-07ae-4d3d-d77d-08daf4a00df8 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 13:22:29.2546 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XYikwKUFYdx18E4u3dzo48Do5JxeflI1BAjbMOUxSHXrKlWrDwWdYwqFgEYGyiqHRYG5QugzQ8EOu5v01WmKYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR18MB5059 X-Proofpoint-GUID: f-XlizDnmrUh3Ub2QXLqzaE8BoMQ0h4b X-Proofpoint-ORIG-GUID: f-XlizDnmrUh3Ub2QXLqzaE8BoMQ0h4b X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-12_08,2023-01-12_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Morten, My comments are inline. >-----Original Message----- >From: Morten Br=F8rup >Sent: Thursday, January 12, 2023 6:09 PM >To: Ankur Dwivedi ; dev@dpdk.org >Cc: thomas@monjalon.net; david.marchand@redhat.com; mdr@ashroe.eu; >orika@nvidia.com; ferruh.yigit@amd.com; chas3@att.com; >humin29@huawei.com; linville@tuxdriver.com; ciara.loftus@intel.com; >qi.z.zhang@intel.com; mw@semihalf.com; mk@semihalf.com; >shaibran@amazon.com; evgenys@amazon.com; igorch@amazon.com; >chandu@amd.com; Igor Russkikh ; >shepard.siegel@atomicrules.com; ed.czeck@atomicrules.com; >john.miller@atomicrules.com; ajit.khaparde@broadcom.com; >somnath.kotur@broadcom.com; Jerin Jacob Kollanukkaran >; Maciej Czekaj [C] ; Shijith >Thotton ; Srisivasubramanian Srinivasan >; Harman Kalra ; >rahul.lakkireddy@chelsio.com; johndale@cisco.com; hyonkim@cisco.com; >liudongdong3@huawei.com; yisen.zhuang@huawei.com; >xuanziyang2@huawei.com; cloud.wangxiaoyun@huawei.com; >zhouguoyang@huawei.com; simei.su@intel.com; wenjun1.wu@intel.com; >qiming.yang@intel.com; Yuying.Zhang@intel.com; beilei.xing@intel.com; >xiao.w.wang@intel.com; jingjing.wu@intel.com; junfeng.guo@intel.com; >rosen.xu@intel.com; Nithin Kumar Dabilpuram ; >Kiran Kumar Kokkilagadda ; Sunil Kumar Kori >; Satha Koteswara Rao Kottidi >; Liron Himi ; >zr@semihalf.com; Radha Chintakuntla ; >Veerasenareddy Burru ; Sathesh B Edara >; matan@nvidia.com; viacheslavo@nvidia.com; >longli@microsoft.com; spinler@cesnet.cz; chaoyong.he@corigine.com; >niklas.soderlund@corigine.com; hemant.agrawal@nxp.com; >sachin.saxena@oss.nxp.com; g.singh@nxp.com; apeksha.gupta@nxp.com; >sachin.saxena@nxp.com; aboyer@pensando.io; Rasesh Mody >; Shahed Shaikh ; Devendra >Singh Rawat ; andrew.rybchenko@oktetlabs.ru; >jiawenwu@trustnetic.com; jianwang@trustnetic.com; jbehrens@vmware.com; >maxime.coquelin@redhat.com; chenbo.xia@intel.com; >steven.webster@windriver.com; matt.peters@windriver.com; >bruce.richardson@intel.com; mtetsuyah@gmail.com; grive@u256.net; >jasvinder.singh@intel.com; cristian.dumitrescu@intel.com; jgrajcia@cisco.c= om >Subject: [EXT] RE: [PATCH v5 1/6] eal: trace: add trace point emit for blo= b > >External Email > >---------------------------------------------------------------------- >> From: Ankur Dwivedi [mailto:adwivedi@marvell.com] >> Sent: Thursday, 12 January 2023 12.22 >> >> Adds a trace point emit function for emitting a blob. The maximum blob >> bytes which can be captured is maximum value contained in uint16_t, >> which is 65535. >> >> Also adds test case for emit array tracepoint function. >> >> Signed-off-by: Ankur Dwivedi >> --- > >Excellent, thank you. > >[...] > >> +#define rte_trace_point_emit_blob(in, len) \ do { \ >> + if (unlikely(in =3D=3D NULL)) \ >> + return; \ >> + __rte_trace_point_emit(len, uint16_t); \ >> + memcpy(mem, in, len); \ >> + mem =3D RTE_PTR_ADD(mem, len); \ >> +} while (0) > >I am somewhat unsure about my concerns here, so please forgive me if they = are >invalid... > >Is rte_trace_point_emit_blob() always called with "len" being a variable, = then >this is OK. Yes rte_trace_point_emit_blob is always called with len being a variable. > >If "len" can be a non-constant formula (e.g. len++), you need a temporary >variable: > >#define rte_trace_point_emit_blob(in, len) \ do { \ > uint16_t _len =3D len; \ > if (unlikely(in =3D=3D NULL)) \ > return; \ > __rte_trace_point_emit(_len, uint16_t); \ > memcpy(mem, in, _len); \ > mem =3D RTE_PTR_ADD(_mem, _len); \ >} while (0) > >But I don't think this can ever happen. Yes, I think the same. > >However, if "len" can be a constant (e.g. 6), does __rte_trace_point_emit(= len, >uint16_t) accept it? (The __rte_trace_point_emit() macro is shown below.) = A >constant has no pointer to it (i.e. &6 does not exist). > >Looking deeper at it, I'm afraid this question can be generalized to all t= he >existing macros/functions calling __rte_trace_point_emit(). > >And now that I have hijacked your patch with a generalized question, I won= der >if the existing __rte_trace_point_emit() has a bug? It uses sizeof(in), bu= t I think >it should use sizeof(type). > >It looks like this: > >#define __rte_trace_point_emit(in, type) \ do { \ > memcpy(mem, &(in), sizeof(in)); \ > mem =3D RTE_PTR_ADD(mem, sizeof(in)); \ >} while (0) > >Alternatively, __rte_trace_point_emit() should RTE_BUILD_BUG_ON(typeof(in) >!=3D type). Yes there would be compilation error if typeof(in) is not same as type. > > >If my concerns above are invalid, then: > >Acked-by: Morten Br=F8rup