From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 14705A00C4; Sun, 24 Apr 2022 10:34:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1AEF40042; Sun, 24 Apr 2022 10:34:04 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 290C24003F for ; Sun, 24 Apr 2022 10:34:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650789242; x=1682325242; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=vtW20jF9+mDaEmDRiYFci9Z8ATICH3M69AquJstM3Mw=; b=h12v0FXJDGP1yuAbyRhbKiTSeCVLvfrI5Vi6ZrRi1KIJSmesI9cfR6p1 NfFEcqtZ2bVq59z3+XJNgs0H/CfZMSqQ7HicbThIyvETh4agQavLwL0sk n0WAZXD0TL113DbwCbO1/rVcVBYi78/MvQoHbea7kTP595JE9kKBXSHgR sjhgKJMONMbA2w9qdWc7nStOWpBZ4KmtXkls6MrAh3fiJQWz76ouP3H5j jh5pkiQlc0Ge5WnqHMGs7gwFiSw7hACj58/tg97EoCEiP3SIVrJ9nvxas KA5u+JvrL/aQ8Czk7tf1SZYFPrF0wZPY67KBwICXcXezN6Ar+N0tPYwHO A==; X-IronPort-AV: E=McAfee;i="6400,9594,10326"; a="325488257" X-IronPort-AV: E=Sophos;i="5.90,286,1643702400"; d="scan'208";a="325488257" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2022 01:34:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,286,1643702400"; d="scan'208";a="531591787" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga006.jf.intel.com with ESMTP; 24 Apr 2022 01:34:00 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 24 Apr 2022 01:34:00 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sun, 24 Apr 2022 01:34:00 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sun, 24 Apr 2022 01:33:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NUqOinRe0IwDoD3ScuQvyMJsz3SjPxTWcrYFJ2u0KhtoHdgcNqqv/rYhfyxeIDPw4tE6Nmr+skEMrCMSA+EKLp4KN3ml6tP/DgL6F6gkhS31hvABmfyYZNANSP39k6S5Cp0fY19HQByK7qJ+q7FzZPb1YP60lTYmMVRbhG9ISSS3Q1fTO42ZYORO1Y6nq8UQuRziCpJwErhr4/UL/E4uuGXZLW5dCMYB1gjim2A9myAQTiDyAzZ6BdIrp78JTEBEbpLX5MmtxTDQWc5D4e1H4YiLQtgzTpS+vm0EcsC4ux3ea0RR1ytFpmh+e9hixh058FgvGGad6qbRrZENzm2d/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=De+ylVHK6pOkSUCx/4ThanIQdxrh+h0uLwoIc1XM9eQ=; b=KY/g0RxuGA1lONOMk0vbPDnqbw1/2MUtTQDRXFYUbF+P+CCpnqticL+iQkWkbBuYL79ol/bkVDbDJ0YeA7YaP/gVmI+uISMd06fr3uctyNpdooIqRn0NSDLUCM7MoGRgXYiQE5YK0qFJ2C6zf8lEcjmlqg/CtW5Ph8iPbqyiLCG38C8B9Shu5Bn7FE45f3Z/cuuuQEo1jeVj/scC/bjc5nSv4Y9xrFaPQZ0/g4DUYGW0kAAgRkMfMTrIJE4O04Bdg8YDOHz8uskw9oWe+qy4B5KBVIW2LcspEEdgxjhYDqwCxATjrm5AXTbedMj8itB1OmtEIqbEFWDBz07Mo5umiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO6PR11MB5602.namprd11.prod.outlook.com (2603:10b6:303:13a::5) by SA0PR11MB4606.namprd11.prod.outlook.com (2603:10b6:806:71::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Sun, 24 Apr 2022 08:33:58 +0000 Received: from CO6PR11MB5602.namprd11.prod.outlook.com ([fe80::ac26:a55b:f183:d9a8]) by CO6PR11MB5602.namprd11.prod.outlook.com ([fe80::ac26:a55b:f183:d9a8%5]) with mapi id 15.20.5186.020; Sun, 24 Apr 2022 08:33:58 +0000 From: "Zeng, ZhichaoX" To: "dev@dpdk.org" CC: "Yang, Qiming" , "Wang, Haiyue" , David Marchand , "Ray Kinsella" Subject: RE: [DPDK v4] net/ixgbe: promote MDIO API Thread-Topic: [DPDK v4] net/ixgbe: promote MDIO API Thread-Index: AQHYU5qh9kJuxvJ9Z0OjL7145I3AWqz+wbIw Date: Sun, 24 Apr 2022 08:33:58 +0000 Message-ID: References: <20220412175602.965278-1-zhichaox.zeng@intel.com> <20220419110613.61268-1-zhichaox.zeng@intel.com> In-Reply-To: <20220419110613.61268-1-zhichaox.zeng@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1094e278-4746-4d88-4bbb-08da25cd2d2e x-ms-traffictypediagnostic: SA0PR11MB4606:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KPSolWLymaTye8fellDAb6ELf5+U3ww0utHD9ras7HSQ37/IkF0xnDxsuZPScJoBu9l7m1THjdeV0r4Twh655ezhKM1lRwGftS1i7JjnTEj4eXOQcJWgFges6nE2IyGJkWvn3o0G5AnPSNMS5K/UQZgxAUUt9NzhvH6KXVoA6PcDukkXsmWUXNaSv5gxY8K/Gxyl6PNDEyo1ex915sXgbmxNnmcfjLRQShAJiFBJk9OOrPV+gB7JQzwkL0kqpybYQNv3y2OP5AKAq/2knyfuaIa8UVrY1gHCN2cydf3arg24nSC7YLvrLqHDDUWocwOxlWU+EGyCmyD/lc0DR/tmW1kWq/qQfhMDesfzPl4+h2ur7/f9uOdWpLy/jgQl7/hAEmQclN0K985PIeYpaXZgQodmMxvL4UZftQuCyazr8Dbi5dl3AuwvX/wfl7iXn6MiAfx4dLvuvfzYFGe2jFI4Iepe7rRdizBMIsF6ch4+zlHG7ot3gd0cy3tnbv7XF3VoJQOvl2in7AfZY5ekDIy1hNKWN5ZPmndgQYb/mpbnAWRFcdUGHjpmlIdMKoQOukgItpuGx142QRvFdpICdJQ2D+k/yvtUbk56ZMc5WtkCzHbkpiivVcMRIoR1vc/FZ18tHKRXVgdMVR/zRZAsEeTJ2jGcZ/ut7FKAACwenKqvG1U4VGnfWEWuDluHeqkx04sKq0y1dzh0EZzpVoEqIfzyJg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR11MB5602.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(55016003)(76116006)(66946007)(8676002)(71200400001)(66556008)(52536014)(9686003)(7696005)(38070700005)(66446008)(66476007)(53546011)(33656002)(5660300002)(26005)(6506007)(122000001)(186003)(64756008)(38100700002)(54906003)(86362001)(316002)(6916009)(2906002)(83380400001)(4326008)(82960400001)(8936002)(508600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?P+LBmg/SBzm0xyXMMujLMK44Ko8+KT1gelV1MkmYy27ccTHE6u1T58s8ywsA?= =?us-ascii?Q?nH+gBPykoeqPsou8lcqv/Q/LCzptMefOksqerDssSQuTT2K+nvBhPPg8Qt5y?= =?us-ascii?Q?nuYP+tUQFJEA8WAlb2ruDv+oGLcAEEATWh/tWYlpxDBnoTDSfenaG4iRZ6Tv?= =?us-ascii?Q?QpfjvX+LeePUHrlrX8vQEpFpJmUuxvFO6Q4X3PdVutsklLuDoFJaauolhdO4?= =?us-ascii?Q?JdBhNweQmi8EpbhSabJLx60rA0BkGwm7aEAOrZ5+I9I8rpOWqHhMlX+I4xTn?= =?us-ascii?Q?rBYADgHcoAAu87iTyp9pGhha/XJMz0XHxtCcF+ZkTGJkglBJUb8vYNPIYHg4?= =?us-ascii?Q?ET/eq9FHFKg0Fcu0UX6vALiSPsMRwuPmv+dcaBCRD5tJ5VrhcYucVK97b7M4?= =?us-ascii?Q?XWC3mL14XPH/qlS1rG0+YmzFt6pcxY8IJvZBpjvzihzZh5GY1AV6Lr0e07De?= =?us-ascii?Q?7XvAeqNxMufAcDnzglLTHnI4E62JNSlkpBvoqvlMCDDo6oE5yoFDLeoRfuPW?= =?us-ascii?Q?V/UtGpC2uHvDGlgy3aQ+m6X2aTNYdWgtHIqay6kuvxCCvsXpT4S1Q/xT6pKL?= =?us-ascii?Q?G0ZmMjc5ZvPDHSYAmOqA0FxjbV66Q1UdEL3Iov36+CbewWf1lQa5r6UcR0rH?= =?us-ascii?Q?GRZQhXocjWHqqk97lkyGPvmVTxieI4s2/ZH8zqEBzXQeP5iao0bN1LMTRm0k?= =?us-ascii?Q?yVYUC9BoiFY4+yPQPqnpwhtYm5e75tEE7grCf/CeIMvOcZpOoReX9QfaimSd?= =?us-ascii?Q?R5eQpq+QiAaMqMVAJWb4cjtnfey67g6IJhlqM0/FhqyGXfXni15weZ0xRzlZ?= =?us-ascii?Q?qEutjIMpdK8hywOsdcV2FAx/pK0TYKjMLi0JeJIzVx3QxpdONhpU4nT6lJT+?= =?us-ascii?Q?souvJOX8V++9Tyi0DO5u7qkgP0X/GifBhqPucwKR4Ai/FmKPm+9FWSKcoEEx?= =?us-ascii?Q?dWx+Jv+IYth0g1/N27mldJebKwW4UYZvBVTX114xSTPxhaNLTUsPBgeFw/oc?= =?us-ascii?Q?OyHFA1dN32lMnasB/st+iVlupyOkJ/DTVFWfiIJpw80netebBfWF0axZs0SU?= =?us-ascii?Q?H2b4fhDm4fTLf24SFCBBY1uc0BmzLb6VFYIHR21xWSvwWuYvtUgUS5HBxiBM?= =?us-ascii?Q?fwO9NGTZW/JBHQaisvOc79+NkofRNzlDoBFysiArX9oRvYbJ9i+L3R7FLrP1?= =?us-ascii?Q?scJek3FcLuOeRP1C8KtbVZn9r556etqynOKe7LOCs9DTbk+TMBVRCxFzzEIY?= =?us-ascii?Q?47kYewYd/yf7HxLOLVzlSPYDzXXaNURXesE+1yYHW+kjkjCpjzUhp+2AWslx?= =?us-ascii?Q?PL6rLSnrlWWVNXdJJtKmq9OxWHZMb3DGTi3pRWdZiYZQvIgcLHc+WTeAyLNP?= =?us-ascii?Q?RuRahvkOO/9YqKjXe45L1aV0bT7Np0g+wewmaeMl7RuT8KIjBk8F3mDAorIm?= =?us-ascii?Q?t1RPQGSm7j3x770OC6C8RIILgI3sQm8ARfJ1X2STHQ2l1hUtLZIbPVM6Xt24?= =?us-ascii?Q?U0sGIAw2Q+SatUFkmKzDScTgxCBkfcOFUGkfsrsNtsEgiGxoxmvpPgi52Tlf?= =?us-ascii?Q?Bg4gKSj5TKQcopRNRh2bNa4twKUsrYhuiU3p1IiipcNOD0kmEuakvrSpmTDI?= =?us-ascii?Q?yJHrmjcxdgEUOODV30C6Q1urhuWEK2ijsAGZFbMmgAfKrNIV5+2b/ppOaX/f?= =?us-ascii?Q?/KGVeszzGBWkhfK1h24+Da139lfPKA8LqhEL0FjQkfVef0lNlGHPZj0Il2v0?= =?us-ascii?Q?TUxhyqCK5g=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5602.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1094e278-4746-4d88-4bbb-08da25cd2d2e X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2022 08:33:58.2241 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QhfU0ycCBghkq623EVk/vDLM+tbxstS6O+MhkvrpOlSSvWQeQv6gSdR/qYF3VHuOc5EltoxaD8+HV4uvmyHgBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4606 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Ray, David: What is your opinion on this patch? Regards, Zhichao -----Original Message----- From: Zeng, ZhichaoX =20 Sent: Tuesday, April 19, 2022 7:06 PM To: dev@dpdk.org Cc: Yang, Qiming ; Wang, Haiyue ; mdr@ashroe.eu; Zeng, ZhichaoX Subject: [DPDK v4] net/ixgbe: promote MDIO API From: Zhichao Zeng Promote the MDIO APIs to be stable. Signed-off-by: Zhichao Zeng --- drivers/net/ixgbe/rte_pmd_ixgbe.h | 5 ----- drivers/net/ixgbe/version.map | 10 +++++----- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h b/drivers/net/ixgbe/rte_pmd_= ixgbe.h index eef6f6661c..426fe5845b 100644 --- a/drivers/net/ixgbe/rte_pmd_ixgbe.h +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h @@ -586,7 +586,6 @@ int rte_pmd_ixgbe_bypass_wd_reset(uint16_t port); * - (-ENODEV) if *port* invalid. * - (IXGBE_ERR_SWFW_SYNC) If sw/fw semaphore acquisition failed */ -__rte_experimental int rte_pmd_ixgbe_mdio_lock(uint16_t port); =20 @@ -600,7 +599,6 @@ rte_pmd_ixgbe_mdio_lock(uint16_t port); * - (-ENOTSUP) if hardware doesn't support. * - (-ENODEV) if *port* invalid. */ -__rte_experimental int rte_pmd_ixgbe_mdio_unlock(uint16_t port); =20 @@ -622,7 +620,6 @@ rte_pmd_ixgbe_mdio_unlock(uint16_t port); * - (-ENODEV) if *port* invalid. * - (IXGBE_ERR_PHY) If PHY read command failed */ -__rte_experimental int rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr, uint32_t dev_type, uint16_t *phy_data); @@ -646,7 +643,6 @@ rte_pmd_i= xgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr, * - (-ENODEV) if *port* invalid. * - (IXGBE_ERR_PHY) If PHY read command failed */ -__rte_experimental int rte_pmd_ixgbe_mdio_unlocked_write(uint16_t port, uint32_t reg_addr, uint32_t dev_type, uint16_t phy_data); @@ -725,7 +721,6 @@ enum { * - (-ENODEV) if *port* invalid. * - (-ENOTSUP) if hardware doesn't support this feature. */ -__rte_experimental int rte_pmd_ixgbe_upd_fctrl_sbp(uint16_t port, int enable); =20 diff --git a/drivers/net/ixgbe/version.map b/drivers/net/ixgbe/version.map = index bca5cc5826..f0f29d8749 100644 --- a/drivers/net/ixgbe/version.map +++ b/drivers/net/ixgbe/version.map @@ -16,6 +16,10 @@ DPDK_22 { rte_pmd_ixgbe_macsec_enable; rte_pmd_ixgbe_macsec_select_rxsa; rte_pmd_ixgbe_macsec_select_txsa; + rte_pmd_ixgbe_mdio_lock; + rte_pmd_ixgbe_mdio_unlock; + rte_pmd_ixgbe_mdio_unlocked_read; + rte_pmd_ixgbe_mdio_unlocked_write; rte_pmd_ixgbe_ping_vf; rte_pmd_ixgbe_set_all_queues_drop_en; rte_pmd_ixgbe_set_tc_bw_alloc; @@ -31,6 +35,7 @@ DPDK_22 { rte_pmd_ixgbe_set_vf_vlan_filter; rte_pmd_ixgbe_set_vf_vlan_insert; rte_pmd_ixgbe_set_vf_vlan_stripq; + rte_pmd_ixgbe_upd_fctrl_sbp; =20 local: *; }; @@ -40,9 +45,4 @@ EXPERIMENTAL { =20 rte_pmd_ixgbe_get_fdir_info; rte_pmd_ixgbe_get_fdir_stats; - rte_pmd_ixgbe_mdio_lock; - rte_pmd_ixgbe_mdio_unlock; - rte_pmd_ixgbe_mdio_unlocked_read; - rte_pmd_ixgbe_mdio_unlocked_write; - rte_pmd_ixgbe_upd_fctrl_sbp; }; -- 2.25.1