From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 850A141C87; Mon, 13 Feb 2023 11:22:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 62D6540ED8; Mon, 13 Feb 2023 11:22:42 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 95C1040A81 for ; Mon, 13 Feb 2023 11:22:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676283760; x=1707819760; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=O4VrCDZWrQwyXK+OyBYATIFQmez98Bm8SBYjty7LWaM=; b=b5B5JDoxsmCVuxUM3NgJb5x105eXb+8Qm/SlVZDk4JRluaQaUgBV2y61 KVwpYT+G4hyWVdC2ZcmtsTkt+GRxdLbFYhg/JBHoo4yzKsZCutU5JjmpU g8A8jXnvIVY4AKaWI1SP1mu28qn2kDvZH+Y+qNFTJ/dELTp4mooP+7LMV rkPfUODsnI5zTIsNdS8n0+Rstw5ao2bt0SiqMuAgreSEo6dVw2C1G1e+T RPHSLIlWXL+ykHCv8DLZi7ATMK11B/B9WWDWi4xCamA0WFdTiH9yBC1G3 oEAKEacz0ZVsdL3jHZD7KkinfVtM7TP8QMMX3HBHErjPVFJ3jvXmB295N g==; X-IronPort-AV: E=McAfee;i="6500,9779,10619"; a="314500994" X-IronPort-AV: E=Sophos;i="5.97,293,1669104000"; d="scan'208";a="314500994" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2023 02:22:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10619"; a="811539389" X-IronPort-AV: E=Sophos;i="5.97,293,1669104000"; d="scan'208";a="811539389" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 13 Feb 2023 02:22:39 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 13 Feb 2023 02:22:38 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 13 Feb 2023 02:22:38 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 13 Feb 2023 02:22:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c9lvjhYJxTNfpBgDY2XJGCYilZezZxj8LC4xszXQ7gta8ScHeysfk7sGDNCxY57hfrekAjcfYieO8HaAHESfITJjvNoybsshT1oXOEdJ7TioNEn9N/2yo3plCWjmrXBmBLC8xoN45GjK+cNNaHF3ZnY+lCfs5GTqqBW9drAp76hdrBWCrf3a9VUN4HAdIHraX7/VdPL6NIU5tLEwkBwHv+rWK7FchRcMPKpoup3Sp+ltokHLff6Y/kraKrRIlnwgupl6fG5CNSgwoBaX/bNzulKyUq7jpdw47iCVyNB1jRRX1wWEqJMloTrS9M6PnJqIYyU6AurlA6vPkUQFnFFgkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O4VrCDZWrQwyXK+OyBYATIFQmez98Bm8SBYjty7LWaM=; b=Q6axpZnGhx8/BaqPyvZpNVYVYQjdW78SBFwqOtH6/IL4gAcp+t3O6xtdQZwNL5ybFsqFOzTdGeTQMKFHHsvedi7cCE6GsunxLZ9kSYfxjSsHI9FgtcdBC+WMAFjJsZiKl18CiZ4Op7n6N6mqfAHjNODpOUJtcjAOhfGYRB2O8zS8U7fz//Pd4kswsIVXT7lWhiPhX9Rc/yBPTqqo+Eie1KbwiKctkcPKoezW1irI66MATPcwMNVYYcHp+jV5pNUoFAekZw58nxeDiIzppA8U1qm4co0Nm2UIs8OwdGOXgQMCmxy23tqv5FfDF6BfDWoENZ7ZA7a/TurK0Ya3e7lFrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO6PR11MB5602.namprd11.prod.outlook.com (2603:10b6:303:13a::5) by PH7PR11MB6747.namprd11.prod.outlook.com (2603:10b6:510:1b5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.23; Mon, 13 Feb 2023 10:22:35 +0000 Received: from CO6PR11MB5602.namprd11.prod.outlook.com ([fe80::3b28:4c3d:1225:fff7]) by CO6PR11MB5602.namprd11.prod.outlook.com ([fe80::3b28:4c3d:1225:fff7%3]) with mapi id 15.20.6086.022; Mon, 13 Feb 2023 10:22:35 +0000 From: "Zeng, ZhichaoX" To: "Matz, Olivier" CC: "dev@dpdk.org" , "Zhou, YidingX" , "Jiang, YuX" Subject: RE: [PATCH] lib/net: support UDP pseudo-header for UFO Thread-Topic: [PATCH] lib/net: support UDP pseudo-header for UFO Thread-Index: AQHZJmd2ZBE7lqtOTUagRdSXAptCo67IV/WAgAR9geA= Date: Mon, 13 Feb 2023 10:22:34 +0000 Message-ID: References: <20230112092608.868006-1-zhichaox.zeng@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR11MB5602:EE_|PH7PR11MB6747:EE_ x-ms-office365-filtering-correlation-id: 07d21eb9-3136-476b-11f7-08db0dac3939 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aiGkzMORG07LQhsAwZIKFlzUNAG55+XlS1VH/R1usVBgvhc4JNBgE0qxbuxyA3iLNRlLdn+SDEbF116+4RJnbzWhqWJJF4fAANZWQC3pmHO55gmU182nlzxRJBeIHfRADmNod0pYy94zkS9NZMBG1iQboprJAEyJSdtEQ0tSB2g6hcvVX+4ekX0KzDxQDdb3teAkb5NUicQa56z4ypxwzKGdK79dAabVHMcsR+83ljeZ65h7WP1OyiV9f934POmyPxBoVyHpXgBcb0TPSjMckBaolyGCdiSfGK1nx/w4IV4lD1DeNfWvOBJtuiG1YPU1iSF0JuduYQzfqYBzJsVd9Or3ciumGmMN3PIJmF+SNEGm3p33vlNf1PE+s7gJQGgqVM0eD8ZNwbnhQ2LysF7GdyvFou62QUPD+keuEBVXiggPRUGXB24yOF6gLI/QlwjyE6SAk+i9uawurmS0BDsZ/KS7uburw72Hdl1QM2cW/Oc1X9e0CEpQANh8cL0cCyQr5NYy2Wv1i2kmeo6l57kflUa+MtE+r32Ot305rlWG7sIWxnmYi4D3DugPyEuqi8SIPbiRLBQCFVjAYqffs0x6DXEP2uJMYHg7gcBvi4in0OcxKFHxDhPJg+RVdaoTr4LUdOw75efTjG18OzD4Uw+CyeYry/jaTOm5shjXDgOr2iS1O24crhTsQW9R6j3kubovG+fcK7fppwFAuoXIFLJPSg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR11MB5602.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(136003)(396003)(376002)(366004)(39860400002)(346002)(451199018)(8676002)(71200400001)(8936002)(2906002)(52536014)(38100700002)(7696005)(55016003)(107886003)(5660300002)(53546011)(86362001)(26005)(9686003)(122000001)(186003)(54906003)(6506007)(41300700001)(82960400001)(478600001)(316002)(64756008)(66556008)(66476007)(4326008)(6916009)(76116006)(66946007)(66446008)(38070700005)(33656002)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MENGSpNqNGyhyztHIoU6bJrpCzvw/LbQoo2UG3j3VRcBe2ScrSfhXmav5TaY?= =?us-ascii?Q?rVBU2EJXKPJ8zonekstCn8UxILbKaVsebZkVDXS8WHtSVs/SCbT6Cudlbdmy?= =?us-ascii?Q?75IqM8AAWv9pCf/MTDPP2dmqadBOa3/b+VGVmiPC8buBhRviaDNN6DW7HbVO?= =?us-ascii?Q?Z8kNvZAV+8yorJ1QdGQNRy/V/uygfy0wCbfrjBxRW7ozAvQirLhYwVU5a7Kq?= =?us-ascii?Q?1yhsB70FCmLhd2zYU585q9E63aMCxipyY5Srv54dba9l3+ccp+CN/ZUvmVRP?= =?us-ascii?Q?rGZdtJWutLFxt1RCVUuiAUrv4NTUYN1OwhhGs39nhJrwS2232C8zRGS8fvmu?= =?us-ascii?Q?71dcL8ijbM7M8kZuUBxRXuzfiWyRJAjCUzBh+PhHvQ4FuXIdOBPNAq1ZMDOY?= =?us-ascii?Q?pPyHA4KazWGD00X57a9f9M6m3oVBHrZySXtDAnE9BegrOV/qWE8VWkn71yx7?= =?us-ascii?Q?ZLFMrLXV1RsxH4IddyYKB80qB9TvqxYj99bUcp3gukLcNcK93ODWBaP+Byhf?= =?us-ascii?Q?zgIFZuBMZmttDw4uDR8hgbf6EnNYDJE0BKeUkfxRE4XAz5hUM5IKHilB2xom?= =?us-ascii?Q?NUU6PWbYFcPyOlJOywZrAA6xvCeUjyUQOeR34+/Fjb8xicGKy6SkLv/ErjdC?= =?us-ascii?Q?bgypcF7Ne9DlUjBQBO19MmnUMrNIpLb1+imjjMadzMDLpqxuhc4zLxBD25J5?= =?us-ascii?Q?E1dI06D9lGRQWuPPPe7bHMjta7pQqulS4LWnqpFmvgJkxrS52xrGJl7F1MQE?= =?us-ascii?Q?DIW0iqtgSUJdUi/WkeNm0qySw3j14F87knsIAB0r7sBXe+L1vzXFegStzpIe?= =?us-ascii?Q?jZOJLaEN7rLJlV1K98SbE8CyUXd9MMunV4el2Iihm9Lgm7p+fVyf3nsOU3C3?= =?us-ascii?Q?AkryxN44slHQRqF56N+gD2CAIAETAL+MsLj4wPG1OQbqAItVrjEy3V4G9z8M?= =?us-ascii?Q?lSMhNuolWMUacvmFFtPfRbhJMxaGAjp4oVdW/HymYAlX0UnSiywfHfwtDebF?= =?us-ascii?Q?8CctG9Ozb4NOr5eIAr7I/fq/93VqPiXpNE0/N3GhKlxcwb9NuvysI7dT7xx+?= =?us-ascii?Q?8DAgbSaqawKPV4q7Hq1nKqj2AXfso2Kv6+9SZykr3JRbtU8tcHF8Ebv+RO9K?= =?us-ascii?Q?dcLBqUzDUEtiChaf4Y/AV5GVJfl/owlVM0TnrZh3/28wo4IhTsVXyDYeFv0n?= =?us-ascii?Q?jkibKVARuoO4Ako8rsVk/31uShGCe/F3KdGRM2iEziEqVbpwb5bDepcojjoq?= =?us-ascii?Q?XBClRbAmcdTCrix7HeI5DJMtJQvSSveMbRnIqm3qkAq5Ok5ZquYa7WYgjhTd?= =?us-ascii?Q?zxTDnUt9xbdXanT3I4wQbaJ+QfBGO1jRUYai6ywEbWcu9lRS+hsCOrxkZA5p?= =?us-ascii?Q?jYntZYVBOJw1Vnt/bV83M5ACkZSsE0RzvkqL/hq4ZOeEo/YEOAo719hlIVGj?= =?us-ascii?Q?a5DWM4F5/y/wdIoFtmqSPkB9zHu6o85nRmvQ1wtyQCq40dAuDLn6KH9NEZzE?= =?us-ascii?Q?NRVhyg5h45KzHltiGWi5EjLlJkgONSgejCyWRNkE0j3XXYsEtkzQIXvoxXH8?= =?us-ascii?Q?3evaMUNvcjFfzI7KhYXcqQR7bTHzmSWgMHZ10yKC?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5602.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 07d21eb9-3136-476b-11f7-08db0dac3939 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Feb 2023 10:22:34.8478 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vXbhYUO3MwwPfknYYyqtMYVLWGti9jxwalaZmBXc4HOWr/u1JPW8hihM94LOmTYOQcAA3PUXKkOhTiYFT1kdDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6747 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Olivier, Thanks for your comments.=20 Yes, this patch is to support the UDP fragmentation offload feature in the iavf driver, which is planned to be fully supported in 23.07. It's my fault for not clarifying the details. In addition, is it acceptable to add the UDP_SEG flag separately now? If it's acceptable, I'll resubmit v2 and add more details into the log. If not, I'll submit it later with the rest code of the UFO feature. BR Zhichao > -----Original Message----- > From: Olivier Matz > Sent: Friday, February 10, 2023 9:20 PM > To: Zeng, ZhichaoX > Cc: dev@dpdk.org; Zhou, YidingX > Subject: Re: [PATCH] lib/net: support UDP pseudo-header for UFO >=20 > Hello Zhichao, >=20 > Sorry for the delayed response. >=20 > > >=20 > Can you give some more detail about how rte_ipv4_phdr_cksum() is called i= n > your > use-case? (what driver, what libs, what use-case) >=20 > Currently, I see that only the iavf driver supports udp-segmented packets= . > The > lib/vhost is also able to pass the offload information to the virtio ring= . >=20 > For me, the mbufs that have offload flags and that are being transmitted = to a > driver should use the rte_eth_tx_prepare() API. This function will (among > other > things) update the required checksums in the packet when Tx offload is se= t. >=20 > Most drivers call rte_net_intel_cksum_flags_prepare() in their > tx_pkt_prepare > callback, so I suspect this function has to be updated. Note that updatin= g it > may have an impact on its user that supports UDP_SEG (lib/vhost and > driver/net/iavf). >=20 > I'm not saying that the patch is wrong, but I would like to better unders= tand > why you need it. >=20 > Regards, > Olivier