Re: [dpdk-dev] [PATCH v4 0/2] enable protocol agnostic flow offloading in RSS

["Xu, Ting" <ting.xu@intel.com>]

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Friday, November 5, 2021 9:23 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Xu, Ting <ting.xu@intel.com>
> Cc: dev@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Guo, Junfeng
> <junfeng.guo@intel.com>; orika@nvidia.com; viacheslavo@nvidia.com; Yigit,
> Ferruh <ferruh.yigit@intel.com>; andrew.rybchenko@oktetlabs.ru
> Subject: Re: [dpdk-dev] [PATCH v4 0/2] enable protocol agnostic flow
> offloading in RSS
> 
> 05/11/2021 14:18, Xu, Ting:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 04/11/2021 03:22, Ting Xu:
> > > > Enable protocol agnostic flow offloading to support raw pattern
> > > > input for RSS hash flow rule creation. It is based on Parser Library
> feature.
> > > > Current rte_flow raw API is utilized.
> > >
> > > I remember raw item was especially targetting encapsulation action.
> > > Which action do you achieve in ice PMD? Only RSS with raw item?
> > >
> > > For matching, raw item is quite limited. I think the new flex item
> > > is more appropriate for general custom protocol parsing.
> > > Did you look into flex item feature?
> > >
> > Hi, Thomas, we make use of the API for rte_raw to achieve our protocol
> > agnostic flow offloading method, including RSS and FDIR.
> > Behind it is the new Parser Library feature based on DDP,
> 
> Where is this parser library code?

Parser Library is committed before as ice base code.

> 
> > rather than the original logic I think.
> 
> > Binary-format pattern spec and mask are passed to Parser Library and
> > the corresponding protocol ID and offset will be provided.
> 
> Sorry you didn't reply about the new flex item added in this release.
> Do you know it was added?
> 	https://git.dpdk.org/dpdk/commit/?id=dc4d860e8a89
> 

Protocol agnostic flow offloading is based on ice DDP feature, although they all want to make flow creation more flexible, I think it is different with flex item.
@Zhang, Qi Z Hi, Qi, are you familiar with flex item?