From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FC69A00BE; Thu, 10 Feb 2022 17:33:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 04BBD41156; Thu, 10 Feb 2022 17:33:35 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2083.outbound.protection.outlook.com [40.107.94.83]) by mails.dpdk.org (Postfix) with ESMTP id CC8E341156 for ; Thu, 10 Feb 2022 17:33:32 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ORaWPQKCruMm0UisqTT7zHT5Yby9/o4wAUtOhFyQf31O8shWF/RYriV2MUMkhVXDnpZetfIHWYcmFsAUGcnOFYjZ470zqO2Jah5hEUuEYbe5Px9Kkkl4G4l5jX2lf8rYUB0QBz6fNX+YC7XKPMrHu+EOe2f5SNwWA4UnMZGcDNnDx5vc9qVOOUPA979KewqBLvOZeIstkZGPKSB34GAKxHDHRWaj78EW040FgTIGqaKiruhdxinKQVtwC9STI+lOjjtqHToNQWhyGjcFF2mf3MbCZxCbeVM5vh9YdW9b0YBitZIL9NG0EFrsUdAd5AQv+a63QLR8mjqWs6CuUuqYIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DgKlNp5UvZqcdc+Rx2KjRY2Ru5zRrFv9HqjLDRW6V/s=; b=nHGDAx4U0CJc5zPB2lsK5IEgFva7vy1FVBnMIcoXepof7d7DFrFmjnXg2C9q/Oj/xLSE4RAwVyvlmqviRhxui2m5OPfwb1j5AZ0DoKzzsJdmx+xWnpmDbF9xAZRbxSt2w/VD8hu1fT5/OPZl2W/85mt/rREIhngBvNgkNnUvvrNpNImbPV1hRcb0BJ70vex9lvLQQ+E8MKEiTnIaSwZ8t6c8SzIJS2T3a/MYq4lkdzHuDpy5AqNZvXLQZb3BgfL/Hoos0XNT78F+cPd1xwhjV/f2HFw2g/1gY9Jpcpj2I+SG/mtzi9vFoE5Ssv+0RIjydg7fxnvUC/NEivhCcaJ6Mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DgKlNp5UvZqcdc+Rx2KjRY2Ru5zRrFv9HqjLDRW6V/s=; b=F9Rrdgxso8cDFiMVaDxnRwoxakj6CQeWoY4cH/q+S/Ar5/Mk4/5tB3i62UVa9ChdHBLRSiQVAY4QCifi+ypDxr7wewkJNEPebxmsU7B0k05yV00nhLcE/S9LHrut6gs6RbXV7vBLVAkURwgCiwXWnofay1xzIc6N1xVksU66FWxFa33eprW6j6shpG3kHtYltE7FqRqGwzZuMOrKNXUeLG/yoCrhwp5ulJuXKWUBdv4rx2l93u4laIyuxjzP6tpYgNr0HfJPDkm8a1jQNR0AfJ09J2ozH9WmqXOEIVsyxHnqIr8AWjTYY9qgPOp3BRPuCqj+d2+YTXwozsoNX39YKA== Received: from MN2PR12MB3293.namprd12.prod.outlook.com (2603:10b6:208:106::13) by DM5PR12MB1609.namprd12.prod.outlook.com (2603:10b6:4:10::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.16; Thu, 10 Feb 2022 16:33:31 +0000 Received: from CO6PR12MB5396.namprd12.prod.outlook.com (2603:10b6:303:139::8) by MN2PR12MB3293.namprd12.prod.outlook.com (2603:10b6:208:106::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 10 Feb 2022 16:33:29 +0000 Received: from CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::94af:4a1a:26aa:cc1c]) by CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::94af:4a1a:26aa:cc1c%6]) with mapi id 15.20.4975.014; Thu, 10 Feb 2022 16:33:29 +0000 From: Suanming Mou To: Asaf Penso , Ferruh Yigit , Alexander Kozyrev , "dev@dpdk.org" CC: Ori Kam , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "ivan.malov@oktetlabs.ru" , "andrew.rybchenko@oktetlabs.ru" , "mohammad.abdul.awal@intel.com" , "qi.z.zhang@intel.com" , "jerinj@marvell.com" , "ajit.khaparde@broadcom.com" , "bruce.richardson@intel.com" Subject: RE: [PATCH v4 00/10] ethdev: datapath-focused flow rules management Thread-Topic: [PATCH v4 00/10] ethdev: datapath-focused flow rules management Thread-Index: AQHYHf1p7PUq/U4Qm0m4aKYjboH+ZqyM8o0AgAADVgCAAAWHMA== Date: Thu, 10 Feb 2022 16:33:29 +0000 Message-ID: References: <20220206032526.816079-1-akozyrev@nvidia.com > <20220209213809.1208269-1-akozyrev@nvidia.com> <245157e3-1948-f207-9cdd-88ce22cad453@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fc9ceedd-c567-41e4-477c-08d9ecb31236 x-ms-traffictypediagnostic: MN2PR12MB3293:EE_|DM5PR12MB1609:EE_ x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /PpSE7GM5Z6L7YOIVhiO2ydu8GDSuIcsIZ4uKLZ97FSs1Ch5DY15AkDURzxs9RWb7mtjaKuJ/Fw6e1tP2fJqeuzei//mucKlIb/CgivHEP/xYWyYNAAS+ZQB8Yzo0q4h5xetu0Cmm1cCv4DTxX9tS0y8XKhWn+QaLfV338qzi0p/KdWPiPWtw4ynWkiZ9UJuER9YSiOySSTzFZSrWJj8SPCMmrpbTUMWoWsGCtSqyru0qSbFpneyrrlYDXMPZVjjUGJ330ZJuMa904e/x5l3t7/x5/bvNQ6xIJUACNi5jdiFu5GwdOKoSzGPJRdnji7IWg9sgCiZichQCPrX0AmD4CpZXQCMndtWw+qjojeLfgj7rk1W8ziW4wRH8LYXMkW/tsXTjaSzm8f/n6UcN6cbJMmh0Nk8CHL27x7PVRNdAyn/cYnbK7La/3T7flhf0oU6EZNytDwRYyy6qw3zoSy/pDpaz5VaJJTPuYWMb8wvrnUVGBYuez/SXRfFouTf2cNQU0Ib1UWbtRgyRl1Un5qKrvfUiEoRFPohIFnmvhnLyaxFIAx6Zz+VzTF/ZxM4iSWselok9XcUELGIoGJgfpDPX6YBUORCxRoQYt/98ioPGKqZKrcKwMoIkpjX7bO0wnRZFGs9BGhKMlgHF5V+Dj4Qupn0VzXZzKZRdxK1qP67cRLKtxUb7ldmuvYlaFcU4swEjFvjnt/rUVrF4SNWa1o5ORFdkEHLIHHu+AFo0DfJagux1m9uxmpAi0E1UaU5MTxGUwslNFh72uWEjpPIR8UtcfdMi31KpRqpaSwlrO1zwduDZ0/synPxesLeYM5DWlrRkFAlifAr20bfZq5umr7xIw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB3293.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(316002)(110136005)(54906003)(66476007)(8676002)(83380400001)(52536014)(122000001)(76116006)(4326008)(66946007)(66556008)(64756008)(66446008)(9686003)(8936002)(53546011)(6506007)(38100700002)(38070700005)(26005)(186003)(7696005)(86362001)(7416002)(508600001)(2906002)(966005)(5660300002)(55016003)(71200400001)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fLWpU5msOVE7x6sQGt2hHfSPB7+P96JnmyeBq49j7Z4fcDMNayMfnijTdqR8?= =?us-ascii?Q?gChQUY7ppbZXfoqbh+M6kkwkmI9j5ikOOr98pcxxHH4modds+mdipMMUNqYC?= =?us-ascii?Q?7DYebj+rkfJvYMGExv0v8QaQixH9MzCKF6gYZKAm88AiSCiGvulyn4SXI30h?= =?us-ascii?Q?/yiradaL4AywOirG3/lYrLk657KzGQ6OLD0i0234/jJY+c+ePi1dkz7uAMY+?= =?us-ascii?Q?4y14U2rY26mzcqW+jaMA+TBafSIVnIHffeI7YyWN2xOZwPlC8glxEVNC7H2E?= =?us-ascii?Q?21jfGlJiNuU8o7B42jSObrPLfP9X2cZlsTMxV6ysfbbBXqQh9VTKJU9YEvRo?= =?us-ascii?Q?i0M69LgR9tIPdRN7X64wep3zgoU91cu8waPtqxWeHopbU/vop/0PvqjkbzFJ?= =?us-ascii?Q?cvATejd9ztNX4liO480oFPq5o9CSkmxTJENo2T2A2TxlTPcxnZ46AJEcn6ev?= =?us-ascii?Q?mXcM46y0PLcgncHdZKU7+MmWozB9mwKprRH1jTImhwX3RvAxML7SB49XBa7M?= =?us-ascii?Q?nnNtKmPTGmhkn6WCQAjHYPG6GPM/TfqHxeE8s5naoSDfo0HQzJFaUM6mjBLn?= =?us-ascii?Q?BIFKgLgYdVWPNlK/3+mw+cAz5zUACGdGOHU0y1opPHh/UqrY0j6MGOFsqeNb?= =?us-ascii?Q?qFY+gVv8bMtEdV2uoGiewlFR2NltR9MTmIAKfu06F9vtMGYnwp/73qbkKMfJ?= =?us-ascii?Q?9PgRy6drf/fs8WP+3BzSN/lKbd7qRSol8r/sg+zvHcwD1hDLCUxCB2P2dFX+?= =?us-ascii?Q?xDXVAIXZNh3f9X1JZ0unIwPWa23nWbWvXLaCvCHay9wRpFawqc5WYb4R2UbB?= =?us-ascii?Q?Wb5QIAkZAF3CCV0pmpyEzMSyJ7n4SrE4lXUk6S10jYaipz4Cx9d3/UqyMp6n?= =?us-ascii?Q?Tt5R5Jo9pH1AVDr3Hv7RWdI7xx/CpFC+KCSkdXXNE8EChWvwLu8lIuhT8MjW?= =?us-ascii?Q?HwTNH2lXdNOmiFhBoYrkpkAWMPE6V4MqExyz2arKyd01fZ9OE/1DtykBlz8n?= =?us-ascii?Q?gr9AbkbvEuAIU19mJIzMG++NHKBSmpD+zcxIN13g0M/74Gdd//bZnr8zA1uh?= =?us-ascii?Q?iPBjy05jPteFeLKKAgZp91Duqo3xktwy3Bj4HlbKL/yZ4MZJ0KQlDYAUr9x3?= =?us-ascii?Q?yU0rFCk+aE2wF4axhSNOdrx8pDLD8UVn8u/IANZgL2Aui54fO+v7lVknvDyr?= =?us-ascii?Q?VQGQsmdqPYof8nyrPdaHLotJQBfaIxmtaLx/ZRz/uio3Kv2oUKruXkfVmBeI?= =?us-ascii?Q?XIn7BEfg3tVLsxJs3m+1ZRwW01OE0fevK3fAuU/ezMxw45klKzgvU+ElbJtt?= =?us-ascii?Q?tw0fwbxyXM3NtNLEqdUSvBjAQYrQN3jBPgfHCWbcEltjpCtLQAzJeDBsea49?= =?us-ascii?Q?hwW7xIBfWrTSWTvdESuHZXPhwgKKqIHEWHfMFYgpETZxj1IjFN5WwBTgahql?= =?us-ascii?Q?qGR8tmNLC7jS4qOtUblV7fP8raVdRv/3ECB+81E3/VOVSi60XN48g/jXo7lN?= =?us-ascii?Q?vN/7qKaSQ+ir3ETO51F3Gt2x7biRQRjy1PueZS6Fvz+OtfxgAcT3+dDEtemw?= =?us-ascii?Q?CXrsCodsFK7MLifew/w/kIBNehZox7kjuV4he7ANctr4dqlIo9SLefIA9n65?= =?us-ascii?Q?z7x0iSK52Fb9VIZTzZOspAc=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5396.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc9ceedd-c567-41e4-477c-08d9ecb31236 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2022 16:33:29.6912 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gYggOIS90xHu6axr+Jpe5tZR7beB8qsrkUsfEmgXGC5tCA9L/3WxAqK+Ota8cH0H+VVPxdjKsF8X1HVBpYx5WQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1609 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, I wish the PMD part is not too late. You can find the series here: https://patches.dpdk.org/project/dpdk/cover/20220210162926.20436-1-suanming= m@nvidia.com/ Thanks, Suanming Mou > -----Original Message----- > From: Asaf Penso > Sent: Friday, February 11, 2022 12:12 AM > To: Ferruh Yigit ; Alexander Kozyrev > ; dev@dpdk.org; Suanming Mou > > Cc: Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; ivan.malov@oktetlabs.ru; > andrew.rybchenko@oktetlabs.ru; mohammad.abdul.awal@intel.com; > qi.z.zhang@intel.com; jerinj@marvell.com; ajit.khaparde@broadcom.com; > bruce.richardson@intel.com > Subject: RE: [PATCH v4 00/10] ethdev: datapath-focused flow rules > management >=20 > Thanks, Ferruh. > The pmd part is being updated according to the previous API comments. > @Suanming Mou is working on it and will send it once ready, before the > weekend. >=20 > Regards, > Asaf Penso >=20 > >-----Original Message----- > >From: Ferruh Yigit > >Sent: Thursday, February 10, 2022 6:00 PM > >To: Alexander Kozyrev ; dev@dpdk.org > >Cc: Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL) > >; ivan.malov@oktetlabs.ru; > >andrew.rybchenko@oktetlabs.ru; mohammad.abdul.awal@intel.com; > >qi.z.zhang@intel.com; jerinj@marvell.com; ajit.khaparde@broadcom.com; > >bruce.richardson@intel.com > >Subject: Re: [PATCH v4 00/10] ethdev: datapath-focused flow rules > >management > > > >On 2/9/2022 9:37 PM, Alexander Kozyrev wrote: > >> Three major changes to a generic RTE Flow API were implemented in > >> order to speed up flow rule insertion/destruction and adapt the API > >> to the needs of a datapath-focused flow rules management applications: > >> > >> 1. Pre-configuration hints. > >> Application may give us some hints on what type of resources are neede= d. > >> Introduce the configuration routine to prepare all the needed > >> resources inside a PMD/HW before any flow rules are created at the > >> init > >stage. > >> > >> 2. Flow grouping using templates. > >> Use the knowledge about which flow rules are to be used in an > >> application and prepare item and action templates for them in advance. > >> Group flow rules with common patterns and actions together for better > >resource management. > >> > >> 3. Queue-based flow management. > >> Perform flow rule insertion/destruction asynchronously to spare the > >> datapath from blocking on RTE Flow API and allow it to continue with > >> packet > >processing. > >> Enqueue flow rules operations and poll for the results later. > >> > >> testpmd examples are part of the patch series. PMD changes will follow= . > >> > >> RFC: > >> https://patchwork.dpdk.org/project/dpdk/cover/20211006044835.3936226- > >1 > >> -akozyrev@nvidia.com/ > >> > >> Signed-off-by: Alexander Kozyrev > >> Acked-by: Ori Kam > >> > >> --- > >> v4: > >> - removed structures versioning > >> - introduced new rte_flow_port_info structure for rte_flow_info_get > >> API > >> - renamed rte_flow_table_create to rte_flow_template_table_create > >> > >> v3: addressed review comments and updated documentation > >> - added API to get info about pre-configurable resources > >> - renamed rte_flow_item_template to rte_flow_pattern_template > >> - renamed drain operation attribute to postpone > >> - renamed rte_flow_q_drain to rte_flow_q_push > >> - renamed rte_flow_q_dequeue to rte_flow_q_pull > >> > >> v2: fixed patch series thread > >> > >> Alexander Kozyrev (10): > >> ethdev: introduce flow pre-configuration hints > >> ethdev: add flow item/action templates > >> ethdev: bring in async queue-based flow rules operations > >> app/testpmd: implement rte flow configuration > >> app/testpmd: implement rte flow template management > >> app/testpmd: implement rte flow table management > >> app/testpmd: implement rte flow queue flow operations > >> app/testpmd: implement rte flow push operations > >> app/testpmd: implement rte flow pull operations > >> app/testpmd: implement rte flow queue indirect actions > >> > > > >Hi Jerin, Ajit, Ivan, > > > >As far as I can see you did some reviews in the previous versions, but > >not ack the patch. > >Is there any objection to last version of the patch, if not I will proce= ed with it. > > > > > >Hi Alex, > > > >As process we require at least one PMD implementation (it can be draft) > >to justify the API design. > > > >If there is no objection from above reviewers and PMD implementation > >exists before end of the week, I think we can get the set for -rc1. > > > >Thanks, > >ferruh