From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FD55A0C51; Tue, 13 Jul 2021 01:26:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF9A94069E; Tue, 13 Jul 2021 01:26:19 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08on2040.outbound.protection.outlook.com [40.107.102.40]) by mails.dpdk.org (Postfix) with ESMTP id 71FD64069D for ; Tue, 13 Jul 2021 01:26:18 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DF1hBiKoU0vO+XzZP3rfebsnBcazLd9mnZAQmOVtShoEn+bsazuymXK7fieVA1/2EmadlUnpuqHnznI9BEkFNNosAYOHCab//VxlGADtPB/H3M2htwRDSd38yZBhBWqz75TkSpbZdLoBn9A7hpeTx8dFHA25ym5BQ8xhDazW/KP412XXpRmfSzWARrBpIFgLU0Nw3uAUowBVkCptT5qZGOSurFdsmQEISZgYNMlImnC7piptA90qkuQsLLMFJpnluimRTYhy5JptYnSbA3YzHkN+VeXzMY9oHUAanopNs3NSD6XL8fq2pHKCxtB9mIYEZv12QJRG96fKnuDSfHqhFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dENZB4ieRWjhfPikmziOQSWjrxNfb/THfksrh1XkZZQ=; b=RSyA+ZWZPc1Yvb9SJgydMy8eYlfVHaDml3IvPgO0QO4EvIhB6lWrZMxYPhwj4dA3VUI8PtHjbJbt5jvbRtSdAIYSb1+4RBgflAUgDbqi5onvDzNwoHeawZl2bq8Ij4aBIp/u/tNefejf06t3NJ0KWoVbXLffnLIjAibFyh3V2NE83MAduriW6Z0H0UwS4Hm8SqflbqDNdo663JfxmzWIvZaDx4wmeWqKmjJsMibugQdoCg8+fyhCmC0V2Fj74xnFxTq1Lj5w1xyNVu8v39unyv1x0WUamoKHSSh9KstriQHaJYy3SL/Vs/aUa3QgaKsn7s2rkhHYgLRcH0kB5X1JLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dENZB4ieRWjhfPikmziOQSWjrxNfb/THfksrh1XkZZQ=; b=fVa11d27/heRyvtAnEZ6gCEDgUmw4mqXKr0n37+5QyOvdfExriaT9EG0EoaLYjOL5g+k5pWXRjrUO0i9fjEL2/memjHUToeJhyTOyEmKrBd/J6zvcbwQ56Ro8WBRBwBssuU+rEMFUf/MNEh90/+e+erNg4PSUDBKzNcLLV4I8GutaPQozNaz26Rt58kKNMEpTiw0wMAN5wW1Ro6D/tH+92OhvQuM1KDwrLrIxFzUUfmt+rtN3mudI0EMk2O+qz3z59sA9S//utGQfvGdB8JGfjwcnxT/PRI/iQRxUh9AVpxGVvvglRJeX0m2Jy/C/3eTvJteXJ4wDAAlHQOYkEVAUw== Received: from CO6PR12MB5396.namprd12.prod.outlook.com (2603:10b6:303:139::8) by CO6PR12MB5492.namprd12.prod.outlook.com (2603:10b6:5:35d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.26; Mon, 12 Jul 2021 23:26:17 +0000 Received: from CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::3dfc:6b6a:662:7f51]) by CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::3dfc:6b6a:662:7f51%8]) with mapi id 15.20.4308.027; Mon, 12 Jul 2021 23:26:16 +0000 From: Suanming Mou To: Raslan Darawsheh , Slava Ovsiienko , Matan Azrad CC: Ori Kam , "dev@dpdk.org" Thread-Topic: [PATCH v5 14/26] common/mlx5: add list lcore share Thread-Index: AQHXdy5zZfNpfk2pdk2kT52e65kn5qs/+6bA Date: Mon, 12 Jul 2021 23:26:16 +0000 Message-ID: References: <20210527093403.1153127-1-suanmingm@nvidia.com> <20210712014654.32428-1-suanmingm@nvidia.com> <20210712014654.32428-15-suanmingm@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d29ba9ea-3f52-40db-bffd-08d9458c7295 x-ms-traffictypediagnostic: CO6PR12MB5492: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2733; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: z9keyjGOvQR8YtRju1cWno3k5Y3LNtHH5U4mVtDK/On4ER8zTpMRhOxdVejqgg7a9jvfaXqc7WXFyu/VF/SikVgNXCa180qqzmhWeTxOaSX3E+0Nvt5HHnk7hRLF+g2OMzrPFmJwsiWHfY8Dr+RCH+gv6Q3f+NynQAiWQINSPCAWmi7nZYJEpYz+tYCktQOgGQKHGcIlAOCMdcmEu0my5oLpc2XELMOK1y5uGme+sD+Z2JH2KLJ0FT2Ppx9JtSwsdICsYc7vDiWtrCzpyhsYfbEPbMuBnbLdg9uhSkuIxpwXwAj8kXf9Zo345v/dZ1+PaEvngzN4/UeewjRf4Msmrg2cARBi9bfG3bgzWLGfAZaX71Ri5C9et9Hy4VcrboTqP1Z+1R9b//uv23dr+Kutj88qKI+iKqG1yR/GTu7TE0aVUN+D0jQ2bKoHJcdMT8eHeFaKVNzRRNEvLzQzQzzDJxxTL8CadNti+m80RbHLgEtgwjnvjRzyBuXLohJLpby9jJAsjqgb2Uz8Qlt4H3cm+zQwqKCl4I1H9zj74RACUiz3VmQkxN2F63sEtxxkCx+lx3fo4q8IJbn/gFVKXfyg8YSWkGbqs6c+/tT09okM87CIpCDxJfyYhWUufW9v9iH91bolC4cq8aoeIXEYGAUbEg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5396.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(376002)(366004)(346002)(39850400004)(53546011)(8936002)(7696005)(478600001)(38100700002)(316002)(52536014)(122000001)(71200400001)(55016002)(26005)(6506007)(9686003)(83380400001)(6636002)(110136005)(33656002)(66946007)(76116006)(2906002)(66446008)(8676002)(66476007)(66556008)(64756008)(5660300002)(86362001)(4326008)(54906003)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IhCkSz4jlmdWTKhDyZEUrM/iwCP+dXiA32XCrzdb8YSTSgm3OBoKaDn5N/OQ?= =?us-ascii?Q?+U+l3Tk5jcupBrH7/ugFnyJ2XiCfVwssaRgl2OxX/VJfc/svEzQ3N7wR4EVo?= =?us-ascii?Q?BnqyPXSLQ9tfsaLHBdZ94liLU+RbFRMJCsgjPJxBpDJe0uZovKz3UHgPtugj?= =?us-ascii?Q?fJrnBboQVGIPKB3cGvvBKCWMjYJ/YNZ7QWs06tcs+zhCQmtv5BuFKjTnU6GR?= =?us-ascii?Q?XtEfvG4ESNsPu1CQUx+GHkqVO1TEdSkXDQJ+S5umf5cNTmk20EPQUPXcHCOa?= =?us-ascii?Q?3TcIP32C5Hhwi4r2xynrAL0TrSk9nXTlANaVnxYCilLLs/fxGZJppPaDRk0K?= =?us-ascii?Q?iMNY8XUAdAV97mc3za2noPhx4qg/0fSw/3NDRlbmK05VZqUktbQ7w/quCGAj?= =?us-ascii?Q?VYESRm4U6Zmdu+3AdPYXIJSlw0g5GmZ53/hUy/VM+JqbOM+vIKKuC1gELGNo?= =?us-ascii?Q?qt6nXSaxYb0X96wEWmSvMQSc5+5YIoTcCAmysDpbdyDvaPRQKvxLirBW1waA?= =?us-ascii?Q?kuRGvRf0a0eRjUEHLd3BM4dRcUK55SOZuMHgAmaHIQyVhDMjR9cqezlNNH2C?= =?us-ascii?Q?JBbCoSqbeBFG6fH/6viG1RP84BOtZICuAvQziz4uFhJuTchB0ByiPvimZEZ6?= =?us-ascii?Q?bx9PhyfxPgjC9m/fYdAqG68pSDE2uYp/R5TlD7vEQ53XkEjrTpoiSM4XLs3O?= =?us-ascii?Q?a7YkpCTxY5+AN6gy4+1pcTIx3ZUUVUegDA3PaUmOQpdkRIbeLXVqAE7p8vG7?= =?us-ascii?Q?pUiaU0XuWWi48f/awV+4UhoRWabxpKVFxG0EXiBq5JbXgoo/8hLHiZJ512f3?= =?us-ascii?Q?MZnuAxZs8iyhKgfztWuABeXg27ASlWNOcSURXnfjYIlgbGFJqo1I9B2ypbQx?= =?us-ascii?Q?nk3h6IZicIu0nFOD2yWaW/LI1UYnw2Gc8u9FQbuJNGTvCOw4rQfRU6CvlR5T?= =?us-ascii?Q?+Ae8y4bc5kZntNemiJog9cv8BMEiRkPrOnbdcuBYvqxKk+H8EblHxrItZz1L?= =?us-ascii?Q?UGkDZmOCyEe3dGZwU4qxNqu4+psW1Tmqx2/gRTX662Q2nuUoZSIP1KgaNgL2?= =?us-ascii?Q?IcZbLR16h1FhULRums+JNskyvCDqhVZYlTp8bllEzqLVGO0BcjASzISF6AYv?= =?us-ascii?Q?h3gD+U9HVv9nMFz1tax4AQajNbn2sHuLf61IRkCVq42ALfpuGpHbzVhHLj49?= =?us-ascii?Q?2zpC4MWdVMrKdYiGweY8xelMmTbyVESuA/Ij+Kt9Qb8BRwNvJweMllIFsjhm?= =?us-ascii?Q?dW4E47PzbXeY2NJrjS0psQw7j4YvguHxkZxS6bkLAACHAYVIpuQrAx520ALW?= =?us-ascii?Q?aCllho5ycmAR/ylYHKtKgINa?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5396.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d29ba9ea-3f52-40db-bffd-08d9458c7295 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jul 2021 23:26:16.8476 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jCoH4+P58blDYrTibKHgY0Uufcgtngz17RvIF+S5XsHSvqk7IdqsSUyQ+FF/mm5pOjBBEskuwsjpgMea4qE3Ew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5492 Subject: Re: [dpdk-dev] [PATCH v5 14/26] common/mlx5: add list lcore share X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Raslan, > -----Original Message----- > From: Raslan Darawsheh > Sent: Monday, July 12, 2021 10:59 PM > To: Suanming Mou ; Slava Ovsiienko > ; Matan Azrad > Cc: Ori Kam ; dev@dpdk.org > Subject: RE: [PATCH v5 14/26] common/mlx5: add list lcore share >=20 > Hi Suanming, >=20 > This patch will cause the following failure in compilation with CLANG : > [1443/3183] Compiling C object > drivers/libtmp_rte_common_mlx5.a.p/common_mlx5_mlx5_common_utils.c.o > FAILED: > drivers/libtmp_rte_common_mlx5.a.p/common_mlx5_mlx5_common_utils.c.o > clang -Idrivers/libtmp_rte_common_mlx5.a.p -Idrivers -I../../root/dpdk/dr= ivers - > Idrivers/common/mlx5 -I../../root/dpdk/drivers/common/mlx5 - > Idrivers/common/mlx5/linux -I../../root/dpdk/drivers/common/mlx5/linux - > Ilib/hash -I../../root/dpdk/lib/hash -I. -I../../root/dpdk -Iconfig - > I../../root/dpdk/config -Ilib/eal/include -I../../root/dpdk/lib/eal/inclu= de - > Ilib/eal/linux/include -I../../root/dpdk/lib/eal/linux/include -Ilib/eal/= x86/include > -I../../root/dpdk/lib/eal/x86/include -Ilib/eal/common - > I../../root/dpdk/lib/eal/common -Ilib/eal -I../../root/dpdk/lib/eal -Ilib= /kvargs - > I../../root/dpdk/lib/kvargs -Ilib/metrics -I../../root/dpdk/lib/metrics - > Ilib/telemetry -I../../root/dpdk/lib/telemetry -Ilib/net -I../../root/dpd= k/lib/net - > Ilib/mbuf -I../../root/dpdk/lib/mbuf -Ilib/mempool - > I../../root/dpdk/lib/mempool -Ilib/ring -I../../root/dpdk/lib/ring -Ilib/= rcu - > I../../root/dpdk/lib/rcu -Ilib/pci -I../../root/dpdk/lib/pci -Idrivers/bu= s/pci - > I../../root/dpdk/drivers/bus/pci -I../../root/dpdk/drivers/bus/pci/linux = - > I/usr/usr/include -Xclang -fcolor-diagnostics -pipe -D_FILE_OFFSET_BITS= =3D64 - > Wall -Winvalid-pch -Werror -O2 -g -include rte_config.h -Wextra -Wcast-qu= al - > Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing- > declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition= - > Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings= - > Wno-address-of-packed-member -Wno-missing-field-initializers - > D_GNU_SOURCE -fPIC -march=3Dnative -DALLOW_EXPERIMENTAL_API - > DALLOW_INTERNAL_API -std=3Dc11 -Wno-strict-prototypes -D_BSD_SOURCE - > D_DEFAULT_SOURCE -D_XOPEN_SOURCE=3D600 -pedantic -DPEDANTIC - > DRTE_LOG_DEFAULT_LOGTYPE=3Dpmd.common.mlx5 -MD -MQ > drivers/libtmp_rte_common_mlx5.a.p/common_mlx5_mlx5_common_utils.c.o > -MF > drivers/libtmp_rte_common_mlx5.a.p/common_mlx5_mlx5_common_utils.c.o. > d -o > drivers/libtmp_rte_common_mlx5.a.p/common_mlx5_mlx5_common_utils.c.o > -c ../../root/dpdk/drivers/common/mlx5/mlx5_common_utils.c > ../../root/dpdk/drivers/common/mlx5/mlx5_common_utils.c:152:6: error: > variable 'entry' is used uninitialized whenever 'if' condition is false [= -Werror,- > Wsometimes-uninitialized] > if (list->lcores_share) { > ^~~~~~~~~~~~~~~~~~ > ../../root/dpdk/drivers/common/mlx5/mlx5_common_utils.c:165:32: note: > uninitialized use occurs here > entry =3D list->cb_create(list, entry, ctx); > ^~~~~ > ../../root/dpdk/drivers/common/mlx5/mlx5_common_utils.c:152:2: note: > remove the 'if' if its condition is always true > if (list->lcores_share) { > ^~~~~~~~~~~~~~~~~~~~~~~~ > ../../root/dpdk/drivers/common/mlx5/mlx5_common_utils.c:136:31: note: > initialize the variable 'entry' to silence this warning > struct mlx5_list_entry *entry, *local_entry; > ^ > =3D NULL > 1 error generated. > [1500/3183] Compiling C object > drivers/libtmp_rte_net_mlx5.a.p/net_mlx5_mlx5_tx_empw.c.o > ninja: build stopped: subcommand failed. >=20 >=20 > ######################## > Build failed! > CC: clang version 12.0.0 (Fedora 12.0.0-2.fc34) OK, I will check it. >=20 >=20 > Kindest regards, > Raslan Darawsheh >=20