From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 345974331B; Mon, 13 Nov 2023 14:13:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B9344067A; Mon, 13 Nov 2023 14:13:39 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2053.outbound.protection.outlook.com [40.107.237.53]) by mails.dpdk.org (Postfix) with ESMTP id C1FC9402F0; Mon, 13 Nov 2023 14:13:37 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UeCAg4FNH1xFKa5IBwOLS06PSUXn/FJOQpVWbMXaz7FNZWZUQYuVs56oYYd/9Of6qGkIHrFzwom//9dEZQuHjf0ePOSK1j95Wg7rbSUqfsaxqsw4pY9dEZ2GaahxC1yPcHTXuQ1/iFz6wT5VgVdIQcT3jjEJtF3kZO6BdCXsVQVKAJwu/A4NwPNW2PKvwhZKZXwigB83JY9Jmeo6Ruoy3M93V4kW1G+iMprvOC1h2QXvJI2GcP9YBjR37sWc/0Z40axYjk7Jv/qYvE3s3uVLtKrwhY2VEtqs5yatNWTK0nWQ5C2M16ipfLKhB+NEjyS9GjOmO2qnHiMPe5VC+eI7KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aQiFibSBq3UFN9iX9q1MOCnjh0ZTTMwC89EDoIXmZVI=; b=EvB1NxxkNzV25nXrEmNqpsK136B22kvuXblCbGTEq/ZAmR97fiYvPOfY0wi0Ft9uYkoDuNA4EW+gDZuWyo6U+16/CDs/y5qU3bF5bOQGS0E05VhFuvZTFmleamY029czI2IpG/UFbaQPdkfxWw9qN1rv81d4Ke6EkDw2yiTOt8o5zqRTOHdUhAE/t03a+3e71SaSG9tDHNlHN0AEnZht8eI7aRB4hOuspLyBj2b34IQlp4Nz9hXD6/BwLlAqeS+7wPkjxhuxcTXAa12mXj6UCZimPtUDa55Ag/PkHUWpfW4WrohqOuw7WNzGRtl4UVga8Rv6Q3GASxwoKTOqXMgvKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aQiFibSBq3UFN9iX9q1MOCnjh0ZTTMwC89EDoIXmZVI=; b=bqiZhSPqMaVb9FG6iUSCyqts1ivqR82szAeGg4E7zrxFtKAFhh3tEDcI8c7xOvP3HFPUv/fvFZOSXGBQ37XpAq7xkMwdUvCF2bVDlpCCxk1cxRFFCa6rJwYYFvTWC+UMLbZkShEMCVpuCxdUXK94S86vqWjedTKOiIK2goomkSH5BxMeeXvmL7ymcBKBX1lguWBWlNTycCK7VIu0rf5sqtd5w9bMlijrbrSAtOEt7lNScaqISof/megbizKOnrKQF41MfK/jWbEJqPvIn191rtDPJEXikHbvGFvzokC4t4cPUQr6qKfPlBYNz5VMbQgLi0L6sq+p+O67fWr26BoajQ== Received: from CO6PR12MB5396.namprd12.prod.outlook.com (2603:10b6:303:139::8) by SA1PR12MB6947.namprd12.prod.outlook.com (2603:10b6:806:24e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.29; Mon, 13 Nov 2023 13:13:35 +0000 Received: from CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::62e9:ab3c:240b:ea17]) by CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::62e9:ab3c:240b:ea17%4]) with mapi id 15.20.6977.029; Mon, 13 Nov 2023 13:13:35 +0000 From: Suanming Mou To: Bing Zhao , Matan Azrad , Slava Ovsiienko , Raslan Darawsheh , Ori Kam CC: "dev@dpdk.org" , Dariusz Sosnowski , "stable@dpdk.org" Subject: RE: [PATCH] net/mlx5: fix the LACP redirection in Rx domain Thread-Topic: [PATCH] net/mlx5: fix the LACP redirection in Rx domain Thread-Index: AQHaFi7KeBbC9vJT40CL79oZJKvNV7B4OMzw Date: Mon, 13 Nov 2023 13:13:35 +0000 Message-ID: References: <20231113124136.8071-1-bingz@nvidia.com> In-Reply-To: <20231113124136.8071-1-bingz@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR12MB5396:EE_|SA1PR12MB6947:EE_ x-ms-office365-filtering-correlation-id: a074dee5-27f3-4614-731a-08dbe44a57bd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vij5/T39Q2HxWX0MKSiEs3GrGpeD9O23gdIykcaiFG5V8Do0hH3bBEJ9TzVmq0Cvpb540OUA5m/JUrm6r8SuudKA+ncJ80o2wIa9oCQ00znSTatEtY9CKJXpASY7T3Sls4NTtWQHbc/Yi6tiQOdAxA9HwjpZDV9IK64z6Po2qVaRggB8KZImh052M3/SufR146PgbjZq2wHe0OtJqConCwH5hg+lhHJnQ9XUwlffT1OOwB86aO4Pp6cFMP6oeqL4eNvN/egdvqnpD/rVMYE1pR4FtzJskWxYv5vq6iWMGNhwijPafUhWLQBA8RGug5jz831H4D0sXOMVMsjGYACgJHMZ29z58DR7jtAo6E/lbVzuAS0vgi2xYg/RyI2LOsq4WdylSwh+2/dJ1qy9d/LiIP3WE7h4QnqmgFWd/MrIPbcv1taO0l9vNYthK2dc/ZlaVrP10qyDWiav2IofhE9qYjXL3rr1yNWjNiKLJb4cZr57QJxZic093pgtExbIOeYGSDwvwdz/ry7+3ivm6iRyl48JgqtfZUpwlndCvtmI/DzUG9xxcFDbH30kFV3sHg17BhmZad5ASvPtBznRaHzRuKBdDJ+IVukbnI/xsEHaWakQpU3YRUGxx/EBluV47QDN x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5396.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(346002)(136003)(376002)(396003)(39860400002)(230922051799003)(186009)(1800799009)(64100799003)(451199024)(55016003)(66556008)(66476007)(66446008)(64756008)(54906003)(66946007)(76116006)(110136005)(86362001)(33656002)(38070700009)(38100700002)(122000001)(9686003)(83380400001)(6636002)(26005)(71200400001)(6506007)(7696005)(53546011)(450100002)(41300700001)(2906002)(478600001)(316002)(5660300002)(4326008)(52536014)(8676002)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aREei0YzaXyDa5jdSp7ySo2nKdQ3OAibL/ZJ8fm38ZEEiv3TGv3Mf1w3s5TZ?= =?us-ascii?Q?8vOvmYADYa4n6V0rp5TzBV0UDnZnPVAXKBr5m1ICBGRiaMSH4LjP63Hr2NY3?= =?us-ascii?Q?wBNcNrhVJHK3A9wasBnh1SJ/5cSnAVOTUpqGZ168rJj2U3zP5KehKM+wNr5x?= =?us-ascii?Q?iQtYyGegJN4WkMZHRU7fN3AWk54mSO8umHOCWDKsWOzHysvdrnjvD5/oZDik?= =?us-ascii?Q?EP9+9T8yUMi7gvvsVo/yGkhDeBEDhrWuy52wYzCl5rBFSsAB4aEAZThf+eZQ?= =?us-ascii?Q?798Np9o099pnMPD7EkfZBe5gHNEPH7dSe07itpt/GgtiF3HPNsLoVg6aw79G?= =?us-ascii?Q?a63lWmvyVj/NTO554SSBZJOVmzg+ly4fIvhV4ILHRIzYFovDI2SVzUrTlNxM?= =?us-ascii?Q?aS1h9Qka9GsXsGNcaehkfTi3TykDVMwoUXi8ermm8KBm6HADWjg21iNiH9kW?= =?us-ascii?Q?O46LqjjftvQHlTKZH//S/l8bNx+xRb3m9WXJ+kbpZ7DyIWKhaw9wFxNBRfVp?= =?us-ascii?Q?j8WY2U5UOLw9rRJye+eD9CKF4E/y4gQi20pUP9cDfE4yTz/kt/9uINoIYTt+?= =?us-ascii?Q?yOvcfRrRByDFOg11kIT8ku3XFkOdCN/vMjdchlMC+0W7xnVCiNbdqvU5f7sB?= =?us-ascii?Q?sanWhIuO5u3KUlrQ6iK5AnI8TmBMdpN3HNSqTaJPF/ssEyGnnfk16s8S/Gw/?= =?us-ascii?Q?1QeYsPla3ZhkhFDBeCMAhAReG1svERSx5rzMv04dRR7EYiefFFFoxoB/j74E?= =?us-ascii?Q?aEedjT/DqWCY0gNa2vKzZu+tJEM0UBwYfYUW3htlPNO+NUH7jpUcMsY53IKH?= =?us-ascii?Q?pq1melGvWddet337rV1LaEhJcfv4PgkIG0g6Vfi25nFqOqNqCodAkgdAhj+d?= =?us-ascii?Q?oObHPdDWmZgSZGFAbJRMOKBoV91zu/+VnHJyUBUm8KGKRMgZQnrEkX7QJOnG?= =?us-ascii?Q?zNgKSCqUpdLnZb+wMsYvrGgnHNmI8gCpzRkGBn72AcCXlxD3ZilOSOFBqSD7?= =?us-ascii?Q?0e3ibaBC54DThg4IuMLaVdtokHT8C32qdQ7BhSipVjhagCQH6qzkXG2suxY+?= =?us-ascii?Q?bM58ptQ0CCvdSt3QXlV+TmYGpeo1DRtHDdSGXUjM+yjhWzsyvEuRa+rZviJn?= =?us-ascii?Q?lrd1i/5URiluDc/6RgwcngNn75QBJYxSFLWsHHaiIFoFncRmp/7UZq6h4QNh?= =?us-ascii?Q?roY6fOALJG8iTF+qlCFp46dq1lXDITOb43/ulL2as7yApggJuH9hEEel7dog?= =?us-ascii?Q?A8mso1S06yznXEYbUfHdZ82RY7cRs9f6BDvJ4YMLSaLf6iteAfxaO3eO/kLb?= =?us-ascii?Q?Q47uFSVCqtkPHBWAO2dJfyKpCJ75sKpfWjaGvJlBt5Or0S9GbXBZpIti0WPN?= =?us-ascii?Q?OHAxSf/QzWuhyfI/4RV7tm6puppSDNu5xvBrYeJopyMB76x7I3F6CsdHowUF?= =?us-ascii?Q?4I2Kls1CR+8xgE5ZyyHNX5yXuKAKEqlmge4JvlTE7l3rv7sLCemlJ3TQ+WSZ?= =?us-ascii?Q?GKB0teMcLoVt31XIlTP4+47NHMk4yXgZgT/W31B52OuI/QHNsNnE6vC64YN4?= =?us-ascii?Q?LEmeYPiSuiaCzWGweK2cqnU5iZTmE2WOCDnysPWz?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5396.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a074dee5-27f3-4614-731a-08dbe44a57bd X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2023 13:13:35.3543 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2B+DLCxKEg2aKi/uUS3qpmeFF40XNffUg3FtqloxoKd0xlTyM9HLOL32Q81O1mEup31U2t6wVRubKmXrhPWq1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6947 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, One small comment, v2 is needed. > -----Original Message----- > From: Bing Zhao > Sent: Monday, November 13, 2023 8:42 PM > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh ; Suanming > Mou ; Ori Kam > Cc: dev@dpdk.org; Dariusz Sosnowski ; > stable@dpdk.org > Subject: [PATCH] net/mlx5: fix the LACP redirection in Rx domain >=20 > When the "lacp_by_user" is not set from the application in bond mode, the= LACP > traffic should be handled by the kernel driver by default. >=20 > This commit adds the missing support in the template API when "dv_flow_en= =3D2". > The behavior will be the same as that in the DV mode with "dv_flow_en=3D1= ". The > LACP packets will be redirected to the kernel when starting the steering = in the > NIC Rx domain. >=20 > With this commit, the DEFAULT_MISS action usage is refactored a bit. > In the HWS, one unique action can be created with supported bits set in t= he "flag" > per port. The *ROOT_FDB and *HWS_FDB flag bits will only be set when the = port > is in switchdev mode and working as the E-Switch manager proxy port. The = SF/VF > and all other representors won't have the FDB flag bits when creating the > DEFAULT_MISS action. >=20 > Fixes: 9fa7c1cddb85 ("net/mlx5: create control flow rules with HWS") > Cc: dsosnowski@nvidia.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Bing Zhao > --- > drivers/net/mlx5/linux/mlx5_os.c | 8 +- > drivers/net/mlx5/mlx5.h | 1 + > drivers/net/mlx5/mlx5_flow.h | 1 + > drivers/net/mlx5/mlx5_flow_hw.c | 249 +++++++++++++++++++++++++++++-- > drivers/net/mlx5/mlx5_trigger.c | 3 + > 5 files changed, 249 insertions(+), 13 deletions(-) >=20 > diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/ml= x5_os.c [snip] > @@ -8327,6 +8503,10 @@ flow_hw_create_ctrl_tables(struct rte_eth_dev *dev= , > struct rte_flow_error *error > ret =3D rte_flow_error_set(error, EINVAL, >=20 > RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, > "Failed to create control tables."); > + if (priv->hw_tx_meta_cpy_tbl) { I assume it should be hw_lacp_rx_tbl here. Can you please send v2 for that= ? And LGTM for left code. It's OK to add my ack for v2. Acked-by: Suanming Mou > + flow_hw_table_destroy(dev, priv->hw_tx_meta_cpy_tbl, NULL); > + priv->hw_tx_meta_cpy_tbl =3D NULL; > + } [snip] > 2.34.1