From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16396A0C49; Tue, 20 Jul 2021 11:08:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F28F240696; Tue, 20 Jul 2021 11:08:37 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2048.outbound.protection.outlook.com [40.107.96.48]) by mails.dpdk.org (Postfix) with ESMTP id 77E004068F for ; Tue, 20 Jul 2021 11:08:36 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cY3ljQ8L2TmRA5EJwT8BVnPbzTVDrmA1IOBiA/oPfRMnGbVk9QOYBmTKKTXJ+OqL7RSlCNa3MdtwLjoHNediuP+4NCC4mvZjCikBazZDAcQb9AhifkxYHv0a12DBJjSPJbIg9Jib+WiPw56olZQWrhuFBLV59Nn9Rxu0t+jRF/T6xGVN0SSLjG8I9IaE+Ktes0SnyTg2Jr8wpLH2T/7eV8sG0U5e0IVY8TK3Y3rQ8fk5DWeQA7e4gkJd1MqJdXgLE++2LkiPYtRzgKRxTBuJiIM0OqOmLA/ZtT8QSlXuQAr79btw98SDdiXG/0urJJ6xQSWplYJ4SreRkFhlboG3cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GLBYUd1cf1TfKUAJRKUGm5WAD5mpzJ+1wE8Vt3PWs2s=; b=ibjirVKQz7tjO5af1BV6da4rOmIGD6DiBCoDl3SIfrWMnQsPwS8s4dW+U69vxI+2bcrKYdNRtgBplgf0vs/+9weWzQy+Mo5Ur329jD4a8JJx0g3naZ2rMBKAsuhzFZWxAl4Oix6nlW5X0bV9STdOuKT9vH31sqixZPwmvXcC+94Y2TX3v0Wz7NzRVyciAHYENtWUtYOtf4pJNhm+Z1BGynzN5RmxJIGQTPXd1oT+fRyswvxl6XT5IgBLtSG2uuOpDK5NArZHDWcQcefJ5CWGA6Y8tDBFipvXm8u0NC6pF3oFne+OFrPhjgBFo+FqYDoTYgVeMZTU5h4Ev/JYwalK7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GLBYUd1cf1TfKUAJRKUGm5WAD5mpzJ+1wE8Vt3PWs2s=; b=VhnfUhO3FsE5hHuCGyUubLF9XC6oFuhfmSdOOy2nmrXDUkDjugJiFKCLVKEXUxjzsesAw42mObv/Uy6tJzS8chWq11146ohFN2Ic3ISSyfsCOKVevs387h7XvmOzOfMBaHPpqV3w6W6WU1stQ/k3OlB6XyiTEhtzYx61ZPEcfsOOePftCO4Vo5QHTzIc+JzEyuaCx4Whw07DNR8OACYlHGhAYdBGQcV2S5j1+qIIlUNVfP2VLFp1vzUYTLG/lsQE3DPuWm89LlfcpCMovCiK6MsVfgOK7dG0JOUvu/v12P7L6c9NTVwkdmtUQsgkiP1oNowwwQtcTGVKCFb9pZB99Q== Received: from CO6PR12MB5396.namprd12.prod.outlook.com (2603:10b6:303:139::8) by CO6PR12MB5443.namprd12.prod.outlook.com (2603:10b6:303:13a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.23; Tue, 20 Jul 2021 09:08:35 +0000 Received: from CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::3dfc:6b6a:662:7f51]) by CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::3dfc:6b6a:662:7f51%8]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 09:08:35 +0000 From: Suanming Mou To: Akhil Goyal , Shiri Kuzin , "dev@dpdk.org" CC: Matan Azrad , "david.marchand@redhat.com" Thread-Topic: [EXT] [PATCH v8 06/16] crypto/mlx5: add dev stop and start operations Thread-Index: AQHXeZhhn9lv7JVckUi/cmn/GWb2XatGAugAgAWXe6A= Date: Tue, 20 Jul 2021 09:08:35 +0000 Message-ID: References: <20210715150817.51485-1-shirik@nvidia.com> <20210715164126.54073-1-shirik@nvidia.com> <20210715164126.54073-7-shirik@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6700cd37-146f-4bd0-f00c-08d94b5df452 x-ms-traffictypediagnostic: CO6PR12MB5443: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2201; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eS1jdis+52OlKvr3/Vrkt7DiLxBsEiYbmUY7eIs5vfZ/HVEIIonidS0JonoqWDjmaEbIgall6fQ8fscHYDrqsfoxQt+DwvwgiKpMAOXVw74j1Ry3MW6Dp0Wd0ISMOWBu7x0Yk4CIJkcj+8Bcn0kSJJ8uu0kMGiNvdCb87cWJLIAsAHfwCLkuMC485Zmdtd4GGhAX1hmcn9GWcxmQF9P/Plxh/dvoWzn6PiW0cnPlbvAtDE8X5XS1/dwwMAuwCWQlPKurgBzHm2TeBSUMBjOD6vo5C3vQ6h9kvgiUMYUzv4rDcFmQZvuao8ZWs8M/lSljFnrW7LJZTq9ZhmPUR4bBbOQ1FwZG9iaXBcNePMMPjN1hCd9c6w4BGvfgZ/OWi1z7ZgFtdBAp2+9tUJFPE350Awx863vqhf2/DXAcB8PYAwWhiygn68JlcJFfHuvO3c/RoigkeVoIG7WrKdIMuSuwgUXmN77NYlg2BiVsNG7TREMRYTKcfgWPwoaDR/SVSPWGMLO+EsuGEotm6oRpL5pwo2lX+Q5Hv3QDYWeI2DluafS3zBtXmijrgwGs2Z9UCwSAMB1RvcSsfjO9bsmdhKtZc7NpghbKwXlNlwNQTVdG5aYJMCVA9mvssWQe8elFAvdEV4uiw/7DXmtI1o9ndcqHI4I0XkMCguK8B9VDbisLUfF/ynAgisSsg20vzOfE0c7aHH1GBvsfLE0N6kc+rO4E1Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5396.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(366004)(346002)(376002)(136003)(8936002)(52536014)(53546011)(54906003)(2906002)(8676002)(110136005)(71200400001)(6506007)(316002)(66556008)(4326008)(33656002)(83380400001)(66446008)(76116006)(186003)(7696005)(26005)(122000001)(5660300002)(66476007)(9686003)(38100700002)(478600001)(64756008)(66946007)(55016002)(86362001)(38070700004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sygC2XXERBpvl9geur4WJKpqP/iWcgqhqL7kbqgTJPAzkMfYw2zbYkK4/Wjg?= =?us-ascii?Q?060bFOHL5WDe0/h1uupxNP9hmTk/ugGb8E+SLAVmLnjVfTQjzrYKXil4HN+l?= =?us-ascii?Q?mgE7QxeHah9y+IuV0nmsMe0hDunm0u24pjSUJWxIqDZOR6dXrPSOGHOMMEQt?= =?us-ascii?Q?/It4PEWfGffkvWDFNzx27fwG5cnmSrMp0phw09onrkKED50iD53N1ZgvDI8Z?= =?us-ascii?Q?q6YpK2/dnkeN6Gbi/prSqUjlNQTy4YzBZiLD+E7CgQX7mgugf7RqjmseKges?= =?us-ascii?Q?SyFDtS7cO+cdY+tbfjvd5C7/tkDmo+iF+AcN+j3sH+5wRfT0ddaAROxlA97P?= =?us-ascii?Q?tUrY5Cb0aZl+5DJKxpQWWmQV7Yip3lmXGRtxkgED2Y14FHj+di0lGyK/yqwF?= =?us-ascii?Q?GyS8nyXlfvThJJMQv07cm0GrAgUTAfjGkhZIH1/PCqu6kB5ZTobdxCOk4Uf+?= =?us-ascii?Q?N+yNs4g1q9MzS8QX9+YeWEPXPZHMoJid0S0/aE89FFWGUVVQH823d3Jj+OKB?= =?us-ascii?Q?u9jhJySXhBWkZgK82DLqMB5YaYUqcoCfy9hPOW8qB5OIQeP8MBanMB/o4N1N?= =?us-ascii?Q?Tx8ulDEh7Mxf020orlBqWeXIJ1XHthAT1MC+XqgB7HTOtQsw7EdFTpEXenV5?= =?us-ascii?Q?qKuJaYfqUzDoEoVG5EVFqlwTphBWnhkkp2tGD39vvAKC/9pYqb0XheE0X83+?= =?us-ascii?Q?YGX/LQSH+RzkjrQ++wi/QowFoF5CuUINFaOosNuFn2pvgmNhsH6OUZc3zeV/?= =?us-ascii?Q?3bXxioizjuQs2gM4/WuVh3ywWkVmsg3hgFOSmgnh/GP6Z/EWY7TyyD+IYahs?= =?us-ascii?Q?/oZUqCNwQSOx3pultzQvSMJOAB9Za3tY8HkwNpY0APXM2oJ5tOY+mjFEpk6j?= =?us-ascii?Q?s6rq3wiwHOTszxoaADjhYLfClggAjtow7B0qgNxCWeZEkz5m0UynMzLJPq6G?= =?us-ascii?Q?wYbnlL268PcYKu4YEzzcj22P6wc52kJhR3MChAdDuMpjTmd5Fci7MGnnGSd+?= =?us-ascii?Q?Wl8mS2jmqd4Ze6J9ZRPVya1JpyUMcK+AO6A0NIIDHjfe1zvjeJZDdWgWDGoR?= =?us-ascii?Q?KOLk1XDF7uSinMd61/L6ZW3hA3H0TD441LaWR0HGCUs82BA7ZVG+WEz/Bm3p?= =?us-ascii?Q?UmY/81FYXrU/E3VaUvdrnpPNxt22ku0zFb7WYEoAh2O5HgG4R92uPGxQ9yDA?= =?us-ascii?Q?DvTFSWU2ieclZPvzCKZ5zREJCkmK1gw3Jbug7g7XYBjkyzY9y7t5jDrNFNH5?= =?us-ascii?Q?dDoAYHPsJkjc551AHZvGGJelc6mWJjG7U8U+OwKFeqtiOaLnPXgJBodjr7hc?= =?us-ascii?Q?TsPY6vUnSwOibu5jMdGo8h8T?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5396.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6700cd37-146f-4bd0-f00c-08d94b5df452 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2021 09:08:35.1369 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: S+s2BQ0pxgrU2jsWjMJ3ebpQ0R8dM5k7/cTlsaORSGyBpGe1esqxNS5mAJZKRazjPRMiRHXj6uhk5k4YQxxtig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5443 Subject: Re: [dpdk-dev] [EXT] [PATCH v8 06/16] crypto/mlx5: add dev stop and start operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Akhil Goyal > Sent: Saturday, July 17, 2021 3:45 AM > To: Shiri Kuzin ; dev@dpdk.org > Cc: Matan Azrad ; Suanming Mou > ; david.marchand@redhat.com > Subject: RE: [EXT] [PATCH v8 06/16] crypto/mlx5: add dev stop and start > operations >=20 > > Add the dev_start function that is used to start a configured device. > > Add the dev_stop function that is used to stop a configured device. > > > > Both functions set the dev parameter as used and return 0. > > > > Signed-off-by: Shiri Kuzin > > Acked-by: Matan Azrad > > --- > > drivers/crypto/mlx5/mlx5_crypto.c | 17 +++++++++++++++-- > > 1 file changed, 15 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/crypto/mlx5/mlx5_crypto.c > > b/drivers/crypto/mlx5/mlx5_crypto.c > > index ebaa65c7a9..37e66cf57b 100644 > > --- a/drivers/crypto/mlx5/mlx5_crypto.c > > +++ b/drivers/crypto/mlx5/mlx5_crypto.c > > @@ -131,6 +131,19 @@ mlx5_crypto_dev_configure(struct rte_cryptodev > > *dev, > > return 0; > > } > > > > +static void > > +mlx5_crypto_dev_stop(struct rte_cryptodev *dev) { > > + RTE_SET_USED(dev); > > +} > > + > > +static int > > +mlx5_crypto_dev_start(struct rte_cryptodev *dev) { > > + RTE_SET_USED(dev); > > + return 0; > > +} > > + > > static int > > mlx5_crypto_dev_close(struct rte_cryptodev *dev) { @@ -360,8 +373,8 > > @@ mlx5_crypto_queue_pair_setup(struct rte_cryptodev *dev, uint16_t > > qp_id, > > > > static struct rte_cryptodev_ops mlx5_crypto_ops =3D { > > .dev_configure =3D mlx5_crypto_dev_configure, > > - .dev_start =3D NULL, > > - .dev_stop =3D NULL, > > + .dev_start =3D mlx5_crypto_dev_start, > > + .dev_stop =3D mlx5_crypto_dev_stop, > > .dev_close =3D mlx5_crypto_dev_close, > > .dev_infos_get =3D mlx5_crypto_dev_infos_get, > > .stats_get =3D NULL, >=20 >=20 > This patch could be squashed in your basic operations patch as these ops = are not > doing Anything. OK, good suggestion.