From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BBCE43A77; Mon, 5 Feb 2024 12:49:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C573402BE; Mon, 5 Feb 2024 12:49:21 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2084.outbound.protection.outlook.com [40.107.92.84]) by mails.dpdk.org (Postfix) with ESMTP id 45181402A2 for ; Mon, 5 Feb 2024 12:49:20 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CbsBvg8Q1uyDhVj0kdBLVcZPHZ2vbALh8uCmUVOGylkUVn71yvJNEFRvumvcnAol+Kc3j1V1pFMQZcVokwXZnvnjgylFD6NC9keNd+nVTO8LSidp/02kTdlZ8KIu8tBpnMBcuuWJyQzG3V9HU0WEPvGQcAUvOZFUCOXjWe3a0aHbrGwn8qRbAtxGsEyfSK4p3PFWvG/e/oSZ+mx5QNPT0O4nAHKn6NNyTpSVkekciH0Ecyfq54PREr6mU5FJ1eVsqzntxXZNDUEuEvwCYSGmZaV80wKsLwun7D/biCsythE2klgySlb1u5JaCVbcbwo+PpBLEnXXHibzNg6wNZUavQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AGyOq9jX14bEgsrQajXqt+lHO3tB9AcCIHpHG55vmcY=; b=HtblmaWo4U9+slAUyg60pDkpwMcVnSgauDZiJtAg0exjdg2BdRS2lx0GuHayW8sC6zVag84LeD2Qd57UnE7OM70QpI+QcV7ItrGBxhEY3GonFF3HKYAmAuhIDJkHUkFVWnRs/wOiamZwUOf/8JQI49tGoQm5vXnnl6LXWEateThaxCgqw3IS96i7ibzo3n/EwjXsI2j37KdtumlDT72Km9jV7Yw/aIEyacqkVfsdNGub9/Twk34BaFk90LOlIVMNyw9adU0c7KKFMy5YDv3GvG660SFbkKrCAHq+FWr4aFl44fkMNyKvbZWKfu2IAqTBpUnpZtJZlD4uAbf5jayPzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AGyOq9jX14bEgsrQajXqt+lHO3tB9AcCIHpHG55vmcY=; b=CzsJEKpBBy0aegUYENE3SLpFZvPXgfHELgupQq953BU6+5jyDS+YJYV9jIVEbxPcpHoLl+SDnCjckTWOuli2bIB1vZQ7qYVcOkMAbUCR4Jue+LKIPhMhKuzXrzH4rsquhfJDRnuDUAvD9AMz2K4/DMULRtBhDXTyAGQZ9Q5uoSEZoe1zOaaFB8EXOFqOL6WG4sKJrrtuT+gEBT8ls8EtUkAMnZWBkoc5OC57J1P+0MgbkP3voa42kk1q5MrpT/eQ6i36JGbL6hy4Wl32jeIla4Byd1CvPNINGT1eVJZgij4Kh5d23bGjMrS5NsQXcS/oC73ABFZqo8LgvOBwczu3dg== Received: from CO6PR12MB5396.namprd12.prod.outlook.com (2603:10b6:303:139::8) by IA0PR12MB8352.namprd12.prod.outlook.com (2603:10b6:208:3dd::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.15; Mon, 5 Feb 2024 11:49:18 +0000 Received: from CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::df56:6290:5b5a:e018]) by CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::df56:6290:5b5a:e018%7]) with mapi id 15.20.7270.016; Mon, 5 Feb 2024 11:49:17 +0000 From: Suanming Mou To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" CC: "ferruh.yigit@amd.com" , Ori Kam , Aman Singh , Yuying Zhang , Dariusz Sosnowski , Slava Ovsiienko , Matan Azrad , Andrew Rybchenko , "dev@dpdk.org" Subject: RE: [PATCH v6 1/3] ethdev: rename action modify field data structure Thread-Topic: [PATCH v6 1/3] ethdev: rename action modify field data structure Thread-Index: AQHaVXDTzfKj1kOrVU6QywO0hkyH57D7oIsAgAAGo3A= Date: Mon, 5 Feb 2024 11:49:17 +0000 Message-ID: References: <20231214031227.363911-1-suanmingm@nvidia.com> <20240202004234.503097-1-suanmingm@nvidia.com> <20240202004234.503097-2-suanmingm@nvidia.com> <3279240.44csPzL39Z@thomas> In-Reply-To: <3279240.44csPzL39Z@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR12MB5396:EE_|IA0PR12MB8352:EE_ x-ms-office365-filtering-correlation-id: 24206fb8-8f65-452d-bae7-08dc26407bf4 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jQy4UQ8E124RNmZFrTq+b7s0rAJMOeeUqeELWLxgUfjl8mPE6top2xZu9psJCroRnmhz3pgjuQ2bF239idvRue0zZIZxkin3PAuNTwl2+NLsvS4LZMFih7CpHOdFqPXXpd7XqN5GWE1ubzcRUGqIMpoxYR3tO/7B7R4ZpU/JFRUTTvCJRaBZ3BjBHVOwYf0r7JIjUuyVk7SfyU9MG+8tTw4K3Ja+K9kSU8KB7owRbKMhCvKtSaUKM1zfGnqJwLlgfcmUc39Nmgi9dEn1auCPg9fGyKz23kYTEqksNdWVXonZmhkig3AMFCFi2QJvLFg/ZLGXTGGhvIgYDlE+HhTaXyAFDH3bz/szR4ClpnFfqTZtDjOe3drp+nZ3P4ntt7PpdtPhIHuV6peAxiqvFHFvYytIJ023U7qLJAw42TjDUzpvuOR4/DX/e4FC2eI3ZTVb5wea0pLMhBDIaRCFATwpWm4U5aKFiatV7LhkWairx4IOMgpd5e49dR8RLW0It/R6CSATpDP2MppILGuV0h1M+AAQDWdnZef1Jq7qFPuXYzju8DZ5ynyyYoV1/lnOd1xMgqTbSuFzOVjoKJqzrTUwOKg6x9XaxFGMQFKPmYRiaPGTzvpIwWxFEai33Q4IVMMN x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5396.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(376002)(396003)(39860400002)(346002)(136003)(230922051799003)(64100799003)(1800799012)(186009)(451199024)(41300700001)(55016003)(33656002)(478600001)(53546011)(9686003)(38070700009)(86362001)(316002)(54906003)(26005)(83380400001)(52536014)(66946007)(66446008)(8676002)(5660300002)(64756008)(66476007)(71200400001)(66556008)(6506007)(38100700002)(8936002)(76116006)(6916009)(4326008)(7696005)(122000001)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Bme+T9QuRpdyIqLDqoIzkd0j80UJMo4AkdA+jdwD2mrYpWhMYZjcO8cdwP6j?= =?us-ascii?Q?sIsyjOEcEklXmMiSrvprhwZ6N08Ri0014+OfkvI7vZ+/mAZSxJEGDw6yPT6T?= =?us-ascii?Q?WAArpHwz5SaJoiQ/3zT593lYehNVFUKJoim6wYiBLzkm55iJ+r1/y4V2XLPs?= =?us-ascii?Q?y1Br821PMMgJVek8ysvwP3qK9FDKXhr5jeCGIi9b1NmiddVUTv67hakVF+oo?= =?us-ascii?Q?dXlSnfONWMG4cj4hYlb+juRQUomr7ceKa3MiJ1RKqkzMZOu1qC1z7GqJGyPg?= =?us-ascii?Q?5+aJeygbxJ/NNCoKlhs2sB5+2hwc8llWRP6KSduOZknuoqfP6IZu68X0kVQ4?= =?us-ascii?Q?idGBpvuCEm3cQ0o/QzS0+OI4hdYHDlhzm+3pq5qTjDpmJf7s5xHG1QjWY90K?= =?us-ascii?Q?LdSyu54pooE5GDoG5Xyta/x3mMvR0AxbuCwwbwVFkTxjyLr3wXbt3HNQ8mSl?= =?us-ascii?Q?VBFulZwXlaB0oXq3TqTmgf7EJ/lU1avcdglaCwyLC0S6UEr2zDpJm+tZ/mvm?= =?us-ascii?Q?FkwhaBCvL+o1BMV/Wj6bUtGG/gCiBFybb5KFMlE12Lv46kIWnFuVm9q9rrln?= =?us-ascii?Q?9QPDC7pe6DMX9P7AtEW+26wD8HuhpTpwMkvig8hUnXFU1ytCsetrVfS1ewQi?= =?us-ascii?Q?IMVEXtqzp+CgeovLu7bTifvZPdFfOLAPeN1pa85KLLfXKl8dh8Kti40ggBUh?= =?us-ascii?Q?z6D5sRCXlbfjBvWY7ThdEiyk2kVoPy6FCcdXsep2R2181Zax5+p4URjWIVfM?= =?us-ascii?Q?khVNTAohlS9lLeNugRBHzXFKUJ85+jvmgN8ZvASxccon80Az5corgMxSS4+D?= =?us-ascii?Q?hICclbwRnsF3aTCIuDX2K1DLXN2K7CTBt91oJNkSGihDrPdEpIhRx8WdgPF0?= =?us-ascii?Q?vj4vH0gUpawvtqT2nQS3vPHw+UnG/Gh3UmqIjFmGjFdUbphorebKYm4IfVNC?= =?us-ascii?Q?H284HZ+im1jloBnIGQNMY1U4nvR1bpw4B0IJjsnUz377EzX1RBV6mNBwPq7Z?= =?us-ascii?Q?d7c97OxWb/e9WdrGfRBOW/Pj9JUTDBV03qi7Nb2JgGH9g24YJdDfDvuW8ODt?= =?us-ascii?Q?rS+OSclEx94Cijt6GB3XwGpeqLIIbEfWG7Avs7E9UjH+jf5sTyGRjjCNOf5S?= =?us-ascii?Q?QxH3ois4KgjTi0iifm/dtPuzwfJrHGK8uZc1+w0gTCO7YwefSfT1lFYu1Hwd?= =?us-ascii?Q?gIFR46zI/ppG3lCs0j5ywUKpOxLkQCdNArgml2sJIKVw6k+V828eW+QSxyNF?= =?us-ascii?Q?FyqlTY7BQOW4VtN1EzmJoYjp33eEepCVuK9ZMsShXg4NEz+fv91pgUYmaS4l?= =?us-ascii?Q?EUVKAI2c2Nx4MMo3HyDxROhi6WPsDqt6D+m8vqppOHtyAgK33dZpvHKfD81e?= =?us-ascii?Q?HQhy1MXZxe8hfa0uwcI6a/4uGZ3w3BhBAFr26gLoPCjb4UYNUZw94gJ/nTtG?= =?us-ascii?Q?mwyUdKzj6iP8RuQmmTwlYCTAECuupYe4Xk6DtCtSLjcqyH96NOCJsVcTUHn3?= =?us-ascii?Q?gMdplm0iEL0VowqrsJvHjZl6i2qbshwjT6Q/WSTkdsQ7Ko4uVT7x/6gLzD3G?= =?us-ascii?Q?0zrCCl3Zq1kQUwIRT6WMxf2d/74t7brgeTScm2Ed?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5396.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24206fb8-8f65-452d-bae7-08dc26407bf4 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2024 11:49:17.8620 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XHUMyZDHMj2iPc8Fcre8VPm4hrx6yXn69QZuAOcCcYMHzA4XRKC/DY91ZaOB61hedf1HqeDmF226ciud7Ong4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8352 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas, > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, February 5, 2024 7:23 PM > To: Suanming Mou > Cc: ferruh.yigit@amd.com; Ori Kam ; Aman Singh > ; Yuying Zhang ; Dariu= sz > Sosnowski ; Slava Ovsiienko > ; Matan Azrad ; Andrew > Rybchenko ; dev@dpdk.org > Subject: Re: [PATCH v6 1/3] ethdev: rename action modify field data struc= ture >=20 > 02/02/2024 01:42, Suanming Mou: > > --- a/doc/guides/rel_notes/release_24_03.rst > > +++ b/doc/guides/rel_notes/release_24_03.rst > > @@ -124,6 +124,8 @@ ABI Changes > > > > * No ABI change that would break compatibility with 23.11. > > > > +* ethdev: Rename the experimental ``struct > > +rte_flow_action_modify_data`` to be ``struct rte_flow_field_data`` >=20 > It should be in API change section. > Please us past tense as recommened in comments in the file. OK. >=20 > > --- a/lib/ethdev/rte_flow.h > > +++ b/lib/ethdev/rte_flow.h > > @@ -3894,6 +3894,7 @@ struct rte_flow_action_ethdev { > > > > /** > > * Field IDs for MODIFY_FIELD action. > > + * e.g. the packet field IDs used in RTE_FLOW_ACTION_TYPE_MODIFY_FIELD= . >=20 > Better to give the full name in the first line, so no need to add a secon= d line of > comment. So maybe " Field IDs for packet field, used by RTE_FLOW_ACTION_TYPE_MODIFY_= FIELD."? But when COMPARE item to be added. It will be " Field IDs for packet field,= used by RTE_FLOW_ACTION_TYPE_MODIFY_FIELD and RTE_FLOW_ITEM_TYPE_COMPARE."= And I assume that will still need a second line since it is too long. >=20 > [...] > > - * Field description for MODIFY_FIELD action. > > + * Field description for packet field. > > + * e.g. the packet fields used in RTE_FLOW_ACTION_TYPE_MODIFY_FIELD. >=20 > Same here, can be one simple line with full name. >=20 >=20