From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8688642D06; Tue, 20 Jun 2023 11:42:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5783E410D7; Tue, 20 Jun 2023 11:42:39 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2056.outbound.protection.outlook.com [40.107.220.56]) by mails.dpdk.org (Postfix) with ESMTP id AC1A04068E for ; Tue, 20 Jun 2023 11:42:37 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G5+lDsDQWuZgtq7+W/w4bkYKt5OGMnS1dWRfov51nGdbip+r3b6M0EO9lda3lQFBiTV/+lrhxhjq/F/ido+xxq2hnYWNkD6+chMHkrB4uTJl9vlt3SjDER5GpBZDZfr5lkabiQpjL/6e4ydfauzFznEBUcDp95eoBZJ+ELszNsoEIlLHB+ptqeJlcRxaW6O2FG4adzzJn7KgsgheZgsQmUiUCc6OAY4dL4CobrqLTRxGUhnQQUL8fv7IWAOqjTkBVJmJOVKrgqRYWOw7fjEMdU+98s8ktGvJ57qxfo6JtbsFnvryzzWrOKs7ibgxzbL0kLaxwgSrqH0dku/8WCgi8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yrbyWEErMd412tgOFSnJ7rWJcocAfL5p7ENZlg8F6Fk=; b=og0gClZxEZAnwWXVox2IzmFaG1ulhzlFa4WayYvc2K6FV2CAeCNo+U4Cey183L36zTP04oeEKrjtxYDB80kn+eZEl6P3/sGiiqbLgx2h44Ijgb3oAJvXUZq5ydSfyn43TrKTl24QngCZEqZf10g1QS9Gox3V9xQKgn03FMunVMJAiwMP7YNc0Q4PPmCTWw7v2VkBz7dZbUyEiUKAeFBqVxd0JYz9yVkSVFC60iEReP9v2xFriJSkJYym4HWjMBNM4iCIEOfzgl8kzt8rDHjXT9uaZs43iHzBtNZNcdpuTjz2syzM1gwbk2qJCSAD4/a5Snmc3WSml/cRBZ+gyUP36g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yrbyWEErMd412tgOFSnJ7rWJcocAfL5p7ENZlg8F6Fk=; b=TiisUlr7psuLkH+wyWA2MPFGoOx9Ghh3GWAVDkwBslG0u7Rp3gXCqOzqjJ1HiT+Z7AdTObQ4XSU0wwlq87benBgySvjKlHJaUsAlL03UxbKSaSKylZyaBmTO77tyyLgss6A60q8vo9WLCILwpCsozsOcfI+t5iZ/e2F0rJXxf0U6D7OdndFgleZXi/296WwXzqjRzYSJMKTL2xEDph+Ny5EWWtMaLhwgAW6/QrAxH2AgPeNzeCrGLnJGTtMOq2/dPsE8nD6bUOqZIwsgS6clhJTOKQko0eifrfhtF9q4riE0DPpCzdCBOy2Vqi0qIpO4YKqfbCnRA+AhOTwyA2M8sg== Received: from CO6PR12MB5396.namprd12.prod.outlook.com (2603:10b6:303:139::8) by PH7PR12MB6468.namprd12.prod.outlook.com (2603:10b6:510:1f4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.37; Tue, 20 Jun 2023 09:42:35 +0000 Received: from CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::18a8:95dd:6dcb:bbfa]) by CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::18a8:95dd:6dcb:bbfa%6]) with mapi id 15.20.6500.036; Tue, 20 Jun 2023 09:42:35 +0000 From: Suanming Mou To: Akhil Goyal , Matan Azrad CC: Raslan Darawsheh , "dev@dpdk.org" Subject: RE: [EXT] [PATCH v3 9/9] crypto/mlx5: enable AES-GCM capability Thread-Topic: [EXT] [PATCH v3 9/9] crypto/mlx5: enable AES-GCM capability Thread-Index: AQHZoxYZsnxyJryZyEe4gJcYK2Imla+TbA+AgAAEIUA= Date: Tue, 20 Jun 2023 09:42:35 +0000 Message-ID: References: <20230418092325.2578712-1-suanmingm@nvidia.com> <20230620012322.788099-1-suanmingm@nvidia.com> <20230620012322.788099-10-suanmingm@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR12MB5396:EE_|PH7PR12MB6468:EE_ x-ms-office365-filtering-correlation-id: fc7f5f94-0d7b-4803-91d1-08db7172ad53 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uKUm+xbYzM3d+DGGrNEUiOZjqjhoNIyNl/kU+Amn7o3stFDEeYIJ3X5s1L3beEFY/ZZJSVBHcJ1pBYyMXzmrJt062ixHpDOLVY4EdlW/AzGn1r6sVTWhlMakA9rMJzRiys493ahrGvp7qlaw6VzquQ1fZwDaWqrrYl+bjmzg1xl7KcULqnFpth4mg8NXjsaG3yoCOgiIuubq1Ss+Dr9jv8r1qeNN96z0476KbMf/5tSJ9OKCQ041Lii8KPiA8kM5YMbDDx8MKemlY7QfdpCnJPJ4F0IzYhADnhF9+KL7sWC2fFSgkvIjwxaKDE0fb4gh5bHasuK5FWjbHQJIMr8AzMFV8iu525z/BQp3mzH7lPqxG7B9UaBtI12gcor0zDmVF/pvtxbWVUQgyyIELahE3DnrDA1FPrLb+pUbDE+YszGtiSCjIOpB9BZauOdOVVW1iozne8POyYl4sNq73IAVVYEkN1QXh0kn0bZFlWSls325fzDmO5O/pUfI7OByrQj1QDwn42McYKV3snLpfJTTODo0cSVGiPwLnCUo677cXtnc/b648otbyVJ6Vm42oTmmhIX3ufQuHkEikOhJiegYaV7fjnMjhVKfi64v4SPpbDSTEuHhn9cw4TUmRpR8hI6e x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5396.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(39860400002)(346002)(376002)(136003)(396003)(451199021)(66556008)(33656002)(66446008)(6636002)(4326008)(76116006)(66946007)(66476007)(316002)(64756008)(52536014)(5660300002)(2906002)(8676002)(8936002)(41300700001)(9686003)(55016003)(7696005)(38070700005)(54906003)(110136005)(86362001)(478600001)(38100700002)(122000001)(6506007)(53546011)(26005)(186003)(71200400001)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dJHLWk5HJGW20GBqT+XURcmMpbQ0qsOgW+RvfqCllsoMvutAwT/D9Xd5fMYs?= =?us-ascii?Q?Bxt6uwgOaewugg7nBGzkxpl6SqBGaIlGNm0bpfyVCTtCy6il8Lbk4JggeUbj?= =?us-ascii?Q?dtiftYUp3pl+juJn5QK6AIv58opaZJtt2XZtZrbf6gbY23XRdCFD2F+zXZP7?= =?us-ascii?Q?mDZ7hrIBB6kZEv/3KSru8E74BIQ1JFBGbdu35XRk+TxAoKMCtKJq5wyCcszB?= =?us-ascii?Q?coBz+VdPrhSszuUdEO+jDdf/laIrOPsFWQNnYrBCjGdgKIo2Q3JnPCzH4uMi?= =?us-ascii?Q?vFL25Zi/fyzYY6QDjbzrJRp10hu3/8BjT9N+XRgS+q9FxeAvrgW8KBKCrop2?= =?us-ascii?Q?MkA3P2bGQnHPAv250jQVe3pcw69zFC1WxrAAkOT4zwTSAhF0G7leIN6iDIXy?= =?us-ascii?Q?wZp5tcGzxHJgFB7e0CB5WXx5fIQXuKj3nCU0KF33SQlXuMr0zeGrP8FseygL?= =?us-ascii?Q?wZOXGV62bjLg07I7e5rw6jD7x4P2OnLityr3e/pL/Yz6Mtqv1gljFD1dGsLZ?= =?us-ascii?Q?WLG20FOHp1/bCEMbatzTjQirK4xaD6qKSHkpN+7bu/+qtL9erR1ob81eF4jO?= =?us-ascii?Q?m+ThwjU8ZNoFT8qczXrZRhaWLPf+C5lJPUYNLPJd8kPoI0/SQuK0q8M09WAY?= =?us-ascii?Q?kjv/WXinvDxhkH/Rbb4qE3my5PLgn3E0sfdvP34a0L64V7IJG7j7YG/G4+Km?= =?us-ascii?Q?qlnr6qTsTdgH11FEFMmnuCL4Y0feR2kvS4mqH6yX9GUkmc50xI28QDRtpcl2?= =?us-ascii?Q?RvUBK779I4BeUqHOcMpkIs6Vc/uCJm8ThPMJMGMdnnSNo9sRIQadGckaVxqI?= =?us-ascii?Q?J7n5gZI9s4F5E4V06zSYTLqKYpa4kwOrWdjpm4ygYLjnOY4xu+du39aMJ4CR?= =?us-ascii?Q?vq5mR3eyItN6uabUsQMyB9OMZKrPjKbZZjTtJz21HvJgbF8Vbq/rttrOUKyx?= =?us-ascii?Q?/DRbiJ2fOmMmwPAYbgiuGuykhd1v/OoRJfkkigmtD0gJZQp3S/yMptAas9Up?= =?us-ascii?Q?nXs/dgD1pM3OkKrVrC7qpBnwvY4jeLU7JQb3EmZHhJmZB5EegjyltsYVkN3a?= =?us-ascii?Q?YZqAjrTmzZXU89C9vt7nWXTKvuOxaFtgCJc8hI5p3lb/zj646s5SYtpDVGXO?= =?us-ascii?Q?8M77J0cCCzOZBBgq8R6+vZ9tPhJDbMT60NaS8Eqrimu6kgCXHtNpH1N9kDbi?= =?us-ascii?Q?w1/zP54iyFVi6qY06JokuB4xO4AP41L17ES+sI5RM4u2MU4/sGJWVcNN2OHf?= =?us-ascii?Q?cZi2TzFUhT2wz1ZxBrJBzpR1CZQeGRfR3eer+xJ1DvGFmJoGiAV4p8XYT9BU?= =?us-ascii?Q?WuNkZxaU4DDwwXvwWenwNoMcYoX34LRxFrSO206tq29vbX4xMBOS1A1XWgvo?= =?us-ascii?Q?KM+1TI/d7CRySxFGY3q1KZFZhkWLW21kD5F4cNQmxCtslpKzy3Ng+QPxyfvz?= =?us-ascii?Q?4TnPcmuBcaU8PQNTHH2YIN+8JDaPou6CbIEO/fDp5FoZQ/RsjPjj38VlZlMm?= =?us-ascii?Q?u8N5nyORd8mdLWa0g1I3EppJdaX9ulwKDf8V4pR0ImCx8z0de3zKLpQ2OIp4?= =?us-ascii?Q?zpREcivJjkWQz8pdjEp56bt7/Wg/FK/Fw2LAKOLP?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5396.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc7f5f94-0d7b-4803-91d1-08db7172ad53 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2023 09:42:35.1147 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NGOR0u4j2Htq8RlVuKbF7g8hnPxClBp6exYMdU0cGfC+zV6VPU9/Ii54EeKSz8DJHRy3QEnEtm4wH8+1KD6x7w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6468 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Tuesday, June 20, 2023 5:25 PM > To: Suanming Mou ; Matan Azrad > > Cc: Raslan Darawsheh ; dev@dpdk.org > Subject: RE: [EXT] [PATCH v3 9/9] crypto/mlx5: enable AES-GCM capability >=20 > > This commit generates AES-GCM capability based on the NIC attributes > > and enables AES-GCM algo. > > > > An new devarg "algo" is added to identify if the crypto PMD will be > > initialized as AES-GCM(algo=3D1) or AES-XTS(algo=3D0, default). > > > > Signed-off-by: Suanming Mou >=20 > You should mention changelog for the changes done in the current patchset= over > previous one. > It helps in review. V1 is RFC, V1 compared to V2 was xts and gcm file split. V3 just did a mino= r fix in aes-gcm 256 key creation. I put the change log in the cover-letter, but thanks for the suggestion, wi= ll update the change log in single patch as well. >=20 > Also update to "doc/guides/cryptodevs/features/mlx5.ini" is missing in th= is patch. You are right, it is missing here. >=20 > Also get an ack from mlx5 crypto maintainer. >=20 >=20 > > --- > > doc/guides/cryptodevs/mlx5.rst | 48 +++++++++++++++++++- > > doc/guides/rel_notes/release_23_07.rst | 1 + > > drivers/crypto/mlx5/mlx5_crypto.c | 26 +++++++++-- > > drivers/crypto/mlx5/mlx5_crypto.h | 1 + > > drivers/crypto/mlx5/mlx5_crypto_gcm.c | 63 > > ++++++++++++++++++++++++++ > > 5 files changed, 134 insertions(+), 5 deletions(-)