From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40B2942B25; Wed, 17 May 2023 09:43:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C6E94114A; Wed, 17 May 2023 09:43:02 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2058.outbound.protection.outlook.com [40.107.96.58]) by mails.dpdk.org (Postfix) with ESMTP id 649144067B for ; Wed, 17 May 2023 09:43:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VkU7krVZyE3FrDafgZPD9wgxpfwqQsYdZubjDp3ZsB5hciil/Zm6eyHwpK5VD3LHSO9EOoPQon8qZjjrevdt1VcMq1E1gTtX4sTsc3wUjO0vfYg/+DxjxGhFJU2mjqdLXHKW+OFP0mxe2e3v0ejHaE7ok3dReZdJSehL5Bh+nz+1Zguj/HT4u9pXnsPvKJji5hRfQHwiwi2wr/rKjvQN8Igdvn37el0+v6jrcCdcqiAsMsemM5XVZq3/u6WJFIbdYV2EjrdulDNjq9lJaHT/I/TVZyxymvnpjvyGveoXjOBOcj9qpUNS6eseI6m70C0XSoLMozOe9wMGdz27w0DoPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ozUqUU8pYyRrgDJbNMqnl5nVDMjWmUxCfYh35TURUxE=; b=jzpGCDwUKN3bRLHo7nGln6UXITMrw63vtrHqnqJ33zy4Tlusx2rC+l2zh4RpjfFz0gKSX+J96nBWV1VoltRzPAygg4wsGVOYO7t1DLrg+sFMTO2TAWm/9r7XKnbTmQ1OgpFr0JvZrNkUFQjq6hh31CHUUYfMYDl62OQg2m0swrPYj7CEJAizYh6saaTO19NkIiFTByP79LgZ9nbl8PrWnhURUg8hT74zeQSMyUbjCJBjwO8I6pwFsgdAtGTFTDm5NXQyBeLLgVYW3EqPg28/mD09tF/Oo1PJ/heNenvWVINSg/NLiCJZxn6zrnQgO2LkRMuLW1T/MZ7PdZrrV0b4sA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ozUqUU8pYyRrgDJbNMqnl5nVDMjWmUxCfYh35TURUxE=; b=Fa+MGw0CU/vZBAe0Ymcw1yK+zPlgJjaonuwruCw8Qxx4fb3cAUhZzK8k5bsN7u+Yc4fnHoPTCGfAuFt6ww0CWSWuOKbLP0k8BcYcBCy6GY5xS9nPBzOhhXlDQ7ks9ECU1Yv9vGWxinUumhC9mE7Mlb1B4wnRDcoEb1vqwfP/caKA0szzD34wRJ19+k/n8iqdhwmPYPZVr3Q41kNICZUU2xzAWvvVlbWlsta07TkGHfHKwjSTITnRaugnpgpx9gYe2E0sm9+kIBMeqWcOTA5RoZ5CyH5CL74T9CKZG4eRbymdgk03N7RvTIeT/5uMI9j06hF1S46Hs3i7nyR6SgJZXQ== Received: from CO6PR12MB5396.namprd12.prod.outlook.com (2603:10b6:303:139::8) by CH0PR12MB5249.namprd12.prod.outlook.com (2603:10b6:610:d0::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33; Wed, 17 May 2023 07:42:58 +0000 Received: from CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::1ff3:30ef:e7d1:8596]) by CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::1ff3:30ef:e7d1:8596%6]) with mapi id 15.20.6387.029; Wed, 17 May 2023 07:42:58 +0000 From: Suanming Mou To: Akhil Goyal , Matan Azrad CC: Raslan Darawsheh , Maayan Kashani , "dev@dpdk.org" , "NBU-Contact-Thomas Monjalon (EXTERNAL)" Subject: RE: [EXT] [RFC PATCH 1/5] crypto/mlx5: add AES-GCM capability Thread-Topic: [EXT] [RFC PATCH 1/5] crypto/mlx5: add AES-GCM capability Thread-Index: AQHZcdeOwDEUUa5Oyk21Cok2IGw/qq9eQQ2AgAAA0HA= Date: Wed, 17 May 2023 07:42:58 +0000 Message-ID: References: <20230418092325.2578712-1-suanmingm@nvidia.com> <20230418092325.2578712-2-suanmingm@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR12MB5396:EE_|CH0PR12MB5249:EE_ x-ms-office365-filtering-correlation-id: d219d095-d13f-477f-7908-08db56aa5583 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wK6istR5kkQu/TSYzPhLesNwigg16LPmWzdM7CJoXymXSaESi8dwioMDrh+3GRvvOgdS+QszN+GjCHoT6fiT6aArNgsLGzPH7BEzN0hypEzh4qsFy1kpDPlKnw7EWotVVlnEs/tEAR0rfeXT5kaiIVXiSpwrlfZ+K6se51/9JkSH7yjv0SAzpfG8dGy8W41ca7mEu7mtk31ue4mvrJk6JSclkCr5bDuAD77k0uWnpf/BqzG4scwxDRaZT4Gfy7z4cOhgKKZ34sdthf0R4/OacGBBShqJoUEoTBh3LzXRue7rQYazghXmWU1MdVeoqvgyg6wMOHzf/vvvtv/TDC+VfXybP4xcyRBZlQ/IgP3/+B7vESsCiWLJZNDxQ6hY4nZhEqO8uqAHQoPYl/jGCtYhnhYf8xfjiNJgdZ6i4M3Sjh922qlY2CoptGpoejMh4VsDKviKCU1JobjDIORhOfM6uOcwXe45e9hiYID0XuQi5hiT36vEiOqG4h7GeG/uOtTKfKw2ruyqy6nOBrPqWQ9UCDuRwpmo7+/qABs4BwEDsPCmoWAV1wpPu/apxZ4OsYDgCCStjxnnr8B7lSIDrzwt75RVgJWuekrY1z2s+FAvFYnXYCMtjL/eWW6V2pz6ZBAi x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5396.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(136003)(366004)(376002)(396003)(39860400002)(451199021)(8676002)(8936002)(316002)(6636002)(4326008)(52536014)(5660300002)(122000001)(55016003)(38100700002)(71200400001)(2906002)(478600001)(38070700005)(7696005)(54906003)(66946007)(26005)(186003)(64756008)(66556008)(33656002)(41300700001)(66476007)(66446008)(83380400001)(9686003)(110136005)(6506007)(76116006)(86362001)(53546011); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?26sEeaTbDFI8mpwW7UHYTo7D3lwK1HDmMcAfEFo39o7eGK5TqCEhvVo69IET?= =?us-ascii?Q?ZZKjYJuv6AOFwtYfdsYQvrXwp7h9D5rgqlBgL0pB0WOdoZxVjdVQCR9Oav0B?= =?us-ascii?Q?v+xRZk0YvSvQznm1VjpHar06LGF14+iHQaE/MbIM2YBh5oVA5fIka3kXpB2E?= =?us-ascii?Q?GjnFdQzr2uiaabUtr4AyiZLWNvp6PkKhMEOgY5wBT81WtkqfRKUOPw8Fx2rl?= =?us-ascii?Q?obAVlDK8jL1d1NQYErEtvUFU6OXXyql4xxr1rkCQzWVb5PCJgdqfBBSlEc6n?= =?us-ascii?Q?GbPWjilgchN3VXlvuFcYsgPO8C3Y7w4ZsA2SuT9XiOVkYVd56+GAiB3NCbnH?= =?us-ascii?Q?iUGiO5xGZwAwBedV+RNLi7vGppfPu4pn3/Dqo1ZkHT/7gPznHcqSU3NwvCWu?= =?us-ascii?Q?mIMdqOXeOWw2cfkRKFg5Ol/AmmUXKH8FLjeA+5Mc9YZlbP7cGuoHuIWOsKAF?= =?us-ascii?Q?XwT5TV/GG0Gun8+08Mkn7gwdI8nYazGecy5q06VsKj76VUsW1qrkHCJc5Oo0?= =?us-ascii?Q?e35bGDefs6PDg8p8NYBnCVybZ16+QyVuhVURBCpVYHKlEWGk83fpwpCyoXRc?= =?us-ascii?Q?NHZbfiAc+J7zQt0s5UTj/ojydWqq3axBqONy8uRrGZz5ANviGAypgtr7X2D+?= =?us-ascii?Q?jhs5aqeiWSwiQF2ybVPutG6Y0YKNz9rBRYYS6f1zUnsRBDCIaRmk0Mt5j3lB?= =?us-ascii?Q?GbuWMN/nxxKZx3dOh0ANBRiMHERrczWlIY6sqtd0xYYXuABAHlD9bIi+3Ypl?= =?us-ascii?Q?lC7VOah0DAMXtpaRIvx35KMW20Ap8pXEGanEvs5V51TDbipn5xxHeuncc1LE?= =?us-ascii?Q?aItmtvtd/XAnNtx5xxBwi/rp2KmfIiB3y512J6w/X+Rn2jTsNGBKVyOM4dz5?= =?us-ascii?Q?x23DI0pdPCot0EhIMd8rBw12dmPw2ygzOAP38ZCzlKVpsrapF85iIuKazxs0?= =?us-ascii?Q?yQGsQkSGbmYhE69AER2nu6EC1dWS+J4DLIQ9fnN2FTio6ONS7I2zceL162UN?= =?us-ascii?Q?gkEdYnPUgMEx0sZfWIqv/rNzy9UDVPAhRLWo155DX5SvgHsZIS3iNpDwbFug?= =?us-ascii?Q?NRj4edZfRPb9AeOSxyvQwspas4/k47CmaRfKKul53SqVGUUwL4TxPzIGSMM5?= =?us-ascii?Q?DtqZ4muz+0PoeZaOuY4xAx5qU2/aBiSLmg4T9OPnJUGBkVuP7yERVgjsy+zt?= =?us-ascii?Q?naWcXqTaGEEyO2FhL6KdqSYiHTleWhjDAzv5bpS4kQePvkSIC3ikfnBTGiXP?= =?us-ascii?Q?Q8aiR66/aG3UcrPboShLX/c1KWr9E5BsxcDcaEGbDFfBGFVO4N6DubvX1H1J?= =?us-ascii?Q?itPRpPEn8xNEu2HYWpE6kTNsqyakvDnnkAFAEAxPeu4kGYtNAOt1F6jIEOwk?= =?us-ascii?Q?VfokjtaD+jSDiGN57HRjaJcY8dikc81xAthzWEK2q/3t9RhwthNuBBGVkr1/?= =?us-ascii?Q?9L/1bgEiNkmBB4so8ecORdDiKwc1Ej0VlI+Eyelg/SmF/b6ze7T+akEASYtk?= =?us-ascii?Q?kz0qt+PUG1Yc7X4uJ50ofysDVbXsUXizadE+QBm4p0tMVe6AoWuGomG7L/T5?= =?us-ascii?Q?3wlRyAROzOh+dJJ1o9Iy/qmndDYqTqoTkrPorJMU?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5396.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d219d095-d13f-477f-7908-08db56aa5583 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2023 07:42:58.2164 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4b2aaxHtfZynXszM6URUjzFwE7aZiylzgOWGdeF1TDBfTru9GrLO6hFtvd/mZwd+qW/9u95ZOtYdMHPchboRrQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5249 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Wednesday, May 17, 2023 3:37 PM > To: Suanming Mou ; Matan Azrad > > Cc: Raslan Darawsheh ; Maayan Kashani > ; dev@dpdk.org; NBU-Contact-Thomas Monjalon > (EXTERNAL) > Subject: RE: [EXT] [RFC PATCH 1/5] crypto/mlx5: add AES-GCM capability >=20 > > Subject: [EXT] [RFC PATCH 1/5] crypto/mlx5: add AES-GCM capability > > > > AES-GCM provides both authenticated encryption and the ability to > > check the integrity and authentication of additional authenticated > > data (AAD) that is sent in the clear. > > > > This commit adds the AES-GCM capability query and check. An new devarg > > "algo" is added to identify if the crypto PMD will be initialized as > > AES-GCM(algo=3D1) or AES-XTS(algo=3D0, default). >=20 > Why do you need a devarg for identifying the algorithm? > Is it not sufficient to use enums rte_crypto_aead_algorithm and > rte_crypto_cipher_algorithm? >=20 > Devargs are normally added for things which are specific to a particular = PMD And > which is not exposed via public APIs. > For identification of algo, it is not needed to use devargs. Due to current HW limitation, the NIC can only be initialized as GCM or XTS= working mode during probe. It's not able to provide both in running time. = That's the main reason for the devarg.=20 Session configure with algo is too late. >=20 > > > > Signed-off-by: Suanming Mou > > ---