From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 510AA438CB; Mon, 15 Jan 2024 08:46:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD4684029F; Mon, 15 Jan 2024 08:46:52 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2073.outbound.protection.outlook.com [40.107.223.73]) by mails.dpdk.org (Postfix) with ESMTP id 9738940272; Mon, 15 Jan 2024 08:46:51 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q+9QwI9OFnZymEkHaUv1TIudjOd2XAu9luhz4inXu5kPmClXJzM1nH3Ej9Ku1Gz4muYIrGG1oZnNFC5nkmTUoMNstKQHNMukriqv5GCAXZX2vo/T/KOEeNTo4TZc0oEUTPmSIddVDNrm3NTPOnqzi50kxM2YQS7viZvndOEPDXzDHdOBF1TWd86qKyv7E7gckf+Q29hZPJx+DoTmT4T5NUTLjVd0FwOJ5qAfb59T9ZWNfEqOMLYUjzxw02VmHhB+RE+Fjfjq6JjvV3AuZCPp2d4a/r5MND95ii9V/Mc4gC5GbDli78hdkYfpyDoMVXvrXXnz+Hjnv/ZnS6V8rtqhwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b5+RxxSP4MOvSE3xCwExw3NWIghvf+g4SX3AYDkUNSg=; b=insUGPJD0YtH073DvuFPd1RCmr0Xmt6zwr2j2Zh8mN7AUy67tZruOjN8DC2mnol+svqFV8PdkXI3Wqq2dk+iT+SBSTIXtFIa2YZbHc1uYZxgKW/v/gbXt/3EPS8ilPv89+xiwbzNvqYjsGEa2MYKdFX/wCnRlbFNnWgxDivrInQAfm9Gkai2s/aDbPCn1sqm2TIjJuCTktDxLttV+4V0KA4KoHQb9T4X0VMCWInny2XgGP9UyhyVxV0bipkCCB9FWRUr0VVssG4NHJxRt8MKk/MsPFP7a4OzxJFWQufjVRvuQlGzLLnLN9JmlI9BCRWYUvbc3fLEWYgzZXrgcpGZtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b5+RxxSP4MOvSE3xCwExw3NWIghvf+g4SX3AYDkUNSg=; b=jmdeCShQcptdiftuFxyhldLMHxg2SYJ4IJnFGCxNYg7mexksJzSyF7WBWXk3Nkj3wqMPk9daEzKJ77+8X23CLo2vndo8VS5IOYXoW77DEmKd5phop/ENcx04NboFAhcWMFxMqL6XoR40xxJbYFpnhhpNrmiMFPZoZVgmPgnSaMKZdeauHlebqJJ3smKIRufIJA2Epsa2SSAkdvQaddmArXu5Xmg6cCfKYK0zHrS2Zfdwf4U9Wt4dqEHNeBMI/b/d1VPPU1yy9XkviT2Mlmfvo1gLV8ul+k2zFZr4AfLFSFDRwNoQHEEpZ4mAAhcrQAB9+WD/BotPS5UKOGUzP09jOQ== Received: from CO6PR12MB5396.namprd12.prod.outlook.com (2603:10b6:303:139::8) by CY5PR12MB6202.namprd12.prod.outlook.com (2603:10b6:930:25::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.20; Mon, 15 Jan 2024 07:46:48 +0000 Received: from CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::df56:6290:5b5a:e018]) by CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::df56:6290:5b5a:e018%6]) with mapi id 15.20.7181.022; Mon, 15 Jan 2024 07:46:48 +0000 From: Suanming Mou To: Anoob Joseph CC: "dev@dpdk.org" , "stable@dpdk.org" , "ciara.power@intel.com" Subject: RE: [EXT] [PATCH] app/test-crypto-perf: add missed resubmission fix Thread-Topic: [EXT] [PATCH] app/test-crypto-perf: add missed resubmission fix Thread-Index: AQHaP6RZwvLFvRqrX0+tLZSqdqNFPbDTKGkAgAdmFTA= Date: Mon, 15 Jan 2024 07:46:48 +0000 Message-ID: References: <20240105065556.906471-1-suanmingm@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR12MB5396:EE_|CY5PR12MB6202:EE_ x-ms-office365-filtering-correlation-id: f961ee0e-1bc0-4df1-31e0-08dc159e2141 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kqyHr+I8tHQvc6QX1+yCWOkK8nZsRwq9FCSTnLj0vHpymVVZheO9bzRqiXOv2vevso37smfspVI3CF9zV8ntIWpe91AZj4TaMY8YoEJ/ft8I5x/eYWmmIKI5Tn9AwmmD+m5Rh63cukHxUcnDCzV7EOWLJBl/0IfstimS3Fl2z9W5R5lONNN90M1DXUBn45hualb3bU+QKIMMHlD6cBt21T7Ka75/O1ONXFWC+Un2opiT7wY0NGFnlWA07LpU5oD4ACDaWGrVhMlZfvM8vmxcWnoqgW/Mzm0zs7LkfhwwmE0CC/QVnig2lC+1Xqqv/p60CPijq6qN4CteKMTykHkvpVHCl8406/UpancM3nKdY3xyQtqNcArjKdQDIwcL6wsqdq8THAnPIQna9LfAYqsrhoSczXPRdcEx3cxT0jsysSqeXJaZLndns+AEC3mAUtPQ3Q0SG7StTu58+yUgmIGMgDUQQjV0AgqMEaLCRMUOzRF8RqOj6R19CQI3o/0zN1RgqZd1Ei2QB2h1T+0oJujIrNtdb2VFyYkspPPzlsNNOEbk3kivTWJbQpTOqtgBT8ZrtPh9mON2JBMn76qR6/rONTRdm3jr2Zj/qVrkVwqPTjetHrMemgxVyIH7pwvuw30NJwi/QPknDjHcCO+Xg2I/AMQ2ng2cJmrHR+uSX3biP/Q= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5396.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(136003)(366004)(396003)(39860400002)(230922051799003)(230273577357003)(230173577357003)(1800799012)(451199024)(186009)(64100799003)(83380400001)(26005)(7696005)(9686003)(53546011)(71200400001)(122000001)(38100700002)(6506007)(5660300002)(52536014)(2906002)(41300700001)(478600001)(66556008)(6916009)(316002)(8676002)(8936002)(76116006)(66446008)(64756008)(54906003)(66946007)(4326008)(66476007)(86362001)(33656002)(38070700009)(55016003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Gm66+dbJEIO4pYGxOXB0y3+Yi21nEeVIJo9wVl0SRKX44FJtkhppP5WiRRQm?= =?us-ascii?Q?fU7sAIqWF05SnN1q08+/JEwuwA/AQXK6RP6AfuvRq63NGZ3M6tm/nNeELIo6?= =?us-ascii?Q?QHNKB6wkXu2fM2gQhbP95gLsAlHR1oVlz5IpXaFkX4VImiLVGBH9iwkr5mOh?= =?us-ascii?Q?gE5zk3xQwdBmteXPNrXuRSs1LFsGcL6QZeLr2qVkIvV/x2AVlmWAJcNvHx1j?= =?us-ascii?Q?r1/woBMsYvtjuD5+DJbEJ01XN4GYo1aTnOFEKo4bcUjfsL8QIvu63nnYygGQ?= =?us-ascii?Q?ppWxR8sT8oIQ4glXkVTDUc6vmafo4TLUPUicYZrTxKlPTZEtV4kG1ScANSUV?= =?us-ascii?Q?RhWHwEwUyKy9fzJucvP06/fo5mH2gvrra8z2/OQYDYtjZfnQzfNoCHQMPfbK?= =?us-ascii?Q?k+tQDazE1bnaQP/UuMX+RsYfr7Dg2sz63QgcwuqXz0+1muy92dxNHyhkTNAG?= =?us-ascii?Q?FAXiVNZ2b3lSV1DTNYnyWsnK+4dFdAl1yzyWRU2W5hXhOzyY0+5FJc57NUiw?= =?us-ascii?Q?4gUI5wY6eJTv42JEBPb4Rr85gcfgikz7bpUyXNmE0Br5t4isfqqcNjF5g7p/?= =?us-ascii?Q?s94Nq5Hvk2Zkb7dVsMx3mTAzL4aZ1QRMwtppDPj7X5WaodN2TxE6RwdzGDkV?= =?us-ascii?Q?IRwJE9pQOF8bBAaVPjN3TwegvmwqU0ij3p5WS7zkKFHUn3N3cUnlqiiJ+keW?= =?us-ascii?Q?HElHlVS9RDE1Hvi8gCokFjQELTGojeKN+Gpch4BWiVaWPh8v3qrtBCUD9PpU?= =?us-ascii?Q?V4aZj5XjLR2UknwPgLOBH70uUsVcXnzCk1zs69OMoFahaE3l/APx1Uyv0auO?= =?us-ascii?Q?T6GYJ+7pRBAhyVq2m4OYpRy4H+Gh8NN0sqm2X6V1e8Vxt58KCNaus5MpJa/L?= =?us-ascii?Q?JXcpjHG9C/7hlVC7Ehe0WjDGLzk66D33G5uHBj8Kx1PJM+Z0gKycmQpqcJa2?= =?us-ascii?Q?14JGj0g4DE82vrRngr7wWqgn87Q8fo1QnbG+eWNeeUoj3WAMg8sMSo5l/b7A?= =?us-ascii?Q?4Z2HXpafqVzYJdKTzIMKWc0xF4o8G0nuO3Q/nTGoi6Ha+qJ6LnxIS3mz/qhw?= =?us-ascii?Q?dJ4dYpKX5tKm3w0roJVHhia+23w3PeAhBmxaFBziFwGg6yLNuZiyocQVF381?= =?us-ascii?Q?jLIThDSJ4lvrjx/Q+S5l2cpmeexq1peQe6vemEipVnMY7spkYz8r08nBKuYk?= =?us-ascii?Q?h5mHC4hOJnVPRSkzeWGwUzAzm00ogy0NgUnPstv6Qhr6Qg7hnWGcRLyypZ2F?= =?us-ascii?Q?YsVeLcL5Q2gJsxFTiIVAYjWgA/4S0Xwi7iadsorBr8qe7EJwKUoXADSLTpYD?= =?us-ascii?Q?LU3DSZ/wQL9/QsjeDVO5tZVN7Is8tBCWttFBhFx35th9t9KfgENT7ThOqUgs?= =?us-ascii?Q?dyuLLJ/npxN+tc2EknsMWZuBvGrgAjzdyyu3jFEZxXoNhD2GxbO/0hSFwzox?= =?us-ascii?Q?3Syx7k6ZSRnyuWIzbfv3Zv5Ef8puN5oVU0Num66cOSqQmZCn0cldoglTD9ke?= =?us-ascii?Q?CJbUEiFlPTOqZC7ugCBc5msWFfprqQNGwG664NEfwQ4UdPRUKn1gXHgnpvqo?= =?us-ascii?Q?BAWyDSSelwfz9oFs5smq63G6P+pvHyrt5zEX3i4/?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5396.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f961ee0e-1bc0-4df1-31e0-08dc159e2141 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jan 2024 07:46:48.6159 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vwtWihx8jwXUoUbclVPW064rLl47MjihDfhfAAXMna5Bwn6DYYnGdrgMGaSyJaOZU767ldjE5MmeDlzVD1Xy0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6202 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Anoob Joseph > Sent: Wednesday, January 10, 2024 10:47 PM > To: Suanming Mou > Cc: dev@dpdk.org; stable@dpdk.org; ciara.power@intel.com > Subject: RE: [EXT] [PATCH] app/test-crypto-perf: add missed resubmission = fix >=20 > Hi Suanming, >=20 > Please see inline. >=20 > Thanks, > Anoob >=20 > > -----Original Message----- > > From: Suanming Mou > > Sent: Friday, January 5, 2024 12:26 PM > > To: Anoob Joseph ; ciara.power@intel.com > > Cc: dev@dpdk.org; stable@dpdk.org > > Subject: [EXT] [PATCH] app/test-crypto-perf: add missed resubmission > > fix > > > > External Email > > > > ---------------------------------------------------------------------- > > Currently, after enqueue_burst, there may be ops_unused ops left for > > next round enqueue. And in next round preparation, only ops_needed ops > > will be added. But if in the final round the left ops is less than > > ops_needed, there will be invalid ops between the new needed ops and > previous unused ops. > > The previous unused ops should be moved front after the needed ops. > > > > In the commit[1], an resubmission fix was added to throughput test, > > and the fix was missed for verify. > > > > This commit adds the missed resubmission fix for verify. > > > > [1] 44e2980b70d1 ("app/crypto-perf: fix crypto operation > > resubmission") > > > > Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test > > application") > > > > Cc: stable@dpdk.org > > > > Signed-off-by: Suanming Mou > > --- > > app/test-crypto-perf/cperf_test_verify.c | 14 +++++++++++++- > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > diff --git a/app/test-crypto-perf/cperf_test_verify.c > > b/app/test-crypto- perf/cperf_test_verify.c index > > 2b0d3f142b..0328bb5724 100644 > > --- a/app/test-crypto-perf/cperf_test_verify.c > > +++ b/app/test-crypto-perf/cperf_test_verify.c > > @@ -275,7 +275,6 @@ cperf_verify_test_runner(void *test_ctx) > > ops_needed, ctx->sess, ctx->options, > > ctx->test_vector, iv_offset, &imix_idx, NULL); > > > > - > > /* Populate the mbuf with the test vector, for verification */ > > for (i =3D 0; i < ops_needed; i++) > > cperf_mbuf_set(ops[i]->sym->m_src, > > @@ -293,6 +292,19 @@ cperf_verify_test_runner(void *test_ctx) > > } > > #endif /* CPERF_LINEARIZATION_ENABLE */ > > > > + /** > > + * When ops_needed is smaller than ops_enqd, the > > + * unused ops need to be moved to the front for > > + * next round use. > > + */ > > + if (unlikely(ops_enqd > ops_needed)) { > > + size_t nb_b_to_mov =3D ops_unused * sizeof( > > + struct rte_crypto_op *); >=20 > [Anoob] The alignment is relaxed to 100 chars now. In case you think it i= mprove > code legibility. >=20 > Patch looks good either way. Make sense, it is due to the code was copied directly from previous fix. Wi= ll try to update v2. Thanks. >=20 > Acked-by: Anoob Joseph >=20 > > + > > + memmove(&ops[ops_needed], &ops[ops_enqd], > > + nb_b_to_mov); > > + } > > + > > /* Enqueue burst of ops on crypto device */ > > ops_enqd =3D rte_cryptodev_enqueue_burst(ctx->dev_id, > > ctx->qp_id, > > ops, burst_size); > > -- > > 2.34.1